[PATCH] D56530: [X86] Add versions of the avx512 gather intrinsics that take the mask as a vXi1 vector instead of a scalar (clang side)

This revision was automatically updated to reflect the committed changes. Closed by commit rC351390: [X86] Add versions of the avx512 gather intrinsics that take the mask as a vXi1… (authored by ctopper, committed by ). Changed prior to commit: https://reviews.llvm.org/D56530?vs=180978&id=18215

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. @jhibbits sorry for not answering earlier, I was occupied with NY holidays, and then had a lot of stuff on the road. Trying to sync to your latest changes, I merged the updated https://reviews.llvm.org/D54583 in my local copy with your fixes to libcall expansion. From

[PATCH] D55782: Fix isInSystemMacro to handle pasted token

serge-sans-paille added a comment. @rsmith up! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55782/new/ https://reviews.llvm.org/D55782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D56831: [NewPM] Add -fsanitize={memory, thread} handling to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rC351423: [NewPM] Add -fsanitize={memory,thread} handling to clang (authored by pfaffe, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D56831?vs=

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. Actually I am not sure about Linux, since this is bare metal, and I just used what fited. However, it does not look like 128-bit or 64-bit long doubles are related. I retried to compile the test case with powerpc-gnu-freebsd target (and even made a compile-time assertio

[PATCH] D56802: [CodeGenObjC] Treat ivar offsets variables as constant if they refer to ivars of a direct subclass of NSObject with an @implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rC351461: [CodeGenObjC] Use a constant value for non-fragile ivar offsets when possible (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D56802?vs=182214&id=182336#toc

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. You are right, had to modify it like this to get the crash with FreeBSD triple: void f1(long double v, void *a) { } void f2(void* v, __builtin_va_list arg) { f1(__builtin_va_arg(arg, long double), 0); } Repository: rC Clang CHANGES SINCE LAST ACTIO

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

This revision was automatically updated to reflect the committed changes. Closed by commit rL351463: [Documentation] Add a chapter about Clang-tidy integrations. (authored by eugenezelenko, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D56632: [analyzer] Track region liveness only through base regions.

This revision was automatically updated to reflect the committed changes. Closed by commit rC351499: [analyzer] Make sure base-region and its sub-regions are either all alive or… (authored by dergachev, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D56824: [analyzer] MoveChecker: add ".assign" to the list of common reinitializing methods.

This revision was automatically updated to reflect the committed changes. Closed by commit rC351500: [analyzer] MoveChecker: Add one more common resetting method, "append". (authored by dergachev, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56824/

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

whisperity added a comment. In D35068#1361902 , @Szelethus wrote: > Edit: it doesn't, but CMake is mostly a C project and it does! CMake really isn't a C project if you look at what language it actually uses - the C files come from tests and system util

[PATCH] D56735: [OpenCL] Fix overloading ranking rules to work correctly for address space conversions

This revision was automatically updated to reflect the committed changes. Closed by commit rL351546: [OpenCL] Fix overloading ranking rules for addrspace conversions. (authored by stulova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D54141: [clang-tidy] add deduplication support for run-clang-tidy.py

MyDeveloperDay added a comment. > LLVM is very chatty as well, I don't consider LLVM to be a bad code-base. > Take readability-braces-around-statements for example. Do we need a llvm-elide-braces-for-small-statements? This would make a great pre-review check Repository: rCTE Clang Tools Ext

[PATCH] D56915: [clangd] Make background index less chatty

This revision was automatically updated to reflect the committed changes. Closed by commit rL351563: [clangd] Make background index less chatty (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56915?vs=182523&id=

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

This revision was automatically updated to reflect the committed changes. Closed by commit rL351580: [OPENMP][DOCS] Release notes/OpenMP support updates, NFC. (authored by kli, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56733?vs=1

[PATCH] D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra

MyDeveloperDay added inline comments. Comment at: llvm-svn.src/tools/clang/tools/extra/docs/clang-tidy/checks/cppcoreguidelines-avoid-goto.rst:11 from the CppCoreGuidelines and -`6.3.1 from High Integrity C++

[PATCH] D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra

MyDeveloperDay added a comment. the closest I can see is https://www.perforce.com/resources/qac/high-integrity-cpp-coding-standard#statements which take you to section 6 of the standard, but I see no id or name tags to get you to 6.3.1 Repository: rCTE Clang Tools Extra CHANGES SINCE LAST

[PATCH] D56879: [Sema] Suppress a warning about a forward-declared fixed enum in C mode

This revision was automatically updated to reflect the committed changes. Closed by commit rC351595: [Sema] Suppress a warning about a forward-declared fixed enum in C mode (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D56879?vs=182548&id=182597#toc Repo

[PATCH] D56823: [analyzer] Do not try to body-farm bodies for Objective-C properties with custom accessors.

This revision was automatically updated to reflect the committed changes. Closed by commit rC351609: [analyzer] Do not try to body-farm Objective-C properties with custom accessors. (authored by dergachev, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D56899: [analyzer] pr37688: Fix a crash on trying to evaluate a deleted destructor of a union.

This revision was automatically updated to reflect the committed changes. Closed by commit rL351610: [analyzer] pr37688: Fix a crash upon evaluating a deleted destructor of a union. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56926/new/ https://reviews.llvm.org/D56926 ___ cfe-commits mailing list cfe-comm

[PATCH] D56965: [X86] Remove the cvtuqq2ps256/cvtqq2ps256 mask builtins. Replace with uitofp/sitofp and select.

This revision was automatically updated to reflect the committed changes. Closed by commit rL351694: [X86] Remove the cvtuqq2ps256/cvtqq2ps256 mask builtins. Replace with… (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTI

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. Justin, I am currently testing the latest patches, yet so far it looks very good. Thanks. I rechecked GCC, and it seems that it forces 64-bit long double for SPE regardless of the target. Could you please force that in LLVM as well? While imperfect, I currently changed

[PATCH] D56852: [AArch64] Use LL for 64-bit arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL351740: [AArch64] Use LL for 64-bit intrinsic arguments (authored by sam_parker, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56852?vs=1824

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rC351747: [OpenCL] Allow address spaces as method qualifiers. (authored by stulova, committed by ). Herald added a subscriber: ebevhan. Changed prior to commit: https://reviews.llvm.org/D55850?vs=182496&i

[PATCH] D56429: fix python3 compability issue

serge-sans-paille added a comment. @roxma: do you want me to commit this on your behalf? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56429/new/ https://reviews.llvm.org/D56429 ___ cfe-commits mailing list cfe-commi

[PATCH] D56429: fix python3 compability issue

roxma added a comment. Yes please. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56429/new/ https://reviews.llvm.org/D56429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE351862: [Documentation] Use HTTPS whenever possible. (authored by eugenezelenko, committed by ). Changed prior to commit: https://reviews.llvm.org/D56926?vs=182590&id=182947#toc Repository: rCTE Cl

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: alexfh, JonasToth, hokein, Eugene.Zelenko, aaron.ballman. MyDeveloperDay added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. The usefulness of **modernize-use-override** can be reduced if you h

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay updated this revision to Diff 183063. MyDeveloperDay added a comment. Adding release note change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57087/new/ https://reviews.llvm.org/D57087 Files: clang-tidy/modernize/UseOverrideCheck.cpp clang-tidy/modernize/UseOverride

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rL351941: [clangd] Fix crash due to ObjCPropertyDecl (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56916?vs=182942&id=

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay added a comment. In D57087#1367610 , @alexfh wrote: > I tend to think that a better migration strategy is to change the compiler to > a C++11-compatible one first, and then turn on C++11 mode and migrate the > code (possibly file-by-file o

[PATCH] D56946: [Documentation] Use HTTPS whenever possible in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL351976: [Documentation] Use HTTPS whenever possible (authored by eugenezelenko, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56946?vs=18264

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay added inline comments. Comment at: clang-tidy/modernize/UseOverrideCheck.cpp:32 +: ClangTidyCheck(Name, Context), + OverrideMacro(Options.get("OverrideMacro", "override")), + FinalMacro(Options.get("FinalMacro", "final")) {} alexfh wr

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay updated this revision to Diff 183268. MyDeveloperDay marked 12 inline comments as done. MyDeveloperDay added a comment. Addressing review comments, - reduce changes causing excessive string concats and problems with temporaries - simplify cxx version and macro checks CHANGES SINC

[PATCH] D56429: fix python3 compability issue

This revision was automatically updated to reflect the committed changes. Closed by commit rL352039: Fix python3 compability issue in clang binding (authored by serge_sans_paille, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56429?v

[PATCH] D56429: fix python3 compability issue

serge-sans-paille added a comment. Thanks @roxma for the patch! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56429/new/ https://reviews.llvm.org/D56429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D57093: [CodeComplete] [clangd] Fix crash on ValueDecl with a null type

This revision was automatically updated to reflect the committed changes. Closed by commit rL352040: [CodeComplete] [clangd] Fix crash on ValueDecl with a null type (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D57111: Make Clang not crash on calls to destructors on incomplete pointer types

This revision was automatically updated to reflect the committed changes. Closed by commit rL352047: [Sema] Don't crash when recovering from a misspelled pseudo destructor call to… (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D57175: [NFC][clang] Test updates for CreateAlignmentAssumption() changes in D54653

This revision was automatically updated to reflect the committed changes. Closed by commit rL352090: [NFC][clang] Test updates for CreateAlignmentAssumption() changes in D54653 (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D57154: [WebAssembly] Support __float128

This revision was automatically updated to reflect the committed changes. Closed by commit rC352100: [WebAssembly] Support __float128 (authored by djg, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D57154?vs=183302&id=183369#toc Repos

[PATCH] D57155: [WebAssembly] Add a __wasi__ target macro

This revision was automatically updated to reflect the committed changes. Closed by commit rL352105: [WebAssembly] Add a __wasi__ target macro (authored by djg, committed by ). Changed prior to commit: https://reviews.llvm.org/D57155?vs=183306&id=183375#toc Repository: rL LLVM CHANGES SINCE

[PATCH] D57160: [WebAssembly] Add an import_module function attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rC352106: [WebAssembly] Add an import_module function attribute (authored by djg, committed by ). Changed prior to commit: https://reviews.llvm.org/D57160?vs=183322&id=183378#toc Repository: rC Clang

[PATCH] D57064: [Sema] Improve a -Warray-bounds diagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rL352239: [Sema] Improve a -Warray-bounds diagnostic (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57064?vs=182960&id=1836

[PATCH] D57258: Attempt to fix build on Windows with LLVM_ENABLE_PIC=OFF

This revision was automatically updated to reflect the committed changes. Closed by commit rC352253: Attempt to fix build on Windows with LLVM_ENABLE_PIC=OFF (authored by nico, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57258/new/ https://review

[PATCH] D56998: [X86] Custom codegen 512-bit cvt(u)qq2tops, cvt(u)qqtopd, and cvt(u)dqtops intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL352267: [X86] Custom codegen 512-bit cvt(u)qq2tops, cvt(u)qqtopd, and cvt(u)dqtops… (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D57238: [AST][NFC] Various cleanups to GenericSelectionExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL352275: [AST][NFC] Various cleanups to GenericSelectionExpr (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57238?vs=

[PATCH] D57104: [AST] Pack GenericSelectionExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL352276: [AST] Pack GenericSelectionExpr (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57104?vs=183349&id=183698#toc

[PATCH] D56792: Rename getTypeQualifiers to getMethodQualifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rL352349: Rename getTypeQualifiers to getMethodQualifiers. (authored by stulova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56792?vs=182066

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

This revision was automatically updated to reflect the committed changes. Closed by commit rL352369: [AST] Introduce GenericSelectionExpr::Association (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57106?vs=18

[PATCH] D57280: [clang][OpenMP] OMPFlushClause is synthetic, no such clause exists

This revision was automatically updated to reflect the committed changes. Closed by commit rL352390: [clang][OpenMP] OMPFlushClause is synthetic, no such clause exists (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. @jhibbits it appears that va_list is not functional with SPE (va_arg returns garbage for double and stuff like printf is not functional). Is this expected or I miss a patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49754/new/ https

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. Right, I noticed the same thing yesterday. There is an override calling LowerVAARG for 64-bit integers, yet that is not a thing that does lowering for all the rest. I believe it is derived somewhere from td calling conventions. I will check it out later this evening and

[PATCH] D56852: [AArch64] Use LL for 64-bit arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL352463: [AArch64] Update int64_t ACLE builtin arguments (authored by sam_parker, committed by ). Changed prior to commit: https://reviews.llvm.org/D56852?vs=183820&id=184031#toc Repository: rL LLVM

[PATCH] D52984: [analyzer] Checker reviewer's checklist

This revision was automatically updated to reflect the committed changes. Closed by commit rL352470: [analyzer] Added a checklist to help checker authors and reviewers (authored by xazax, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D57230: [analyzer] Toning down invalidation a bit

This revision was automatically updated to reflect the committed changes. Closed by commit rL352473: [analyzer] Toning down invalidation a bit (authored by xazax, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57230?vs=183702&id=18404

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. Thanks for pointing it out. You could use hasFeature from there during construction: return SetCGInfo( new PPC32TargetCodeGenInfo(Types, CodeGenOpts.FloatABI == "soft" || getTarget().hasFeature("spe"))); It works for me, but probably a separate argument is

[PATCH] D57380: [clang-tools-extra] add missing .clang-format and .clang-tidy for use with git monorepo

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: JonasToth, alexfh, hokein, aaron.ballman. MyDeveloperDay added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Before git monorepo, clang-tools-extra inherited its .clang-format and .clang-tidy files from

[PATCH] D56267: [clangd] Interfaces for writing code actions

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE352494: [clangd] Interfaces for writing code tweaks (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D56267?vs=184039&id=184074#toc Repository: rCTE Clang T

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay added a comment. I checked this out and built this and it works really well. The thing I really like is that it helps to format Windows resource include files e.g. 'Resource.h' better than before. Which changes the current clang-formatted version #define IDD_

[PATCH] D57384: [clangd] Make -clang-tidy-checks a non-hidden command-line arg

This revision was automatically updated to reflect the committed changes. Closed by commit rL352509: [clangd] Make -clang-tidy-checks a non-hidden command-line arg (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a subscriber: hfinkel. vit9696 added a comment. That's pretty good. Do you think it is possible to land it in 8.0 release? @hfinkel? @jhibbits could you please include this change too: https://reviews.llvm.org/D49754#1364865? We would prefer to continue using Linux target to be a

[PATCH] D57380: [clang-tools-extra] add missing .clang-format and .clang-tidy for use with git monorepo

MyDeveloperDay abandoned this revision. MyDeveloperDay added a comment. Abandoning as its been superseded by... https://github.com/llvm/llvm-project/commit/149be18dbc4d54328fe33b5ac21dcbbca2b07aa6 Which puts these files at the base of llvm-project Repository: rCTE Clang Tools Extra CHANGES

[PATCH] D57353: [clang-tidy] Add the abseil-duration-double-conversion check

MyDeveloperDay added inline comments. Comment at: docs/clang-tidy/checks/abseil-duration-double-conversion.rst:20 + + + // Original - Conversion to integer and back again hwright wrote: > Eugene.Zelenko wrote: > > Unnecessary empty line. > This is consistent wit

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

This revision was automatically updated to reflect the committed changes. Closed by commit rC352572: [analyzer] NFC: GenericTaintChecker: Revise rule specification mechanisms. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D55734?vs=179436&id=184201#to

[PATCH] D57101: [OpenCL] Add generic addr space to the return of implicit assignment

This revision was automatically updated to reflect the committed changes. Closed by commit rL352617: [OpenCL] Add generic addr space to the return of implicit assignment. (authored by stulova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D55782: Fix isInSystemMacro to handle pasted token

serge-sans-paille updated this revision to Diff 184275. serge-sans-paille added a comment. Patch updated to take into account @rsmith remarks. Test case added as an illustration. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55782/new/ https://reviews.llvm.org/D

[PATCH] D55782: Fix isInSystemMacro to handle pasted token

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments. Comment at: include/clang/Basic/SourceManager.h:1458-1460 + // This happens when the macro is the result of a paste, in that case + // its spelling is the scratch mem

[PATCH] D57452: [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit

This revision was automatically updated to reflect the committed changes. Closed by commit rL352631: [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57452?vs=

[PATCH] D56760: Add a new builtin: __builtin_dynamic_object_size

This revision was automatically updated to reflect the committed changes. Closed by commit rL352665: Add a new builtin: __builtin_dynamic_object_size (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56760?vs=181923&i

[PATCH] D57476: [CodeGenObjC] Use an invoke instead of a call when calling `objc_alloc` or `objc_allocWithZone`

This revision was automatically updated to reflect the committed changes. Closed by commit rC352687: [CodeGenObjC] Handle exceptions when calling objc_alloc or objc_allocWithZone (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D57476?vs=184381&id=184385#toc

[PATCH] D57343: lit: Let lit.util.which() return a normcase()ed path

This revision was automatically updated to reflect the committed changes. Closed by commit rL352704: lit: Let lit.util.which() return a normcase()ed path (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D57343?vs=183912&id=184408#toc Repository: rL LLVM C

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

MyDeveloperDay added inline comments. Comment at: clang-tidy/abseil/WrapUniqueCheck.cpp:27 + + return (ArgRef.str().length() > 0) ? ArgRef.str() + ")" : "()"; +} couldn't this be ``` return (!ArgRef.empty()) ? ArgRef.str() + ")" : "()"; ``` You know I think t

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

MyDeveloperDay added inline comments. Comment at: clang-tidy/abseil/WrapUniqueCheck.cpp:54 + const auto *facExpr = Result.Nodes.getNodeAs("facCons"); + const auto *callExpr = Result.Nodes.getNodeAs("callExpr"); + I'm not sure how expensive getNodeAs is... or if

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

MyDeveloperDay added inline comments. Comment at: clang-tidy/abseil/WrapUniqueCheck.h:27 +private: + std::string getArgs(const SourceManager *SM, const CallExpr *MemExpr); + Nit: could this method could be static in the cpp file and not in the header? Reposito

[PATCH] D57353: [clang-tidy] Add the abseil-duration-double-conversion check

MyDeveloperDay added inline comments. Comment at: docs/clang-tidy/checks/abseil-duration-double-conversion.rst:20 + + + // Original - Conversion to integer and back again hwright wrote: > MyDeveloperDay wrote: > > hwright wrote: > > > Eugene.Zelenko wrote: > > >

[PATCH] D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept

MyDeveloperDay added inline comments. Comment at: clang-tidy/modernize/UseNoexceptCheck.h:1 //===--- UseNoexceptCheck.h - clang-tidy-*- C++ -*-===// // Nit: sorry OCD kicking in... space after tidy and before first - Repository: rCT

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

MyDeveloperDay added a comment. This is the clang-tidy revision that mgiht have caught the str().length() > 0 case D56644: [clang-tidy] readability-container-size-empty handle std::string length() adding a a cross reference for that work. Repository: rCTE

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

MyDeveloperDay added inline comments. Comment at: test/clang-tidy/readability-container-size-empty.cpp:135 + // CHECK-FIXES: {{^ }}if (str.empty()){{$}} + if (str.length() == 0) +; could you add a test that checks if StringRef.str().length() >0 becomes !

[PATCH] D57523: Fix uninitialized value in ABIArgInfo

serge-sans-paille created this revision. serge-sans-paille added a reviewer: hans. Herald added a subscriber: cfe-commits. GCC-9 takes advantage of this uninitialized values to optimize stuff, which ends up in failing validation when compiling clang. This fixes https://bugs.llvm.org/show_bug.cgi

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

This revision was automatically updated to reflect the committed changes. Closed by commit rC352788: [CodeComplete] Propagate preferred types through parser in more cases (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D56723?vs=184038&id=184568#toc Re

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

This revision was automatically updated to reflect the committed changes. Closed by commit rL352796: [clangd] A code action to swap branches of an if statement (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D56611?vs=184588&id=184594#toc Repository:

[PATCH] D53543: [analyzer] MallocChecker: pr39348: Realize that sized delete isn't a custom delete.

This revision was automatically updated to reflect the committed changes. Closed by commit rL345802: [analyzer] pr39348: MallocChecker: Realize that sized delete isn't custom… (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D53265: [PowerPC] Support constraint 'wi' in asm

This revision was automatically updated to reflect the committed changes. Closed by commit rC345809: [Clang][PowerPC] Support constraint 'wi' in asm (authored by helijia, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D53265?vs=169645&i

[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

This revision was automatically updated to reflect the committed changes. Closed by commit rOMP345867: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D53141?vs=172007&id=172

[PATCH] D53979: [analyzer][CTU] Correctly signal in the function index generation tool if there was an error

This revision was automatically updated to reflect the committed changes. Closed by commit rL345965: [analyzer][CTU] Correctly signal in the function index generation tool if there… (authored by xazax, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D54010: [CodeGen] Fix a crash when updating a zeroinitialize designated initializer

This revision was automatically updated to reflect the committed changes. Closed by commit rC346004: [CodeGen] Fix a crash when updating a designated initializer (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D54010?vs=172306&id=172396#toc Repository: r

[PATCH] D53974: [clang-tidy] new check: bugprone-too-small-loop-variable

whisperity added inline comments. Comment at: docs/clang-tidy/checks/bugprone-too-small-loop-variable.rst:18 +This for loop is an infinite loop because the short type can't represent all +values in the [0..size] interval. + Format the interval as code (monospace)

[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

This revision was automatically updated to reflect the committed changes. Closed by commit rC346069: Add /Zc:DllexportInlines option to clang-cl (authored by tikuta, committed by ). Changed prior to commit: https://reviews.llvm.org/D51340?vs=172348&id=172485#toc Repository: rC Clang https:/

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Higuoxing reclaimed this revision. Higuoxing added a comment. In https://reviews.llvm.org/D47687#1288272, @vsapsai wrote: > Sorry, you've decided to abandon the patch, it took a lot of good work. Xing, > are you sure you don't want to see this change finished? No, I am working on this :) > I

[PATCH] D52795: [analyzer][PlistMacroExpansion] Part 3.: Macro arguments are expanded

whisperity added inline comments. Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:1018 +auto It = CurrExpArgTokens.begin(); +while (It != CurrExpArgTokens.end()) { + if (It->isNot(tok::identifier)) { xazax.hun wrote: > Maybe a for loop mor n

[PATCH] D53334: [Frontend/Modules] Show diagnostics on prebuilt module configuration mismatch too

whisperity planned changes to this revision. whisperity added a comment. In https://reviews.llvm.org/D53334#1288057, @dblaikie wrote: > In https://reviews.llvm.org/D53334#1273877, @whisperity wrote: > > > @dblaikie I have created a test, but unfortunately `%clang_cpp` in LIT > > invokes `clang -

[PATCH] D52034: [Clang] Add options -Xclang -coverage-filter and -Xclang -coverage-exclude to filter the files to instrument with gcov

calixte updated this revision to Diff 172752. calixte added a comment. Change options names to -fprofile-exclude-files & -fprofile-filter-files and add some doc in UserManual. Repository: rC Clang https://reviews.llvm.org/D52034 Files: docs/UsersManual.rst include/clang/Driver/Options.t

[PATCH] D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov

calixte updated this revision to Diff 172761. calixte added a comment. Fix plural form of regex and just use ';' as separator. Repository: rC Clang https://reviews.llvm.org/D52034 Files: docs/UsersManual.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/

[PATCH] D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov

calixte updated this revision to Diff 172905. calixte added a comment. Update doc. Repository: rC Clang https://reviews.llvm.org/D52034 Files: docs/UsersManual.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/BackendUtil.cpp lib/Driver/ToolCha

[PATCH] D53334: [Frontend/Modules] Show diagnostics on prebuilt module configuration mismatch too

whisperity updated this revision to Diff 172908. whisperity added a comment. Test was added. Repository: rC Clang https://reviews.llvm.org/D53334 Files: lib/Frontend/CompilerInstance.cpp test/Modules/Inputs/module-mismatch.cppm test/Modules/mismatch-diagnostics.cpp Index: test/Module

[PATCH] D54156: [CodeComplete] Do not complete self-initializations

This revision was automatically updated to reflect the committed changes. Closed by commit rL346301: [CodeComplete] Do not complete self-initializations (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D54156 Files:

[PATCH] D53334: [Frontend/Modules] Show diagnostics on prebuilt module configuration mismatch too

whisperity updated this revision to Diff 173124. whisperity added a comment. Yes, down the line I realised the function is not needed. (It emits a diagnostic because the diagnostic comes from comparing the AST file's config blocks to the current (at the time of import) compilation.) I have simp

[PATCH] D53263: Fix places where the return type of a FunctionDecl was being used in place of the function type

bobsayshilol added a reviewer: rjmccall. bobsayshilol added a comment. Ping. https://reviews.llvm.org/D53263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54298: [clang-cl] Add warning for /Zc:dllexportInlines- when the flag is used with /fallback

This revision was automatically updated to reflect the committed changes. Closed by commit rC346491: [clang-cl] Add warning for /Zc:dllexportInlines- when the flag is used with… (authored by tikuta, committed by ). Changed prior to commit: https://reviews.llvm.org/D54298?vs=173302&id=173305#toc

<    9   10   11   12   13   14   15   16   17   18   >