whisperity added inline comments.
================
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:1018
+ auto It = CurrExpArgTokens.begin();
+ while (It != CurrExpArgTokens.end()) {
+ if (It->isNot(tok::identifier)) {
----------------
xazax.hun wrote:
> Maybe a for loop mor natural here?
I asked this one already in the earlier (non-split) diff and the reason for the
`while` is that there are a lot of conditional moves, advancements and even an
`erase` call in the loop body.
https://reviews.llvm.org/D52795
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
