[PATCH] D104036: [clang][deps] Prevent unintended modifications of the original TU command-line

thakis added a comment. Either this or your concurrent commit broke check-clang: http://45.33.8.238/linux/48839/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104036/new/

[PATCH] D104387: [clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support (PR36003)

thakis added a comment. Nice, that's much less convoluted than I had feared :) Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:1255 +} + } + `/external:env` should happen after winsysroot I think. sysroots try to make builds hermetic and env vars defeat

[PATCH] D104387: [clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support (PR36003)

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. That's a good argument. lgtm. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:1273 + +if (include_var) { + StringRef(*include_var) Why not keep the

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

thakis added a comment. We also see check-all timeout recently (fairly consistently), see https://bugs.chromium.org/p/chromium/issues/detail?id=1221702 Since Stella reported problems with this too, I speculatively reverted it (and follow-ups) in fb32de9e97af0921242a021e30020ffacf7aa6e2

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

thakis added a comment. FWIW https://lab.llvm.org/buildbot/#/builders/123 has been red for several days after this landed too (eg https://lab.llvm.org/buildbot/#/builders/123/builds/4545) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88666/new/ h

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

thakis added a comment. Looks like this breaks check-llvm on mac, see http://45.33.8.238/mac/32814/summary.html Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104058/new/ https://re

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

thakis added a comment. This breaks check-clang: http://45.33.8.238/linux/49502/step_7.txt Please take a look and revert for now if it takes a while to fix. It's been a pretty rough day for the tree. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

thakis added a comment. Probably the "need to bump AST serialization Version after adding a langopt" thing again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104484/new/ https://reviews.llvm.org/D104484 _

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

thakis added a comment. a8bf33ad36837b398d3dabfd5fff1142660a1dca fixed this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104484/new/ https://reviews.llvm.org/D104484 ___

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/43180/step_8.txt "The command line is too long" Maybe some arts could be passed via a response file instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ htt

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

thakis added a comment. In D86671#2920294 , @dougpuob wrote: > In D86671#2919077 , @thakis wrote: > >> This breaks tests on windows: http://45.33.8.238/win/43180/step_8.txt >> >> "The command line is too long" Maybe

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

thakis added a comment. Any news here? This has been broken for over a day now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ https://reviews.llvm.org/D86671 ___ cfe-commits mailing list cfe-c

[PATCH] D107325: [clang-tidy] Fix command line is too long issue which breaks test on Windows

thakis added a comment. Thanks! Since the config file contents are fixed as far as I can tell, maybe we could instead just add a file with the right contents to `clang-tools-extra/test/clang-tidy/checkers/Inputs` and refer to that? (Use `%S/Inputs/myfile.txt`) (Alternatively you could use the

[PATCH] D107325: [clang-tidy] Fix command line is too long issue which breaks test on Windows

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-identifier-naming/hungarian-notation1/.clang-tidy:3 +CheckOptions: + - { key: readability-

[PATCH] D107325: [clang-tidy] Fix command line is too long issue which breaks test on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG559d142331c2: [clang-tidy] Fix command line is too long issue which breaks test on Windows (authored by dougpuob, committed by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D107325: [clang-tidy] Fix command line is too long issue which breaks test on Windows

thakis added a comment. The bot is happy again, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107325/new/ https://reviews.llvm.org/D107325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107703: [AST][clangd] Expose documentation of Attrs on hover.

thakis added a comment. The docs are in rST format. Is that the format LSP wants? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107703/new/ https://reviews.llvm.org/D107703 ___ cfe-commits mailing list c

[PATCH] D107703: [AST][clangd] Expose documentation of Attrs on hover.

thakis added a comment. Also, I tweaked the tablegen bits a bit to be more like all the other tablegen bits in 189911203779e793cb7767ad233d9994a88c7ea3 . Hope that's ok :) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D107961: [clang-format] Distinguish K&R C function definition and attribute

thakis added a comment. Looks like this breaks tests: http://45.33.8.238/linux/53600/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107961/new/ https://reviews.llvm.org/D1

[PATCH] D108223: gn build: Build libclang.so on ELF platforms.

thakis added a comment. Hm, I kind of like the PIC-less build. But probably not worth having a toggle for it, I suppose. So lg, but: Comment at: llvm/utils/gn/secondary/clang/tools/libclang/BUILD.gn:16 - # For now, make libclang a static lib there. - libclang_target_type = "

[PATCH] D108223: gn build: Build libclang.so on ELF platforms.

thakis accepted this revision. thakis added inline comments. This revision is now accepted and ready to land. Comment at: llvm/utils/gn/secondary/llvm/tools/lto/BUILD.gn:19 "//llvm/lib/Target:TargetsToBuild", +":exports", ] Run `gn format` before comi

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

thakis added a comment. This seems to break tests: http://45.33.8.238/linux/49790/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://reviews.llvm.org/D104714 ___ cfe-commits mai

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

thakis added a comment. Oh I see this assumes that lit.site.cfg.py is below clang_obj_root. I guess that's my problem, looking… Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://reviews.llvm.org/D104714 ___

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

thakis added a comment. I landed a fix attempt for my thing in fda790fbfa0cba426d5e3787429a51e09ec64c6d . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://revie

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

thakis added a comment. Another thing: https://reviews.llvm.org/harbormaster/unit/view/789318/ # command stderr: /var/lib/buildkite-agent/builds/llvm-project/clang/test/utils/update_cc_test_checks/check-globals.test:83:10: error: LIT-RUN: expected string not found in input LIT-RUN: PASS:

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

thakis added a comment. This breaks tests on Windows: http://45.33.8.238/win/40864/step_7.txt Please take a look, and please revert if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

thakis added a comment. Thanks. Looks like it flakily fails on mac too every now and then: http://45.33.8.238/mac/33005/step_7.txt Maybe you print something in nondeterministic iteration order? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

thakis added a comment. Cool, can we revert this for now then? Flakily failing on my m1 bot too: http://45.33.8.238/macm1/12514/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

thakis added a comment. Reverted for now in d5402a2fee5d860e20378f819e200865af3a6113 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

thakis added a comment. (here's another flaky failure that was due to this: http://45.33.8.238/mac/33008/step_7.txt ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967 _

[PATCH] D100553: [clangd] Log feature configuration (linux+asan+grpc) of the clangd build

thakis added a comment. (fyi: this broke mac builds. i fixed that in b56e5f8a10c1ec4fd3750bdd269fbad778820326 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100553/new/ https:/

[PATCH] D100553: [clangd] Log feature configuration (linux+asan+grpc) of the clangd build

thakis added a comment. Hm, my fix doesn't work either :/ https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8842935257512920928/+/u/package_clang/stdout?format=raw -c /opt/s/w/ir/cache/builder/src/third_party/llvm/clang-tools-extra/clangd/xpc/XPCTransport.cpp I

[PATCH] D100553: [clangd] Log feature configuration (linux+asan+grpc) of the clangd build

thakis added a comment. Tried again in 2f79acb7b701c41494abff588b5f03a74ea2e11d . If someone wants to figure out how to make xpc see Features.inc in the cmake build, that'd work too. Repository: rG LLVM Github Monorepo CH

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

thakis added a comment. Hi, you have to bump clang/include/clang/Serialization/ASTBitCodes.h's VERSION_MAJOR after adding a LangOption, else builds with LLVM_APPEND_VC_REV=NO won't invalidate their module cache correctly. See e.g. https://reviews.llvm.org/rGb8b7a9dcdcbc Without that, tests are

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

thakis added a comment. Thanks for the fix :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105112/new/ https://reviews.llvm.org/D105112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D105236: [PowerPC] Implement Load and Reserve and Store Conditional Builtins

thakis added a comment. Looks like this breaks tests: http://45.33.8.238/linux/50465/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D

[PATCH] D104915: [OpenCL] Add support of __opencl_c_read_write_images feature macro

thakis added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7412 +!S.getOpenCLOptions().isSupported("__opencl_c_read_write_images", + S.getLangOpts( || DeclTy->isPipeType()) { A

[PATCH] D105311: Optimize getters for non-atomic, copied properties

This revision was automatically updated to reflect the committed changes. Closed by commit rG45ffe6341d96: [clang/objc] Optimize getters for non-atomic, copied properties (authored by dmaclach, committed by thakis). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[PATCH] D105892: [NFC] Silence build warning by placing parentheses around condition

thakis added a comment. This is not NFC, is it? Before, this got evaluated as `(!S.getLangOpts().OpenCLCPlusPlus && S.getLangOpts().OpenCLVersion < 200) || (S.getLangOpts().OpenCLVersion == 300 && !S.getOpenCLOptions().isSupported("__opencl_c_read_write_images", S.getLangOpts()))`. Now, it's e

[PATCH] D105890: [NFC] Add paranthesis around logical expression to silence -Wlogical-op-parentheses warning.

thakis added a comment. I think this is incorrect. See D105892 and https://reviews.llvm.org/D104915#2873851 . Don't blindly land changes to suppress warnings – the warnings exist to tell us something :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D105892: [OpenCL] Add verbosity when checking support of read_write images

thakis added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105892/new/ https://reviews.llvm.org/D105892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D105679: [clangd] Add CMake option to (not) link in clang-tidy checks

thakis added a comment. Nit: I find the name a bit confusing. When I first saw this commit, I thought this would be a list of clang-tidy checks to support, not a binary on/off toggle. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105679/new/ http

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

thakis added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1059 +#undef strcasecmp +#undef strncasecmp + Why do we need this with bazel but not with other windows builds? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112399/new/ h

[PATCH] D109506: [clangd] Print current request context along with the stack trace

thakis added a comment. This doesn't build on windows: http://45.33.8.238/win/47615/step_4.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109506/new/ https://reviews.llvm.org/D10

[PATCH] D109506: [clangd] Print current request context along with the stack trace

thakis added a comment. In D109506#3086214 , @smeenai wrote: > In D109506#3086183 , @thakis wrote: > >> This doesn't build on windows: http://45.33.8.238/win/47615/step_4.txt >> >> Please take a look and revert fo

[PATCH] D109506: [clangd] Print current request context along with the stack trace

thakis added a comment. Thanks for the fixes! My bots are happy now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109506/new/ https://reviews.llvm.org/D109506 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D112287: [clang] Implement CFG construction for @try and @catch

thakis marked 4 inline comments as done. thakis added a comment. Thanks, all done. Looks like there's no range access to a try's catch blocks, so no for-range loop for now. Maybe I'll add range accessors for those later. Comment at: clang/lib/Analysis/CFG.cpp:3895 CFGBlock *

[PATCH] D112287: [clang] Implement CFG construction for @try and @catch

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04f30795f166: [clang] Implement CFG construction for @try and @catch (authored by thakis). Herald added a project: clang. Changed prior to commit:

[PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

thakis added a comment. Follow-up commit https://github.com/llvm/llvm-project/commit/1c2e249f938c50e1b331a1f7adc83c0a381f3897 (which doesn't seem to have its own phab link) broke clangd tests everywhere, e.g. http://45.33.8.238/linux/59134/step_9.txt Please take a look. This is like the third

[PATCH] D112542: [clang] Convert ObjCAtTryStmt to llvm::TrailingObjects

thakis created this revision. thakis added a reviewer: hans. thakis requested review of this revision. And make it final while here. No behavior change. https://reviews.llvm.org/D112542 Files: clang/include/clang/AST/StmtObjC.h Index: clang/include/clang/AST/StmtObjC.h

[PATCH] D112543: [clang] Add range accessor for ObjCAtTryStmt catch_stmts and use it

thakis created this revision. thakis added a reviewer: hans. thakis requested review of this revision. No behavior change. https://reviews.llvm.org/D112543 Files: clang/include/clang/AST/StmtObjC.h clang/lib/AST/StmtPrinter.cpp clang/lib/Analysis/CFG.cpp clang/lib/CodeGen/CGObjCMac.cpp

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

thakis added a comment. Mentioning it here in case others run into the same thing: We bisected a 7x (!) binary size regression to this. Details at https://bugs.chromium.org/p/chromium/issues/detail?id=1261715 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

thakis added inline comments. Comment at: clang/unittests/Interpreter/CMakeLists.txt:5 + OrcJIT + Support ) v.g.vassilev wrote: > v.g.vassilev wrote: > > thakis wrote: > > > Why are these additions needed here again? This change doesn't add any > > > code t

[PATCH] D112542: [clang] Convert ObjCAtTryStmt to llvm::TrailingObjects

thakis added a comment. > Do you think the ObjCAtTryStmt::Create and CreateEmpty methods could be > simplified by using totalSizeToAlloc()? Oh nice. Done :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112542/new/ https://reviews.llvm.org/D112542

[PATCH] D112542: [clang] Convert ObjCAtTryStmt to llvm::TrailingObjects

thakis updated this revision to Diff 382627. thakis added a comment. more CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112542/new/ https://reviews.llvm.org/D112542 Files: clang/include/clang/AST/StmtObjC.h clang/lib/AST/StmtObjC.cpp Index: clang/lib/AST/StmtObjC.cpp

[PATCH] D112543: [clang] Add range accessor for ObjCAtTryStmt catch_stmts and use it

thakis marked an inline comment as done. thakis added a comment. Done, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112543/new/ https://reviews.llvm.org/D112543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D112542: [clang] Convert ObjCAtTryStmt to llvm::TrailingObjects

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c10c9d8e800: [clang] Convert ObjCAtTryStmt to llvm::TrailingObjects (authored by thakis). Herald added a project: clang. Repository: rG LLVM Gith

[PATCH] D112543: [clang] Add range accessor for ObjCAtTryStmt catch_stmts and use it

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc7aaa2efefdd: [clang] Add range accessor for ObjCAtTryStmt catch_stmts and use it (authored by thakis). Herald added a project: clang. Changed prior

[PATCH] D112704: Re-instate -Wweak-template-vtables as a no-op flag

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112704/new/ https://reviews.llvm.org/D112704

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

thakis added a comment. This doesn't seem to be working very well: thakis@thakis:~/src/llvm-project$ cat test.cc #include #include #include int main() { uint16_t hextets[8]; int chars_scanned; char buf[] = "1234:5678:9abc:def0:1234:5678:9abc:def0"; sscanf(buf,

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

thakis added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1059 +#undef strcasecmp +#undef strncasecmp + GMNGeoffrey wrote: > chandlerc wrote: > > thakis wrote: > > > Why do we need this with bazel but not with other windows builds? > > I do

[PATCH] D112289: Support: Use sys::path::is_style_{posix,windows}() in a few places

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/47971/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112289/new/ https://reviews.ll

[PATCH] D113021: [cmake] Make LLVM_ENABLE_LLD=ON work better on macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d3953499c8c: [cmake] Make LLVM_ENABLE_LLD=ON work better on macOS (authored by thakis). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.l

[PATCH] D113096: [X86][MS-InlineAsm] Add constraint *m for memory access w/ global var

thakis added a comment. Looks like this breaks tests on Mac: http://45.33.8.238/mac/38266/step_11.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113096/new/ https://reviews.llvm.

[PATCH] D113189: [clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Generally lg. I find the word "allowlist" (and to a lesser level also "ignorelist") a bit awkward; imho you can often make things more clear by rephrasing things away from "foolist". A few sug

[PATCH] D107994: Making the code compliant to the documentation about Floating Point support default values for C/C++. FPP-MODEL=PRECISE enables FFP-CONTRACT (FMA is enabled).

thakis added a comment. This fixes tests on macOS, but I don't know if the space is there intentionally to check for presence of any attributes: % git diff diff --git a/clang/test/CodeGen/ffp-contract-option.c b/clang/test/CodeGen/ffp-contract-option.c index 04d23d5f90b7..327722f56f4e 100

[PATCH] D112914: Misleading identifier detection

thakis added a comment. The test seems to trigger an assert: http://45.33.8.238/linux/60293/step_9.txt Please take a look! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

thakis added a comment. The test is failing on non-arm macs: http://45.33.8.238/mac/38601/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113120/new/ https://reviews.llvm.o

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: dexonsmith, dang. thakis requested review of this revision. With this, void f() { __asm__("mov eax, ebx"); } now compiles with clang with -masm=intel. This matches gcc. The flag is not accepted in clang-c

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

thakis added a comment. Thanks for pointing out built-in headers, that's a great point. I started adding .att_syntax lines where needed, but the I realized that that doens't work: it's too late for things taking memory, since %0 replacement is done with asm writer setting before getting to read

[PATCH] D97437: Rewrite MSVC toolchain discovery with VFS

thakis added a comment. Thanks for fixing this :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97437/new/ https://reviews.llvm.org/D97437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

thakis added a comment. This seems to flag https://source.chromium.org/chromium/chromium/src/+/master:third_party/libsync/src/sync.c;l=142?q=sync.c&ss=chromium : info->sync_fence_info = (uint64_t) calloc(num_fences, sizeof(struct sync_fence_info)); if ((voi

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

thakis added a comment. FYI, we're seeing test failures caused by this patch in iOS/arm64 builds when arc is used (simulator is fine though): https://bugs.chromium.org/p/chromium/issues/detail?id=1182642#c11 We'll try to investigate a bit more on our side, but I wanted to give an early(ish) he

[PATCH] D97693: [libclang] Remove LIBCLANG_INCLUDE_CLANG_TOOLS_EXTRA

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: arphaman, mgorny. thakis requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. LIBCLANG_INCLUDE_CLANG_TOOLS_EXTRA causes clang-tools-extra tools to be included

[PATCH] D97695: [clang-cl] make -f(no-)ident a CoreOption

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: jansvoboda11, dang. thakis requested review of this revision. https://reviews.llvm.org/D97695 Files: clang/include/clang/Driver/Options.td clang/test/Driver/cl-options.c Index: clang/test/Driver/cl-option

[PATCH] D97695: [clang-cl] make -f(no-)ident a CoreOption

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG83feaa36ad53: [clang-cl] make -f(no-)ident a CoreOption (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D97695: [clang-cl] make -f(no-)ident a CoreOption

thakis added a comment. Thanks! Landed with a more detailed commit description in https://reviews.llvm.org/rG83feaa36ad53ce93ed808169d3316ed757703e47 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97695/new/ https://reviews.llvm.org/D97695 ___

[PATCH] D97693: [libclang] Remove LIBCLANG_INCLUDE_CLANG_TOOLS_EXTRA

This revision was automatically updated to reflect the committed changes. Closed by commit rG52b8e1059731: [libclang] Remove LIBCLANG_INCLUDE_CLANG_TOOLS_EXTRA (authored by thakis). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D97693?vs=327127&id=327175#toc

[PATCH] D97741: [clang+lld] Pass -platform_version args to ld64.lld

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. If I understand this right, the right patch description should be "fix regression where we didn't pass `-platform_version` to new ld64.lld after D95204 ", righ

[PATCH] D97796: [test] Fix apparent typo in clang/test/Driver/std.c

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. I have no memories of this file, but I agree with your analysis :) Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97796/new/

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

thakis added a comment. > Thank you. Let me know when you have more information. Repro is moving along. https://bugs.chromium.org/p/chromium/issues/detail?id=1182642#c26 and onward are getting pretty close. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

thakis added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10326 + !isa( + Cast->getSubExpr()->IgnoreImplicitAsWritten()->IgnoreParens())) +return; cjdb wrote: > cjdb wrote: > > aaron.ballman wrote: > > > I'm not 100% certain, but

[PATCH] D97101: [Coverage] Emit gap region between statements if first statements contains terminate statements.

thakis added a comment. This broke ContinuousSyncMode/basic.c in check-profile on macOS (see e.g. end of https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8853690069583264896/+/steps/package_clang/0/stdout?format=raw), so I reverted it for now. It repros on my lapt

[PATCH] D98156: [clang/mac] Accept -why_load and make -whyload an alias for it

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: jansvoboda11, dang. thakis requested review of this revision. >From `man ld`: -why_load Log why each object file in a static library is loaded. That is, what symbol was needed. A

[PATCH] D98156: [clang/mac] Accept -why_load and make -whyload an alias for it

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG203731d2c82b: [clang/mac] Accept -why_load and make -whyload an alias for it (authored by thakis). Herald added a project: clang. Repository: rG L

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

thakis added a comment. Looks like this breaks tests on mac: http://45.33.8.238/macm1/5075/step_6.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97068/new/ https://reviews.llvm.

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

thakis added a comment. This seems to break tests everywhere: http://45.33.8.238/linux/41275/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97743/new/ https://reviews.llvm.org/D97743 ___ cfe-co

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

thakis added a comment. Still broken: http://45.33.8.238/linux/41278/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97743/new/ https://reviews.llvm.org/D97743 ___ cfe-commits mailing list cfe-c

[PATCH] D96586: [analyzer][CTU][NFC] Add an extra regression test

thakis added a comment. The test doesn't pass: http://45.33.8.238/linux/41341/step_7.txt I think you just need to say `rm -rf` instead of `rm -r` on line 3 (?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96586/new/ https://reviews.llvm.org/D9658

[PATCH] D97107: Replace func name with regex in update_cc_test_checks

thakis added a comment. This breaks check-llvm on linux and mac: http://45.33.8.238/linux/41398/step_12.txt http://45.33.8.238/macm1/5291/step_10.txt http://lab.llvm.org:8011/#/builders/109 (and on my local build too) Please take a look, and please revert for now if it takes a while to fix. Rep

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

thakis added a comment. Hi, this breaks check-clang on arm macs: http://45.33.8.238/macm1/5421/step_6.txt (The `fatal error: 'opencl-c-base.h' file not found` bit is printed when the test passes too, and is unrelated.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

thakis added a comment. Does it repro if you add `-target arm64-apple-macosx` as arg to c-index-test on the RUN line of that test? Here's the output of that RUN line on an arm mac when the test fails: http://pastie.org/p/1go1Y9WXjs5T371RtyJ3Gi Let's revert for now, things have been broken for

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

thakis added a comment. It repros for me with this local diff % git diff diff --git a/clang/test/Index/opencl-types.cl b/clang/test/Index/opencl-types.cl index 496f38752fa2..13f6058864b5 100644 --- a/clang/test/Index/opencl-types.cl +++ b/clang/test/Index/opencl-types.cl @@ -1,4 +1,4

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

thakis added a comment. In case it's useful, here's the output of the RUN line on an m1 mac with this patch locally reverted (where the test passes): http://pastie.org/p/2F3Y0xUMtH5RP9TVRzG4LI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97058/ne

[PATCH] D98539: [OpenCL] Set target as spir for c-index-test for OpenCL

thakis added a comment. Can we get this landed asap please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98539/new/ https://reviews.llvm.org/D98539 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

thakis added a comment. I'm going to revert this in 30 minutes. The tree has been red for 12h due to this then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97058/new/ https://reviews.llvm.org/D97058 _

[PATCH] D93164: [AST] Add generator for source location introspection

thakis added a subscriber: rsmith. thakis added a comment. A few more high-level questions: - What's the point of the intermediary json file? Why not generate the final c++ directly? (As far as I can tell, this wasn't discussed during the review yet) - Do we need to generate code for this at al

[PATCH] D93164: [AST] Add generator for source location introspection

thakis added a comment. ast-dump-tool is still somewhere in lib/ instead of in tools/ in the reland as far as I can tell. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 ___

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

thakis updated this revision to Diff 387381. thakis added a comment. - rebase on top of recent (partially still pending) llvm patches - use `{...|...}` in intrinsic headers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113707/new/ https://reviews.llvm.org/D113707 Files: clang/include

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

thakis added a comment. Fairly big update. I'd like to punt on the pragma for now since this became a lot more involved than expected already (see dependent patches; several of them have already landed). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113707/new/ https://reviews.llvm.or

<    7   8   9   10   11   12   13   14   15   16   >