thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Generally lg. I find the word "allowlist" (and to a lesser level also
"ignorelist") a bit awkward; imho you can often make things more clear by
rephrasing things away from "foolist". A few suggestions along those lines
below.
================
Comment at: clang/include/clang/AST/CommentHTMLTags.td:55
-// Define a blacklist of attributes that are not safe to pass through to HTML
+// Define an ignorelist of attributes that are not safe to pass through to HTML
// output if the input is untrusted.
----------------
"Define a list of…"
================
Comment at: clang/include/clang/AST/CommentHTMLTags.td:58
//
-// FIXME: this should be a whitelist. When changing this to a whitelist, don't
-// forget to change the default in the TableGen backend.
+// FIXME: this should be an allowlist. When changing this to an allowlist,
+// don't forget to change the default in the TableGen backend.
----------------
"This should be a list of attributes that _are_ safe. When making this change,
don't forget…"
================
Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:570
"%select{is not C++|is packed|is a union|is trivially copyable|"
- "has trivial destructor|is standard layout|is in a blacklisted file|"
- "is blacklisted}1">, ShowInSystemHeader,
+ "has trivial destructor|is standard layout|is in a ignorelisted file|"
+ "is ignorelisted}1">, ShowInSystemHeader,
----------------
s/a/an/
================
Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:571
+ "has trivial destructor|is standard layout|is in a ignorelisted file|"
+ "is ignorelisted}1">, ShowInSystemHeader,
InGroup<SanitizeAddressRemarks>;
----------------
"is ignored"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113189/new/
https://reviews.llvm.org/D113189
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
