[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 503046. michaelplatings added a comment. - Make "experimental" more obvious. - Demonstrate using a Clang-generated flag directly in Flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https:

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The name "flag" impli

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings added a comment. Thanks @MaskRay for taking a look and thanks @simon_tatham for the review of the change. This change affects existing code so I think it deserves its own commit, but I'll move it down the stack to before D142932 so that later c

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings updated this revision to Diff 503899. michaelplatings added a comment. Rebase on top of D142905 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145567/new/ https://reviews.llvm.org/D145567 Files:

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 503900. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib.h clang/

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 503902. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td clang/

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 503903. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Dri

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 503904. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h clang/

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 503905. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp cl

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 503906. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst clang/docs/index.rst

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings updated this revision to Diff 503913. michaelplatings added a comment. Tiny tweak: undo an unnecessary change to a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145567/new/ https://reviews.llvm.org/D145567 Files: clang/inclu

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings marked an inline comment as done. michaelplatings added a comment. Thanks @peter.smith. I've opted to leave the comment as-is. If we can expect a tag_set to actually contain flags then I've continued to use that terminology. Comment at: clang/lib/Driver/ToolCha

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 504771. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. parse -> parseYaml Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932

[PATCH] D142932: Multilib YAML parsing

michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:66 + /// options and look similar to them, and others can be defined by a + /// particular multilib.yaml. A multilib is considered compatible if its tags + /// are a subset of the tags der

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 504772. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/Too

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 504774. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 504775. michaelplatings added a comment. Reference Multilib.rst from comment in Multilib.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings marked an inline comment as done. michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:67 + /// a subset of the flags derived from the Clang command line options. + const flag_set &flags() const { return Flags; } ---

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings abandoned this revision. michaelplatings marked an inline comment as done. michaelplatings added a comment. We're going back to "flags": https://discourse.llvm.org/t/rfc-multilib/67494/14 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 505047. michaelplatings added a comment. tags->flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib.h clang/li

[PATCH] D142933: Add -print-multi-selection-tags-experimental option

michaelplatings updated this revision to Diff 505048. michaelplatings added a comment. tags->flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td clang/in

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 505050. michaelplatings added a comment. tags->flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Drive

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 505051. michaelplatings added a comment. tags->flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h clang/in

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 505052. michaelplatings added a comment. tags->flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clan

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 505053. michaelplatings added a comment. tags->flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst clang/docs/index.rst

[PATCH] D153292: [Driver][BareMetal] Error if no matching multilib

michaelplatings created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Previously if no matching multilib was found then the user

[PATCH] D153292: [Driver][BareMetal] Error if no matching multilib

michaelplatings marked an inline comment as done. michaelplatings added a comment. Thanks @simon_tatham. I agree there's definitely scope to improve this. The behaviour is quite specific so I kept the code in the BareMetal toolchain rather than as part of the core Multilib class. Other toolchain

[PATCH] D153418: Adding iconv support to CharSetConverter class

michaelplatings added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:62 +if(Iconv_FOUND AND NOT Iconv_IS_BUILT_IN) + set(system_libs ${system_libs} ${Iconv_LIBRARIES}) +endif() This doesn't look like an idomatic way to link a library. Could you use

[PATCH] D153430: Warn on invalid Arm or AArch64 baremetal target triple

michaelplatings created this revision. michaelplatings added reviewers: peter.smith, DavidSpickett. Herald added subscribers: abidh, kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald ad

[PATCH] D153292: [Driver][BareMetal] Error if no matching multilib

This revision was automatically updated to reflect the committed changes. Closed by commit rG028c1033b1ed: [Driver][BareMetal] Error if no matching multilib (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153292/new/ htt

[PATCH] D153430: Warn on invalid Arm or AArch64 baremetal target triple

michaelplatings updated this revision to Diff 533566. michaelplatings added a comment. Apply @DavidSpickett's suggestions. @peter.smith since the warning is only emitted in specific cases that we can be say with a high degree of confidence are incorrect I think it's accurate to say "invalid". I

[PATCH] D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple

michaelplatings added a comment. >selects the fallback GCC toolchain driver; did you mean > This is a correct description of the current behaviour, but I want to keep the freedom to change the behaviour in future. Therefore I'd like to avoid defining what behaviour an invalid target tripl

[PATCH] D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple

michaelplatings updated this revision to Diff 533904. michaelplatings added a comment. Tweak warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153430/new/ https://reviews.llvm.org/D153430 Files: clang/include/clang/Basic/DiagnosticCo

[PATCH] D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple

This revision was automatically updated to reflect the committed changes. Closed by commit rG041ffc155fd7: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D153691: [Driver][ARM] Warn about -mabi= for assembler input

michaelplatings added a comment. The change seems OK to me in principle, but I'd appreciate the code being more self-descriptive. Thanks. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:528 + +// Accept but warn. +if (Arg *A = Args.getLastArgNoClaim(options::OPT_m

[PATCH] D153691: [Driver][ARM] Warn about -mabi= for assembler input

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153691/new/ https://reviews.llvm.org/D153691 _

[PATCH] D153885: [Clang][Driver] Change missing multilib error to warning

michaelplatings created this revision. michaelplatings added a reviewer: simon_tatham. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The error could be awkward to work around when exper

[PATCH] D153885: [Clang][Driver] Change missing multilib error to warning

michaelplatings updated this revision to Diff 535102. michaelplatings added a comment. Rename variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153885/new/ https://reviews.llvm.org/D153885 Files: clang/include/clang/Basic/DiagnosticDriverKi

[PATCH] D153943: [test] Replace aarch64-*-eabi with aarch64

michaelplatings created this revision. michaelplatings added a reviewer: MaskRay. Herald added subscribers: kmitropoulou, asbirlea, kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commi

[PATCH] D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple

michaelplatings added a comment. In D153430#4453908 , @MaskRay wrote: > Thank you for implementing this warning. Side note: it would be better to (a) > fix the tests separately from (b) implementing the warning and (c) adding > tests to demonstrate the

[PATCH] D153943: [test] Replace aarch64-*-eabi with aarch64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54c79fa53c17: [test] Replace aarch64-*-eabi with aarch64 (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D153885: [Clang][Driver] Change missing multilib error to warning

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc8cbbd55f80: [Clang][Driver] Change missing multilib error to warning (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153885/ne

[PATCH] D146757: [Driver] Enable defining multilib print options independently of flags

michaelplatings added a comment. @phosek ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146757/new/ https://reviews.llvm.org/D146757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. Looks useful, and matches the behaviour I would have expected anyway. The buildkite libcxx tests already rely on being able to pass this variable through, so the same seems d

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

michaelplatings added a comment. It looks like the failing tests already go to some effort to set each of TMP, TEMP & TMPDIR so perhaps they should be simplified to just set CLANG_CRASH_DIAGNOSTICS_DIR instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D146757: [Driver] Enable defining multilib print options independently of flags

michaelplatings updated this revision to Diff 511073. michaelplatings marked 3 inline comments as done. michaelplatings added a comment. Expand constructor comment as suggested by @peter.smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146757/new

[PATCH] D146757: [Driver] Enable defining multilib print options independently of flags

michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:58 + StringRef IncludeSuffix = {}, const flags_list &Flags = flags_list(), + PrintOptionsType PrintOptions = PrintOptionsType::PlusFlags, + const flags_list &Pr

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings updated this revision to Diff 524302. michaelplatings added a comment. Tweak tests to use -### to run faster. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://reviews.llvm.org/D150902 Files: clang/include/clang/B

[PATCH] D146757: [Driver] Enable defining multilib flags verbatim

michaelplatings added a comment. Funnily enough I had the same thought coming to work this morning that we don't need 2 syntaxes. I had an idea that we could only print flags beginning "-" but will consider the other options you suggested as well. Thanks. Repository: rG LLVM Github Monorepo

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

michaelplatings added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:5380-5381 +Builder.CreatePtrToInt(CalleePtr, IntPtrTy); +llvm::Value *AlignedCalleeAddress = Builder.CreateAnd( +CalleeAddress, llvm::ConstantInt::get(IntPtrTy, -2)); +

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

michaelplatings accepted this revision. michaelplatings added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151308/new/ https://reviews.llvm.org/D151308 ___ cfe-commits mailing list cf

[PATCH] D151437: [NFC][Driver] Change MultilibBuilder interface

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Decouple the interfac

[PATCH] D151438: [NFC][Driver] Change Multilib flag representation

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This new representation means that if a string is a valid

[PATCH] D146757: [Driver] Enable defining multilib flags verbatim

michaelplatings abandoned this revision. michaelplatings added a comment. Abandoning this in favour of D151437 & D151438 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146757/new

[PATCH] D151438: [NFC][Driver] Change Multilib flag representation

michaelplatings added a comment. @phosek you made some alternative suggestions: 1. Have two separate lists of include and exclude flags. 2. Store flags as a tuple (or a struct?) of string and a tag (that is include or exclude). The reason for not doing that is to keep multilib selection method

[PATCH] D142893: [NFC] Class for building MultilibSet

michaelplatings updated this revision to Diff 495460. michaelplatings marked 6 inline comments as done. michaelplatings added a comment. Apply improvements suggested by @peter.smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142893/new/ https://

[PATCH] D142893: [NFC] Class for building MultilibSet

michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:25 namespace driver { /// This corresponds to a single GCC Multilib, or a segment of one controlled peter.smith wrote: > It took a bit of reading to work out what the rel

[PATCH] D142905: Change multilib selection algorithm

michaelplatings updated this revision to Diff 495463. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D143059: [NFC] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 495464. michaelplatings added a comment. Herald added a subscriber: jobnoorman. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/

[PATCH] D142905: Change multilib selection algorithm

michaelplatings updated this revision to Diff 495532. michaelplatings marked an inline comment as done. michaelplatings added a comment. Apply improvements suggested by @peter.smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://

[PATCH] D142905: Change multilib selection algorithm

michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:31 public: - using flags_list = std::vector; + using flags_list = std::set; + using arg_list = std::vector; peter.smith wrote: > would flags_set be a better name. I'm gue

[PATCH] D142932: [NFC] Multilib YAML parsing

michaelplatings updated this revision to Diff 495554. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib.h clang/lib/Dri

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings updated this revision to Diff 49. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td clang/include

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 495557. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/Too

[PATCH] D143059: [NFC] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 495558. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 495559. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/lib

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings updated this revision to Diff 495656. michaelplatings marked 6 inline comments as done. michaelplatings added a comment. Apply improvements suggested by @peter.smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 495658. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/Too

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Options.td:4162 def print_multi_lib : Flag<["-", "--"], "print-multi-lib">; +def print_multi_selection_flags : Flag<["-", "--"], "print-multi-selection-flags-experimental">, + HelpText<"Print the fla

[PATCH] D142932: [NFC] Multilib YAML parsing

michaelplatings added a comment. In D142932#4111925 , @phosek wrote: > Do you know if regular expressions are necessary to cover the existing use > cases? Yes. One use case is mapping later architecture versions to the last architecture version support

[PATCH] D142893: [NFC] Class for building MultilibSet

michaelplatings updated this revision to Diff 495798. michaelplatings added a comment. Replace makeMultilibBuilder() with a MultilibBuilder constructor that initializes all suffixes to the same value. In the case of AndroidMipsMultilibs it was apparently intended that only the GCC suffix was se

[PATCH] D142905: Change multilib selection algorithm

michaelplatings updated this revision to Diff 495800. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D142893: [NFC] Class for building MultilibSet

michaelplatings marked 4 inline comments as done. michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:35-39 std::string GCCSuffix; std::string OSSuffix; std::string IncludeSuffix; flags_list Flags; int Priority;

[PATCH] D143587: [Docs] Multilib design

michaelplatings created this revision. michaelplatings added reviewers: peter.smith, phosek. Herald added a subscriber: arphaman. Herald added a project: All. michaelplatings requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D143590: [NFC] Simplify test from change D73904

michaelplatings created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This part of the test can break if multilib is enabled, and isn't

[PATCH] D143590: [NFC] Simplify test from change D73904

This revision was automatically updated to reflect the committed changes. Closed by commit rGf28c28e66457: Simplify test from change D73904 (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143590/new/ https://reviews.llvm

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 496072. michaelplatings added a comment. Made changes requested by @amilendra Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst

[PATCH] D143587: [Docs] Multilib design

michaelplatings marked 3 inline comments as done. michaelplatings added inline comments. Comment at: clang/docs/Multilib.rst:86-89 + a match. + If more than one variant matches then a toolchain may opt to either use only + the *last* matching multilib variant, or may use al

[PATCH] D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a project: All. michaelplatings requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If clang is part of a toolchain that can locate clang_rt libraries

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 496415. michaelplatings marked 7 inline comments as done. michaelplatings added a comment. Incorporate suggestions from @peter.smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://rev

[PATCH] D143587: [Docs] Multilib design

michaelplatings added a comment. > Could be worth adding a design principles section at the end That was a very helpful suggestion, thank you. Writing them out helped me examine the compatibility story more carefully. Consequently I added a requirement for a "minimumClangVersion" property, alth

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 496533. michaelplatings added a comment. Tweak multilib.yaml spec slightly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst

[PATCH] D142932: [NFC] Multilib YAML parsing

michaelplatings updated this revision to Diff 496534. michaelplatings added a comment. Make "variants" required Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib

[PATCH] D143763: [Clang] Add clangMinimumVersion to multilib.yaml

michaelplatings created this revision. michaelplatings added a reviewer: peter.smith. Herald added a subscriber: dmgreen. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This avoids a pot

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 496537. michaelplatings added a comment. Add clangMinimumVersion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp cla

[PATCH] D143059: [NFC] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 496538. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

This revision was automatically updated to reflect the committed changes. Closed by commit rGd61a863050bb: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

michaelplatings added a comment. Hi Petr, In LLVM Embedded Toolchain for Arm we put libclang_rt in the regular library directory, not the resource dir. Therefore `-resource-dir` has no effect for us. Instead of this change, I could have added a `--sysroot` argument to each test, but this change

[PATCH] D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

michaelplatings added a comment. I'm happy to revert this and add `--sysroot` if you prefer. That would fit with keeping the tests hermetic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143666/new/ https://reviews.llvm.org/D143666 __

[PATCH] D144542: [Clang] Improve hermeticity of clang_rt tests

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a project: All. michaelplatings requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Specifying --sysroot prevents libclang_rt from being located in st

[PATCH] D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

michaelplatings added a comment. https://reviews.llvm.org/D144542 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143666/new/ https://reviews.llvm.org/D143666 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D144542: [Clang] Improve hermeticity of clang_rt tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67e28a3010e1: [Clang] Improve hermeticity of clang_rt tests (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142893: [NFC] Class for building MultilibSet

This revision was automatically updated to reflect the committed changes. michaelplatings marked 4 inline comments as done. Closed by commit rG850dab0f2537: [NFC] Class for building MultilibSet (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D142905: Change multilib selection algorithm

michaelplatings updated this revision to Diff 499416. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Remove braces as requested by @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://review

[PATCH] D142932: [NFC] Multilib YAML parsing

michaelplatings updated this revision to Diff 499443. michaelplatings added a subscriber: peter.smith. michaelplatings added a comment. - Squash D143763 into this change as suggested by @MaskRay - Use PascalCase field names as requested by @phosek - Applied impr

[PATCH] D143763: [Clang] Add clangMinimumVersion to multilib.yaml

michaelplatings abandoned this revision. michaelplatings marked 3 inline comments as done. michaelplatings added a comment. Squashed into D142932 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143763/new/ https://r

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings updated this revision to Diff 499450. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Remove braces and blank lines as requested by @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 499479. michaelplatings marked 6 inline comments as done. michaelplatings added a comment. Apply changes requested by @peter.smith and @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings added inline comments. Comment at: clang/test/Driver/baremetal-multilib.cpp:14 +// RUN: | FileCheck %s +// CHECK: "{{.*}}clang{{.*}}" "-cc1" "-triple" "thumbv8m.main-none-unknown-eabihf" +// CHECK-SAME: "-internal-isystem" "{{.*}}/baremetal_multilib/bin/../lib

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 499491. michaelplatings added a comment. Rebase and remove some braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/Ba

<    1   2   3   >