Fznamznon wrote:
> I'm also a bit worried we're updating TextDiagnostic but not SARIFDiagnostic;
> does emitting to SARIF also have interleaving issues?
It seems it does
https://github.com/user-attachments/assets/2837334a-891f-4e1b-8fd0-2f456745ada0";>
I'll try to see what happens in raw_ostre
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/113440
>From 10439ffa9e61240402190538f7a1e1665ca215c8 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Wed, 23 Oct 2024 02:50:50 -0700
Subject: [PATCH] [clang] Apply internal buffering to clang diagnosti
@@ -20008,6 +20008,87 @@ bool Sema::IsValueInFlagEnum(const EnumDecl *ED, const
llvm::APInt &Val,
return !(FlagMask & Val) || (AllowMask && !(FlagMask & ~Val));
}
+bool Sema::ComputeBestEnumProperties(ASTContext &Context, EnumDecl *Enum,
+
https://github.com/Fznamznon commented:
Hi, thank you for the fix! Could you please add a test checking that failing
scenario has been fixed? Could you please also add a release note?
https://github.com/llvm/llvm-project/pull/124819
___
cfe-commits ma
@@ -2610,6 +2610,9 @@ void clang::sema::AnalysisBasedWarnings::IssueWarnings(
// The Callback function that performs analyses:
auto CallAnalyzers = [&](const Decl *Node) -> void {
+if (isa(Node) && Node->hasAttr())
Fznamznon wrote:
The attribute can b
https://github.com/Fznamznon approved this pull request.
I don't have any problem with this either.
https://github.com/llvm/llvm-project/pull/126096
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/126240
>From 04636bea1b873805af02dea865637d7125cee1e5 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Thu, 12 Dec 2024 08:57:37 -0800
Subject: [PATCH 1/2] [MS][clang] Add support for vector deleting des
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/126240
Whereas it is UB in terms of the standard to delete an array of objects via
pointer whose static type doesn't match its dynamic type, MSVC supports an
extension allowing to do it.
Aside from array deletion no
@@ -0,0 +1,41 @@
+// RUN: %clang_cc1 -std=c17 -DPRE_C23 -fsyntax-only -verify -isystem %S/Inputs
%s
+// RUN: %clang_cc1 -std=c23 -DPOST_C23 -fsyntax-only -verify -isystem
%S/Inputs %s
+
+#include
+#include
+
+int printf(const char *restrict, ...);
+
+#if PRE_C23
--
@@ -0,0 +1,41 @@
+// RUN: %clang_cc1 -std=c17 -DPRE_C23 -fsyntax-only -verify -isystem %S/Inputs
%s
+// RUN: %clang_cc1 -std=c23 -DPOST_C23 -fsyntax-only -verify -isystem
%S/Inputs %s
+
+#include
+#include
+
+int printf(const char *restrict, ...);
+
+#if PRE_C23
--
https://github.com/Fznamznon commented:
Perhaps also a release note makes sense so the users know about the change.
https://github.com/llvm/llvm-project/pull/126694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/126694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon approved this pull request.
Makes sense, thank you!
https://github.com/llvm/llvm-project/pull/126658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,41 @@
+// RUN: %clang_cc1 -std=c17 -DPRE_C23 -fsyntax-only -verify -isystem %S/Inputs
%s
+// RUN: %clang_cc1 -std=c23 -DPOST_C23 -fsyntax-only -verify -isystem
%S/Inputs %s
+
+#include
+#include
+
+int printf(const char *restrict, ...);
+
+#if PRE_C23
--
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/126742
When bytes with negative signed char values appear in the data, make sure to
use raw bytes from the data string when preprocessing, not char values.
Fixes https://github.com/llvm/llvm-project/issues/102798
>
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/119402
The C standard doesn't require support for these types and Codegen for these
types is incorrect ATM.
See https://github.com/llvm/llvm-project/issues/119352
>From 9c168204ffa0c23d8138eb1780a0ec54cb29f1c6 Mon S
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/119402
>From 9c168204ffa0c23d8138eb1780a0ec54cb29f1c6 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Tue, 10 Dec 2024 07:50:56 -0800
Subject: [PATCH 1/2] [clang] Reject `_Complex _BitInt`
The C standa
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/119402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/120090
Class BuiltinTypeMethodBuilder has a user-defined destructor so likely compiler
generated special functions may behave incorrectly. Delete explicitly copy
constructor and copy assignment operator to avoid pot
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/120069
CXXMD is checked for null, but it can't be null inside of a visitor's method.
Found by a static analyzer tool.
>From af15db0dcd01cb4295771a77604e9ad7b5c3791c Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Ma
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/120090
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/120090
>From e85b64f919dc3b9e9590f9f344fcb9c277761789 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Mon, 16 Dec 2024 06:29:17 -0800
Subject: [PATCH 1/2] [HLSL][NFC] Fix static analyzer concerns
Class
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/120069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Fznamznon wrote:
> I'm not sure, those enums might evaluate to zero but it makes it clearer and
> correct if they ever change.
No problem, I had the same feeling. Just wanted to double check.
https://github.com/llvm/llvm-project/pull/120259
___
cfe-c
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/120259
Remove unnecessary checks since they are checking that an unsigned number >= 0,
which is always true.
>From d8d8fcf76742e14e6dfe1002e533a097a4ac36f1 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Da
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/120259
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/116976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -627,7 +627,7 @@ class Analyzer {
IsNoexcept = isNoexcept(FD);
} else if (auto *BD = dyn_cast(D)) {
if (auto *TSI = BD->getSignatureAsWritten()) {
-auto *FPT = TSI->getType()->getAs();
+auto *FPT = TSI->getType()->castAs();
https://github.com/Fznamznon approved this pull request.
My concerns are resolved, sorry for holding this!
https://github.com/llvm/llvm-project/pull/117176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
Fznamznon wrote:
@AaronBallman
Tt seems `SetBuffered` is not honored for stderr intentionally :
Here we return 0
https://github.com/llvm/llvm-project/blob/e68a3e4d0dd349a34c02471438d2e97c2b29e846/llvm/lib/Support/raw_ostream.cpp#L858
To not set the buffer here
https://github.com/llvm/llvm-proje
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/117703
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1175,12 +1175,21 @@ Parser::DeclGroupPtrTy
Parser::ParseDeclOrFunctionDefInternal(
}
};
-// Suggest correct location to fix '[[attrib]] struct' to 'struct
[[attrib]]'
+// Suggest correct location to fix '[[attrib]] struct' to 'struct
[[attrib]]'...
https://github.com/Fznamznon commented:
Thank you for the contribution, could you please also add a release note
(similar to other release notes in llvm-project/clang/docs/ReleaseNotes.md) and
a test (similar to some test in clang/test/Parser )?
https://github.com/llvm/llvm-project/pull/124122
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/124122
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon commented:
Yeah, tests seem to be missing
https://github.com/llvm/llvm-project/pull/123495
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2509,6 +2509,20 @@ bool Sema::DiagnoseEmptyLookup(Scope *S, CXXScopeSpec
&SS, LookupResult &R,
DC = DC->getLookupParent();
}
+ // Check whether a similar function-like macro exists and suggest it
Fznamznon wrote:
> I did try it, but in this case t
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/123495
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5936,6 +5936,8 @@ def err_fold_expression_limit_exceeded: Error<
"instantiating fold expression with %0 arguments exceeded expression nesting
"
"limit of %1">, DefaultFatal, NoSFINAE;
+def note_function_like_macro_requires_parens
+: Note<"'%0' is defined here as a
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/121479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -20099,73 +20176,12 @@ void Sema::ActOnEnumBody(SourceLocation EnumLoc,
SourceRange BraceRange,
BestPromotionType = BestType;
BestWidth = Context.getIntWidth(BestType);
- }
- else if (NumNegativeBits) {
-// If there is a negative value, figure out the small
@@ -20008,6 +20008,87 @@ bool Sema::IsValueInFlagEnum(const EnumDecl *ED, const
llvm::APInt &Val,
return !(FlagMask & Val) || (AllowMask && !(FlagMask & ~Val));
}
+bool Sema::ComputeBestEnumProperties(ASTContext &Context, EnumDecl *Enum,
+
https://github.com/Fznamznon approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/120965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2655,6 +2655,15 @@ CXXBaseSpecifier *Sema::CheckBaseSpecifier(CXXRecordDecl
*Class,
return nullptr;
}
+if (BaseType.hasQualifiers() && !isa(BaseType))
{
+ auto Quals =
Fznamznon wrote:
NIT: could you please spell out the type here?
It
@@ -20008,6 +20008,87 @@ bool Sema::IsValueInFlagEnum(const EnumDecl *ED, const
llvm::APInt &Val,
return !(FlagMask & Val) || (AllowMask && !(FlagMask & ~Val));
}
+bool Sema::ComputeBestEnumProperties(ASTContext &Context, EnumDecl *Enum,
+
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/121479
When a single #embed directive is used to initialize a char array, the case is
optimized via swap of EmbedExpr to underlying StringLiteral, resulting in
better performance in AST consumers.
While browsing thr
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/121490
None
>From 2a63bcb5b63f3a8fbeb206fbdbcfc1a328054fe0 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Thu, 12 Dec 2024 08:57:37 -0800
Subject: [PATCH 1/6] Add rough body emission
---
clang/lib/C
Fznamznon wrote:
Oops, too early
https://github.com/llvm/llvm-project/pull/121490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/121490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Fznamznon wrote:
Manual cherry-pick https://github.com/llvm/llvm-project/pull/127222
https://github.com/llvm/llvm-project/pull/126742
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/126978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/126742
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Fznamznon wrote:
> I've uploaded a stand-alone from-source reproducer of the run time crash
> here: https://crbug.com/402425841#comment10
Reproduced. Seems limited to 32-bit build (only reproducible with -m32 option)
and lld linker. Fine with either standard linker or 64-bit build.
https://gi
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/127629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/127629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1752,7 +1752,8 @@ enum class StringLiteralKind {
UTF8,
UTF16,
UTF32,
- Unevaluated
+ Unevaluated,
+ Binary
Fznamznon wrote:
I added some comment. Do you think it turned out helpful?
https://github.com/llvm/llvm-project/pull/127629
___
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/127629
>From 700ec6f78c0a24729801bea381bafbcafb06826b Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Tue, 18 Feb 2025 05:12:07 -0800
Subject: [PATCH 1/3] [clang] Introduce "binary" StringLiteral for #e
Fznamznon wrote:
> No changelog because we want to backport?
No changelog because I forgot. Should we backport though?
https://github.com/llvm/llvm-project/pull/127629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
Fznamznon wrote:
Reduced linkage failure reproducer (can be reduced further, I'm sure), it
consists of 4 files
t.h:
```
#include
struct Base {
Base() {}
virtual ~Base() {}
};
struct ClassA : public Base {
inline ClassA();
virtual ~ClassA(){} ;
};
inline
ClassA::ClassA() {}
vo
Fznamznon wrote:
> I think the `.SCOV$M` section globals should be in the
> `??_EClassA@@UEAAPEXI@Z` comdat group. I think sanitizer coverage (sancov) is
> one of the lesser-used sanitizers here, and it may lack some sophistication
> when it comes to comdat groups. I wasn't aware of this creat
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/127629
>From 700ec6f78c0a24729801bea381bafbcafb06826b Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Tue, 18 Feb 2025 05:12:07 -0800
Subject: [PATCH 1/3] [clang] Introduce "binary" StringLiteral for #e
@@ -4143,6 +4143,7 @@ Sema::IsStringLiteralToNonConstPointerConversion(Expr
*From, QualType ToType) {
// We don't allow UTF literals to be implicitly converted
break;
case StringLiteralKind::Ordinary:
+ case StringLiteralKind::Binary:
Fznamznon wrote:
Ooops, I'll fix the bots quickly
https://github.com/llvm/llvm-project/pull/127629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -319,6 +319,9 @@ Improvements to Clang's diagnostics
- ``-Wc++98-compat`` no longer diagnoses use of ``__auto_type`` or
``decltype(auto)`` as though it was the extension for ``auto``. (#GH47900)
+- Now correctly diagnose use of a tentative definition of an array with stat
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/134088
Sometimes a non-array delete is treated as delete[] when input pointer is
pointer to array. With vector deleting destructors support we now generate a
virtual destructor call instead of simple loop over the e
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/133451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon approved this pull request.
https://github.com/llvm/llvm-project/pull/127061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Fznamznon wrote:
I also noticed that removing -DU_STATIC_IMPLEMENTATION macro passing fixes the
crash.
https://github.com/llvm/llvm-project/pull/126240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
@@ -229,6 +229,12 @@ class CodeGenTypes {
const CGFunctionInfo &arrangeBuiltinFunctionCall(QualType resultType,
const CallArgList &args);
+ /// A SYCL device kernel function is a free standing function with
+ /// spir_kern
@@ -3303,6 +3303,27 @@ void CodeGenModule::EmitDeferred() {
CurDeclsToEmit.swap(DeferredDeclsToEmit);
for (GlobalDecl &D : CurDeclsToEmit) {
+// Functions declared with the sycl_kernel_entry_point attribute are
+// emitted normally during host compilation. During d
Fznamznon wrote:
The problem also is only reproducible when using -start-lib -end-lib options
around icu library object files in the linking command.
https://github.com/llvm/llvm-project/pull/126240
___
cfe-commits mailing list
cfe-commits@lists.llvm.
@@ -0,0 +1,177 @@
+// RUN: %clang_cc1 -fsycl-is-host -emit-llvm -triple x86_64-unknown-linux-gnu
%s -o - | FileCheck --check-prefixes=CHECK-HOST,CHECK-HOST-LINUX %s
+// RUN: %clang_cc1 -fsycl-is-device -emit-llvm -aux-triple
x86_64-unknown-linux-gnu -triple amdgcn %s -o - | File
@@ -0,0 +1,177 @@
+// RUN: %clang_cc1 -fsycl-is-host -emit-llvm -triple x86_64-unknown-linux-gnu
%s -o - | FileCheck --check-prefixes=CHECK-HOST,CHECK-HOST-LINUX %s
+// RUN: %clang_cc1 -fsycl-is-device -emit-llvm -aux-triple
x86_64-unknown-linux-gnu -triple amdgcn %s -o - | File
@@ -0,0 +1,177 @@
+// RUN: %clang_cc1 -fsycl-is-host -emit-llvm -triple x86_64-unknown-linux-gnu
%s -o - | FileCheck --check-prefixes=CHECK-HOST,CHECK-HOST-LINUX %s
+// RUN: %clang_cc1 -fsycl-is-device -emit-llvm -aux-triple
x86_64-unknown-linux-gnu -triple amdgcn %s -o - | File
@@ -732,6 +732,16 @@
CodeGenTypes::arrangeBuiltinFunctionDeclaration(CanQualType resultType,
RequiredArgs::All);
}
+const CGFunctionInfo &
+CodeGenTypes::arrangeSYCLKernelCallerDeclaration(QualType resultType,
+
Fznamznon wrote:
I reduced main code to
```
#include "unicode/filteredbrk.h"
#include
using namespace icu;
int main(int argc, const char** argv) {
UErrorCode status = U_ZERO_ERROR;
//BreakIterator* bi = BreakIterator::createWordInstance(root, status); // Any
iterator will do, make sure fi
Fznamznon wrote:
Removing `static ` from `newUnicodeStringArray` also makes the crash go away...
https://github.com/llvm/llvm-project/pull/126240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Fznamznon wrote:
Thank you for your help @rnk @zmodem !
https://github.com/llvm/llvm-project/pull/126240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/135041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -13,10 +15,41 @@ struct Bar {
struct Baz {
virtual ~Baz() {}
- static void operator delete[](void* ptr) = delete; // expected-note
{{explicitly marked deleted here}}
+ static void operator delete[](void* ptr) = delete; // expected-note
{{explicitly marked deleted here
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/135041
And issue was reported in
https://github.com/llvm/llvm-project/pull/133950 . Since we don't always emit
vector deleting dtors, only error out about ambiguous operator delete[] when it
will be required for vec
Fznamznon wrote:
I posted a PR with a potential fix.
https://github.com/llvm/llvm-project/pull/133950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/135041
>From 9e923b1fe683dea499f7557a48d97aa6d2469c07 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Wed, 9 Apr 2025 09:02:17 -0700
Subject: [PATCH 1/5] [MS][clang] Error about ambigous operator delete
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/135041
>From 9e923b1fe683dea499f7557a48d97aa6d2469c07 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Wed, 9 Apr 2025 09:02:17 -0700
Subject: [PATCH 1/2] [MS][clang] Error about ambigous operator delete
Fznamznon wrote:
Alternatively we can silently fallback to calling scalar operator delete whose
presence is enforced by diagnoistics (i.e call SOMETHING in the vector deleting
destructor like MSVC does) so we don't crash while emitting the destructor and
rely on new[]/delete[] diagnostics.
ht
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/135041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon approved this pull request.
I don't think I have anything to add to the existing feedback.
https://github.com/llvm/llvm-project/pull/133030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
Fznamznon wrote:
I'm concerned though, that MSVC calls SOME destructor and doesn't error out
which seems like a bug. See https://godbolt.org/z/q8znTG5aa .
https://github.com/llvm/llvm-project/pull/135041
___
cfe-commits mailing list
cfe-commits@lists.
Fznamznon wrote:
Soo, I restored all the attributes on vector deleting destructor and the
calling convention (so they are the same as in non-failing case) and the crash
is gone. I'll put a PR reapplying the patch soon. The reduction helped a lot,
thanks!
https://github.com/llvm/llvm-project/p
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/133950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Fznamznon wrote:
@DKLoehr , does clang that is being used also have
https://github.com/llvm/llvm-project/pull/134357 in?
https://github.com/llvm/llvm-project/pull/133950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/135370
See https://github.com/llvm/llvm-project/issues/126629 . Right not they are not
supported properly and support requires modifying several layers of LLVM. For
now simply reject them while proper support is bei
https://github.com/Fznamznon approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/135368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Fznamznon wrote:
> on Windows we could use something like COM1 on Windows.
How would that look like?
https://github.com/llvm/llvm-project/pull/135370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/135370
>From 49e347a73709661fcf3a4805f38cfa2d78e3a196 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Fri, 11 Apr 2025 06:46:00 -0700
Subject: [PATCH 1/3] [clang] Reject character devices in #embed for
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/135370
>From 49e347a73709661fcf3a4805f38cfa2d78e3a196 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Fri, 11 Apr 2025 06:46:00 -0700
Subject: [PATCH 1/4] [clang] Reject character devices in #embed for
Fznamznon wrote:
Yeah, but this is kind of expected. Otherwise it is unclear how to emit vector
deleting destructor body. Should we fallback to calling something, like MSVC
does? See
https://github.com/llvm/llvm-project/pull/135041#issuecomment-2790227622 for
example.
https://github.com/llvm
Fznamznon wrote:
I'm not sure what to say in the release note. Sorry folks, we never really
supported these but now we reject to be safe?
https://github.com/llvm/llvm-project/pull/135370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
Fznamznon wrote:
Oh no, I didn't pick up the test
https://github.com/llvm/llvm-project/pull/135370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/133030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Fznamznon wrote:
> Libcxx tests failed. I'll check them tomorrow.
IMO they fail now in all PRs
https://github.com/llvm/llvm-project/pull/136128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
601 - 700 of 830 matches
Mail list logo
