https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/120259
Remove unnecessary checks since they are checking that an unsigned number >= 0,
which is always true.
>From d8d8fcf76742e14e6dfe1002e533a097a4ac36f1 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya" <mariya.podchishcha...@intel.com>
Date: Tue, 17 Dec 2024 08:15:13 -0800
Subject: [PATCH] [NFC][Clang] Fix static analyzer concerns
Remove unnecessary checks since they are checking that an unsigned
number >= 0, which is always true.
---
clang/lib/Basic/Targets/AMDGPU.h | 1 -
clang/lib/Basic/Targets/NVPTX.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/clang/lib/Basic/Targets/AMDGPU.h b/clang/lib/Basic/Targets/AMDGPU.h
index ea4189cdea47da..e3f0375315ad0c 100644
--- a/clang/lib/Basic/Targets/AMDGPU.h
+++ b/clang/lib/Basic/Targets/AMDGPU.h
@@ -119,7 +119,6 @@ class LLVM_LIBRARY_VISIBILITY AMDGPUTargetInfo final :
public TargetInfo {
(isTargetAddressSpace(A) &&
toTargetAddressSpace(A) == llvm::AMDGPUAS::FLAT_ADDRESS)) &&
isTargetAddressSpace(B) &&
- toTargetAddressSpace(B) >= llvm::AMDGPUAS::FLAT_ADDRESS &&
toTargetAddressSpace(B) <= llvm::AMDGPUAS::PRIVATE_ADDRESS &&
toTargetAddressSpace(B) != llvm::AMDGPUAS::REGION_ADDRESS);
}
diff --git a/clang/lib/Basic/Targets/NVPTX.h b/clang/lib/Basic/Targets/NVPTX.h
index d81b89a7f24ac0..b2f2447917e324 100644
--- a/clang/lib/Basic/Targets/NVPTX.h
+++ b/clang/lib/Basic/Targets/NVPTX.h
@@ -99,7 +99,6 @@ class LLVM_LIBRARY_VISIBILITY NVPTXTargetInfo : public
TargetInfo {
toTargetAddressSpace(A) ==
llvm::NVPTXAS::ADDRESS_SPACE_GENERIC)) &&
isTargetAddressSpace(B) &&
- toTargetAddressSpace(B) >= llvm::NVPTXAS::ADDRESS_SPACE_GENERIC &&
toTargetAddressSpace(B) <= llvm::NVPTXAS::ADDRESS_SPACE_LOCAL &&
toTargetAddressSpace(B) != 2);
}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
