[PATCH] D96487: Restore diagnostic handler after CodeGenAction::ExecuteAction

mantognini created this revision. Herald added a subscriber: dexonsmith. mantognini published this revision for review. mantognini added inline comments. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Comment at: llvm/include/llvm/IR/LLVM

[PATCH] D96487: Restore diagnostic handler after CodeGenAction::ExecuteAction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe54811ff7e0b: Restore diagnostic handler after CodeGenAction::ExecuteAction (authored by mantognini). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

mantognini added a comment. I feel this would be a valuable addition, indeed. Only a minor question from me. Comment at: clang/lib/Driver/Types.cpp:265 .Case("cl", TY_CL) + .Case("clcpp", TY_CLCXX) .Case("cp", TY_CXX) I'm not s

[PATCH] D97203: [OpenCL][PR49264] Allow taking address of functions by enabling the extension

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. looks appropriate to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97203/new/ https://reviews.llvm.org/D97203 ___ cfe-commits

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

mantognini added a comment. Some relatively minor comments, overall direction seems good to me. Comment at: clang/include/clang/Basic/OpenCLOptions.h:67 public: struct OpenCLOptionInfo { // Option starts to be available in this OpenCL version In OpenCL

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

mantognini added a comment. Some minor comments. Comment at: clang/docs/OpenCLSupport.rst:197 +parsing it should not require clang source code modifications. Most commonly +such extensions add functionality via libraries (by adding new non-native +types or functions) parsed reg

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM, thanks for the update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97052/new/ https://reviews.llvm.org/D97052 ___ cfe-comm

[PATCH] D126196: [analyzer] SATest: Ensure Docker image can be built

This revision was automatically updated to reflect the committed changes. Closed by commit rGe15fef41709a: [analyzer] SATest: Ensure Docker image can be built (authored by mantognini). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126196/new/ https:

[PATCH] D126197: [analyzer] SATest: Weaken assumption about HTML files

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ad4f29b545d: [analyzer] SATest: Weaken assumption about HTML files (authored by mantognini). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126197/new/ http

[PATCH] D101043: [OpenCL] Drop extension pragma handling for extension types/declarations

mantognini added a comment. Reasoning and strategy looks sensible to me. I'm not formally approving the patch because I feel I'm not familiar enough with the code base to do that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101043/new/ https://reviews.llvm.org/D101043 __

[PATCH] D100985: [OpenCL] Remove pragma requirement for functions from Arm dot extension

mantognini accepted this revision. mantognini added a comment. Feels appropriate to remove this indeed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100985/new/ https://reviews.llvm.org/D100985 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D100984: [OpenCL] Remove the need for subgroups extension pragma in enqueue kernel builtins

mantognini accepted this revision. mantognini added a comment. Thanks, I believe this goes in the right direction. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100984/new/ https://reviews.llvm.org/D100984 ___ cfe-commits mailing list cfe-com

[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

mantognini added a comment. > This change removes the requirement on pragma when atomic types from the > extensions are supported because the behavior is not conformant. With this > change, the developers can use atomic types from the extensions if they are > supported without enabling the prag

[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

mantognini added inline comments. Comment at: clang/test/Parser/opencl-atomics-cl20.cl:34 atomic_ptrdiff_t pd; -// OpenCL v2.0 s6.13.11.8, _Atomic type specifier and _Atomic type qualifier -// are not supported by OpenCL. - _Atomic int i; // expected-error {{use of undeclared

[PATCH] D93942: [OpenCL] Improve online documentation.

mantognini added a comment. Looks good, only a few typos and minor comments. Comment at: clang/docs/OpenCLSupport.rst:69 ++==+==+==+==

[PATCH] D93958: [OpenCL] Restrict pointer to member functions

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. lgtm, thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93958/new/ https://reviews.llvm.org/D93958 ___ cfe-commits mailing list

[PATCH] D93942: [OpenCL] Improve online documentation.

mantognini added a comment. Thanks for the update. Looks good overall. A minor question about backticks. I'm no native English speaker, so I would recommend a second review from someone else too. Comment at: clang/docs/OpenCLSupport.rst:69 ++==+===

[PATCH] D94021: [OpenCL] Add clang extension for function pointers

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94021/new/ https://reviews.llvm.org/D94021 ___ cfe-commits mailing list cfe-com

[PATCH] D94027: [OpenCL] Add clang extension for variadic functions

mantognini added a comment. LGTM, just one question: I see in the other review you updated clang/test/SemaOpenCL/extension-version.cl. Do you need to do the same here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94027/new/ https://reviews.llvm.org/D94027

[PATCH] D93942: [OpenCL] Improve online documentation.

mantognini added a comment. LGTM, except for a minor typo. Otherwise my comments have been addressed. Thanks. Comment at: clang/docs/OpenCLSupport.rst:69 ++==+==+==+

[PATCH] D94027: [OpenCL] Add clang extension for variadic functions

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. Thanks for the update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94027/new/ https://reviews.llvm.org/D94027 ___ cfe-commits ma

[PATCH] D94188: [OpenCL] Documentation for experimental C++ libraries support

mantognini added a comment. Looks good overall. Comment at: clang/docs/OpenCLSupport.rst:104 +Clang provides the following new WIP features for the developers to experiment +with and provide early feedback or contribute with further improvements. +Feel free to contact us on `cf

[PATCH] D94188: [OpenCL] Documentation for experimental C++ libraries support

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94188/new/ https://reviews.llvm.org/D94188 ___ cfe-commits mailing list cfe-com

<    1   2