[clang] [compiler-rt] [libcxx] [cmake] Add hexagon-linux cmake cache files (PR #98712)

2024-07-15 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,25 @@ + +set(CMAKE_EXE_LINKER_FLAGS "-lclang_rt.builtins-hexagon -nostdlib" CACHE STRING "") +set(CMAKE_SHARED_LINKER_FLAGS "-lclang_rt.builtins-hexagon -nostdlib" CACHE STRING "") +set(CMAKE_CXX_COMPILER_TARGET hexagon-unknown-linux-musl CACHE STRING "") + +set(LLVM_

[clang] [compiler-rt] [libcxx] [cmake] Add hexagon-linux cmake cache files (PR #98712)

2024-07-15 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,25 @@ + +set(CMAKE_EXE_LINKER_FLAGS "-lclang_rt.builtins-hexagon -nostdlib" CACHE STRING "") +set(CMAKE_SHARED_LINKER_FLAGS "-lclang_rt.builtins-hexagon -nostdlib" CACHE STRING "") ldionne wrote: Why are those flags necessary when building for Hexago

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++][WIP] Move the libc++ test format to Lit (PR #90803)

2024-05-06 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/90803 >From ecab1e5689f9f7ea6f87d9cc8c51910b733f6859 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 1 May 2024 18:10:07 -0600 Subject: [PATCH] [libc++][WIP] Move the libc++ test format to Lit This allows the g

[clang] [clang-tools-extra] [libcxx] Reland "[clang] Enable sized deallocation by default in C++14 onwards" (PR #90373)

2024-05-21 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. Let's try this again. Thanks for your perseverance, this is obviously not easy to land but it's important to get it done. Let's hope everything has been addressed this time around. https://github.com/llvm/llvm-project/pull/90373 __

[libunwind] Use relative includes to allow source-based dependencies without `-I` (PR #80443)

2024-05-22 Thread Louis Dionne via cfe-commits
ldionne wrote: > @ldionne, do you find @arichardson reasoning good enough to proceed with > merging this PR? I'm not convinced. We use `#include ` pretty consistently in libc++ and libc++abi and we should strive for all the runtimes to be consistent. I am especially not convinced that the end

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++][WIP] Move the libc++ test format to Lit (PR #90803)

2024-05-22 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,355 @@ +# ===--===## +# +# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++][WIP] Move the libc++ test format to Lit (PR #90803)

2024-05-22 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/90803 >From 4871a82495e0056483759fa207ffbecd63b1e2f8 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 1 May 2024 18:10:07 -0600 Subject: [PATCH] [libc++][WIP] Move the libc++ test format to Lit This allows the g

[clang] [clang][ci] Remove unnecessary BuildKite jobs for Clang (PR #93233)

2024-05-23 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/93233 1. Remove the format-checking job from the BuildKite pipeline. We now have a monorepo-wide format checker implemented with Github Actions, so that should not be necessary anymore. 2. Stop building and testing C

[clang] [clang][ci] Remove unnecessary BuildKite jobs for Clang (PR #93233)

2024-05-23 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/93233 >From 89afeebd55e0ae1167f5af803eb192b73a6e6799 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 23 May 2024 15:31:11 -0400 Subject: [PATCH 1/2] [clang][ci] Remove unnecessary BuildKite jobs for Clang 1. Re

[clang] [clang][ci] Remove unnecessary BuildKite jobs for Clang (PR #93233)

2024-05-23 Thread Louis Dionne via cfe-commits
ldionne wrote: > Do we even need to build Clang and run libc++ jobs? I don't even see them > linked in libc++ PR, even besides the fact that I think libc++ is fully > tested with GitHub Actions. What we're testing is that the changes to Clang didn't break libc++. We're testing Clang via libc+

[clang] [clang][ci] Remove unnecessary BuildKite jobs for Clang (PR #93233)

2024-05-23 Thread Louis Dionne via cfe-commits
ldionne wrote: I will merge once the CI has passed. If someone else sees the CI green, feel free to merge too. @Endilll We could indeed "flatten" the `clang-ci` pipeline into the `github-pull-requests` pipeline. Basically, instead of triggering the `clang-ci` pipeline like this: https://gith

[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)

2024-05-24 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/93318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)

2024-05-24 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/93318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)

2024-05-24 Thread Louis Dionne via cfe-commits
@@ -54,3 +54,68 @@ cmake -S "${MONOREPO_ROOT}"/llvm -B "${BUILD_DIR}" \ echo "--- ninja" # Targets are not escaped as they are passed as separate arguments. ninja -C "${BUILD_DIR}" -k 0 ${targets} + ldionne wrote: I don't think it makes sense to serialize all

[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)

2024-05-24 Thread Louis Dionne via cfe-commits
https://github.com/ldionne requested changes to this pull request. https://github.com/llvm/llvm-project/pull/93318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)

2024-05-24 Thread Louis Dionne via cfe-commits
@@ -54,3 +54,68 @@ cmake -S "${MONOREPO_ROOT}"/llvm -B "${BUILD_DIR}" \ echo "--- ninja" # Targets are not escaped as they are passed as separate arguments. ninja -C "${BUILD_DIR}" -k 0 ${targets} + +runtimes="${3}" +runtime_targets="${4}" + +# Compiling runtimes with just-buil

[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)

2024-05-24 Thread Louis Dionne via cfe-commits
@@ -54,3 +54,68 @@ cmake -S "${MONOREPO_ROOT}"/llvm -B "${BUILD_DIR}" \ echo "--- ninja" # Targets are not escaped as they are passed as separate arguments. ninja -C "${BUILD_DIR}" -k 0 ${targets} + +runtimes="${3}" +runtime_targets="${4}" + +# Compiling runtimes with just-buil

[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)

2024-05-27 Thread Louis Dionne via cfe-commits
@@ -54,3 +54,68 @@ cmake -S "${MONOREPO_ROOT}"/llvm -B "${BUILD_DIR}" \ echo "--- ninja" # Targets are not escaped as they are passed as separate arguments. ninja -C "${BUILD_DIR}" -k 0 ${targets} + ldionne wrote: It seems that we disagree on the approach take

[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)

2024-05-27 Thread Louis Dionne via cfe-commits
@@ -1,82 +0,0 @@ -#===--===## ldionne wrote: `clang/utils/ci/run-buildbot` can be removed too, I think. https://github.com/llvm/llvm-project/pull/93318 __

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-08-01 Thread Louis Dionne via cfe-commits
@@ -3058,6 +3058,133 @@ void Sema::NoteAllFoundTemplates(TemplateName Name) { } } +static QualType commonTypeImpl(Sema &S, TemplateName BaseTemplate, + SourceLocation TemplateLoc, + ArrayRef Ts) { + auto lookUpComm

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-08-01 Thread Louis Dionne via cfe-commits
@@ -1511,6 +1511,46 @@ Attributes (N2335) C2 ``#embed`` (N3017) C23 C89, C++ ===

[clang] [Clang] Add [[clang::diagnose_specializations]] (PR #101469)

2024-08-05 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,34 @@ +// RUN: %clang_cc1 %s -verify + +#if !__has_cpp_attribute(clang::diagnose_specializations) +# error +#endif + +struct [[clang::diagnose_specializations]] S {}; // expected-warning {{'diagnose_specializations' attribute only applies to class templates}} + +templ

[libcxxabi] [libunwind] [libcxxabi][libunwind] Support for using LLVM libc (PR #101688)

2024-08-05 Thread Louis Dionne via cfe-commits
ldionne wrote: > @ldionne I'm starting to think that we should have a generic module in > https://github.com/llvm/llvm-project/tree/main/cmake/Modules that would be > controlled by `LLVM_USE_LIBC` and define `libc-headers`, `libc-static` and > `libc-shared`. That way we could avoid duplicating

[libcxxabi] [libunwind] [libcxxabi][libunwind] Support for using LLVM libc (PR #101688)

2024-08-05 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,39 @@ +#=== ldionne wrote: For now, can't you include `libcxx/cmake/Modules/HandleLibC.cmake` instead? https://github.com/llvm/llvm-project/pull/101688 ___

[libunwind] 1c4867e - [libunwind] Provide a way to conveniently install libunwind headers

2021-12-16 Thread Louis Dionne via cfe-commits
Author: PoYao Chang Date: 2021-12-16T13:32:40-05:00 New Revision: 1c4867e6fc507fe6e81cfc0e3c7148307b4b7433 URL: https://github.com/llvm/llvm-project/commit/1c4867e6fc507fe6e81cfc0e3c7148307b4b7433 DIFF: https://github.com/llvm/llvm-project/commit/1c4867e6fc507fe6e81cfc0e3c7148307b4b7433.diff L

[libunwind] 54a8a0d - [runtimes] Allow FOO_TEST_CONFIG to be a relative path

2021-10-05 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2021-10-05T19:45:50-04:00 New Revision: 54a8a0d09a572a0581c0755541847e016274e15c URL: https://github.com/llvm/llvm-project/commit/54a8a0d09a572a0581c0755541847e016274e15c DIFF: https://github.com/llvm/llvm-project/commit/54a8a0d09a572a0581c0755541847e016274e15c.diff

[libunwind] 60fe1f5 - [runtimes][ci] Run the tests for libunwind in the CI

2021-10-06 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2021-10-06T11:25:26-04:00 New Revision: 60fe1f59d08b815a280761e625d12a74a501f444 URL: https://github.com/llvm/llvm-project/commit/60fe1f59d08b815a280761e625d12a74a501f444 DIFF: https://github.com/llvm/llvm-project/commit/60fe1f59d08b815a280761e625d12a74a501f444.diff

[libunwind] df3de76 - [libc++abi] Change LIBCXXABI_NO_TIMER to LIBCXXABI_USE_TIMER

2021-10-13 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2021-10-13T08:02:31-04:00 New Revision: df3de7647e034797ae3c965d6737bc0a4bc7a779 URL: https://github.com/llvm/llvm-project/commit/df3de7647e034797ae3c965d6737bc0a4bc7a779 DIFF: https://github.com/llvm/llvm-project/commit/df3de7647e034797ae3c965d6737bc0a4bc7a779.diff

[libunwind] 6fd55bb - [libunwind] Add a from-scratch config for running libunwind tests

2021-10-19 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2021-10-19T12:03:58-04:00 New Revision: 6fd55bba61bb4df98f9485b8d3cfc9e956d992b8 URL: https://github.com/llvm/llvm-project/commit/6fd55bba61bb4df98f9485b8d3cfc9e956d992b8 DIFF: https://github.com/llvm/llvm-project/commit/6fd55bba61bb4df98f9485b8d3cfc9e956d992b8.diff

[libunwind] 5a8ad80 - [libunwind] Use the from-scratch testing configuration by default

2021-10-20 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2021-10-20T08:45:58-04:00 New Revision: 5a8ad80b6fa5cbad58b78384f534b78fca863e7f URL: https://github.com/llvm/llvm-project/commit/5a8ad80b6fa5cbad58b78384f534b78fca863e7f DIFF: https://github.com/llvm/llvm-project/commit/5a8ad80b6fa5cbad58b78384f534b78fca863e7f.diff

[libunwind] 070a2dd - [libunwind] Revert "Use the from-scratch testing configuration by default"

2021-10-20 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2021-10-20T17:40:23-04:00 New Revision: 070a2ddcb6657f1b497b8003384bae31e27e497d URL: https://github.com/llvm/llvm-project/commit/070a2ddcb6657f1b497b8003384bae31e27e497d DIFF: https://github.com/llvm/llvm-project/commit/070a2ddcb6657f1b497b8003384bae31e27e497d.diff

[libunwind] e6f39c8 - [libunwind] Fix path to libunwind for per-target-runtime-dir builds

2021-10-22 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2021-10-22T14:36:14-04:00 New Revision: e6f39c8b4891242c0d0d8e7a78041614d9bcdefc URL: https://github.com/llvm/llvm-project/commit/e6f39c8b4891242c0d0d8e7a78041614d9bcdefc DIFF: https://github.com/llvm/llvm-project/commit/e6f39c8b4891242c0d0d8e7a78041614d9bcdefc.diff

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-08-19 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/80007 >From ad17e287c4ceed5d6148d52cbb0ed31fd0d04e99 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 12 Oct 2022 18:06:32 -0400 Subject: [PATCH] [runtimes] Always define cxx_shared, cxx_static & other targets

[libcxx] [libcxxabi] [libunwind] [libc++/libc++abi/libunwind] Add new test configs for Clang runtime library. NFC. (PR #82734)

2024-08-19 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,32 @@ +# This testing configuration handles running the test suite against LLVM's libc++ +# using a static library. +# +# This configuration uses a 'just-built' Clang runtime builtins library to link with +# the tests instead of the target system library. +# +# Provid

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-08-21 Thread Louis Dionne via cfe-commits
ldionne wrote: Ping @petrhosek @vitalybuka. I would like to merge this patch this week. CI seems to be happy, but your CI may be doing something different since IIRC this patch upset your bots the last time I tried landing it. Can you take it for a round to see if that's still the case? https

[clang] [clang][driver] Fix -print-target-triple OS version for apple targets (PR #104037)

2024-08-21 Thread Louis Dionne via cfe-commits
ldionne wrote: Thanks for the writeup, this is useful. This leaves me wondering if `arm64-apple-darwin22.4.0` might be the right target triple then, but the effective triple would be e.g. `arm64-apple-macos12.0.0`? https://github.com/llvm/llvm-project/pull/104037 __

[libunwind] [libunwind] Stop installing the mach-o module map (PR #105616)

2024-08-22 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/105616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Merge lifetimebound and GSL code paths for lifetime analysis (PR #104906)

2024-08-23 Thread Louis Dionne via cfe-commits
ldionne wrote: @hokein @vvereschaka Yeah, I get the same conclusion as you. I think that's a false positive, this is just moving the content of an engaged `std::optional`. https://github.com/llvm/llvm-project/pull/104906 ___ cfe-commits mailing list c

[clang] [Clang] Add __builtin_is_within_lifetime to implement P2641R4's std::is_within_lifetime (PR #91895)

2024-08-23 Thread Louis Dionne via cfe-commits
https://github.com/ldionne commented: I did a very cursory review and this seems good to me, the tests seem to cover what the paper was intending to provide. https://github.com/llvm/llvm-project/pull/91895 ___ cfe-commits mailing list cfe-commits@list

[clang] [Clang] Add __builtin_is_within_lifetime to implement P2641R4's std::is_within_lifetime (PR #91895)

2024-08-23 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,431 @@ +// RUN: %clang_cc1 -std=c++20 -Wno-unused %s -verify=expected,cxx20 -Wno-vla-cxx-extension +// RUN: %clang_cc1 -std=c++23 -Wno-unused %s -verify=expected,sincecxx23 -Wno-vla-cxx-extension +// RUN: %clang_cc1 -std=c++26 -Wno-unused %s -verify=expected,sincecxx2

[clang] [Clang] Add __builtin_is_within_lifetime to implement P2641R4's std::is_within_lifetime (PR #91895)

2024-08-23 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/91895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement `__is_virtual_base_of()` intrinsic (PR #100393)

2024-08-23 Thread Louis Dionne via cfe-commits
ldionne wrote: The libc++ part: https://github.com/llvm/llvm-project/pull/105847 https://github.com/llvm/llvm-project/pull/100393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add __builtin_is_within_lifetime to implement P2641R4's std::is_within_lifetime (PR #91895)

2024-08-23 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,431 @@ +// RUN: %clang_cc1 -std=c++20 -Wno-unused %s -verify=expected,cxx20 -Wno-vla-cxx-extension +// RUN: %clang_cc1 -std=c++23 -Wno-unused %s -verify=expected,sincecxx23 -Wno-vla-cxx-extension +// RUN: %clang_cc1 -std=c++26 -Wno-unused %s -verify=expected,sincecxx2

[libcxxabi] [libunwind] [libcxxabi][libunwind] Support for using LLVM libc (PR #101688)

2024-08-23 Thread Louis Dionne via cfe-commits
ldionne wrote: Gentle ping https://github.com/llvm/llvm-project/pull/101688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

2024-08-26 Thread Louis Dionne via cfe-commits
@@ -284,7 +284,7 @@ def sync_csv(rows: List[Tuple], from_github: List[PaperInfo]) -> List[Tuple]: results.append(gh.for_printing()) continue elif paper.status != gh.status: -print(f"We found a CSV row and a Github issue with differen

[clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

2024-08-26 Thread Louis Dionne via cfe-commits
https://github.com/ldionne requested changes to this pull request. https://github.com/llvm/llvm-project/pull/105990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libcxx] [libunwind] [llvm] [openmp] [cmake] switch to CMake's native `check_{compiler,linker}_flag` (PR #96171)

2024-06-25 Thread Louis Dionne via cfe-commits
ldionne wrote: @h-vetinari This one still looks like a real issue: https://buildkite.com/llvm-project/github-pull-requests/builds/74912#01903ca1-8089-4388-afdb-b65d400e6315 The rest looks good indeed. https://github.com/llvm/llvm-project/pull/96171 _

[clang] [compiler-rt] [libcxx] [libunwind] [llvm] [openmp] [cmake] switch to CMake's native `check_{compiler,linker}_flag` (PR #96171)

2024-06-26 Thread Louis Dionne via cfe-commits
ldionne wrote: I'm sorry to be the bearer of bad news, but it looks like Android is failing with this patch: https://buildkite.com/llvm-project/libcxx-ci/builds/35981#01905269-56a0-4314-a350-0b99ece37e89 This is kinda weird, it fails due to the ABI list changing. I checked other recent execut

[libunwind] eeb9316 - [runtimes][NFC] Improve error message when running Lit incorrectly

2024-06-26 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2024-06-26T15:44:28-05:00 New Revision: eeb931641ae735faa25283ddb2465318302e864f URL: https://github.com/llvm/llvm-project/commit/eeb931641ae735faa25283ddb2465318302e864f DIFF: https://github.com/llvm/llvm-project/commit/eeb931641ae735faa25283ddb2465318302e864f.diff

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Probe for -nostdlib++ and -nostdinc++ with the C compiler (PR #108357)

2024-09-12 Thread Louis Dionne via cfe-commits
@@ -38,9 +38,13 @@ check_cxx_compiler_flag(-nolibc CXX_SUPPORTS_NOLIBC_FLAG) # required during compilation (which has the -nostdlib++ or -nodefaultlibs). libc is # required for the link to go through. We remove sanitizers from the # configuration checks to avoid spurious link

[clang] [clang][NFC] Add missing space in -Wunsafe-buffer-usage documentation (PR #107905)

2024-09-16 Thread Louis Dionne via cfe-commits
ldionne wrote: I don't think this is very controversial so I'll land now that the CI has run. https://github.com/llvm/llvm-project/pull/107905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [clang][NFC] Add missing space in -Wunsafe-buffer-usage documentation (PR #107905)

2024-09-16 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/107905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Remove unused HAVE_LIBCXXABI variable from Android cache (PR #111007)

2024-10-08 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/111007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-10-08 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/80007 >From 447159a21d73d6b4b5c6f6c4710231f01e0af4fc Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 12 Oct 2022 18:06:32 -0400 Subject: [PATCH] [runtimes] Always define cxx_shared, cxx_static & other targets

[clang] Fix out-of-bounds access to std::unique_ptr (PR #111581)

2024-10-09 Thread Louis Dionne via cfe-commits
ldionne wrote: Amazing to see this paying off! https://github.com/llvm/llvm-project/pull/111581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-10-09 Thread Louis Dionne via cfe-commits
ldionne wrote: @petrhosek Where is the cache generating that build? The fix for this is: ``` # On embedded platforms that don't support shared library targets, CMake implicitly changes shared # library targets to be static library targets. This results in duplicate definitions of the static #

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-10-10 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/80007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia][CMake] Set output name for libc++ shared library (PR #111791)

2024-10-10 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/111791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia][CMake] Set output name for libc++ shared library (PR #111791)

2024-10-10 Thread Louis Dionne via cfe-commits
ldionne wrote: Thanks! https://github.com/llvm/llvm-project/pull/111791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia][CMake] Set output name for libc++ shared library (PR #111791)

2024-10-10 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/111791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [runtimes][NFC] Reindent CMake files (PR #111821)

2024-10-10 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/111821 This is a purely mechanical commit for fixing the indentation of the runtimes' CMakeLists files after #80007. That PR didn't update the indentation in order to make the diff easier to review and for merge confl

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-10-08 Thread Louis Dionne via cfe-commits
ldionne wrote: I had to fix how we were excluding targets from `EXCLUDE_FROM_ALL`, which didn't work as intended and was breaking the MinGW CI. I'll merge this if the CI passes. https://github.com/llvm/llvm-project/pull/80007 ___ cfe-commits mailing

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-10-08 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/80007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-10-11 Thread Louis Dionne via cfe-commits
ldionne wrote: If other folks get here because of an error like `multiple rules generate lib/SOMETHING.a`, this is the issue (from https://github.com/llvm/llvm-project/pull/80007#issuecomment-2402188675): > > The fix for this is: > > ``` > # On embedded platforms that don't support shared li

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-18 Thread Louis Dionne via cfe-commits
ldionne wrote: Can you explain again why the compiler isn't providing the C library and the start files implicitly by default, just like it does for non-GPU code? https://github.com/llvm/llvm-project/pull/112025 ___ cfe-commits mailing list cfe-commi

[clang] [compiler-rt] [libcxx] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-10-21 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/112978 >From a57278b0c6a34dda5b937bae2e37c5c57855ac9a Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 13 May 2022 09:26:01 -0400 Subject: [PATCH 1/3] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends

[libcxx] [libcxxabi] [libunwind] [runtimes] Improve the documentation for LIBCXX_ADDITIONAL_COMPILE_FLAGS (PR #112733)

2024-10-17 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/112733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [runtimes] Avoid cluttering the top-level build directory with test artifacts (PR #112717)

2024-10-17 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/112717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-10-10 Thread Louis Dionne via cfe-commits
ldionne wrote: @ilovepi Some things that *could* be going wrong: The `cxx_shared` target is now defined when it wasn't before, and something in your CMake has e.g. `if (TARGET cxx_shared)` and does something it shouldn't based on that. Otherwise, it's also possible that `libc++.so` doesn't get

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-10-10 Thread Louis Dionne via cfe-commits
ldionne wrote: Also, this is another reminder that we would benefit from having Fuchsia builders in the pre-commit CI. We've asked before and we'll keep asking until we get them: Fuchsia is amongst the last platform that frequently reports errors but doesn't provide us with any pre-commit visi

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-10 Thread Louis Dionne via cfe-commits
ldionne wrote: Converting to draft since this is for discussion only. https://github.com/llvm/llvm-project/pull/111861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-10 Thread Louis Dionne via cfe-commits
https://github.com/ldionne converted_to_draft https://github.com/llvm/llvm-project/pull/111861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [runtimes][NFC] Reindent CMake files (PR #111821)

2024-10-10 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/111821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Fix libunwind library path for runtime test (PR #110777)

2024-10-02 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/110777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Fix libunwind library path for runtime test (PR #110777)

2024-10-02 Thread Louis Dionne via cfe-commits
ldionne wrote: > > This can be merged by whoever sees the CI green first. > > There are 6 failing build so far but all due to the "runner received a > shutdown signal", not actually a build/test failure? Should I do another > rebase to trigger a rerun? Or we can just land it now? Merged since

[clang] [compiler-rt] [libcxx] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-10-22 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/112978 >From 85bac5f281c3d6038eda67eb8c0faf356a51c621 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 13 May 2022 09:26:01 -0400 Subject: [PATCH 1/4] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/111861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: https://github.com/ldionne commented: Thanks a lot, I think this is a really promising proposal. I would love to have something like that in the standard library. I think the main thing that's still missing he

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -0,0 +1,517 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -0,0 +1,517 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -0,0 +1,517 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -0,0 +1,517 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -0,0 +1,517 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -0,0 +1,517 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -0,0 +1,517 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -0,0 +1,517 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -0,0 +1,517 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -0,0 +1,517 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -0,0 +1,517 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -0,0 +1,517 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -0,0 +1,517 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Probe for -nostdlib++ and -nostdinc++ with the C compiler (PR #108357)

2024-10-25 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/108357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread Louis Dionne via cfe-commits
ldionne wrote: Trying to understand what this patch does, basically it adds a summary when looking at the results of a BuildKite job? Previously: https://github.com/user-attachments/assets/62dcabf5-414d-4c6b-928d-55df39ca02e0";> After this patch: https://github.com/user-attachments/assets/489b

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-10-24 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From cb6359e96c6fd2c2af90f84c32487977a6e1b819 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 31 Jul 2024 13:00:25 -0400 Subject: [PATCH 1/3] [libc++] Make benchmarks forward-compatible with the test su

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread Louis Dionne via cfe-commits
ldionne wrote: > The script is already written and works, and there still isn't a concrete > timeline for when we are going to move things over to Github actions. This > solves a valid complaint I hear somewhat often. For libc++ at least, there > are definitely platforms that will not be able

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-29 Thread Louis Dionne via cfe-commits
ldionne wrote: FWIW, I didn't mean to derail this effort or create significant additional complexity by saying what I said above. My intention was only to point out the tradeoff of adding new functionality for a temporary benefit, which wasn't clear to me had been thought about in those terms.

[clang] [compiler-rt] [libcxx] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-11-04 Thread Louis Dionne via cfe-commits
ldionne wrote: > Looking at our current cmake config, we're using: > > ``` > -DLIBCXX_STATICALLY_LINK_ABI_IN_STATIC_LIBRARY=ON \ > -DLIBCXX_ENABLE_ABI_LINKER_SCRIPT=ON \ > ``` > > Do I understand correctly that the new replacement for that would be? > > ``` > -DLIBCXX_ABILIB_FOR_SHARED="shared

[compiler-rt] [libunwind] [llvm] [cmake] Remove obsolete files, docs and CMake variables related to the standalone build (PR #112741)

2024-11-05 Thread Louis Dionne via cfe-commits
ldionne wrote: Both CI failures seem to be unrelated. https://github.com/llvm/llvm-project/pull/112741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libcxx] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-11-05 Thread Louis Dionne via cfe-commits
@@ -230,11 +230,22 @@ else() endif() set(LIBCXX_SUPPORTED_ABI_LIBRARIES none libcxxabi system-libcxxabi libcxxrt libstdc++ libsupc++ vcruntime) -set(LIBCXX_CXX_ABI "${LIBCXX_DEFAULT_ABI_LIBRARY}" CACHE STRING "Specify C++ ABI library to use. Supported values are ${LIBCXX_SUP

[clang] [compiler-rt] [libcxx] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-11-05 Thread Louis Dionne via cfe-commits
@@ -230,11 +230,22 @@ else() endif() set(LIBCXX_SUPPORTED_ABI_LIBRARIES none libcxxabi system-libcxxabi libcxxrt libstdc++ libsupc++ vcruntime) -set(LIBCXX_CXX_ABI "${LIBCXX_DEFAULT_ABI_LIBRARY}" CACHE STRING "Specify C++ ABI library to use. Supported values are ${LIBCXX_SUP

<    3   4   5   6   7   8   9   10   >