https://github.com/ldionne labeled
https://github.com/llvm/llvm-project/pull/65517
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
The direction we've been taking with these config files is to keep the base
config setup as simple as possible and avoid the proliferation of options that
are not fundamentally tied to the test suite. These kinds of options should
instead be hardcoded in a suitable `.cfg.in` fil
ldionne wrote:
Your `.cfg.in` files can use CMake variables themselves! In fact you can even
add new parameters that are only valid for that configuration of the library,
for example see
https://github.com/llvm/llvm-project/blob/main/libcxx/test/configs/apple-libc%2B%2B-backdeployment.cfg.in#L
ldionne wrote:
There shouldn't be any changes under libcxxabi. Those changes are not necessary.
https://github.com/llvm/llvm-project/pull/66295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
@@ -2,6 +2,24 @@
@SERIALIZED_LIT_PARAMS@
+# Workaround for https://gitlab.kitware.com/cmake/cmake/-/issues/19180.
+#
+# On Apple platforms, CMake resolves the compiler to the final binary using
+# `$(xcrun --find `). Unfortunately, running this compiler as-is
+# doesn't work
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/66265:
>From c325c0ba95e6d6abe7ff1a371853051bab0510af Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 13 Sep 2023 13:30:30 -0400
Subject: [PATCH] [runtimes] Remove explicit -isysroot from the testing
configurat
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/66265:
>From dfca35edb3eb6c0cd2e7d3292f854dcd9bdc6cb7 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 13 Sep 2023 13:30:30 -0400
Subject: [PATCH] [runtimes] Remove explicit -isysroot from the testing
configurat
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/66509
Instead of using the BuildKite jobs, use GitHub actions to detect clang-format
violations and trailing whitespace in PRs.
Fixes #66468
>From 46330c22414ed8722e85ff349f502d4e5a1bac5d Mon Sep 17 00:00:00 2001
Fro
ldionne wrote:
@tru Sounds good! I gave you https://github.com/llvm/llvm-project/issues/66468
too.
https://github.com/llvm/llvm-project/pull/66509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
ldionne wrote:
I guess I'll close this and reopen when I have something that actually works
for handling trailing whitespace.
https://github.com/llvm/llvm-project/pull/66509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/66509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
ldionne wrote:
You're right, sorry for the noise. It supports a custom comparator, not a
custom projection. I
https://github.com/ldionne resolved
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
ldionne wrote:
You're right, sorry for the noise. It supports a custom comparator, not a
custom projection. I
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
https://github.com/ldionne resolved
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -108,7 +108,33 @@ constexpr bool test() {
auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove {
return x; };
assert(&std::ranges::clamp(val, low, high, moving_comp, prvalue_proj) ==
&val);
}
+ { // Make sure we don't call the projection more than
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -108,7 +108,33 @@ constexpr bool test() {
auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove {
return x; };
assert(&std::ranges::clamp(val, low, high, moving_comp, prvalue_proj) ==
&val);
}
+ { // Make sure we don't call the projection more than
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -108,7 +108,33 @@ constexpr bool test() {
auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove {
return x; };
assert(&std::ranges::clamp(val, low, high, moving_comp, prvalue_proj) ==
&val);
}
+ { // Make sure we don't call the projection more than
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
ldionne wrote:
What a tricky change! The ones that seem simple are sometimes the ones that end
up being the most involved :)
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
ldionne wrote:
What a tricky change! The ones that seem simple are sometimes the ones that end
up being the most involved :)
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
@@ -108,7 +108,33 @@ constexpr bool test() {
auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove {
return x; };
assert(&std::ranges::clamp(val, low, high, moving_comp, prvalue_proj) ==
&val);
}
+ { // Make sure we don't call the projection more than
@@ -108,7 +108,33 @@ constexpr bool test() {
auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove {
return x; };
assert(&std::ranges::clamp(val, low, high, moving_comp, prvalue_proj) ==
&val);
}
+ { // Make sure we don't call the projection more than
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
Author: Louis Dionne
Date: 2023-09-15T17:26:16-04:00
New Revision: a52560c8dd804104041e3cde4d9b9b89bf22f81e
URL:
https://github.com/llvm/llvm-project/commit/a52560c8dd804104041e3cde4d9b9b89bf22f81e
DIFF:
https://github.com/llvm/llvm-project/commit/a52560c8dd804104041e3cde4d9b9b89bf22f81e.diff
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/66649
Fixes #66468
>From df20b6321bf9332571fc4e45ae370793876f7773 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Mon, 18 Sep 2023 09:58:29 -0400
Subject: [PATCH] [clang] Improve CI output when trailing whitespace i
ldionne wrote:
@asl This should make it a bit more explicit. I see this now when running
locally:
```
+ echo '*** Checking for trailing whitespace left in Clang source files ***'
*** Checking for trailing whitespace left in Clang source files ***
+ grep -rnI '[[:blank:]]$' clang/lib clang/inclu
https://github.com/ldionne resolved
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne resolved
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
> Any idea why the CI is failing? It mentions line 86 not being constexpr
> because of assert, but it doesn't seem like I've done anything which should
> affect that...
I looked into it a bit and I think the CI is failing because of the
`std::forward` problem. The assertion on
ldionne wrote:
> Any idea why the CI is failing? It mentions line 86 not being constexpr
> because of assert, but it doesn't seem like I've done anything which should
> affect that...
I looked into it a bit and I think the CI is failing because of the
`std::forward` problem. The assertion on
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
@@ -108,7 +108,34 @@ constexpr bool test() {
auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove {
return x; };
assert(&std::ranges::clamp(val, low, high, moving_comp, prvalue_proj) ==
&val);
}
+ { // Make sure we don't call the projection more than
@@ -108,7 +108,34 @@ constexpr bool test() {
auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove {
return x; };
assert(&std::ranges::clamp(val, low, high, moving_comp, prvalue_proj) ==
&val);
}
+ { // Make sure we don't call the projection more than
Author: Nikolas Klauser
Date: 2023-07-12T08:33:22-04:00
New Revision: 2a3322bab069166dd0da8474534d0b8dad25b949
URL:
https://github.com/llvm/llvm-project/commit/2a3322bab069166dd0da8474534d0b8dad25b949
DIFF:
https://github.com/llvm/llvm-project/commit/2a3322bab069166dd0da8474534d0b8dad25b949.dif
Author: Louis Dionne
Date: 2023-08-23T22:21:53-04:00
New Revision: bb6073c7e32b5062a6969242c6bd4fe859e2e5e0
URL:
https://github.com/llvm/llvm-project/commit/bb6073c7e32b5062a6969242c6bd4fe859e2e5e0
DIFF:
https://github.com/llvm/llvm-project/commit/bb6073c7e32b5062a6969242c6bd4fe859e2e5e0.diff
Author: Louis Dionne
Date: 2023-08-25T07:52:40-04:00
New Revision: 5e603450bb33e99aada164fc9f647c6bec21e092
URL:
https://github.com/llvm/llvm-project/commit/5e603450bb33e99aada164fc9f647c6bec21e092
DIFF:
https://github.com/llvm/llvm-project/commit/5e603450bb33e99aada164fc9f647c6bec21e092.diff
Author: Louis Dionne
Date: 2023-08-30T09:15:55-04:00
New Revision: eb27be95a4c648707ad93e48049b3d463260a747
URL:
https://github.com/llvm/llvm-project/commit/eb27be95a4c648707ad93e48049b3d463260a747
DIFF:
https://github.com/llvm/llvm-project/commit/eb27be95a4c648707ad93e48049b3d463260a747.diff
Author: Louis Dionne
Date: 2023-08-31T09:52:41-04:00
New Revision: e34ddb1b5da499d0e7c8e0d33ff1ec89d97cf5f1
URL:
https://github.com/llvm/llvm-project/commit/e34ddb1b5da499d0e7c8e0d33ff1ec89d97cf5f1
DIFF:
https://github.com/llvm/llvm-project/commit/e34ddb1b5da499d0e7c8e0d33ff1ec89d97cf5f1.diff
Author: Louis Dionne
Date: 2023-08-31T11:55:10-04:00
New Revision: ba55034a898baf728f4d78ec811664b2a154bbfe
URL:
https://github.com/llvm/llvm-project/commit/ba55034a898baf728f4d78ec811664b2a154bbfe
DIFF:
https://github.com/llvm/llvm-project/commit/ba55034a898baf728f4d78ec811664b2a154bbfe.diff
Author: Louis Dionne
Date: 2023-08-31T11:55:10-04:00
New Revision: b397921fc7ef4e2882b3ae9c5f12fb40daca4078
URL:
https://github.com/llvm/llvm-project/commit/b397921fc7ef4e2882b3ae9c5f12fb40daca4078
DIFF:
https://github.com/llvm/llvm-project/commit/b397921fc7ef4e2882b3ae9c5f12fb40daca4078.diff
Author: Louis Dionne
Date: 2020-02-20T12:35:15-05:00
New Revision: 6fa3894c4e771c773712b1ae777f78c1c922a908
URL:
https://github.com/llvm/llvm-project/commit/6fa3894c4e771c773712b1ae777f78c1c922a908
DIFF:
https://github.com/llvm/llvm-project/commit/6fa3894c4e771c773712b1ae777f78c1c922a908.diff
Author: Louis Dionne
Date: 2020-02-04T19:31:53-05:00
New Revision: 361ba3ad1f8779584d94868dc2cb8dd2860c5eba
URL:
https://github.com/llvm/llvm-project/commit/361ba3ad1f8779584d94868dc2cb8dd2860c5eba
DIFF:
https://github.com/llvm/llvm-project/commit/361ba3ad1f8779584d94868dc2cb8dd2860c5eba.diff
Author: Louis Dionne
Date: 2023-03-25T15:57:20-04:00
New Revision: 731264b0c2af7aa46bd39625202a99e06cfccff9
URL:
https://github.com/llvm/llvm-project/commit/731264b0c2af7aa46bd39625202a99e06cfccff9
DIFF:
https://github.com/llvm/llvm-project/commit/731264b0c2af7aa46bd39625202a99e06cfccff9.diff
Author: Louis Dionne
Date: 2023-03-30T06:57:56-04:00
New Revision: ed61d6a46611cfb144b260e0dd0fb1b5783562d9
URL:
https://github.com/llvm/llvm-project/commit/ed61d6a46611cfb144b260e0dd0fb1b5783562d9
DIFF:
https://github.com/llvm/llvm-project/commit/ed61d6a46611cfb144b260e0dd0fb1b5783562d9.diff
Author: Louis Dionne
Date: 2023-04-15T10:37:28+01:00
New Revision: ca4fb463187ce244d61dc62a8f4e3e01d1872cc2
URL:
https://github.com/llvm/llvm-project/commit/ca4fb463187ce244d61dc62a8f4e3e01d1872cc2
DIFF:
https://github.com/llvm/llvm-project/commit/ca4fb463187ce244d61dc62a8f4e3e01d1872cc2.diff
Author: Louis Dionne
Date: 2023-02-14T17:21:34-05:00
New Revision: 33d0d1e36ffac3ff7fb29e5f8e34a6b6957ad8e9
URL:
https://github.com/llvm/llvm-project/commit/33d0d1e36ffac3ff7fb29e5f8e34a6b6957ad8e9
DIFF:
https://github.com/llvm/llvm-project/commit/33d0d1e36ffac3ff7fb29e5f8e34a6b6957ad8e9.diff
Author: Louis Dionne
Date: 2023-02-14T17:28:22-05:00
New Revision: cafb1c1cb24179bdf4361bf510590b4ea4e52135
URL:
https://github.com/llvm/llvm-project/commit/cafb1c1cb24179bdf4361bf510590b4ea4e52135
DIFF:
https://github.com/llvm/llvm-project/commit/cafb1c1cb24179bdf4361bf510590b4ea4e52135.diff
Author: Louis Dionne
Date: 2023-04-18T12:03:06Z
New Revision: 1ae57fed8806886238b7603f6b3b54350da83f0e
URL:
https://github.com/llvm/llvm-project/commit/1ae57fed8806886238b7603f6b3b54350da83f0e
DIFF:
https://github.com/llvm/llvm-project/commit/1ae57fed8806886238b7603f6b3b54350da83f0e.diff
LOG:
Author: Louis Dionne
Date: 2023-04-24T16:44:05-04:00
New Revision: 5084ba395e487adee67ba38cc5c68ff7e052e37c
URL:
https://github.com/llvm/llvm-project/commit/5084ba395e487adee67ba38cc5c68ff7e052e37c
DIFF:
https://github.com/llvm/llvm-project/commit/5084ba395e487adee67ba38cc5c68ff7e052e37c.diff
ldionne updated this revision to Diff 48012.
ldionne added a comment.
Address some remaining issues:
- Rename __nth_element to __type_pack_element, as suggested by Richard Smith
- Fix template parameter position issue in createTypePackElementParameterList
AFAICT, the only remaining issue is whet
ldionne added a comment.
ping
http://reviews.llvm.org/D15421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne added a comment.
No problem for the delay; we're all busy :-). Unfortunately, the patch does not
apply cleanly on `master` anymore, so I'll rebase it and someone can then
commit it for me.
http://reviews.llvm.org/D15421
___
cfe-commits mai
ldionne updated this revision to Diff 58619.
ldionne added a comment.
Rebase the patch on top of the current `master`. The patch passes all of
Clang's tests (`make check-clang`). I also removed the TODO comment about
diagnostics, since that was answered by Richard Smith.
http://reviews.llvm.or
ldionne added a reviewer: rsmith.
ldionne updated this revision to Diff 44779.
ldionne added a comment.
Rebase on top of the master branch, and add Richard Smith as a reviewer, since
he also reviewed David Majnemer's original patch (suggested by Nathan Wilson).
http://reviews.llvm.org/D15421
F
ldionne added a comment.
In http://reviews.llvm.org/D15421#326209, @nwilson wrote:
> In http://reviews.llvm.org/D15421#326144, @rsmith wrote:
>
> > Bikeshedding on the name a bit... how about `__type_pack_element`?
>
>
> Hmm, I kind of felt like having `nth` in there implied we're indexing into
ldionne updated this revision to Diff 44907.
ldionne marked 4 inline comments as done.
ldionne added a comment.
Address Richard Smith's review comments:
- Remove IndexType parameter, and make Index a std::size_t
- Remove assertion about APSInt::GetExtValue()
- Other style changes
Still left to d
Hi,
I wrote a patch that adds a `__nth_element` builtin that allows fetching the
n-th type of a parameter pack with very little compile-time overhead. The patch
was inspired by r252036 and r252115 by David Majnemer, which add a similar
`__make_integer_seq` builtin for efficiently creating a
`s
ldionne created this revision.
ldionne added a reviewer: majnemer.
ldionne added a subscriber: cfe-commits.
This patch adds a `__nth_element` builtin that allows fetching the n-th type of
a parameter pack with very little compile-time overhead. The patch was inspired
by r252036 and r252115 by Da
ldionne updated this revision to Diff 42443.
ldionne added a comment.
Added full lines of context. Sorry for not doing it the first time around.
http://reviews.llvm.org/D15421
Files:
include/clang/AST/ASTContext.h
include/clang/AST/DeclTemplate.h
include/clang/Basic/Builtins.h
include/c
ldionne added a comment.
We should probably consider changing the name from `__nth_element` to something
else, perhaps something that contains the word "pack". This is especially true
if we are to implement other intrinsics for manipulating parameter packs, like
slicing (as proposed by Eric Fis
ldionne added a comment.
This LGTM. I also just confirmed that it fixes the original issue in Hana that
caused me to report PR22806.
http://reviews.llvm.org/D12502
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
https://github.com/ldionne approved this pull request.
LGTM if CI is happy.
https://github.com/llvm/llvm-project/pull/97495
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
> @wzssyqa Is it OK with you if I go ahead and merge this PR? I plan to follow
> up with further improvements but this is necessary to fix the build of LLVM
> runtime libraries in the bootstrapping build.
Is there a filed issue linked to this?
https://github.com/llvm/llvm-proje
https://github.com/ldionne requested changes to this pull request.
Sorry for the delay. I have some questions and comments but this looks
reasonable.
https://github.com/llvm/llvm-project/pull/98712
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/98712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,25 @@
+
+set(LLVM_DEFAULT_TARGET_TRIPLE hexagon-unknown-linux-musl CACHE STRING "")
+set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR OFF CACHE BOOL "")
+set(LLVM_ENABLE_RUNTIMES libcxx;libcxxabi;libunwind;compiler-rt CACHE STRING
"")
+set(LIBCXX_INCLUDE_BENCHMARKS OFF CACHE BOO
@@ -0,0 +1,25 @@
+
+set(LLVM_DEFAULT_TARGET_TRIPLE hexagon-unknown-linux-musl CACHE STRING "")
+set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR OFF CACHE BOOL "")
+set(LLVM_ENABLE_RUNTIMES libcxx;libcxxabi;libunwind;compiler-rt CACHE STRING
"")
+set(LIBCXX_INCLUDE_BENCHMARKS OFF CACHE BOO
@@ -0,0 +1,25 @@
+
+set(LLVM_DEFAULT_TARGET_TRIPLE hexagon-unknown-linux-musl CACHE STRING "")
+set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR OFF CACHE BOOL "")
+set(LLVM_ENABLE_RUNTIMES libcxx;libcxxabi;libunwind;compiler-rt CACHE STRING
"")
+set(LIBCXX_INCLUDE_BENCHMARKS OFF CACHE BOO
@@ -0,0 +1,25 @@
+
+set(LLVM_DEFAULT_TARGET_TRIPLE hexagon-unknown-linux-musl CACHE STRING "")
ldionne wrote:
Do you really need this setting here? Can't you instead set
`CMAKE_CXX_COMPILER_TARGET`?
https://github.com/llvm/llvm-project/pull/98712
__
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/107905
That missing space was causing the whole sentence to be rendered incorrectly in
the resulting HTML.
>From df520b4cb99001b81ab00fa530718a2307dafb6f Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Mon, 9 Sep 2
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/107905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/104037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/104037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne approved this pull request.
This seems really nice! Again, I don't own the driver but IMO this seems fine
to me.
https://github.com/llvm/llvm-project/pull/104037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
@@ -0,0 +1,35 @@
+// Test the output of -print-target-triple on Darwin.
+
+//
+// All platforms
+//
+
+// RUN: %clang -print-target-triple \
+// RUN: --target=x86_64-apple-macos -mmacos-version-min=15 \
+// RUN: -resource-dir=%S/Inputs/resource_dir 2>&1 \
+// RUN: | File
@@ -0,0 +1,35 @@
+// Test the output of -print-target-triple on Darwin.
+
ldionne wrote:
```suggestion
// Test the output of -print-target-triple on Darwin.
// See https://github.com/llvm/llvm-project/issues/61762
```
https://github.com/llvm/llvm-project/pull/1
ldionne wrote:
@mstorsjo I think you put the finger on something I don't really understand at
the moment. What is the relationship between `armv7` and `thumbv7` as a target
triple? Is there any documentation on what an "effective triple" is in
comparison to a "non-effective triple"?
Separatel
https://github.com/ldionne approved this pull request.
This patch isn't blocked by libc++, thanks for fixing the incorrect usage. This
isn't a review of the patch itself, just unblocking for libcxx-reviewers.
https://github.com/llvm/llvm-project/pull/92957
__
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/94791
We were not making any distinction between e.g. the "Apple-flavored" libc++
built from trunk and the system-provided standard library on Apple platforms.
For example, any test that would be XFAILed on a back-dep
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/94791
>From 61a434bae9f3787122e123540b7c379f410e037b Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Fri, 31 May 2024 10:55:53 -0700
Subject: [PATCH 1/2] [libc++] Fix deployment target Lit features
We were not makin
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/85097
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
CC @philnik777
https://github.com/llvm/llvm-project/pull/95004
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne approved this pull request.
Thanks for fixing the libc++ tests. That part of the patch LGTM.
https://github.com/llvm/llvm-project/pull/94355
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/ldionne approved this pull request.
FWIW I am happy with the one line change in `libcxxabi/`. For libc++ to
officially support this beyond just a fun proof of concept, we'd need a story
for running the tests and set up a pre-commit CI for it though.
I'm approving just to get
ldionne wrote:
For tidying up the libc++ review queue, please remove the `libc++` tag once you
rebase this (the small changes in `libcxx` will go away).
https://github.com/llvm/llvm-project/pull/93388
___
cfe-commits mailing list
cfe-commits@lists.llv
501 - 600 of 937 matches
Mail list logo
