@@ -851,6 +851,33 @@ static void InitializePredefinedMacros(const TargetInfo
&TI,
Twine(getClangFullCPPVersion()) + "\"");
// Initialize language-specific preprocessor defines.
+ if (LangOpts.getLibcxxHardeningMode()) {
+const char *LibcxxHardenin
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/77806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/78869
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Jan =?utf-8?q?Kokemüller?= ,
Jan =?utf-8?q?Kokemüller?= ,
Jan =?utf-8?q?Kokemüller?= ,
Jan =?utf-8?q?Kokemüller?= ,
Jan =?utf-8?q?Kokemüller?= ,
Jan =?utf-8?q?Kokemüller?= ,
Jan =?utf-8?q?Kokemüller?= ,
Jan =?utf-8?q?Kokemüller?= ,
Jan =?utf-8?q?Kokemüller?= ,
Jan =?utf-8?q?Kokemüller?= ,
Jan =?utf
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/69498
>From 6f89b118ed56ad7a3af1996e19ccd30cc893c51e Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 14 Jun 2023 17:49:22 -0700
Subject: [PATCH 1/8] [libc++] Fix the behavior of throwing `operator new`
under -f
https://github.com/ldionne approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/77164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/77176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -350,6 +363,9 @@ _LIBCPP_HARDENING_MODE_DEBUG
#define _LIBCPP_ASSERT_PEDANTIC(expression, message)
_LIBCPP_ASSUME(expression)
#define _LIBCPP_ASSERT_INTERNAL(expression, message)
_LIBCPP_ASSUME(expression)
#define _LIBCPP_ASSERT_
https://github.com/ldionne approved this pull request.
@philnik777
> Does this actually improve the performance anywhere? AFAICT all we gain is
> avoiding the messages being generated in the binary, but I'm not convinced
> that's much of a problem. e.g. in the `std::next` case, there doesn't s
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/77405
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -53,10 +53,9 @@ struct __debug_less {
_LIBCPP_CONSTEXPR_SINCE_CXX14 inline _LIBCPP_HIDE_FROM_ABI void
__do_compare_assert(long, _LHS&, _RHS&) {}
};
-// Pass the comparator by lvalue reference. Or in debug mode, using a
-// debugging wrapper that stores a reference.
-#if
@@ -52,204 +51,234 @@
class ComparisonResults {
ldionne wrote:
We need to take the parts of this test that would reproduce an OOB access
inside `std::sort` & friends to a new test file. And that one should be enabled
whenever the valid-element-access checks
@@ -360,11 +365,13 @@ _LIBCPP_HARDENING_MODE_DEBUG
#define _LIBCPP_ASSERT_VALID_ELEMENT_ACCESS(expression, message)
_LIBCPP_ASSERT(expression, message)
#define _LIBCPP_ASSERT_NON_NULL(expression, message)
_LIBCPP_ASSERT(expression, message)
#de
https://github.com/ldionne demilestoned
https://github.com/llvm/llvm-project/pull/77176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/69498
>From 6f89b118ed56ad7a3af1996e19ccd30cc893c51e Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 14 Jun 2023 17:49:22 -0700
Subject: [PATCH 01/11] [libc++] Fix the behavior of throwing `operator new`
under
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/78869
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/78869
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/79157
I was looking for the documentation of that attribute, and the best I could
find was a Stackoverflow answer or the commit message that originally
introduced the attribute. I figured I might as well document what
@@ -3220,8 +3220,8 @@ def TypeVisibility : InheritableAttr {
let Args = [EnumArgument<"Visibility", "VisibilityType",
["default", "hidden", "internal", "protected"],
["Default", "Hidden", "Hidden", "Protected"]>];
-// let
ldionne wrote:
The CI failure is the bootstrapping build agent dying, definitely not related
to this. Shipping.
https://github.com/llvm/llvm-project/pull/68109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
ldionne wrote:
The CI failure is the bootstrapping build agent dying, definitely not related
to this. Shipping.
https://github.com/llvm/llvm-project/pull/68109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/68109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/68109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/67023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/67023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/67023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/67023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/69498
>From 77c0256c3ae99808a8def68bfcf5eee2fad704ca Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 14 Jun 2023 17:49:22 -0700
Subject: [PATCH 1/6] [libc++] Fix the behavior of throwing `operator new`
under -f
@@ -7,6 +7,8 @@
//===--===//
#include <__memory/aligned_alloc.h>
+#include <__overridable_function>
ldionne wrote:
So this file needs to be shared between libc++abi and libc++, unfortunately
@@ -7,6 +7,8 @@
//===--===//
#include <__memory/aligned_alloc.h>
+#include <__overridable_function>
ldionne wrote:
So this file needs to be shared between libc++abi and libc++, unfortunately
@@ -38,39 +44,53 @@ static void* operator_new_impl(std::size_t size) noexcept {
_LIBCPP_WEAK void* operator new(std::size_t size) _THROW_BAD_ALLOC {
void* p = operator_new_impl(size);
-# ifndef _LIBCPP_HAS_NO_EXCEPTIONS
if (p == nullptr)
-throw std::bad_alloc();
-#
@@ -38,39 +44,53 @@ static void* operator_new_impl(std::size_t size) noexcept {
_LIBCPP_WEAK void* operator new(std::size_t size) _THROW_BAD_ALLOC {
void* p = operator_new_impl(size);
-# ifndef _LIBCPP_HAS_NO_EXCEPTIONS
if (p == nullptr)
-throw std::bad_alloc();
-#
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/69498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Louis Dionne
Date: 2023-10-23T17:40:20-07:00
New Revision: 4c8f2b01470d38f0757f2404dbb0f0335ac331db
URL:
https://github.com/llvm/llvm-project/commit/4c8f2b01470d38f0757f2404dbb0f0335ac331db
DIFF:
https://github.com/llvm/llvm-project/commit/4c8f2b01470d38f0757f2404dbb0f0335ac331db.diff
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/67670
>From 72bda6810909f90f22dc77a04cabf0b4c19668cf Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Tue, 26 Sep 2023 19:02:00 -0400
Subject: [PATCH 1/2] [libc++] Make sure we implement and test LWG2280 properly
We
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/68413
>From 24d5794c366670fb4d8fe3ec72c27d7c9ef335b9 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Fri, 6 Oct 2023 08:57:23 -0400
Subject: [PATCH 1/2] [libc++] Fix complexity guarantee in std::clamp
This patch pre
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/68413
>From 24d5794c366670fb4d8fe3ec72c27d7c9ef335b9 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Fri, 6 Oct 2023 08:57:23 -0400
Subject: [PATCH 1/3] [libc++] Fix complexity guarantee in std::clamp
This patch pre
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/67670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Louis Dionne
Date: 2020-11-06T17:26:42-05:00
New Revision: c1887e3f15aeac7037b88b066b33d142c6bb1321
URL:
https://github.com/llvm/llvm-project/commit/c1887e3f15aeac7037b88b066b33d142c6bb1321
DIFF:
https://github.com/llvm/llvm-project/commit/c1887e3f15aeac7037b88b066b33d142c6bb1321.diff
Author: Louis Dionne
Date: 2020-10-08T14:28:13-04:00
New Revision: 504bc07d1afc7bad7b980a977141696ec8298e7e
URL:
https://github.com/llvm/llvm-project/commit/504bc07d1afc7bad7b980a977141696ec8298e7e
DIFF:
https://github.com/llvm/llvm-project/commit/504bc07d1afc7bad7b980a977141696ec8298e7e.diff
Author: Louis Dionne
Date: 2020-10-09T12:41:41-04:00
New Revision: a3a24316087d0e1b4db0b8fee19cdee8b7968032
URL:
https://github.com/llvm/llvm-project/commit/a3a24316087d0e1b4db0b8fee19cdee8b7968032
DIFF:
https://github.com/llvm/llvm-project/commit/a3a24316087d0e1b4db0b8fee19cdee8b7968032.diff
Author: Louis Dionne
Date: 2020-10-20T10:51:05-04:00
New Revision: eaa928b71a090905cb178c22054cdf6aa8eb80cb
URL:
https://github.com/llvm/llvm-project/commit/eaa928b71a090905cb178c22054cdf6aa8eb80cb
DIFF:
https://github.com/llvm/llvm-project/commit/eaa928b71a090905cb178c22054cdf6aa8eb80cb.diff
Author: Erik Pilkington
Date: 2021-05-28T12:00:33-04:00
New Revision: dc672999a9b12a156991891dc400308b52d569ba
URL:
https://github.com/llvm/llvm-project/commit/dc672999a9b12a156991891dc400308b52d569ba
DIFF:
https://github.com/llvm/llvm-project/commit/dc672999a9b12a156991891dc400308b52d569ba.dif
Author: Louis Dionne
Date: 2021-06-01T08:47:50-04:00
New Revision: 97d234935f1514af128277943f30efc469525371
URL:
https://github.com/llvm/llvm-project/commit/97d234935f1514af128277943f30efc469525371
DIFF:
https://github.com/llvm/llvm-project/commit/97d234935f1514af128277943f30efc469525371.diff
Author: Erik Pilkington
Date: 2021-06-02T10:30:24-04:00
New Revision: 369c64839946d89cf5697550b6feeea031b2f270
URL:
https://github.com/llvm/llvm-project/commit/369c64839946d89cf5697550b6feeea031b2f270
DIFF:
https://github.com/llvm/llvm-project/commit/369c64839946d89cf5697550b6feeea031b2f270.dif
Author: Louis Dionne
Date: 2021-09-23T13:09:32-04:00
New Revision: e6126faba060d5341dae6c5cc99a22a80d8c4d23
URL:
https://github.com/llvm/llvm-project/commit/e6126faba060d5341dae6c5cc99a22a80d8c4d23
DIFF:
https://github.com/llvm/llvm-project/commit/e6126faba060d5341dae6c5cc99a22a80d8c4d23.diff
Author: Louis Dionne
Date: 2021-07-06T08:42:07-04:00
New Revision: f7d8754312bf3d10fb902d94f2bc84e3adf12ba4
URL:
https://github.com/llvm/llvm-project/commit/f7d8754312bf3d10fb902d94f2bc84e3adf12ba4
DIFF:
https://github.com/llvm/llvm-project/commit/f7d8754312bf3d10fb902d94f2bc84e3adf12ba4.diff
Author: Louis Dionne
Date: 2021-07-14T14:29:29-04:00
New Revision: 5099e0156818665ae5381337f64ca68d659e0556
URL:
https://github.com/llvm/llvm-project/commit/5099e0156818665ae5381337f64ca68d659e0556
DIFF:
https://github.com/llvm/llvm-project/commit/5099e0156818665ae5381337f64ca68d659e0556.diff
Author: Louis Dionne
Date: 2021-07-14T15:15:22-04:00
New Revision: 850b57c5fbe7b44d18c9667bb31adfbe307453a6
URL:
https://github.com/llvm/llvm-project/commit/850b57c5fbe7b44d18c9667bb31adfbe307453a6
DIFF:
https://github.com/llvm/llvm-project/commit/850b57c5fbe7b44d18c9667bb31adfbe307453a6.diff
Author: Louis Dionne
Date: 2021-10-26T09:34:40-04:00
New Revision: 56b74613bf9168bb79e0088b424ec0b6dd0a66c9
URL:
https://github.com/llvm/llvm-project/commit/56b74613bf9168bb79e0088b424ec0b6dd0a66c9
DIFF:
https://github.com/llvm/llvm-project/commit/56b74613bf9168bb79e0088b424ec0b6dd0a66c9.diff
Author: Louis Dionne
Date: 2021-10-27T17:30:07-04:00
New Revision: 3e39bbf5f9614327bb09d6527db8b40fc472fedf
URL:
https://github.com/llvm/llvm-project/commit/3e39bbf5f9614327bb09d6527db8b40fc472fedf
DIFF:
https://github.com/llvm/llvm-project/commit/3e39bbf5f9614327bb09d6527db8b40fc472fedf.diff
Author: Louis Dionne
Date: 2021-11-25T15:28:17-05:00
New Revision: ebfeeec4c4bcc4373e5d5dfaff7ee75959a7c931
URL:
https://github.com/llvm/llvm-project/commit/ebfeeec4c4bcc4373e5d5dfaff7ee75959a7c931
DIFF:
https://github.com/llvm/llvm-project/commit/ebfeeec4c4bcc4373e5d5dfaff7ee75959a7c931.diff
Author: Louis Dionne
Date: 2021-12-01T12:57:01-05:00
New Revision: fa1c077b41ae1335332d65399802f2c68e82ca7b
URL:
https://github.com/llvm/llvm-project/commit/fa1c077b41ae1335332d65399802f2c68e82ca7b
DIFF:
https://github.com/llvm/llvm-project/commit/fa1c077b41ae1335332d65399802f2c68e82ca7b.diff
Author: Louis Dionne
Date: 2021-12-01T12:57:30-05:00
New Revision: dc1244dc4e76316ab24596545951d3dc47359875
URL:
https://github.com/llvm/llvm-project/commit/dc1244dc4e76316ab24596545951d3dc47359875
DIFF:
https://github.com/llvm/llvm-project/commit/dc1244dc4e76316ab24596545951d3dc47359875.diff
Author: Louis Dionne
Date: 2022-08-16T09:27:18-04:00
New Revision: 65d83ba34378b8e740c5203fe46a9c50d2aeb862
URL:
https://github.com/llvm/llvm-project/commit/65d83ba34378b8e740c5203fe46a9c50d2aeb862
DIFF:
https://github.com/llvm/llvm-project/commit/65d83ba34378b8e740c5203fe46a9c50d2aeb862.diff
Author: Louis Dionne
Date: 2022-08-23T17:02:51-04:00
New Revision: 7dfcf9342b5af794aadd4ca81490090fe7ca6a45
URL:
https://github.com/llvm/llvm-project/commit/7dfcf9342b5af794aadd4ca81490090fe7ca6a45
DIFF:
https://github.com/llvm/llvm-project/commit/7dfcf9342b5af794aadd4ca81490090fe7ca6a45.diff
Author: Louis Dionne
Date: 2022-08-24T08:50:52-04:00
New Revision: 3e84cdbee467f97026f1ad421abcaf9b862c1ff4
URL:
https://github.com/llvm/llvm-project/commit/3e84cdbee467f97026f1ad421abcaf9b862c1ff4
DIFF:
https://github.com/llvm/llvm-project/commit/3e84cdbee467f97026f1ad421abcaf9b862c1ff4.diff
Author: Louis Dionne
Date: 2022-08-24T09:13:29-04:00
New Revision: b1320f7c9b907d39c8ceca9b91d66046441f1ae3
URL:
https://github.com/llvm/llvm-project/commit/b1320f7c9b907d39c8ceca9b91d66046441f1ae3
DIFF:
https://github.com/llvm/llvm-project/commit/b1320f7c9b907d39c8ceca9b91d66046441f1ae3.diff
Author: Louis Dionne
Date: 2022-10-11T15:18:22-04:00
New Revision: f8409af354c1398ebf4ece67a315c94ba19714b5
URL:
https://github.com/llvm/llvm-project/commit/f8409af354c1398ebf4ece67a315c94ba19714b5
DIFF:
https://github.com/llvm/llvm-project/commit/f8409af354c1398ebf4ece67a315c94ba19714b5.diff
Author: Louis Dionne
Date: 2022-12-19T16:11:39-05:00
New Revision: 6540f32db09cf6b367812642fbd91d44cbb6638d
URL:
https://github.com/llvm/llvm-project/commit/6540f32db09cf6b367812642fbd91d44cbb6638d
DIFF:
https://github.com/llvm/llvm-project/commit/6540f32db09cf6b367812642fbd91d44cbb6638d.diff
Author: Louis Dionne
Date: 2022-12-20T19:56:28-05:00
New Revision: 52aab0e4b4a5d6728f4bb9c7b3340133f585fc15
URL:
https://github.com/llvm/llvm-project/commit/52aab0e4b4a5d6728f4bb9c7b3340133f585fc15
DIFF:
https://github.com/llvm/llvm-project/commit/52aab0e4b4a5d6728f4bb9c7b3340133f585fc15.diff
Author: Louis Dionne
Date: 2022-11-16T15:25:32-05:00
New Revision: 9621b1776a1b3d16735b3c5da31585ad64a018df
URL:
https://github.com/llvm/llvm-project/commit/9621b1776a1b3d16735b3c5da31585ad64a018df
DIFF:
https://github.com/llvm/llvm-project/commit/9621b1776a1b3d16735b3c5da31585ad64a018df.diff
Author: Louis Dionne
Date: 2022-05-26T15:29:39-04:00
New Revision: 92bbcfaa97408991813fda5c56e864c629f67a01
URL:
https://github.com/llvm/llvm-project/commit/92bbcfaa97408991813fda5c56e864c629f67a01
DIFF:
https://github.com/llvm/llvm-project/commit/92bbcfaa97408991813fda5c56e864c629f67a01.diff
Author: Louis Dionne
Date: 2022-05-27T13:15:48-04:00
New Revision: 719bf2d9d9fdb8792b15d93364c9c6b2ddd68a36
URL:
https://github.com/llvm/llvm-project/commit/719bf2d9d9fdb8792b15d93364c9c6b2ddd68a36
DIFF:
https://github.com/llvm/llvm-project/commit/719bf2d9d9fdb8792b15d93364c9c6b2ddd68a36.diff
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -108,7 +108,34 @@ constexpr bool test() {
auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove {
return x; };
assert(&std::ranges::clamp(val, low, high, moving_comp, prvalue_proj) ==
&val);
}
+ { // Make sure we don't call the projection more than
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -108,7 +108,34 @@ constexpr bool test() {
auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove {
return x; };
assert(&std::ranges::clamp(val, low, high, moving_comp, prvalue_proj) ==
&val);
}
+ { // Make sure we don't call the projection more than
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/66801
This reverts commit aa60b2687, which was a temporary workaround.
This was originally https://reviews.llvm.org/D158694.
>From 7683064a0b9aa7d76cf6fcbd8c804ad897c4b625 Mon Sep 17 00:00:00 2001
From: Louis Dionne
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/66649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/66940
On Apple platforms, we always support the -nostdlib++ flag. Hence, it is not
necessary to manually link against system libraries. In fact, doing so causes
us to link against libSystem explicitly, which messes up
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/66940
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -659,24 +659,22 @@ function(cxx_link_system_libraries target)
target_add_link_flags_if_supported(${target} PRIVATE "--unwindlib=none")
endif()
- if (LIBCXX_HAS_SYSTEM_LIB)
-target_link_libraries(${target} PRIVATE System)
- endif()
-
- if (LIBCXX_HAS_PTHREAD_LIB
ldionne wrote:
I think when the @llvm/pr-subscribers-libcxx group was pinged 2 weeks ago, most
of us didn't have the right GH notifications set up yet and we didn't see it.
Looking now.
https://github.com/llvm/llvm-project/pull/65246
___
cfe-commits
ldionne wrote:
Note that you should probably rebase your patch onto `main` and force-push to
update the PR. The CI for Clang now runs on Windows from GH PRs as well (it
used not to when you submitted the patch, I think).
https://github.com/llvm/llvm-project/pull/65246
_
ldionne wrote:
Ok so after scratching my head a bit, I'm actually not certain of how to
proceed with this. I can't find a way to implement `__libcpp_datasizeof` in
libc++ that doesn't involve `offsetof`, so our only option would be to silence
the warning. We could do it like (if we end up doin
ldionne wrote:
> Thank you for your review! Here are some comments and my thoughts.
>
> > Note that you should probably rebase your patch onto main and force-push to
> > update the PR
>
> Does it mean that I can rebase and force-push since (it should be avoided in
> normal case but) this is a
https://github.com/ldionne commented:
Is there a reason why *all* configurations shouldn't be doing this?
https://github.com/llvm/llvm-project/pull/67201
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/67205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
@mordante I'm not certain what's going on here, I get
```
[...]/clang_modules_include.gen.py/__std_clang_module.compile.pass.mm:22:2:
error: import of module 'std' imported non C++20 importable modules
22 | @import std;
| ^
1 error generated.
```
Can you assist? It onl
ldionne wrote:
You could add it to all the `.cfg.in` files (I think we agree that it's what
makes sense in theory) and then see whether the flags change in the
configurations tested in the CI.
https://github.com/llvm/llvm-project/pull/67201
___
cfe-c
https://github.com/ldionne resolved
https://github.com/llvm/llvm-project/pull/66545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/66545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -314,5 +317,14 @@ def getStdFlag(cfg, std):
AddCompileFlag("-D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES"),
],
),
+Parameter(
+name="executor",
+type=str,
+default=f"{sys.executable}
{Path(__file__).resolve().parent.parent.parent
@@ -314,5 +317,14 @@ def getStdFlag(cfg, std):
AddCompileFlag("-D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES"),
],
),
+Parameter(
+name="executor",
+type=str,
+default=f"{sys.executable}
{Path(__file__).resolve().parent.parent.parent
ldionne wrote:
> > @arichardson
>
> Sorry about that! It looks like the cmake file quoting needs to be updated.
> Alternatively I could revert the part of this change that deprecates the
> executor variable.
Let's not un-deprecate the executor variables -- it's really great that we're
removin
ldionne wrote:
I just want to slide in to say that I *really* like this patch from the point
of view of `std::string`'s implementation. Our `__default_init()` method and
the `if (is_constant_evaluated())` were pretty awful, and I think it's great to
remove them.
I agree it could cause a porta
ldionne wrote:
@kasuga-fj Ok, let's take the diff I posted earlier in the comments and silence
the warning in libc++ then. Once you do that, the libc++ test suite shouldn't
fail with your patch anymore so your CI should be green. Then libc++ will be
out of your way and it's up to the Clang fol
https://github.com/ldionne resolved
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne resolved
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
This seems to be a bit stuck. I checked out the patch locally and that was
helpful to understand some of the issues. I think the final patch should be:
```
commit c667f036c4228b9cf0172c311537ab96ef61fcf5
Author: PandaNinjas
Date: Wed Sep 13 17:38:17 2023 -0700
[libc++] Pr
ldionne wrote:
This seems to be a bit stuck. I checked out the patch locally and that was
helpful to understand some of the issues. I think the final patch should be:
```
commit c667f036c4228b9cf0172c311537ab96ef61fcf5
Author: PandaNinjas
Date: Wed Sep 13 17:38:17 2023 -0700
[libc++] Pr
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/67691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/67691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/67691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,20 @@
+
+macro(serialize_lit_param param value)
+ string(APPEND SERIALIZED_LIT_PARAMS "config.${param} = ${value}\n")
ldionne wrote:
This looks reasonable, but could we avoid using the global variable
`SERIALIZED_LIT_PARAMS` here? We should thread it
301 - 400 of 933 matches
Mail list logo
