Author: Louis Dionne Date: 2022-05-27T13:15:48-04:00 New Revision: 719bf2d9d9fdb8792b15d93364c9c6b2ddd68a36
URL: https://github.com/llvm/llvm-project/commit/719bf2d9d9fdb8792b15d93364c9c6b2ddd68a36 DIFF: https://github.com/llvm/llvm-project/commit/719bf2d9d9fdb8792b15d93364c9c6b2ddd68a36.diff LOG: [runtimes] Officially deprecate the legacy testing configuration system Add a warning and tweak the release note to explain that the deprecation targets libc++, libc++abi and libuwnind as well. Also, as a fly-by, ensure that our CI runs the legacy testing configuration for libc++, libc++abi and libunwind. This doesn't matter too much since it's deprecated, but we might as well test it properly. Differential Revision: https://reviews.llvm.org/D126478 Added: Modified: libcxx/docs/ReleaseNotes.rst libcxx/test/configs/legacy.cfg.in libcxx/utils/ci/run-buildbot libcxxabi/test/lit.site.cfg.in libunwind/test/lit.site.cfg.in Removed: ################################################################################ diff --git a/libcxx/docs/ReleaseNotes.rst b/libcxx/docs/ReleaseNotes.rst index 514de5de3213d..b2bd0718001e5 100644 --- a/libcxx/docs/ReleaseNotes.rst +++ b/libcxx/docs/ReleaseNotes.rst @@ -148,7 +148,8 @@ Build System Changes its own headers. - The legacy testing configuration is now deprecated and will be removed in the next release. For - most users, this should not have any impact. However, if you are testing libc++ in a configuration - or on a platform that used to be supported by the legacy testing configuration and isn't supported - by one of the configurations in ``libcxx/test/configs``, please reach out to the libc++ developers - to get your configuration supported officially. + most users, this should not have any impact. However, if you are testing libc++, libc++abi or + libunwind in a configuration or on a platform that used to be supported by the legacy testing + configuration and isn't supported by one of the configurations in ``libcxx/test/configs``, + ``libcxxabi/test/configs`` or ``libunwind/test/configs``, please move to one of those + configurations or define your own. diff --git a/libcxx/test/configs/legacy.cfg.in b/libcxx/test/configs/legacy.cfg.in index 8bb5bc76aa5ee..a7ac6f8042402 100644 --- a/libcxx/test/configs/legacy.cfg.in +++ b/libcxx/test/configs/legacy.cfg.in @@ -62,3 +62,6 @@ import libcxx.test.config configuration = libcxx.test.config.Configuration(lit_config, config) configuration.configure() configuration.print_config_info() + +lit_config.warning("This is a legacy testing configuration which will be removed in LLVM 16. " + "Please use one of the configurations in libcxx/test/configs or define your own.") diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot index 23708e680893f..2b9f129fd2588 100755 --- a/libcxx/utils/ci/run-buildbot +++ b/libcxx/utils/ci/run-buildbot @@ -462,7 +462,9 @@ bootstrapping-build) ;; legacy-test-config) clean - generate-cmake -DLIBCXX_TEST_CONFIG="legacy.cfg.in" + generate-cmake -DLIBCXX_TEST_CONFIG="legacy.cfg.in" \ + -DLIBCXXABI_TEST_CONFIG="${MONOREPO_ROOT}/libcxxabi/test/lit.site.cfg.in" \ + -DLIBUNWIND_TEST_CONFIG="${MONOREPO_ROOT}/libunwind/test/lit.site.cfg.in" check-runtimes ;; legacy-project-build) diff --git a/libcxxabi/test/lit.site.cfg.in b/libcxxabi/test/lit.site.cfg.in index ae387f55e0356..7a786a3a7691e 100644 --- a/libcxxabi/test/lit.site.cfg.in +++ b/libcxxabi/test/lit.site.cfg.in @@ -60,3 +60,6 @@ import libcxxabi.test.config configuration = libcxxabi.test.config.Configuration(lit_config, config) configuration.configure() configuration.print_config_info() + +lit_config.warning("This is a legacy testing configuration which will be removed in LLVM 16. " + "Please use one of the configurations in libcxxabi/test/configs or define your own.") diff --git a/libunwind/test/lit.site.cfg.in b/libunwind/test/lit.site.cfg.in index 9fb324007a55a..31530935ce876 100644 --- a/libunwind/test/lit.site.cfg.in +++ b/libunwind/test/lit.site.cfg.in @@ -56,3 +56,6 @@ import libunwind.test.config configuration = libunwind.test.config.Configuration(lit_config, config) configuration.configure() configuration.print_config_info() + +lit_config.warning("This is a legacy testing configuration which will be removed in LLVM 16. " + "Please use one of the configurations in libunwind/test/configs or define your own.") _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
