[clang] [libcxx] Unifying __is_trivial_equality_predicate and __is_trivial_plus_operation into __desugars_to (PR #68642)

2023-10-30 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/68642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libcxx] Unifying __is_trivial_equality_predicate and __is_trivial_plus_operation into __desugars_to (PR #68642)

2023-10-30 Thread Louis Dionne via cfe-commits
@@ -18,8 +18,11 @@ _LIBCPP_BEGIN_NAMESPACE_STD -template -struct __is_trivial_plus_operation : false_type {}; +template +struct __desugars_to : false_type {}; + +template +struct __desugars_to<_Operation, _Operation> : true_type {}; ldionne wrote: Now thi

[clang-tools-extra] [libcxx] Unifying __is_trivial_equality_predicate and __is_trivial_plus_operation into __desugars_to (PR #68642)

2023-10-30 Thread Louis Dionne via cfe-commits
@@ -18,8 +18,11 @@ _LIBCPP_BEGIN_NAMESPACE_STD -template -struct __is_trivial_plus_operation : false_type {}; +template ldionne wrote: I think what we want is something like this: ``` struct __equal_tag {}; struct __plus_tag {}; // etc... template struc

[clang-tools-extra] [libcxx] Unifying __is_trivial_equality_predicate and __is_trivial_plus_operation into __desugars_to (PR #68642)

2023-10-30 Thread Louis Dionne via cfe-commits
https://github.com/ldionne requested changes to this pull request. https://github.com/llvm/llvm-project/pull/68642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-30 Thread Louis Dionne via cfe-commits
@@ -772,15 +774,19 @@ elseif (LIBCXX_HARDENING_MODE STREQUAL "unchecked") config_define(0 _LIBCPP_ENABLE_DEBUG_MODE_DEFAULT) endif() -if (LIBCXX_PSTL_CPU_BACKEND STREQUAL "serial") +if (LIBCXX_PSTL_BACKEND STREQUAL "serial") config_define(1 _LIBCPP_PSTL_CPU_BACKEND_SERIAL

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-30 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,41 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-30 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,41 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-30 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/66968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-30 Thread Louis Dionne via cfe-commits
@@ -466,6 +466,114 @@ Unpoisoning may not be an option, if (for example) you are not maintaining the a * You are using allocator, which does not call destructor during deallocation. * You are aware that memory allocated with an allocator may be accessed, even when unused by co

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-30 Thread Louis Dionne via cfe-commits
@@ -330,6 +330,23 @@ def getStdFlag(cfg, std): default=f"{shlex.quote(sys.executable)} {shlex.quote(str(Path(__file__).resolve().parent.parent.parent / 'run.py'))}", help="Custom executor to use instead of the configured default.", actions=lambda execut

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-30 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,41 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-30 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,41 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-30 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/66968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-30 Thread Louis Dionne via cfe-commits
@@ -466,6 +466,114 @@ Unpoisoning may not be an option, if (for example) you are not maintaining the a * You are using allocator, which does not call destructor during deallocation. * You are aware that memory allocated with an allocator may be accessed, even when unused by co

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-30 Thread Louis Dionne via cfe-commits
https://github.com/ldionne requested changes to this pull request. https://github.com/llvm/llvm-project/pull/66968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [clang-tools-extra] [clang] [llvm] [libc++] Fix complexity guarantee in ranges::clamp (PR #68413)

2023-10-31 Thread Louis Dionne via cfe-commits
@@ -37,9 +37,10 @@ struct __fn { _LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj, __high), std::invoke(__proj, __low))), ldionne wrote: @var-const I think we have an interesting case here. This assertion causes the complexity guar

[clang] [Clang] Warn on deprecated specializations used in system headers. (PR #70353)

2023-10-31 Thread Louis Dionne via cfe-commits
ldionne wrote: @cor3ntin This is really nice, thanks for the patch! The CI should pass if you merge `main` into your branch -- you were the victim of a temporary CI issue that has been fixed since then. https://github.com/llvm/llvm-project/pull/70353 ___

[clang] [llvm] [libcxx] [clang-tools-extra] [libc++] Fix complexity guarantee in ranges::clamp (PR #68413)

2023-10-31 Thread Louis Dionne via cfe-commits
@@ -37,9 +37,10 @@ struct __fn { _LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj, __high), std::invoke(__proj, __low))), ldionne wrote: We discussed this just now and we both feel that while this pedantically makes us non-conformi

[clang] [clang][driver] Add \/../include/c++/v1 to include path on Darwin (PR #70817)

2023-10-31 Thread Louis Dionne via cfe-commits
ldionne wrote: Is there any reason why we don't just use `Dir` all the time? What's the difference between those two? I think I wrote this code a few years ago and I can guarantee you that I simply didn't know there was a difference between `Dir` and `InstalledDir` (since I still don't know th

[clang-tools-extra] [libcxx] [clang] [llvm] [libc++] Fix complexity guarantee in ranges::clamp (PR #68413)

2023-10-31 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/68413 >From 24d5794c366670fb4d8fe3ec72c27d7c9ef335b9 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 6 Oct 2023 08:57:23 -0400 Subject: [PATCH 1/4] [libc++] Fix complexity guarantee in std::clamp This patch pre

[clang-tools-extra] [clang] [libcxx] [llvm] [libc++] Fix complexity guarantee in ranges::clamp (PR #68413)

2023-11-01 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/68413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [libcxx] [clang-tools-extra] [libc++] Allow running the test suite with optimizations (PR #68753)

2023-11-01 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/68753 >From 9824ef111975386152173916c1fd6a85264be0a0 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 10 Oct 2023 16:35:11 -0700 Subject: [PATCH 1/3] [libc++] Allow running the test suite with optimizations This

[libcxx] [clang] [clang-tools-extra] [llvm] [libc++] Allow running the test suite with optimizations (PR #68753)

2023-11-01 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/68753 >From 9824ef111975386152173916c1fd6a85264be0a0 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 10 Oct 2023 16:35:11 -0700 Subject: [PATCH 1/4] [libc++] Allow running the test suite with optimizations This

[libcxx] [clang] [llvm] [libc] [clang-tools-extra] [compiler-rt] [flang] [libcxxabi] [lld] [libc++] Fix the behavior of throwing `operator new` under -fno-exceptions (PR #69498)

2023-11-05 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,38 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-

[libc] [libcxx] [clang] [libcxxabi] [llvm] [lld] [flang] [clang-tools-extra] [compiler-rt] [libc++] Fix the behavior of throwing `operator new` under -fno-exceptions (PR #69498)

2023-11-05 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/69498 >From 77c0256c3ae99808a8def68bfcf5eee2fad704ca Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 14 Jun 2023 17:49:22 -0700 Subject: [PATCH 1/7] [libc++] Fix the behavior of throwing `operator new` under -f

[libc] [libcxx] [clang] [libcxxabi] [llvm] [lld] [flang] [clang-tools-extra] [compiler-rt] [libc++] Fix the behavior of throwing `operator new` under -fno-exceptions (PR #69498)

2023-11-05 Thread Louis Dionne via cfe-commits
ldionne wrote: > I think we can check whether it's been overridden more easily using an asm > alias like this (when libc++ is built under -fno-exceptions): This doesn't work on Darwin (apparently we don't support the alias attribute on that platform). I could investigate doing this all non-Dar

[clang-tools-extra] [llvm] [libcxx] [clang] [libunwind] [libc++] Allow running the test suite with optimizations (PR #68753)

2023-11-05 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/68753 >From 9824ef111975386152173916c1fd6a85264be0a0 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 10 Oct 2023 16:35:11 -0700 Subject: [PATCH 1/5] [libc++] Allow running the test suite with optimizations This

[clang] [libcxx] [clang-tools-extra] [llvm] [libc++] P2770R0: "Stashing stashing iterators for proper flattening" (PR #66033)

2023-12-12 Thread Louis Dionne via cfe-commits
ldionne wrote: Thanks for the ping (and the patch!) https://github.com/llvm/llvm-project/pull/66033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [clang-tools-extra] [llvm] [libc++] P2770R0: "Stashing stashing iterators for proper flattening" (PR #66033)

2023-12-12 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/66033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [clang] [PowerPC] Emit libcall to frexpl for calls to frexp(ppcDoublDouble) (PR #75226)

2023-12-12 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. Just approving the libc++ part of the change, which is not controversial. Please work with the other reviewers for the rest of the patch. Thanks for working on this! https://github.com/llvm/llvm-project/pull/75226 _

[libcxx] [libcxxabi] [libunwind] [runtimes] Don't link against compiler-rt explicitly when we use -nostdlib++ (PR #75089)

2023-12-13 Thread Louis Dionne via cfe-commits
ldionne wrote: > I'm trying to implement support for building libunwind, libc++abi and libc++ > against LLVM libc in which case we won't be able to rely on `-nostdlib++`, > we'll need to use `-nostdlib` to avoid linking the C library. We can still > use `-nostdlib++` when LLVM libc isn't being

[libunwind] [libcxxabi] [libcxx] [runtimes] Don't link against compiler-rt explicitly when we use -nostdlib++ (PR #75089)

2023-12-13 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/75089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [llvm] [clang] [libc] [flang] [mlir] [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction (PR #73618)

2023-12-14 Thread Louis Dionne via cfe-commits
https://github.com/ldionne requested changes to this pull request. https://github.com/llvm/llvm-project/pull/73618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [llvm] [clang] [libc] [libcxx] [flang] [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction (PR #73618)

2023-12-14 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,102 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[llvm] [flang] [libcxx] [clang] [libc] [mlir] [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction (PR #73618)

2023-12-14 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,102 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[mlir] [libcxx] [clang] [libc] [llvm] [flang] [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction (PR #73618)

2023-12-14 Thread Louis Dionne via cfe-commits
@@ -242,6 +248,57 @@ auto to_address(const _Pointer& __p) noexcept -> decltype(std::__to_address(__p) } #endif +#if _LIBCPP_STD_VER >= 23 + +template +struct __pointer_of {}; + +template + requires(__has_pointer<_Tp>::value) +struct __pointer_of<_Tp> { + using type = type

[llvm] [mlir] [libc] [libcxx] [clang] [flang] [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction (PR #73618)

2023-12-14 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,201 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[flang] [clang] [libc] [llvm] [mlir] [libcxx] [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction (PR #73618)

2023-12-14 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,97 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-

[libc] [libcxx] [clang] [flang] [mlir] [llvm] [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction (PR #73618)

2023-12-14 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/73618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [llvm] [clang] [libc] [flang] [mlir] [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction (PR #73618)

2023-12-14 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,97 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-

[llvm] [libc] [flang] [libcxx] [mlir] [clang] [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction (PR #73618)

2023-12-14 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,102 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[libc] [clang] [mlir] [flang] [libcxx] [llvm] [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction (PR #73618)

2023-12-14 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,97 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-

[mlir] [libcxx] [clang] [llvm] [flang] [libc] [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction (PR #73618)

2023-12-14 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,102 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[flang] [libcxx] [mlir] [llvm] [libc] [clang] [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction (PR #73618)

2023-12-14 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,159 @@ +//===--===// ldionne wrote: Nit: these test names are a bit hard to read, I would suggest `out_ptr.general.pass.cp`, `out_ptr_t.convert.pass.cpp`, etc. https://github.com/llv

[clang] [llvm] [mlir] [libc] [flang] [libcxx] [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction (PR #73618)

2023-12-14 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,97 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-

[libunwind] [libunwind] Use -nostdlib++ when linking libunwind (PR #75646)

2023-12-15 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/75646 We shouldn't need to link against libc++ or libc++abi when building libunwind, since that would otherwise be a circular dependency. >From c5ff17c24afba4b44e45894452c733fef0183fb0 Mon Sep 17 00:00:00 2001 From: L

[libunwind] [libunwind] Use -nostdlib++ when linking libunwind (PR #75646)

2023-12-18 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/75646 >From c5ff17c24afba4b44e45894452c733fef0183fb0 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 15 Dec 2023 14:14:44 -0500 Subject: [PATCH 1/2] [libunwind] Use -nostdlib++ when linking libunwind We shouldn

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2023-12-18 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/75841 This removes a long standing piece of technical debt. Most other platforms have moved all their header search path logic to the driver, but Darwin still had some logic for setting framework search paths present

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2023-12-18 Thread Louis Dionne via cfe-commits
@@ -758,9 +758,14 @@ void darwin::Linker::ConstructJob(Compilation &C, const JobAction &JA, } } - // Add non-standard, platform-specific search paths, e.g., for DriverKit: - // -L/System/DriverKit/usr/lib - // -F/System/DriverKit/System/Library/Framework + // Add

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2023-12-18 Thread Louis Dionne via cfe-commits
@@ -758,9 +758,14 @@ void darwin::Linker::ConstructJob(Compilation &C, const JobAction &JA, } } - // Add non-standard, platform-specific search paths, e.g., for DriverKit: - // -L/System/DriverKit/usr/lib - // -F/System/DriverKit/System/Library/Framework + // Add

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2023-12-18 Thread Louis Dionne via cfe-commits
ldionne wrote: @jlebar The CI seems to be failing due to a test you were the last to touch: ``` TEST 'Clang :: Preprocessor/cuda-macos-includes.cu' FAILED Exit Code: 1 Command Output (stderr): -- [...] error: CHECK-DAG: expected string not found in inp

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2023-12-18 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/75841 >From ca2a85880cec704225c0b1d5241cf299d5dcad41 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Mon, 18 Dec 2023 12:53:23 -0500 Subject: [PATCH 1/2] [clang][Darwin] Remove legacy framework search path logic in

[libunwind] [libunwind] Use -nostdlib++ when linking libunwind (PR #75646)

2023-12-19 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/75646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind][WebAssembly] Don't build libunwind.cpp (PR #73196)

2023-11-23 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/73196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libunwind] [libcxxabi] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

2023-11-23 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/67201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] [libunwind] [libcxx] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

2023-11-23 Thread Louis Dionne via cfe-commits
ldionne wrote: Closing since it seems we don't want to pursue this anymore, since `@CMAKE_CXX_FLAGS_INIT@` are flags for the library build, not necessarily for the tests to use. https://github.com/llvm/llvm-project/pull/67201 ___ cfe-commits mailing

[llvm] [clang] [SME2] Add LUTI2 and LUTI4 quad Builtins and Intrinsics (PR #73317)

2023-11-27 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/73317 >From f5b909e24e3cea49d98b40797880e4329a7a1e4f Mon Sep 17 00:00:00 2001 From: Matt Devereau Date: Mon, 20 Nov 2023 15:50:28 + Subject: [PATCH 1/2] [SME2] Add LUTI2 and LUTI4 quad Builtins and Intrinsics See

[clang] [Clang] Warn on deprecated specializations used in system headers. (PR #70353)

2023-11-28 Thread Louis Dionne via cfe-commits
ldionne wrote: I'm not familiar with your exact setup, but I think you should probably report those warnings to Google Test and turn off deprecation warnings in your build with `-Wno-deprecated` until you're able to update to a version of Google Test that has fixed this issue? https://github.

[libcxx] [clang] [llvm] [clang-tools-extra] [libc++] P2770R0: "Stashing stashing iterators for proper flattening" (PR #66033)

2023-11-29 Thread Louis Dionne via cfe-commits
https://github.com/ldionne unassigned https://github.com/llvm/llvm-project/pull/66033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [clang] [llvm] [clang-tools-extra] [libc++] P2770R0: "Stashing stashing iterators for proper flattening" (PR #66033)

2023-11-29 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/66033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [libcxx] [libc++] P2770R0: "Stashing stashing iterators for proper flattening" (PR #66033)

2023-11-29 Thread Louis Dionne via cfe-commits
https://github.com/ldionne commented: Thanks! This is almost good to go, but I am still seeing two review comments I had left which I don't think have been addressed. https://github.com/llvm/llvm-project/pull/66033 ___ cfe-commits mailing list cfe-com

[clang-tools-extra] [llvm] [clang] [libcxx] [libc++] P2770R0: "Stashing stashing iterators for proper flattening" (PR #66033)

2023-11-29 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,31 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [clang-tools-extra] [llvm] [libcxx] [libc++] P2770R0: "Stashing stashing iterators for proper flattening" (PR #66033)

2023-11-29 Thread Louis Dionne via cfe-commits
@@ -234,8 +243,37 @@ namespace ranges { __inner_.reset(); } +_LIBCPP_HIDE_FROM_ABI constexpr _Outer& __get_outer() { + if constexpr (forward_range<_Base>) { +return __outer_; + } else { +return *__parent_->__outer_; + } +} + +

[llvm] [clang-tools-extra] [libcxx] [clang] [libc++] P2770R0: "Stashing stashing iterators for proper flattening" (PR #66033)

2023-11-29 Thread Louis Dionne via cfe-commits
@@ -1,57 +0,0 @@ -//===--===// -// -// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. -// See https://llvm.org/LICENSE.txt for license information. -// SPDX-License-Identifier: Apac

[clang] [llvm] [clang-tools-extra] [libcxx] [libc++] P2770R0: "Stashing stashing iterators for proper flattening" (PR #66033)

2023-11-29 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,30 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[libunwind] be811d1 - [libc++] Run picolibc tests with qemu

2023-11-29 Thread Louis Dionne via cfe-commits
Author: Michael Platings Date: 2023-11-29T17:21:08-05:00 New Revision: be811d1617654e46f4f4daa82259ae4fad4c8e6a URL: https://github.com/llvm/llvm-project/commit/be811d1617654e46f4f4daa82259ae4fad4c8e6a DIFF: https://github.com/llvm/llvm-project/commit/be811d1617654e46f4f4daa82259ae4fad4c8e6a.di

[clang] e4f951e - [clang][NFC] Fix typo in comment about Mac Catalyst

2023-11-30 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2023-11-30T11:05:41-05:00 New Revision: e4f951e4eef6128a2e9d8fc103e4402315484d65 URL: https://github.com/llvm/llvm-project/commit/e4f951e4eef6128a2e9d8fc103e4402315484d65 DIFF: https://github.com/llvm/llvm-project/commit/e4f951e4eef6128a2e9d8fc103e4402315484d65.diff

[libcxx] [libunwind] [llvm] [libc++] Allow running the test suite with optimizations (PR #68753)

2023-12-01 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/68753 >From 5dc552a8231132f5ae780e1220961fe22309d49d Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 10 Oct 2023 16:35:11 -0700 Subject: [PATCH 1/4] [libc++] Allow running the test suite with optimizations This

[clang] [CUDA] work around more __noinline__ conflicts with libc++ (PR #74123)

2023-12-01 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/74123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA] work around more __noinline__ conflicts with libc++ (PR #74123)

2023-12-01 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,10 @@ +// CUDA headers define __noinline__ which interferes with libc++'s use of +// `__attribute((__noinline__))`. In order to avoid compilation error, +// temporarily unset __noinline__ when we include affected libc++ header. + +#pragma push_macro("__noinline__") +#un

[clang] [CUDA] work around more __noinline__ conflicts with libc++ (PR #74123)

2023-12-01 Thread Louis Dionne via cfe-commits
https://github.com/ldionne commented: Some review comments if we end up merging this. FWIW I am not thrilled about using `__config` here. That header is an implementation detail of libc++ and defining it and relying on it is somewhat brittle. https://github.com/llvm/llvm-project/pull/74123 __

[clang] [CUDA] work around more __noinline__ conflicts with libc++ (PR #74123)

2023-12-01 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,10 @@ +// CUDA headers define __noinline__ which interferes with libc++'s use of +// `__attribute((__noinline__))`. In order to avoid compilation error, +// temporarily unset __noinline__ when we include affected libc++ header. + +#pragma push_macro("__noinline__") +#un

[libcxx] [libunwind] [llvm] [libc++] Allow running the test suite with optimizations (PR #68753)

2023-12-01 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/68753 >From 5e53337f16aa446d6a2dc764d347ea37b22c3a56 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 10 Oct 2023 16:35:11 -0700 Subject: [PATCH 1/4] [libc++] Allow running the test suite with optimizations This

[libunwind] [llvm] [libcxx] [libc++] Allow running the test suite with optimizations (PR #68753)

2023-12-02 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/68753 >From 5e53337f16aa446d6a2dc764d347ea37b22c3a56 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 10 Oct 2023 16:35:11 -0700 Subject: [PATCH 1/5] [libc++] Allow running the test suite with optimizations This

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2023-12-31 Thread Louis Dionne via cfe-commits
ldionne wrote: I think this can be merged. I would have liked to have @jlebar 's input on interactions with Cuda, but I think this is probably good enough. https://github.com/llvm/llvm-project/pull/75841 ___ cfe-commits mailing list cfe-commits@lists.

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2023-12-31 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/75841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2024-01-08 Thread Louis Dionne via cfe-commits
ldionne wrote: @aeubanks @petrhosek Can you folks share what was the top level invocations you did to get those errors? I am having trouble understanding the problem just from the pasted errors. https://github.com/llvm/llvm-project/pull/75841 ___ cfe

[libcxx] [llvm] [libunwind] [libc++] Allow running the test suite with optimizations (PR #68753)

2024-01-08 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/68753 >From 66c95807524dc8371c83e80d6f4ba58056f455af Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 10 Oct 2023 16:35:11 -0700 Subject: [PATCH] [libc++] Allow running the test suite with optimizations This pat

[llvm] [libcxx] [libunwind] [libc++] Allow running the test suite with optimizations (PR #68753)

2024-01-08 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/68753 >From 66c95807524dc8371c83e80d6f4ba58056f455af Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 10 Oct 2023 16:35:11 -0700 Subject: [PATCH 1/2] [libc++] Allow running the test suite with optimizations This

[llvm] [libunwind] [libcxx] [libc++] Allow running the test suite with optimizations (PR #68753)

2024-01-09 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/68753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][C++26] Implement Pack Indexing (P2662R3). (PR #72644)

2024-01-10 Thread Louis Dionne via cfe-commits
@@ -978,6 +978,20 @@ bool Parser::ConsumeAndStoreFunctionPrologue(CachedTokens &Toks) { } else { break; } + // Pack indexing + if (getLangOpts().CPlusPlus26 && Tok.is(tok::ellipsis) && ldionne wrote: @philnik777 This would requir

[clang] [Clang][C++26] Implement Pack Indexing (P2662R3). (PR #72644)

2024-01-10 Thread Louis Dionne via cfe-commits
@@ -978,6 +978,20 @@ bool Parser::ConsumeAndStoreFunctionPrologue(CachedTokens &Toks) { } else { break; } + // Pack indexing + if (getLangOpts().CPlusPlus26 && Tok.is(tok::ellipsis) && ldionne wrote: I think it might be possible

[compiler-rt] [libc] [flang] [llvm] [libcxx] [clang-tools-extra] [lld] [lldb] [clang] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

2024-01-10 Thread Louis Dionne via cfe-commits
https://github.com/ldionne ready_for_review https://github.com/llvm/llvm-project/pull/73617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [libcxx] [clang-tools-extra] [flang] [libc] [lld] [llvm] [compiler-rt] [clang] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

2024-01-10 Thread Louis Dionne via cfe-commits
https://github.com/ldionne ready_for_review https://github.com/llvm/llvm-project/pull/76447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [libcxx] [clang-tools-extra] [libcxxabi] [mlir] [flang] [libc] [lld] [libclc] [libunwind] [llvm] [openmp] [compiler-rt] [clang] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2024-01-10 Thread Louis Dionne via cfe-commits
https://github.com/ldionne ready_for_review https://github.com/llvm/llvm-project/pull/66963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [libc] [flang] [llvm] [libcxx] [clang-tools-extra] [clang] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

2024-01-10 Thread Louis Dionne via cfe-commits
https://github.com/ldionne ready_for_review https://github.com/llvm/llvm-project/pull/76449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [clang] [openmp] [lld] [llvm] [libcxx] [libc++] Deprecate the _LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_MEMBERS macro (PR #77692)

2024-01-10 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/77692 >From 6b3fd86a9949458410895a2292db935665a2ab77 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 10 Jan 2024 15:23:47 -0500 Subject: [PATCH] [libc++] Deprecate the _LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_MEM

[mlir] [clang] [openmp] [lld] [compiler-rt] [libcxx] [llvm] [libcxxabi] [runtimes] Use LLVM libunwind from libc++abi by default (PR #77687)

2024-01-10 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/77687 >From 6235f49146292293a5ad45bd22f4d7f67d69a241 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 10 Jan 2024 15:56:48 -0500 Subject: [PATCH 1/3] [runtimes] Use LLVM libunwind from libc++abi and compiler-rt

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2024-01-11 Thread Louis Dionne via cfe-commits
ldionne wrote: No, I would like to reproduce locally. https://github.com/llvm/llvm-project/pull/75841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [llvm] [openmp] [compiler-rt] [libcxxabi] [lld] [libcxx] [clang] [runtimes] Use LLVM libunwind from libc++abi by default (PR #77687)

2024-01-11 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/77687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [lld] [libcxx] [openmp] [mlir] [libc++] Deprecate the _LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_MEMBERS macro (PR #77692)

2024-01-11 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/77692 >From 6b3fd86a9949458410895a2292db935665a2ab77 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 10 Jan 2024 15:23:47 -0500 Subject: [PATCH 1/2] [libc++] Deprecate the _LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR

[llvm] [mlir] [compiler-rt] [clang] [openmp] [libcxx] [libcxxabi] [lld] [runtimes] Use LLVM libunwind from libc++abi by default (PR #77687)

2024-01-11 Thread Louis Dionne via cfe-commits
ldionne wrote: @vitalybuka This seems to have broken the ASAN and HWASAN builds here: https://lab.llvm.org/buildbot/#/builders/236/builds/8629/steps/8/logs/stdio https://lab.llvm.org/buildbot/#/builders/168/builds/17965/steps/8/logs/stdio My understanding is that we'd now need to either explicit

[clang] 4722b5d - [clang] Correct the macOS version that supports aligned allocation

2022-07-06 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2022-07-06T15:04:53-04:00 New Revision: 4722b5d1330a1104a0aa256804b9537c4d2c39d4 URL: https://github.com/llvm/llvm-project/commit/4722b5d1330a1104a0aa256804b9537c4d2c39d4 DIFF: https://github.com/llvm/llvm-project/commit/4722b5d1330a1104a0aa256804b9537c4d2c39d4.diff

[clang] a60360f - [clang][NFC] Re-generate CommandLineReference.rst

2022-07-06 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2022-07-06T16:21:14-04:00 New Revision: a60360f99a6c04f88d223628ed8c6fade195b86b URL: https://github.com/llvm/llvm-project/commit/a60360f99a6c04f88d223628ed8c6fade195b86b DIFF: https://github.com/llvm/llvm-project/commit/a60360f99a6c04f88d223628ed8c6fade195b86b.diff

[clang] bb93993 - [libc++] Always build c++experimental.a

2022-07-08 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2022-07-08T16:58:22-04:00 New Revision: bb939931a1adb9a47a2de13c359d6a72aeb277c8 URL: https://github.com/llvm/llvm-project/commit/bb939931a1adb9a47a2de13c359d6a72aeb277c8 DIFF: https://github.com/llvm/llvm-project/commit/bb939931a1adb9a47a2de13c359d6a72aeb277c8.diff

[libunwind] cb055e5 - [libc++] Add a CI job running MSAN

2022-03-31 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2022-03-31T09:31:22-04:00 New Revision: cb055e51f994806160465212ac100485dac48125 URL: https://github.com/llvm/llvm-project/commit/cb055e51f994806160465212ac100485dac48125 DIFF: https://github.com/llvm/llvm-project/commit/cb055e51f994806160465212ac100485dac48125.diff

[libunwind] 282b3eb - [libunwind] Add missing licenses in test files

2022-04-03 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2022-04-03T08:55:57-04:00 New Revision: 282b3eb72372f6a0139923d326b05fc16d86c9fa URL: https://github.com/llvm/llvm-project/commit/282b3eb72372f6a0139923d326b05fc16d86c9fa DIFF: https://github.com/llvm/llvm-project/commit/282b3eb72372f6a0139923d326b05fc16d86c9fa.diff

[libunwind] 44b4f4d - [libunwind] Remove unused substitution in AIX libunwind config

2022-08-03 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2022-08-03T09:28:39-04:00 New Revision: 44b4f4df31ab71457ecd7127e64526cd8237bfa4 URL: https://github.com/llvm/llvm-project/commit/44b4f4df31ab71457ecd7127e64526cd8237bfa4 DIFF: https://github.com/llvm/llvm-project/commit/44b4f4df31ab71457ecd7127e64526cd8237bfa4.diff

[clang] c5ccb78 - [clang][Darwin] Always set the default C++ Standard Library to libc++

2022-08-03 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2022-08-03T15:40:27-04:00 New Revision: c5ccb78ade8136134e0ca9dde64de97f913f0f8c URL: https://github.com/llvm/llvm-project/commit/c5ccb78ade8136134e0ca9dde64de97f913f0f8c DIFF: https://github.com/llvm/llvm-project/commit/c5ccb78ade8136134e0ca9dde64de97f913f0f8c.diff

[libunwind] a59165b - [runtimes] Don't try passing --target flags to GCC

2021-07-15 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2021-07-15T16:52:02-04:00 New Revision: a59165b01778a3b02c510a96951d115d39babd86 URL: https://github.com/llvm/llvm-project/commit/a59165b01778a3b02c510a96951d115d39babd86 DIFF: https://github.com/llvm/llvm-project/commit/a59165b01778a3b02c510a96951d115d39babd86.diff

<    1   2   3   4   5   6   7   8   9   10   >