[PATCH] D77836: [Attribute] Fix noderef attribute false-negatives

leonardchan updated this revision to Diff 261519. leonardchan marked 6 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77836/new/ https://reviews.llvm.org/D77836 Files: clang/include/clang/Sema/Initialization.h clang/lib/S

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a subscriber: mgorny. leonardchan requested review of this revision. This adds a multilib for Fuchsia that is built with the relative vtables ABI. This depend

[PATCH] D85312: [ADT] Move FixedPoint.h from Clang to LLVM.

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. The patch seems straightforward. Other than moving code and trimming `llvm::` from types, not sure if there's anything else I should expect. LGTM. Repository: rG LLVM Github Monor

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

leonardchan updated this revision to Diff 284573. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85576/new/ https://reviews.llvm.org/D85576 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/lib/Driver/ToolChains/Fuchsia.cpp clang/test/Drive

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, rjmccall, rsmith, pcc, hansec. leonardchan added a project: clang. Herald added subscribers: dang, dschuff. leonardchan requested review of this revision. Herald added a subscriber: aheejin. This implements the flag

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:275 + if (DriverArgs.getLastArgValue(options::OPT_fcxx_abi_EQ) == "Fuchsia") +CC1Args.push_back("-fexperimental-relative-c++-abi-vtables"); } phosek wrote: > mcgrathr wro

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan updated this revision to Diff 285192. leonardchan marked 2 inline comments as done. leonardchan edited the summary of this revision. leonardchan added a comment. - Check for lowercase flag values - Remove fuchsia-specific changes Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

leonardchan updated this revision to Diff 285219. leonardchan edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85576/new/ https://reviews.llvm.org/D85576 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/lib/

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan updated this revision to Diff 285449. leonardchan added a comment. Store a TargetCXXABI::Kind instead of a string in LangOpts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 Files: clang/incl

[PATCH] D85924: [clang] Add __RELATIVE_CXX_ABI_VTABLES predefine macro

leonardchan created this revision. leonardchan added reviewers: mcgrathr, phosek. leonardchan added a project: libc++abi. Herald added a project: clang. Herald added a subscriber: cfe-commits. leonardchan requested review of this revision. This will be set if relative vtables are enabled. Reposi

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan updated this revision to Diff 285488. leonardchan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 Files: clang/include/clang/AST/ASTContext.h clang/include/cl

[PATCH] D85924: [clang][feature] Add cxx_abi_relative_vtable feature

leonardchan updated this revision to Diff 285506. leonardchan retitled this revision from "[clang] Add __RELATIVE_CXX_ABI_VTABLES predefine macro" to "[clang][feature] Add cxx_abi_relative_vtable feature". leonardchan edited the summary of this revision. Repository: rG LLVM Github Monorepo CHA

[PATCH] D85943: Hack for automating fixes for some -Wconversion warning instances

leonardchan created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. leonardchan requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85943 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Frontend/fuchsia-wc

[PATCH] D85924: [clang][feature] Add cxx_abi_relative_vtable feature

leonardchan added a comment. CC @aaron.ballman who committed Features.def for signing off or knowing someone who can sign off. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85924/new/ https://reviews.llvm.org/D85924 __

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. In `addSanitizersAtO0`, could you make something similar to the `ASanPass` lambda for the MSan passes and also apply it when adding kernel MSan? Repository: rG LLVM Github Monorep

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

leonardchan added a comment. In D79445#2021502 , @aeubanks wrote: > In D79445#2021311 , @leonardchan > wrote: > > > In `addSanitizersAtO0`, could you make something similar to the `ASanPass` > > lambda for the MSa

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79698/new/ https://reviews.llvm.org/D79698 _

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

leonardchan added a comment. This patch seems to lead to the undefined symbol error we're seeing when building fuchsia: ld.lld: error: relocation refers to a discarded section: __sancov_guards >>> defined in user-x64-sancov.shlib/obj/third_party/ulib/scudo/scudo.string_utils.cc.o >>> refe

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

leonardchan added a comment. Just to followup on this: We believe the root cause of the error we're running into is that some sancov guards in one comdat are being referenced by symbols in another comdat, so due to linking order, the other comdat in question is referencing a sancov guard that w

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

leonardchan added a comment. In D79698#2037425 , @aeubanks wrote: > In D79698#2037305 , @leonardchan > wrote: > > > Just to followup on this: We believe the root cause of the error we're > > running into is that s

[PATCH] D79974: [Fuchsia] Do not enable the Z3 solver for a fuchsia toolchain

leonardchan created this revision. leonardchan added a reviewer: phosek. leonardchan added a project: clang. Herald added subscribers: dexonsmith, mikhail.ramalho, mgorny. phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM, don't forget to

[PATCH] D79974: [Fuchsia] Do not enable the Z3 solver for a fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG592303a53e6b: [Fuchsia] Do not enable the Z3 solver for a fuchsia toolchain (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79974/ne

[PATCH] D72959: Relative VTables ABI on Fuchsia

leonardchan added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:646 + +// Take offset from stub to the vtable component. +llvm::Function *HiddenFunc = M.getFunction(StubName); rjmccall wrote: > That's not what this block is doing. > > I th

[PATCH] D108469: Improve handling of static assert messages.

leonardchan added a comment. I think this might be the cause of the many libc++ static_assert failures we're seeing on our builders: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8810079977358640657/overview Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D128754: Refactor LLVM compression namespaces

leonardchan added a comment. > Feedback needed on: > this namespace approach will result in tooling compression methods being set > at compile time, however we may want to aim for a runtime configurable > approach in the future, likely a new revision of the compressed data formats > that llvm i

[PATCH] D128754: Refactor LLVM compression namespaces

leonardchan added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:183-191 +* Refactor compression namespaces across the project, making way for a possible + introduction of alternatives to zlib compression in the llvm toolchain. + Changes are as follows: + * Remove crc

[PATCH] D128953: refactor compression namespaces making way for a possible introduction of alternatives to zlib compression in the llvm toolchain.

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Should also probably add `[NFC]` to the start of the subject Comment at: lld/ELF/InputSection.cpp:77 +if (!compression::zlib::isAvailable()) + error(

[PATCH] D128754: Refactor LLVM compression namespaces (Part 1: remove crc32)

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Should probably add `[llvm]` to the subject also. Generally it's helpful for immediately knowing which subrepo you're touching. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM although I think I'd be more comfortable with Petr's +2 for cmake changes. Would it be better instead to expose `LLVM_ENABLE_ZSTD` to subrepos like clangd or flang until they're

[PATCH] D130516: [llvm] compression classes

leonardchan added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:193-194 } -if (llvm::compression::zlib::isAvailable()) { +llvm::compression::CompressionAlgorithm *CompressionScheme = +new llvm::compression::ZlibCompressionAlgor

[PATCH] D130516: [llvm] compression classes

leonardchan added inline comments. Comment at: llvm/lib/Support/Compression.cpp:30-32 +ZStdCompressionAlgorithm +*llvm::compression::ZStdCompressionAlgorithm::Instance = +new ZStdCompressionAlgorithm(); Perhaps for each of these, you could instead hav

[PATCH] D130516: [llvm] compression classes

leonardchan added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:255-256 +} else + return error("Compressed string table, but " + + (CompressionScheme->Name + " is unavailable").str()); + } nit: I think `

[PATCH] D131274: [clang][Darwin] Re-apply "Always set the default C++ Standard Library to libc++"

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Asserted locally the test passes. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131274/new/ https://reviews.

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

leonardchan added a comment. Hi. I think this patch may have led to the test failure we're seeing on our clang builders (https://luci-milo.appspot.com/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8840986998954824016): Command Output (stderr): -- /b/s/w/ir/x/w/llvm-project/clang/test/D

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

leonardchan added a comment. In D105960#2897310 , @arphaman wrote: > I think this should be fixed in 40d2d0c41298f1d8a178216e2534b29e3128cf37 > . Thanks. Confirmed the test passes loca

[PATCH] D99381: [compiler-rt][hwasan] Remove __sanitizer allocation functions from hwasan interface

leonardchan updated this revision to Diff 362103. leonardchan retitled this revision from "[compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits" to "[compiler-rt][hwasan] Remove __sanitizer allocation functions from hwasan interface". leonardchan edited the summary of this revisio

[PATCH] D99381: [compiler-rt][hwasan] Remove __sanitizer allocation functions from hwasan interface

leonardchan added a comment. In D99381#2858599 , @mcgrathr wrote: > Frankly I don't think it makes sense to have __sanitizer_mallinfo and those > other allocator functions declared in hwasan_interface_internal.h at all. > Those are neither APIs that the c

[PATCH] D99381: [compiler-rt][hwasan] Remove __sanitizer allocation functions from hwasan interface

leonardchan updated this revision to Diff 362571. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99381/new/ https://reviews.llvm.org/D99381 Files: compiler-rt/lib/hwasan/hwasan_allocation_functions.cpp compiler-rt/lib/hwasan/hwasan_interface_inte

[PATCH] D99381: [compiler-rt][hwasan] Remove __sanitizer allocation functions from hwasan interface

leonardchan added a comment. In D99381#2911459 , @vitalybuka wrote: > In D99381#2911057 , @eugenis wrote: > >> They are used here: >> https://cs.android.com/android/platform/superproject/+/master:bionic/libc/bionic/

[PATCH] D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added projects: clang, Sanitizers. Herald added a subscriber: abrachet. leonardchan requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119201 Files: cla

[PATCH] D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

leonardchan updated this revision to Diff 406664. leonardchan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119201/new/ https://reviews.llvm.org/D119201 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/li

[PATCH] D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

leonardchan updated this revision to Diff 406871. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119201/new/ https://reviews.llvm.org/D119201 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/ToolChains/Fuchsia.cpp Index: clang

[PATCH] D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

leonardchan marked an inline comment as done. leonardchan added a comment. In D119201#3303275 , @phosek wrote: > Have you checked if all the tests are still passing? All the clang tests seem to be passing, but I'll run the llvm and runtimes tests also.

[PATCH] D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. leonardchan marked an inline comment as done. Closed by commit rG4ac58b61022d: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the… (authored by

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

leonardchan accepted this revision. leonardchan added a comment. LGTM tested on mac on my end Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 ___ cfe-commits ma

[PATCH] D66488: [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1 under the new pass manager

leonardchan created this revision. leonardchan added reviewers: pcc, tejohnson. leonardchan added a project: clang. Herald added subscribers: dexonsmith, steven_wu, inglorion, mehdi_amini. Match the behavior of D65009 under the new pass manager also. Repository

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

leonardchan added a comment. It seems that this test leads to an `UNREACHABLE` under the new pass manager (can check this by adding `-fexperimental-new-pass-manager` to the test. I think this is because the passes for lowering the `llvm.coro` intrinsics are not yet ported to the new PM. Would i

[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

leonardchan created this revision. leonardchan added reviewers: chandlerc, echristo, hfinkel, lattner, rupprecht. leonardchan added a project: clang. Herald added subscribers: dexonsmith, mehdi_amini, mgorny. The new PM serves as a replacement for the legacy PM, and promises better codegen, bette

[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

leonardchan added a comment. As of now, from running `check-llvm` and `check-clang` there's 2 failing tests, but I'm trying to get those addressed. - `Clang :: CodeGen/split-lto-unit.c` which should be resolved by D66488 - `Clang :: CodeGenCXX/ubsan-coroutines.

[PATCH] D66493: [NewPM] Run ubsan-coroutines test under the legacy pass manager only

leonardchan created this revision. leonardchan added reviewers: vsk, modocache. leonardchan added a project: clang. Herald added a subscriber: EricWF. The passes that lower the `llvm.coro.*` instrinsics have not yet been ported, so only run under the legacy PM for now. See https://bugs.llvm.org/

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

leonardchan added a comment. In D44672#1637984 , @vsk wrote: > In D44672#1637891 , @leonardchan > wrote: > > > It seems that this test leads to an `UNREACHABLE` under the new pass > > manager (can check this by ad

[PATCH] D66493: [NewPM] Run ubsan-coroutines test under the legacy pass manager only

This revision was automatically updated to reflect the committed changes. Closed by commit rL369442: [NewPM] Run ubsan-coroutines test under the legacy pass manager only (authored by leonardchan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D66488: [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1 under the new pass manager

This revision was automatically updated to reflect the committed changes. Closed by commit rL369550: [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1 under the new… (authored by leonardchan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Change

[PATCH] D66492: [Clang][CodeGen] set alias linkage on QualType

leonardchan added a comment. I think this patch might be causing some test failures on our mac bots: FAIL: Clang :: CodeGen/alias.c (2014 of 15397) TEST 'Clang :: CodeGen/alias.c' FAILED Script: -- : 'RUN: at line 2'; /b/s/w/ir/k/recipe_clea

[PATCH] D66988: [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes

leonardchan created this revision. leonardchan added reviewers: chandlerc, fedor.sergeev, philip.pfaffe. leonardchan added a project: Sanitizers. Herald added subscribers: cfe-commits, hiraditya. Herald added projects: clang, LLVM. This patch merges the sancov module and funciton passes into one m

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

leonardchan accepted this revision. leonardchan added inline comments. Comment at: clang-tools-extra/clang-misexpect/ClangMisExpect.cpp:64 +break; + default: +llvm_unreachable("Bad Profile Format given to clang-misexpect use one of " Nit: The default and

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

leonardchan accepted this revision. leonardchan added a comment. Sorry about that. Still LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 ___ cfe-commits m

[PATCH] D66988: [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes

leonardchan added a comment. *ping* This patch also seems to fix an issue with mismatched PC table and inline counters: ./out/Fuzz2/region_deserialize

[PATCH] D66988: [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66988/new/ https://reviews.llvm.org/D66988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

leonardchan added a comment. Hi! We've noticed that for our arm bots, we're getting some flaky builds that sometimes fail with `error: array designators are a C99 extension [-Werror,-Wc99-designator]` and sometimes don't fail. 2 questions: 1. I can't see it off the patch immediately, but do you

[PATCH] D66988: [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes

This revision was automatically updated to reflect the committed changes. Closed by commit rL370971: [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes (authored by leonardchan, committed by ). Changed prior to commit: https://reviews.llvm.org/D66988?vs=218008&id=218781#toc Reposito

[PATCH] D67253: clang-misexpect: a standalone tool for verifying the use of __builtin_expect with PGO data

leonardchan added inline comments. Comment at: clang-tools-extra/clang-misexpect/ClangMisExpect.cpp:77 +break; +llvm_unreachable("Bad Profile Format given to clang-misexpect use one of " + "(clang, llvm, csllvm, sample)"); Nit: llvm_un

[PATCH] D67323: [NewPM][Sancov] Create the Sancov Pass after building the pipelines

leonardchan created this revision. leonardchan added reviewers: chandlerc, phosek. leonardchan added a project: Sanitizers. Herald added subscribers: cryptoad, kristof.beyls. Herald added a project: clang. We're running into linker errors from missing sancov sections: ld.lld: error: relocation

[PATCH] D67323: [NewPM][Sancov] Create the Sancov Pass after building the pipelines

This revision was automatically updated to reflect the committed changes. Closed by commit rL371326: [NewPM][Sancov] Create the Sancov Pass after building the pipelines (authored by leonardchan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM unless @rjmccall has further comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86632/new/ https://reviews.llvm.org/D86632

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

leonardchan added a comment. Hi. Our GCC builders are failing with [182/12433] CXX kernel-x64-gcc/obj/kernel/lib/ktl/ktl.dummy-new.cc.o FAILED: kernel-x64-gcc/obj/kernel/lib/ktl/ktl.dummy-new.cc.o /b/s/w/ir/k/fuchsia/prebuilt/third_party/goma/linux-x64/gomacc ../../prebuilt/third_party/gc

[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

leonardchan added inline comments. Comment at: llvm/include/llvm/IR/FixedPointBuilder.h:171-172 +// lossless, except for overflow to infinity which is unlikely. +return B.CreateFMul(Result, +ConstantFP::get(DstTy, std::pow(2, -(int)SrcSema.getScale(; + }

[PATCH] D85743: [CodeGen][AArch64] Support arm_sve_vector_bits attribute

leonardchan added a comment. Hi! The `attr-arm-sve-vector-bits-call.c` test seems to be failing on our clang builders: FAIL: Clang :: CodeGen/attr-arm-sve-vector-bits-call.c (3020 of 25924) TEST 'Clang :: CodeGen/attr-arm-sve-vector-bits-call.c' FAILED *

[PATCH] D85743: [CodeGen][AArch64] Support arm_sve_vector_bits attribute

leonardchan added a comment. > The IR differences were caused by the new pass manager which is on by default > for the Fuchsia builder. I've re-landed the patch with a fix for > `CodeGen/attr-arm-sve-vector-bits-call.c` to use the legacy pm with > `-fno-experimental-new-pass-manager`. Thanks f

[PATCH] D85924: [clang][feature] Add cxx_abi_relative_vtable feature

leonardchan added a comment. *ping* @aaron.ballman. Would you be able to sign off on this? Otherwise, I'll probably commit this in the next few days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85924/new/ https://reviews.llvm.org/D85924 ___

[PATCH] D93668: [clang] Add -ffuchsia-c++-abi flag to explicitly use the Fuchsia C++ ABI

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, rnk. leonardchan added a project: clang. Herald added subscribers: dexonsmith, dang. leonardchan requested review of this revision. This is a more concentrated version of D85802 whi

[PATCH] D91387: [Driver] Support UBSan multilib

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91387/new/ https://reviews.llvm.org/D91387 ___

[PATCH] D91385: [DFSan][NewPM] Handle dfsan under NPM

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91385/new/ https://reviews.llvm.org/D91385 ___

[PATCH] D91389: [MemProf][NewPM] Make memprof passes required

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91389/new/ https://reviews.llvm.org/D91389 ___

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added projects: Sanitizers, clang. Herald added subscribers: Sanitizers, mgorny. leonardchan requested review of this revision. This tracks all the compiler/llvm changes needed for building Fuchsia with t

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

leonardchan added a comment. Hi. I suspect it might be this patch or D90984 that might be leading to the test failure we're seeing on our arm64 builders FAIL: Clang-Unit :: AST/./ASTTests/Traverse.IgnoreUnlessSpelledInSourceImplicit (15871 of 26886) **

[PATCH] D83812: [clang][RelativeVTablesABI] Use dso_local_equivalent rather than emitting stubs

leonardchan updated this revision to Diff 306472. leonardchan added a comment. Rebased. @rjmccall This might've changed a bit since you last accepted the revision. Will wait a couple of days before submitting if you have any more comments on this. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

leonardchan added a comment. *ping* any more comments on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85576/new/ https://reviews.llvm.org/D85576 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM but you should probably also wait for @aaron.ballman or @rsmith to also chime in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

leonardchan added a comment. Hi! It looks like this is causing a test failure on our aach64 builders (https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-linux-arm64/b8868095822628984976?): [1113/1114] Running the Clang regression tests llvm-lit: /b/s/w/ir/k/staging/llvm_build/bin/../

[PATCH] D85924: [clang][feature] Add cxx_abi_relative_vtable feature

This revision was automatically updated to reflect the committed changes. Closed by commit rG64c0792946b7: [clang][feature] Add cxx_abi_relative_vtable feature (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85924/new/ https

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added a comment. *ping* Any objections to this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D88936: [HWAsan][NewPM] Handle hwasan like other sanitizers

leonardchan added a comment. To what extent does the IR change? My only concern is the right codegen is still produced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88936/new/ https://reviews.llvm.org/D88936 _

[PATCH] D88936: [HWAsan][NewPM] Handle hwasan like other sanitizers

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. I see. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88936/new/ https://reviews.llvm.org/D88936

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3469 + + // The value can be empty, which indicates the system default should be used. + StringRef CXXABI = Args.getLastArgValue(OPT_fcxx_abi_E

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG683b308c07bf: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use (authored by leonardchan). Changed prior to commit: https://reviews.

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

leonardchan added a comment. This should also be ready now that https://reviews.llvm.org/D85802 landed, unless we don't want to submit this *right* now so the clang builders don't build these multilibs that won't be used yet? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

leonardchan added a comment. > This change implement a slightly different approach from what we discussed, > which is providing an Itanium-compatible (that is `-fc++abi=itanium`) > multilib for compatibility with other compilers, and then enabling relative > vtables by default. Unless there's a

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added a comment. In D85802#2331290 , @rnk wrote: > I'd like to point out that we used to have a very similar flag, but we > removed it back in 2014: http://reviews.llvm.org/D2545 > > Are you sure you need all the flexibility that this flag all

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added a comment. In D85802#2332895 , @phosek wrote: > In D85802#2332808 , @rnk wrote: > >> Would "f[no-]fuchsia-c++-abi-extensions" (or shorter, -ffuchsia-c++-abi) do >> the trick? I know it doesn't map

[PATCH] D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros

leonardchan added a comment. Hi, it seems that `p2.cpp` is failing on our production builder (https://luci-milo.appspot.com/p/fuchsia/builders/prod/clang-linux-x64/b8862835022166171808): FAIL: Clang :: CXX/cpp/cpp.predefined/p2.cpp (1210 of 26900) TEST 'Clang :: CXX/cpp/

[PATCH] D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros

leonardchan added a comment. In D91747#2412212 , @rnk wrote: > Does rG64802d48d51d651bd2e4567b2f228f8795569542 > fix it? Yup, looks like it does. Thanks for the quick fix! Repository

[PATCH] D92140: Fix noderef for array member of deref expr

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. Thanks for catching this. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92140/new/ https://reviews.llvm.org/D92140 _

[PATCH] D92141: Fix noderef for AddrOf on MemberExpr

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Thanks Comment at: clang/test/Frontend/noderef.c:75-76 + // enclosing AddrOf. + p = &s->a;// ok + p = &(*s).a; // ok + p2 = &s->a; // expected-warn

[PATCH] D92291: clang/test: Remove platform-linker feature

leonardchan added a subscriber: phosek. leonardchan added a comment. @phosek This shouldn't affect supporting riscv with our toolchain, right? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92291/new/ https://reviews.llvm.org/D92291 ___ cfe-co

[PATCH] D83812: [clang][RelativeVTablesABI] Use dso_local_equivalent rather than emitting stubs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf8ff75bade7: [clang][RelativeVTablesABI] Use dso_local_equivalent rather than emitting stubs (authored by leonardchan). Repository: rG LLVM Githu

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

This revision was automatically updated to reflect the committed changes. Closed by commit rGfdbd84c6c819: [clang][Fuchsia] Add relative-vtables multilib (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85576/new/ https://rev

[PATCH] D92140: Fix noderef for array member of deref expr

leonardchan added a comment. Sorry. I accidentally missed this in my emails. Will commit these. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92140/new/ https://reviews.llvm.org/D92140 ___ cfe-commits ma

[PATCH] D92140: Fix noderef for array member of deref expr

leonardchan closed this revision. leonardchan added a comment. Committed in 155fca3cae275562e626d3e4fbfac70b4b75d2e7 . (Sorry, I forgot to change the author email in the commit) Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D92141: Fix noderef for AddrOf on MemberExpr

leonardchan closed this revision. leonardchan added a comment. Ok this time I remembered the email. Unsure why the bug isn't automatically closed though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92141/new/ https://reviews.llvm.org/D92141 ___

<    1   2   3   4   5   6   7   8   9   >