leonardchan added a comment.

In D99381#2858599 <https://reviews.llvm.org/D99381#2858599>, @mcgrathr wrote:

> Frankly I don't think it makes sense to have __sanitizer_mallinfo and those 
> other allocator functions declared in hwasan_interface_internal.h at all.
> Those are neither APIs that the compiler emits nor ones that anyone else 
> should use.  They are just implementation details of the allocator 
> interceptors.
> I think a better cleanup is to move those declarations out of that file.  I 
> don't see why they need to be in any header file rather than just in 
> hwasan_allocation_functions.cpp.

I see. So something like this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99381/new/

https://reviews.llvm.org/D99381

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to