omtcyfz added inline comments.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:51-52
@@ -34,4 +50,4 @@
void UseBoolLiteralsCheck::check(const MatchFinder::MatchResult &Result) {
- const auto *Literal = Result.Nodes.getNodeAs("literal");
- const auto *Cast = Result.Nod
omtcyfz added inline comments.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:51-52
@@ -34,4 +50,4 @@
void UseBoolLiteralsCheck::check(const MatchFinder::MatchResult &Result) {
- const auto *Literal = Result.Nodes.getNodeAs("literal");
- const auto *Cast = Result.Nod
omtcyfz added inline comments.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:51-52
@@ -34,4 +50,4 @@
void UseBoolLiteralsCheck::check(const MatchFinder::MatchResult &Result) {
- const auto *Literal = Result.Nodes.getNodeAs("literal");
- const auto *Cast = Result.Nod
omtcyfz added inline comments.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:51-52
@@ -34,4 +50,4 @@
void UseBoolLiteralsCheck::check(const MatchFinder::MatchResult &Result) {
- const auto *Literal = Result.Nodes.getNodeAs("literal");
- const auto *Cast = Result.Nod
omtcyfz updated this revision to Diff 67102.
omtcyfz added a comment.
Added ternary operator example to docs.
https://reviews.llvm.org/D23243
Files:
clang-tidy/modernize/UseBoolLiteralsCheck.cpp
docs/clang-tidy/checks/modernize-use-bool-literals.rst
test/clang-tidy/modernize-use-bool-lite
omtcyfz added a comment.
In https://reviews.llvm.org/D23243#508097, @aaron.ballman wrote:
> LGTM! We may want to consider BinaryConditionalOperator as well, but that can
> be in as a separate patch.
Well, I personally have never seen `BinaryConditionalOperator `in my life.
And honestly I'm no
omtcyfz added a comment.
Ah, and yes, it's better to move `*.yaml` to `extra/test/clang-rename/Inputs`
in order to prevent confusion as every other file in `extra/test/clang-rename`
is a test.
https://reviews.llvm.org/D23198
___
cfe-commits mailin
omtcyfz created this revision.
omtcyfz added a reviewer: alexfh.
omtcyfz added a subscriber: cfe-commits.
`readability-else-after-return` only warns about `return` calls, but [[
http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return |
Coding Stadnards ]] mention `throw`, `contin
omtcyfz updated this revision to Diff 67165.
omtcyfz added a comment.
Do these symbolic pointers seem reasonable?
https://reviews.llvm.org/D23193
Files:
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/Field.cpp
Index: test/clang-rename/Field.cpp
===
omtcyfz updated this revision to Diff 67169.
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
Use shiny `eachOf` and bind everything to `"literal"` value.
https://reviews.llvm.org/D23243
Files:
clang-tidy/modernize/UseBoolLiteralsCheck.cpp
docs/clang-tidy/checks/modernize-
omtcyfz added inline comments.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:41
@@ +40,3 @@
+ // using anyOf(BINDLITERAL(), anything()).
+ anyOf(hasTrueExpression(ignoringParenImpCasts(
+integerLiteral().bind("trueBranchLiteral")))
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
https://reviews.llvm.org/D23243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz updated this revision to Diff 67189.
omtcyfz added a comment.
Remove redundant `anyOf` and `anything`.
https://reviews.llvm.org/D23243
Files:
clang-tidy/modernize/UseBoolLiteralsCheck.cpp
docs/clang-tidy/checks/modernize-use-bool-literals.rst
test/clang-tidy/modernize-use-bool-lit
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
https://reviews.llvm.org/D23243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: omtcyfz
Date: Mon Aug 8 12:11:56 2016
New Revision: 278022
URL: http://llvm.org/viewvc/llvm-project?rev=278022&view=rev
Log:
[clang-tidy] enhance modernize-use-bool-literals to check ternary operator
modernize-use-bool-literals doesn't checks operands in ternary operator.
For example:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278022: [clang-tidy] enhance modernize-use-bool-literals to
check ternary operator (authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D23243?vs=67195&id=67197#toc
Repository:
rL
omtcyfz updated this revision to Diff 67199.
omtcyfz added a comment.
Added more info to the test.
https://reviews.llvm.org/D23193
Files:
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/Field.cpp
Index: test/clang-rename/Field.cpp
==
omtcyfz updated this revision to Diff 67195.
omtcyfz added a comment.
More strict test messages.
https://reviews.llvm.org/D23243
Files:
clang-tidy/modernize/UseBoolLiteralsCheck.cpp
docs/clang-tidy/checks/modernize-use-bool-literals.rst
test/clang-tidy/modernize-use-bool-literals.cpp
Ind
omtcyfz updated this revision to Diff 67289.
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
`auto` -> `SourceLocation`
https://reviews.llvm.org/D23193
Files:
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/Field.cpp
Index: test/clang-rename/
Author: omtcyfz
Date: Tue Aug 9 02:14:48 2016
New Revision: 278099
URL: http://llvm.org/viewvc/llvm-project?rev=278099&view=rev
Log:
[clang-rename] fix bug with initializer lists
Clang-rename is currently not able to find a symbol in initializer list. This
patch fixes described issue.
Reviewers
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278099: [clang-rename] fix bug with initializer lists
(authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D23193?vs=67289&id=67290#toc
Repository:
rL LLVM
https://reviews.llvm.o
omtcyfz added a subscriber: omtcyfz.
omtcyfz added a comment.
In https://reviews.llvm.org/D23279#509047, @Eugene.Zelenko wrote:
> May be this could be Clang-rename mode?
Definitely not.
I think this is in scope of `clang-tidy`.
In https://reviews.llvm.org/D23279#509076, @compnerd wrote:
> Th
omtcyfz added a comment.
And actually it makes much more sense for C than for C++. In C++ you just do
`s/struct/class/g`, insert `public:` and you're golden.
P.S. It actually breaks code. I haven't looked into that, but
bar::Foo foo = { &x, 17, 1.29, 0 }; // CHECK: bar::Foo foo = { 1.29, 0, 1
omtcyfz added a comment.
Please fix the same thing @ `USRLocFinder.cpp:47`.
Other than that, looks OK - a bit more readable. Thanks.
https://reviews.llvm.org/D23298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
omtcyfz added a comment.
In https://reviews.llvm.org/D23279#509567, @omtcyfz wrote:
> In https://reviews.llvm.org/D23279#509047, @Eugene.Zelenko wrote:
>
> > May be this could be Clang-rename mode?
>
>
> Definitely not.
>
> I think this is in scope of `clang-tidy`.
>
> In https://reviews.llvm.org
omtcyfz added a comment.
In https://reviews.llvm.org/D23279#509570, @klimek wrote:
> In https://reviews.llvm.org/D23279#509568, @omtcyfz wrote:
>
> > And actually it makes much more sense for C than for C++. In C++ you just
> > do `s/struct/class/g`, insert `public:` and you're golden.
>
>
> Tha
omtcyfz accepted this revision.
omtcyfz added a comment.
This revision is now accepted and ready to land.
LGTM
Thanks!
Do you have a commit access or do you need me to land the patch?
https://reviews.llvm.org/D23298
___
cfe-commits mailing list
cf
omtcyfz added a comment.
Sure.
https://reviews.llvm.org/D23298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: omtcyfz
Date: Tue Aug 9 05:03:33 2016
New Revision: 278112
URL: http://llvm.org/viewvc/llvm-project?rev=278112&view=rev
Log:
[clang-rename] cleanup: use isWritten
nit: use isWritten and const auto *Initializer in
NamedDeclFindingASTVisitor::VisitCXXConstructorDecl method.
Test plan: make
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278112: [clang-rename] cleanup: use isWritten (authored by
omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D23298?vs=67301&id=67309#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2329
omtcyfz added a comment.
FYI: I think the diff (accessible by `Download Raw Diff`) is corrupted for some
reason; at least I don't see `Index: test/clang-rename/USRLocFinder.cpp` line
in the end, which should be present, I guess.
Repository:
rL LLVM
https://reviews.llvm.org/D23298
___
omtcyf0 updated this revision to Diff 67328.
omtcyf0 added a comment.
Address comments Alex made.
https://reviews.llvm.org/D17990
Files:
clang-tidy/modernize/DeprecatedHeadersCheck.cpp
docs/clang-tidy/checks/modernize-deprecated-headers.rst
test/clang-tidy/modernize-deprecated-headers-cxx
omtcyf0 updated this revision to Diff 67334.
omtcyf0 marked 3 inline comments as done.
omtcyf0 added a comment.
Address remaining comments.
https://reviews.llvm.org/D17990
Files:
clang-tidy/modernize/DeprecatedHeadersCheck.cpp
docs/clang-tidy/checks/modernize-deprecated-headers.rst
test/c
omtcyfz updated this revision to Diff 67347.
omtcyfz marked 2 inline comments as done.
omtcyfz added a comment.
Address the comments.
https://reviews.llvm.org/D23265
Files:
clang-tidy/readability/ElseAfterReturnCheck.cpp
docs/clang-tidy/checks/readability-else-after-return.rst
test/clang-
omtcyfz added inline comments.
Comment at: clang-rename/tool/ClangRename.cpp:65
@@ +64,3 @@
+
+ RenameAllInfo() : Offset(0) {}
+};
AFAIK there's no need to do that, integer types are by default initialized with
0, aren't they?
https://reviews.llvm.org/D23198
omtcyfz added a comment.
In https://reviews.llvm.org/D23279#509896, @compnerd wrote:
> If the argument really is that we want to minimize the tools then Id argue
> that `clang-rename` also belongs in `clang-tidy` as it would be used to
> rename fields to match the naming convention (tidying up
omtcyfz added a comment.
In https://reviews.llvm.org/D23279#510011, @aaron.ballman wrote:
> In https://reviews.llvm.org/D23279#510002, @omtcyfz wrote:
>
> > In https://reviews.llvm.org/D23279#509896, @compnerd wrote:
> >
> > > If the argument really is that we want to minimize the tools then Id
omtcyfz accepted this revision.
omtcyfz added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang-rename/tool/ClangRename.cpp:65
@@ +64,3 @@
+
+ RenameAllInfo() : Offset(0) {}
+};
vmiklos wrote:
> omtcyfz wrote:
> > AFAIK there's
omtcyfz added inline comments.
Comment at: clang-rename/tool/ClangRename.cpp:65
@@ +64,3 @@
+
+ RenameAllInfo() : Offset(0) {}
+};
omtcyfz wrote:
> vmiklos wrote:
> > omtcyfz wrote:
> > > AFAIK there's no need to do that, integer types are by default
> > > initi
omtcyfz added a comment.
In https://reviews.llvm.org/D23279#510061, @alexshap wrote:
> First of all, many thanks for the comments & proposal of clang-refactor.
>
> 1. Regarding high-level project organization: clang-refactor - that can be a
> good place for various refactoring techniques like th
omtcyfz added a comment.
In https://reviews.llvm.org/D23279#510129, @alexshap wrote:
> Regarding TUs - i am aware of that - would be useful if you could provide a
> test which doesn't work - that would help us avoid miscommunication. Thanks.
Suppose you have a `struct Foo` defined in `LibA` an
omtcyfz added inline comments.
Comment at: clang-tidy/readability/ElseAfterReturnCheck.cpp:45
@@ +44,3 @@
+ for (const auto &BindingName :
+ {"return", "continue", "break", "goto", "throw"}) {
+if (Result.Nodes.getNodeAs(BindingName)) {
alexfh wrote:
>
omtcyfz added inline comments.
Comment at: clang-tidy/readability/ElseAfterReturnCheck.cpp:45
@@ +44,3 @@
+ for (const auto &BindingName :
+ {"return", "continue", "break", "goto", "throw"}) {
+if (Result.Nodes.getNodeAs(BindingName)) {
aaron.ballman wr
omtcyfz added a comment.
In https://reviews.llvm.org/D23279#510147, @alexshap wrote:
> Suppose you have a struct Foo defined in LibA and you have used clang-rename
> to rename Foo into Bar (or just a field of Foo say - you have renamed Foo::x
> into Foo::y); LibA is linked to LibB and you have
omtcyfz added a comment.
In https://reviews.llvm.org/D23279#510157, @alexshap wrote:
> The difference is that if we reorder fields the new struct is not
> binary-compatible with the old one.
Exactly. If both libraries are in your project, it becomes broken.
Repository:
rL LLVM
https://rev
omtcyfz added inline comments.
Comment at: clang-tidy/readability/ElseAfterReturnCheck.cpp:45
@@ +44,3 @@
+ for (const auto &BindingName :
+ {"return", "continue", "break", "goto", "throw"}) {
+if (Result.Nodes.getNodeAs(BindingName)) {
aaron.ballman wr
omtcyfz added a comment.
In https://reviews.llvm.org/D23279#510167, @alexshap wrote:
> my point is the following: this tool helps perform some operation (changing
> the order of fields),
> if smb decides to do it manually - the result will have exactly the same
> issue.
While creating tools
omtcyfz updated this revision to Diff 67475.
omtcyfz marked 7 inline comments as done.
omtcyfz added a comment.
Address comments.
https://reviews.llvm.org/D23265
Files:
clang-tidy/readability/ElseAfterReturnCheck.cpp
docs/clang-tidy/checks/readability-else-after-return.rst
test/clang-tidy
omtcyfz updated this revision to Diff 67476.
omtcyfz added a comment.
Make helper matcher `const`.
https://reviews.llvm.org/D23265
Files:
clang-tidy/readability/ElseAfterReturnCheck.cpp
docs/clang-tidy/checks/readability-else-after-return.rst
test/clang-tidy/readability-else-after-return.
omtcyf0 updated this revision to Diff 67488.
omtcyf0 marked 2 inline comments as done.
omtcyf0 added a comment.
Address comments.
https://reviews.llvm.org/D17990
Files:
clang-tidy/modernize/DeprecatedHeadersCheck.cpp
docs/clang-tidy/checks/modernize-deprecated-headers.rst
test/clang-tidy/
omtcyf0 marked 3 inline comments as done.
omtcyf0 added a comment.
https://reviews.llvm.org/D17990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz updated this revision to Diff 67501.
omtcyfz added a comment.
Address comments.
https://reviews.llvm.org/D23158
Files:
test/clang-rename/ClassAsTemplateArgument.cpp
test/clang-rename/ClassFindByName.cpp
test/clang-rename/ClassSimpleRenaming.cpp
test/clang-rename/ClassTestMulti.c
omtcyfz updated this revision to Diff 67512.
omtcyfz marked 4 inline comments as done.
omtcyfz added a comment.
Address comments.
https://reviews.llvm.org/D23265
Files:
clang-tidy/readability/ElseAfterReturnCheck.cpp
docs/clang-tidy/checks/readability-else-after-return.rst
test/clang-tidy
omtcyfz updated this revision to Diff 67513.
omtcyfz added a comment.
Remove braces around single statement in `for` and `if` as Alex proposed.
https://reviews.llvm.org/D23265
Files:
clang-tidy/readability/ElseAfterReturnCheck.cpp
docs/clang-tidy/checks/readability-else-after-return.rst
t
omtcyfz updated this revision to Diff 67515.
omtcyfz added a comment.
Update files not previouysly added with `git add`.
https://reviews.llvm.org/D23158
Files:
test/clang-rename/ClassAsTemplateArgument.cpp
test/clang-rename/ClassAsTemplateArgumentFindByClass.cpp
test/clang-rename/ClassAsT
omtcyfz updated this revision to Diff 67516.
omtcyfz added a comment.
Delete two more files.
https://reviews.llvm.org/D23158
Files:
test/clang-rename/ClassAsTemplateArgument.cpp
test/clang-rename/ClassAsTemplateArgumentFindByClass.cpp
test/clang-rename/ClassAsTemplateArgumentFindByTemplat
Author: omtcyfz
Date: Wed Aug 10 08:28:30 2016
New Revision: 278221
URL: http://llvm.org/viewvc/llvm-project?rev=278221&view=rev
Log:
[clang-rename] merge tests when possible
The only difference between some tests is -offset passed to clang-rename. It
makes sense to merge them into a single file
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278221: [clang-rename] merge tests when possible (authored
by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D23158?vs=67516&id=67517#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2
Author: omtcyfz
Date: Wed Aug 10 08:32:37 2016
New Revision: 278223
URL: http://llvm.org/viewvc/llvm-project?rev=278223&view=rev
Log:
[clang-rename] remove bunch of deprecated tests
Removed:
clang-tools-extra/trunk/test/clang-rename/ClassAsTemplateArgumentFindByClass.cpp
clang-tools-ext
Author: omtcyfz
Date: Wed Aug 10 08:46:36 2016
New Revision: 278225
URL: http://llvm.org/viewvc/llvm-project?rev=278225&view=rev
Log:
[clang-rename] fix test introduced in r278221
Modified:
clang-tools-extra/trunk/test/clang-rename/ComplicatedClassType.cpp
Modified: clang-tools-extra/trunk/t
omtcyfz added a subscriber: omtcyfz.
Comment at: clang-tidy/modernize/DeprecatedHeadersCheck.cpp:79
@@ -69,3 +78,3 @@
for (const auto &KeyValue :
std::vector>(
{{"fenv.h", "cfenv"},
aaron.ballman wrote:
> This will definitely fail in M
omtcyf0 updated this revision to Diff 67519.
omtcyf0 added a comment.
Address comments.
https://reviews.llvm.org/D17990
Files:
clang-tidy/modernize/DeprecatedHeadersCheck.cpp
docs/clang-tidy/checks/modernize-deprecated-headers.rst
test/clang-tidy/modernize-deprecated-headers-cxx03.cpp
t
omtcyf0 marked an inline comment as done.
omtcyf0 added a comment.
https://reviews.llvm.org/D17990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz added a comment.
In https://reviews.llvm.org/D23279#510234, @alexshap wrote:
> > I do think that an automated tool will do a better job of changing field
> > orderings in a non-breaking way than most people would, mostly due to
> > initializer lists.
>
>
> yeah, that was the original mo
omtcyfz added a comment.
In https://reviews.llvm.org/D23279#511202, @bcraig wrote:
> In https://reviews.llvm.org/D23279#511187, @omtcyfz wrote:
>
> > In https://reviews.llvm.org/D23279#510234, @alexshap wrote:
> >
> > > > I do think that an automated tool will do a better job of changing
> > > >
omtcyf0 updated this revision to Diff 67551.
omtcyf0 marked an inline comment as not done.
omtcyf0 added a comment.
Revert changes.
https://reviews.llvm.org/D17990
Files:
clang-tidy/modernize/DeprecatedHeadersCheck.cpp
docs/clang-tidy/checks/modernize-deprecated-headers.rst
test/clang-tid
omtcyf0 added a comment.
In https://reviews.llvm.org/D17990#511429, @alexfh wrote:
> In https://reviews.llvm.org/D17990#511424, @omtcyf0 wrote:
>
> > Revert changes.
>
>
> Thanks! If Aaron has no objections, good to go.
Great! Thank you!
https://reviews.llvm.org/D17990
omtcyf0 added a subscriber: omtcyf0.
omtcyf0 added a comment.
In https://reviews.llvm.org/D23279#511439, @bcraig wrote:
> I will agree that compilation databases are a (mostly) necessary, but not
> sufficient part of the solution. The refactoring tool will need to be
> careful about changing t
Author: omtcyfz
Date: Wed Aug 10 13:01:45 2016
New Revision: 278254
URL: http://llvm.org/viewvc/llvm-project?rev=278254&view=rev
Log:
[clang-tidy] minor improvements in modernise-deprecated-headers check
This patch introduces a minor list of changes as proposed by Richard Smith in
the mailing lis
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278254: [clang-tidy] minor improvements in
modernise-deprecated-headers check (authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D17990?vs=67551&id=67560#toc
Repository:
rL LLVM
Author: omtcyfz
Date: Wed Aug 10 13:05:47 2016
New Revision: 278257
URL: http://llvm.org/viewvc/llvm-project?rev=278257&view=rev
Log:
[clang-tidy] enhance readability-else-after-return
`readability-else-after-return` only warns about `return` calls, but LLVM Coding
Standars stat that `throw`, `co
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278257: [clang-tidy] enhance readability-else-after-return
(authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D23265?vs=67513&id=67561#toc
Repository:
rL LLVM
https://reviews.l
Author: omtcyfz
Date: Thu Aug 11 03:18:39 2016
New Revision: 278324
URL: http://llvm.org/viewvc/llvm-project?rev=278324&view=rev
Log:
[clang-tidy] fix readability-else-after-return test
As pointed by Yung Douglas, exceptions in
test/clang-tidy/readability-else-after-return.cpp are causing PS4 bot
omtcyfz created this revision.
omtcyfz added reviewers: alexfh, klimek.
omtcyfz added a subscriber: cfe-commits.
As Alexander pointed out, LLVM Coding Standards are more conservative about
using `auto`, i.e. it should be used in the following situations:
* When the type is //obvious//, i.e. expl
omtcyfz added a subscriber: omtcyfz.
Comment at: lib/Analysis/CloneDetection.cpp:436
@@ +435,3 @@
+if (IsInMacro) {
+ Signature.Complexity = 0;
+}
Do I understand correctly that a code generated by a macro doesn't affect
"complexity" at all then?
``
omtcyfz added inline comments.
Comment at: lib/Analysis/CloneDetection.cpp:436
@@ +435,3 @@
+if (IsInMacro) {
+ Signature.Complexity = 0;
+}
NoQ wrote:
> omtcyfz wrote:
> > Do I understand correctly that a code generated by a macro doesn't affect
> >
omtcyfz added inline comments.
Comment at: lib/Analysis/CloneDetection.cpp:436
@@ +435,3 @@
+if (IsInMacro) {
+ Signature.Complexity = 0;
+}
omtcyfz wrote:
> NoQ wrote:
> > omtcyfz wrote:
> > > Do I understand correctly that a code generated by a macr
omtcyfz added inline comments.
Comment at: lib/Analysis/CloneDetection.cpp:436
@@ +435,3 @@
+if (IsInMacro) {
+ Signature.Complexity = 0;
+}
omtcyfz wrote:
> omtcyfz wrote:
> > NoQ wrote:
> > > omtcyfz wrote:
> > > > Do I understand correctly that a c
omtcyfz updated this revision to Diff 67989.
omtcyfz marked 3 inline comments as done.
omtcyfz added a comment.
Address comments.
https://reviews.llvm.org/D23397
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFindingAction.cpp
clang-rename/USRLocFinder
omtcyf0 created this revision.
omtcyf0 added reviewers: alexfh, LegalizeAdulthood, Eugene.Zelenko, djasper.
omtcyf0 added a subscriber: cfe-commits.
This patch introduces a proof-of-concept check for clang-tidy aiming to suggest
using ternary operator in order to improve readability.
It's curren
omtcyf0 updated this revision to Diff 48231.
omtcyf0 added a comment.
Followed some suggestions Richard has kindly given me; fixed the nonsense in
SourceRanges' extracting code
http://reviews.llvm.org/D17244
Files:
clang-tidy/readability/BracesAroundStatementsCheck.cpp
clang-tidy/readabili
omtcyf0 created this revision.
omtcyf0 added reviewers: alexfh, LegalizeAdulthood, Eugene.Zelenko.
omtcyf0 added a subscriber: cfe-commits.
This patch introduces the modernize-deprecated-headers check, which is supposed
to replace deprecated C library headers with the C++ STL-ones.
For informati
omtcyf0 updated this revision to Diff 48598.
omtcyf0 added a comment.
fixed clang-tidy/modernize/DeprecatedHeaders.h head typo caused by the check
rename
http://reviews.llvm.org/D17484
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/DeprecatedHeadersCheck.cpp
clang-tidy/m
omtcyf0 updated this revision to Diff 48600.
omtcyf0 added a comment.
Thanks for a review, Eugene!
The FixItHint and warning now comes with the "angled" version of header
wrapping.
http://reviews.llvm.org/D17484
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/DeprecatedHea
omtcyf0 updated this revision to Diff 48613.
omtcyf0 added a comment.
Thanks for a review, Richard!
Fixed all the issues you pointed to!
Thanks for the hint, Eugene!
I'll try to add this functionality to this check later on.
http://reviews.llvm.org/D17484
Files:
clang-tidy/modernize/CMakeLis
omtcyf0 marked 3 inline comments as done.
omtcyf0 added a comment.
http://reviews.llvm.org/D17484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyf0 added a comment.
Thank you for a review, Alex!
I'll clean up the parts you mentioned soon!
In http://reviews.llvm.org/D17484#358617, @alexfh wrote:
> The most important question to this check is that the standard doesn't
> guarantee that the C++ headers declare all the same functions *
omtcyf0 updated this revision to Diff 48711.
omtcyf0 marked 9 inline comments as done.
omtcyf0 added a comment.
Fixed all the issues @alexfh pointed to.
http://reviews.llvm.org/D17484
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/DeprecatedHeadersCheck.cpp
clang-tidy/mod
omtcyf0 added a comment.
Marked the comments as *done*.
Comment at: test/clang-tidy/modernize-deprecated-headers-cxx03.cpp:1
@@ +1,2 @@
+// RUN: %check_clang_tidy %s modernize-deprecated-headers %t -- -- -std=c++03
-isystem %S/Inputs/Headers
+
alexfh wrote:
> Y
omtcyf0 updated this revision to Diff 48797.
omtcyf0 marked 4 inline comments as done.
omtcyf0 added a comment.
Resolved issues @alexfh pointed to.
http://reviews.llvm.org/D17484
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/DeprecatedHeadersCheck.cpp
clang-tidy/moderniz
omtcyf0 updated this revision to Diff 48799.
omtcyf0 added a comment.
changed the warning comment to be more precise; fixed line with > 80 symbols
http://reviews.llvm.org/D17484
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/DeprecatedHeadersCheck.cpp
clang-tidy/modernize
omtcyf0 updated this revision to Diff 48905.
omtcyf0 added a comment.
replaced few explicit casts to llvm::Twine with implicit ones
http://reviews.llvm.org/D17484
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/DeprecatedHeadersCheck.cpp
clang-tidy/modernize/DeprecatedHead
omtcyf0 added a comment.
In http://reviews.llvm.org/D17484#359634, @alexfh wrote:
> Looks good with one nit.
>
> Let me know if you need me to commit the patch for you.
Yes, commit please!
http://reviews.llvm.org/D17484
___
cfe-commits mailing li
omtcyf0 marked 3 inline comments as done.
omtcyf0 added a comment.
Thanks for the review!
I'll fix these issues as soon as I manage to get time for that!
http://reviews.llvm.org/D17244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
omtcyf0 created this revision.
omtcyf0 added reviewers: cfe-commits, alexfh.
Because of the recent Google Code shutdown links to the Google Code Style up
there are no longer relevant.
http://reviews.llvm.org/D17602
Files:
clang-tidy/google/AvoidCStyleCastsCheck.h
clang-tidy/google/ExplicitC
omtcyf0 added inline comments.
Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13
@@ -13,1 +12,3 @@
+https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_
+Definitions
hokein wrote:
> This should be in one line?
It is in
omtcyf0 updated this revision to Diff 49048.
omtcyf0 added a comment.
Removed the breakline.
http://reviews.llvm.org/D17602
Files:
clang-tidy/google/AvoidCStyleCastsCheck.h
clang-tidy/google/ExplicitConstructorCheck.h
clang-tidy/google/OverloadedUnaryAndCheck.h
clang-tidy/google/Unnamed
omtcyf0 added inline comments.
Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13
@@ -13,2 +12,3 @@
+https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions
All parameters should be named, with identical names in the declaratio
omtcyf0 added inline comments.
Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13
@@ -13,2 +12,3 @@
+https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions
All parameters should be named, with identical names in the declaratio
omtcyf0 added a comment.
Thank you very much, @hokein!
http://reviews.llvm.org/D17602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
501 - 600 of 696 matches
Mail list logo
