omtcyfz updated this revision to Diff 65060.
omtcyfz added a comment.
remove redundant `#include` and `using` directives
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRFindingAction.cpp
clang-r
omtcyfz updated this revision to Diff 65066.
omtcyfz added a comment.
@alexfh, or wait... It's fine, I just forgot to add few tests, sorry.
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRFindingA
omtcyfz updated this revision to Diff 65065.
omtcyfz added a comment.
@alexfh, awww, sorry, I've uploaded wrong diff last time for whatever reason...
Can you review the changes please?
Now it contains many new tests and I managed to cut off unnecessary blocks of
code.
https://reviews.llvm.org
omtcyfz added inline comments.
Comment at: test/clang-rename/ComplicatedClassType.cpp:1-6
@@ -1,6 +1,7 @@
-// Unsupported test.
// RUN: cat %s > %t.cpp
-// FIXME: This test contains very simple constructions likely to be seen in any
-// project and therefore passing this test is
Author: omtcyfz
Date: Fri Jul 22 08:41:09 2016
New Revision: 276414
URL: http://llvm.org/viewvc/llvm-project?rev=276414&view=rev
Log:
[clang-rename] introduce better symbol finding
This patch introduces:
* TypeLoc visiting, which helps a lot in renaming types
* NestedNameSpecifierLoc visiting (t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276414: [clang-rename] introduce better symbol finding
(authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D22465?vs=65066&id=65067#toc
Repository:
rL LLVM
https://reviews.llvm.
omtcyfz added a comment.
Just remove it then?
Repository:
rL LLVM
https://reviews.llvm.org/D22654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: omtcyfz
Date: Mon Jul 25 03:56:11 2016
New Revision: 276620
URL: http://llvm.org/viewvc/llvm-project?rev=276620&view=rev
Log:
[clang-rename] fix typos in tests
TemplateFunctionFindBy{Declaration|Use}.cpp contained typos and therefore were
failing. clang-rename passes these tests after typ
omtcyfz added a comment.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D22654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz added a comment.
Apart from my high level concerns, which of course I still have...
Comment at: clang-rename/tool/clang-rename.py:43
@@ -42,2 +42,3 @@
command = [binary,
+ "rename-at",
filename,
`rename-at` isn't necess
omtcyfz created this revision.
omtcyfz added reviewers: alexfh, klimek.
omtcyfz added a subscriber: cfe-commits.
Few simple tweaks allow template parameters to be renamed. See
TemplateTypenameFindBy{TemplateParam|TypeInside}.cpp for example how it works.
https://reviews.llvm.org/D22853
Files:
omtcyfz created this revision.
omtcyfz added reviewers: alexfh, klimek, ioeric.
omtcyfz added a subscriber: cfe-commits.
Change Vim key binding for include-fixer (`,cf` -> `cf`) and
clang-rename (`,cr` -> `cr`) to use `` instead of `,` like cool
Vim people (tm) do.
https://reviews.llvm.org/D228
omtcyfz updated this revision to Diff 65714.
omtcyfz added a comment.
add refernce to what `` is
https://reviews.llvm.org/D22854
Files:
clang-rename/tool/clang-rename.py
docs/clang-rename.rst
docs/include-fixer.rst
include-fixer/tool/clang-include-fixer.py
Index: include-fixer/tool/cla
omtcyfz added a comment.
In https://reviews.llvm.org/D22854#497496, @vmiklos wrote:
> `:help leader` explains it. Or see this link:
> http://learnvimscriptthehardway.stevelosh.com/chapters/06.html#leader. The
> later describes 3 arguments for using `` instead of `,` directly.
I think the poin
Author: omtcyfz
Date: Wed Jul 27 08:37:22 2016
New Revision: 276866
URL: http://llvm.org/viewvc/llvm-project?rev=276866&view=rev
Log:
[clang-rename] skip CXXConversionDecl while searching for NamedDecl
Modified:
clang-tools-extra/trunk/clang-rename/USRFinder.cpp
clang-tools-extra/trunk/te
omtcyfz added a comment.
Any other comments?
https://reviews.llvm.org/D22854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz added inline comments.
Comment at: docs/clang-rename.rst:101
@@ +100,3 @@
+[``
key``](http://vim.wikia.com/wiki/Mapping_keys_in_Vim_-_Tutorial_(Part_3)#Map_leader)
+is a reference to a specific key defined by the mapleader variable and is
binded
+to backslash by default.
omtcyfz updated this revision to Diff 65739.
omtcyfz marked an inline comment as done.
https://reviews.llvm.org/D22854
Files:
clang-rename/tool/clang-rename.py
docs/clang-rename.rst
docs/include-fixer.rst
include-fixer/tool/clang-include-fixer.py
Index: include-fixer/tool/clang-include-f
Author: omtcyfz
Date: Wed Jul 27 09:23:47 2016
New Revision: 276870
URL: http://llvm.org/viewvc/llvm-project?rev=276870&view=rev
Log:
change Vim key binding for include-fixer and clang-rename
Change Vim key binding for include-fixer (`,cf` -> `cf`) and
clang-rename (`,cr` -> `cr`) to use `` inste
omtcyfz added inline comments.
Comment at: docs/clang-rename.rst:101
@@ +100,3 @@
+[``
key``](http://vim.wikia.com/wiki/Mapping_keys_in_Vim_-_Tutorial_(Part_3)#Map_leader)
+is a reference to a specific key defined by the mapleader variable and is
binded
+to backslash by default.
Author: omtcyfz
Date: Wed Jul 27 09:26:03 2016
New Revision: 276871
URL: http://llvm.org/viewvc/llvm-project?rev=276871&view=rev
Log:
fix typo in clang-rename and clang-tidy docs
Modified:
clang-tools-extra/trunk/docs/clang-rename.rst
clang-tools-extra/trunk/docs/include-fixer.rst
Modifi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276870: change Vim key binding for include-fixer and
clang-rename (authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D22854?vs=65739&id=65741#toc
Repository:
rL LLVM
https://re
omtcyfz added a comment.
Well, in this case `SourceMgr` should be removed...
Please accept patches so fast; at least let the others take a look at it.
https://reviews.llvm.org/D22881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
omtcyfz added a comment.
*please don't accept patches so fast
https://reviews.llvm.org/D22881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz added a comment.
if (auto *RD = Loc.getType()->getAsCXXRecordDecl())
return setResult(RD, TypeBeginLoc, TypeEndLoc);
This isn't needed, too...
https://reviews.llvm.org/D22881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
omtcyfz added a comment.
In https://reviews.llvm.org/D22881#498911, @alexshap wrote:
> inside setResult Decl->getQualifiedNameAsString() is used
> so RD should not be nullptr there.
> we get there in the newly added test.
It is used, but then we should add this check to setResult, don't we?
omtcyfz added a comment.
In https://reviews.llvm.org/D22881#498919, @alexshap wrote:
> i took a look at handleNestedNameSpecifierLoc:
>
> const auto *Decl = NameLoc.getNestedNameSpecifier()->getAsNamespace();
> if (Decl) {
>setResult(Decl, NameLoc.getLocalBeginLoc(), NameLoc.getLocalEndLo
Author: omtcyfz
Date: Thu Jul 28 04:05:06 2016
New Revision: 276967
URL: http://llvm.org/viewvc/llvm-project?rev=276967&view=rev
Log:
[clang-rename] USRFinder.cpp cleanup
Modified:
clang-tools-extra/trunk/clang-rename/USRFinder.cpp
Modified: clang-tools-extra/trunk/clang-rename/USRFinder.cpp
omtcyfz added a comment.
Fixed in https://reviews.llvm.org/rL276967
https://reviews.llvm.org/D22906
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: omtcyfz
Date: Thu Jul 28 05:31:16 2016
New Revision: 276971
URL: http://llvm.org/viewvc/llvm-project?rev=276971&view=rev
Log:
[clang-rename] remove redundant *_cast<> traversal
Modified:
clang-tools-extra/trunk/clang-rename/USRLocFinder.cpp
Modified: clang-tools-extra/trunk/clang-ren
omtcyfz added a subscriber: Eugene.Zelenko.
omtcyfz added a comment.
1. Run `clang-format` or something, 80 char width limit is broken in
`tool/ClangRename.cpp` dozen of times.
2. Only do `outs() << "abcd\n" << "efgh\n"` if you have something in between,
which can not be predefined. I.e. if you
omtcyfz added a comment.
Ping. Change is quite trivial.
https://reviews.llvm.org/D22853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz updated this revision to Diff 66095.
omtcyfz added a comment.
git rebase; git resolve conflicts
https://reviews.llvm.org/D22853
Files:
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/TemplateTypenameFindByTemplateParam.cpp
test/clang-rename/TemplateTyp
omtcyfz added a comment.
In https://reviews.llvm.org/D21814#500481, @vmiklos wrote:
> > 1. Run `clang-format` or something, 80 char width limit is broken in
> > `tool/ClangRename.cpp` dozen of times.
>
>
> Done. I was afraid doing that, due to the changes not related to my patch, but
> the resu
omtcyfz added a comment.
besides, let me push one thing; it's about passing a vector of USRs to the
USRLocFinder instead of passing them 1 by 1; removes a need to write that
`FIXME` of yours :)
https://reviews.llvm.org/D21814
___
cfe-commits maili
omtcyfz added a comment.
Hm, nevermind, I should check whether it doesn't break anything.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: omtcyfz
Date: Fri Jul 29 05:16:45 2016
New Revision: 277131
URL: http://llvm.org/viewvc/llvm-project?rev=277131&view=rev
Log:
[clang-rename] speedup RenamingAction
The complexity of renaming a USR is O(N) [N stands for number of nodes in
Translation Unit]. In some cases there are more tha
omtcyfz added a comment.
Apparently it doesn't. Pushed to upstream.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz added a comment.
In https://reviews.llvm.org/D21814#500506, @vmiklos wrote:
> Rebased on top of r277131 and resolved conflicts.
>
> > As for help message, look at clang-tidy. Is there a need in helpMain?
>
>
> I think so; we have this chicken-and-egg problem (see earlier comments of this
omtcyfz added a comment.
P.S. not sure whether we have to write `clang-rename: for the -new-name option:
must be specified` out. We already launched `clang-rename` what else could've
give us an error?
https://reviews.llvm.org/D21814
___
cfe-commit
omtcyfz added a comment.
In https://reviews.llvm.org/D21814#500629, @vmiklos wrote:
> In https://reviews.llvm.org/D21814#500621, @omtcyfz wrote:
>
> > P.S. not sure whether we have to write `clang-rename: for the -new-name
> > option: must be specified` out. We already launched `clang-rename` wh
omtcyfz added a comment.
In https://reviews.llvm.org/D21814#500735, @vmiklos wrote:
> Yes, exactly, so not easy to customize I guess.
Aha, alright. Well, doesn't matter too much.
LGTM.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
omtcyfz created this revision.
omtcyfz added reviewers: bkramer, alexfh, klimek.
omtcyfz added a subscriber: cfe-commits.
This patch aims to add very basic Emacs integration. My experience with Emacs
is limited to few days, so I'm not sure whether I've done things correctly.
https://reviews.llvm
omtcyfz updated this revision to Diff 66292.
omtcyfz added a comment.
Update docs by adding information about Emacs integration.
https://reviews.llvm.org/D23006
Files:
clang-rename/tool/clang-rename.el
docs/clang-rename.rst
Index: docs/clang-rename.rst
=
omtcyfz added inline comments.
Comment at: clang-rename/tool/clang-rename.el:7
@@ +6,3 @@
+
+;; This package allows to filter code through clang-format to fix its
formatting.
+;; clang-format is a tool that formats C/C++/Obj-C code according to a set of
klimek wr
omtcyfz updated this revision to Diff 66296.
omtcyfz marked 2 inline comments as done.
https://reviews.llvm.org/D23006
Files:
clang-rename/tool/clang-rename.el
docs/clang-rename.rst
Index: docs/clang-rename.rst
===
--- docs/clan
omtcyfz created this revision.
omtcyfz added reviewers: alexfh, klimek.
omtcyfz added a subscriber: cfe-commits.
1. Renaming overridden functions only works for two levels of "overriding
hierarchy". `clang-rename` should recursively add overridden methods.
2. Make use of `forEachOverridden` AST M
omtcyfz added a comment.
Manuel, any other comments? Jens seems to be missing and I don't know about
anyone else who is familiar with Emacs :(
https://reviews.llvm.org/D23006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
Author: omtcyfz
Date: Mon Aug 1 07:06:18 2016
New Revision: 277340
URL: http://llvm.org/viewvc/llvm-project?rev=277340&view=rev
Log:
[clang-tidy] remove trailing whitespaces and retab
Modified:
clang-tools-extra/trunk/clang-tidy/cert/LICENSE.TXT
clang-tools-extra/trunk/clang-tidy/cert/St
omtcyfz added inline comments.
Comment at: clang-rename/tool/clang-rename.el:20
@@ +19,3 @@
+ "Rename all instances of the symbol at the point using clang-rename"
+ (interactive "sEnter a new name: ")
+ (let (;; Emacs offset is 1-based.
hokein wrote:
> `s` is a
omtcyfz updated this revision to Diff 66328.
omtcyfz marked 8 inline comments as done.
https://reviews.llvm.org/D23006
Files:
clang-rename/tool/clang-rename.el
docs/clang-rename.rst
Index: docs/clang-rename.rst
===
--- docs/clan
omtcyfz added a comment.
All the comments seem to be addressed.
https://reviews.llvm.org/D23006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: omtcyfz
Date: Mon Aug 1 11:48:33 2016
New Revision: 277354
URL: http://llvm.org/viewvc/llvm-project?rev=277354&view=rev
Log:
[clang-rename] revert r276836
Revert r276836, which resulted in tests passing regardless of the actual tool
replacements.
Modified:
clang-tools-extra/trunk/
omtcyfz updated this revision to Diff 66338.
omtcyfz marked an inline comment as done.
https://reviews.llvm.org/D23009
Files:
clang-rename/USRFindingAction.cpp
test/clang-rename/FunctionOverride.cpp
Index: test/clang-rename/FunctionOverride.cpp
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277356: [clang-rename] handle overridden functions correctly
(authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D23009?vs=66338&id=66340#toc
Repository:
rL LLVM
https://reviews
omtcyfz updated this revision to Diff 66341.
https://reviews.llvm.org/D23006
Files:
clang-rename/tool/clang-rename.el
docs/clang-rename.rst
Index: docs/clang-rename.rst
===
--- docs/clang-rename.rst
+++ docs/clang-rename.rst
@@
omtcyfz marked 2 inline comments as done.
Comment at: clang-rename/tool/clang-rename.el:28
@@ +27,3 @@
+(orig-buf (current-buffer))
+(file-name (buffer-file-name)))
+
alexfh wrote:
> For posterity, please add a short summary of the offline discussi
Author: omtcyfz
Date: Mon Aug 1 12:15:57 2016
New Revision: 277356
URL: http://llvm.org/viewvc/llvm-project?rev=277356&view=rev
Log:
[clang-rename] handle overridden functions correctly
1. Renaming overridden functions only works for two levels of "overriding
hierarchy". clang-rename should r
omtcyfz added inline comments.
Comment at: clang-rename/USRFinder.cpp:80
@@ -79,1 +79,3 @@
TypeBeginLoc, 0, Context.getSourceManager(), Context.getLangOpts());
+if (const auto *TemplateTypeParm =
dyn_cast(Loc.getType())) {
+ return setResult(TemplateTypeParm->ge
omtcyfz updated this revision to Diff 66372.
omtcyfz added a comment.
Addressed comments; updated to the latest revision.
https://reviews.llvm.org/D22853
Files:
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/TemplateTypenameFindByTemplateParam.cpp
test/clang-
omtcyfz updated this revision to Diff 66373.
omtcyfz added a comment.
Apply `clang-format` to fit 80 cols limit.
https://reviews.llvm.org/D22853
Files:
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/TemplateTypenameFindByTemplateParam.cpp
test/clang-rename/Te
omtcyfz marked 3 inline comments as done.
omtcyfz added a comment.
https://reviews.llvm.org/D22853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
https://reviews.llvm.org/D23006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz updated this revision to Diff 66434.
https://reviews.llvm.org/D23006
Files:
clang-rename/tool/CMakeLists.txt
clang-rename/tool/clang-rename.el
docs/clang-rename.rst
Index: docs/clang-rename.rst
===
--- docs/clang-renam
omtcyfz added a comment.
In https://reviews.llvm.org/D23006#502814, @Eugene.Zelenko wrote:
> Please add install rule for clang-rename.el. See clang-format CMakeLists.txt
> as example.
Good point! Thank you!
Done.
https://reviews.llvm.org/D23006
___
omtcyfz updated this revision to Diff 66437.
omtcyfz added a comment.
- s/print/type
- Add `clang-rename.py` to the `CMakeLists.txt` installation instructions.
https://reviews.llvm.org/D23006
Files:
clang-rename/tool/CMakeLists.txt
clang-rename/tool/clang-rename.el
docs/clang-rename.rst
omtcyfz marked 2 inline comments as done.
omtcyfz added a comment.
Thanks! Fixed.
Waiting few more hours just in case anyone will jump in and write few comments.
https://reviews.llvm.org/D23006
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Author: omtcyfz
Date: Tue Aug 2 03:51:26 2016
New Revision: 277433
URL: http://llvm.org/viewvc/llvm-project?rev=277433&view=rev
Log:
[clang-rename] add basic Emacs integration
This patch aims to add very basic Emacs integration.
Reviewers: hokein, alexfh
Differential Revision: https://reviews.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277433: [clang-rename] add basic Emacs integration (authored
by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D23006?vs=66437&id=66442#toc
Repository:
rL LLVM
https://reviews.llvm.org/
omtcyfz added a comment.
//Make sure to rebase once more; documentation was updated in the last
revision.//
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: omtcyfz
Date: Tue Aug 2 04:38:38 2016
New Revision: 277437
URL: http://llvm.org/viewvc/llvm-project?rev=277437&view=rev
Log:
[clang-rename] add support for template parameter renaming
Few simple tweaks allow template parameters to be renamed. See
TemplateTypenameFindBy{TemplateParam|Type
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277437: [clang-rename] add support for template parameter
renaming (authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D22853?vs=66373&id=66446#toc
Repository:
rL LLVM
https://r
omtcyfz created this revision.
omtcyfz added reviewers: alexfh, klimek.
omtcyfz added a subscriber: cfe-commits.
This patch introduces basic capabilities of renaming templated class and its
specializations.
https://reviews.llvm.org/D23058
Files:
clang-rename/USRFinder.cpp
clang-rename/USRFi
Author: omtcyfz
Date: Tue Aug 2 10:10:17 2016
New Revision: 277469
URL: http://llvm.org/viewvc/llvm-project?rev=277469&view=rev
Log:
[clang-rename] fix Emacs script build failure
Clang-rename Emacs integration script sometimes doesn't work correctly.
Modified:
clang-tools-extra/trunk/clang
Author: omtcyfz
Date: Tue Aug 2 13:23:08 2016
New Revision: 277491
URL: http://llvm.org/viewvc/llvm-project?rev=277491&view=rev
Log:
[clang-rename] fix Emacs integration script
Modified:
clang-tools-extra/trunk/clang-rename/tool/clang-rename.el
Modified: clang-tools-extra/trunk/clang-rename
Author: omtcyfz
Date: Wed Aug 3 01:54:24 2016
New Revision: 277577
URL: http://llvm.org/viewvc/llvm-project?rev=277577&view=rev
Log:
[clang-tidy] address concerns with rL277340
alexfh raised a concern with https://reviews.llvm.org/rL277340
After retabbing indentation of .. code-block:: was incr
omtcyfz added inline comments.
Comment at:
test/clang-rename/TemplateClassInstantiationFindByUninstantiatedType.cpp:2
@@ +1,3 @@
+// RUN: cat %s > %t.cpp
+// RUN: clang-rename -offset=440 -new-name=Bar %t.cpp -i --
+// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s
al
omtcyfz added inline comments.
Comment at: test/clang-rename/TemplateClassInstantiationFindByDeclaration.cpp:2
@@ -1,3 +1,3 @@
// RUN: cat %s > %t.cpp
-// RUN: clang-rename -offset=287 -new-name=Bar %t.cpp -i --
+// RUN: clang-rename -offset=159 -new-name=Bar %t.cpp -i --
// RUN
omtcyfz updated this revision to Diff 66634.
https://reviews.llvm.org/D23058
Files:
clang-rename/USRFinder.cpp
clang-rename/USRFindingAction.cpp
test/clang-rename/ComplexFunctionOverride.cpp
test/clang-rename/TemplateClassInstantiationFindByDeclaration.cpp
test/clang-rename/TemplateClas
omtcyfz updated this revision to Diff 66642.
omtcyfz added a comment.
Removed `dump()` call used for debugging purposes.
Removed unneeded header inclusion in `USRFindingAction.cpp`.
https://reviews.llvm.org/D23058
Files:
clang-rename/USRFinder.cpp
clang-rename/USRFindingAction.cpp
test/cl
omtcyfz updated this revision to Diff 66670.
omtcyfz added a comment.
Merged multiple identical tests into a single test with multiple `clang-rename`
invocations.
https://reviews.llvm.org/D23058
Files:
clang-rename/USRFinder.cpp
clang-rename/USRFindingAction.cpp
test/clang-rename/Complex
omtcyfz marked 2 inline comments as done.
Comment at:
test/clang-rename/TemplateClassInstantiationFindByUninstantiatedType.cpp:3
@@ +2,3 @@
+// RUN: clang-rename -offset=440 -new-name=Bar %t.cpp -i --
+// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s
+
alexfh wrote:
Author: omtcyfz
Date: Wed Aug 3 13:15:07 2016
New Revision: 277623
URL: http://llvm.org/viewvc/llvm-project?rev=277623&view=rev
Log:
[docs] fix typo in clang-rename docs
clang-rename is a refactoring tool, not "linter" tool. Fix typo in docs.
Modified:
clang-tools-extra/trunk/docs/clang-ren
Author: omtcyfz
Date: Wed Aug 3 18:00:32 2016
New Revision: 277663
URL: http://llvm.org/viewvc/llvm-project?rev=277663&view=rev
Log:
[clang-rename] improve USRFindingAction
1. Improve templated class renaming, namely add capabilities of finding partial
and full specializations. Every class parti
This revision was automatically updated to reflect the committed changes.
omtcyfz marked an inline comment as done.
Closed by commit rL277663: [clang-rename] improve USRFindingAction (authored by
omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D23058?vs=66670&id=66728#toc
Repositor
omtcyfz created this revision.
omtcyfz added reviewers: alexfh, klimek.
omtcyfz added a subscriber: cfe-commits.
The only difference between some tests is `-offset` passed to `clang-rename`.
It makes sense to merge them into a single file and add multiple tool
invocations.
https://reviews.llvm.
Author: omtcyfz
Date: Thu Aug 4 04:23:30 2016
New Revision: 277709
URL: http://llvm.org/viewvc/llvm-project?rev=277709&view=rev
Log:
[clang-rename] add missing clang-format improvements
r277702 introduced clang-format changes so that later commits wouldn't introduce
non-functional changes while
omtcyfz added a comment.
Actually few changes `clang-format` would produce weren't there. It's either
you used old `clang-format` or you missed them, but there were header
reordering issues. Pushed quick fix.
Repository:
rL LLVM
https://reviews.llvm.org/D23153
___
omtcyfz updated this revision to Diff 66801.
omtcyfz marked an inline comment as done.
https://reviews.llvm.org/D23158
Files:
clang-rename/USRFindingAction.cpp
clang-rename/tool/ClangRename.cpp
test/clang-rename/ClassAsTemplateArgument.cpp
test/clang-rename/ClassAsTemplateArgumentFindByCl
omtcyfz updated this revision to Diff 66803.
omtcyfz added a comment.
Rebased on master. Removed unneeded file copying etc since clang-rename can
output to the stdout.
https://reviews.llvm.org/D23158
Files:
test/clang-rename/ClassAsTemplateArgument.cpp
test/clang-rename/ClassAsTemplateArgu
omtcyfz updated this revision to Diff 66818.
omtcyfz added a comment.
Make testset great again.
https://reviews.llvm.org/D23158
Files:
test/clang-rename/ClassAsTemplateArgument.cpp
test/clang-rename/ClassAsTemplateArgumentFindByClass.cpp
test/clang-rename/ClassAsTemplateArgumentFindByTemp
omtcyfz created this revision.
omtcyfz added a reviewer: alexfh.
omtcyfz added a subscriber: cfe-commits.
`clang-rename` is currently not able to find a symbol in initializer list. This
patch is a fix of that bug.
https://reviews.llvm.org/D23193
Files:
clang-rename/USRFinder.cpp
clang-renam
omtcyfz added a comment.
Still don't see general use case for that one, but since we already support
multiple renamings "at once"...
Would also be nice to support at least `offset + new-name` in YAML input files,
too.
Comment at: clang-rename/tool/ClangRename.cpp:140
@@ -116,
omtcyfz added inline comments.
Comment at: clang-rename/tool/ClangRename.cpp:140
@@ -116,1 +139,3 @@
cl::value_desc("filename"), cl::cat(*Category));
+ cl::opt Input(
+ "input", cl::desc("YAML file to load oldname-newname pairs from."),
vmiklos wrote:
omtcyfz added a comment.
`.cpp.rename-at.yaml`? I understand it's done for the purpose of doing `-input
%s.rename-at.yaml`, though I don't think getting proper names for them and
either doing some string magic in tool invocation or just passing full name is
wrong.
Other than that my concerns s
omtcyfz added a comment.
+ I'll take a look again on Monday, too. May be too sleepy now :)
https://reviews.llvm.org/D23198
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz created this revision.
omtcyfz added reviewers: alexfh, Eugene.Zelenko.
omtcyfz added a subscriber: cfe-commits.
Fixing bug https://llvm.org/bugs/show_bug.cgi?id=28854.
Implicit cast with ternary operator makes AST look in a way in which it feels
reasonable to add second matcher to detec
omtcyfz removed rL LLVM as the repository for this revision.
omtcyfz updated this revision to Diff 67095.
omtcyfz added a comment.
Comment `anyOf()` part in check's matcher and extend testset.
https://reviews.llvm.org/D23243
Files:
clang-tidy/modernize/UseBoolLiteralsCheck.cpp
test/clang-ti
omtcyfz marked 2 inline comments as done.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:38-43
@@ +37,8 @@
+ unless(isInTemplateInstantiation(,
+ anyOf(hasTrueExpression(ignoringParenImpCasts(
+integerLiteral().bind("trueBra
omtcyfz marked 2 inline comments as done.
omtcyfz added a comment.
Thanks.
Yes, sure.
https://reviews.llvm.org/D23243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
401 - 500 of 696 matches
Mail list logo
