[clang-tools-extra] d26dd74 - [clangd] Separate final_result into a different message

2020-10-27 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2020-10-27T11:46:16+01:00 New Revision: d26dd743084a886382204ede5eeed146cd29fcd6 URL: https://github.com/llvm/llvm-project/commit/d26dd743084a886382204ede5eeed146cd29fcd6 DIFF: https://github.com/llvm/llvm-project/commit/d26dd743084a886382204ede5eeed146cd29fcd6.diff

[clang-tools-extra] 5ad6bba - [clangd] Start using SyntaxTrees for folding ranges feature

2020-10-27 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2020-10-27T16:47:35+01:00 New Revision: 5ad6bbacf091c90d47730bf284f4893eb1afb1ee URL: https://github.com/llvm/llvm-project/commit/5ad6bbacf091c90d47730bf284f4893eb1afb1ee DIFF: https://github.com/llvm/llvm-project/commit/5ad6bbacf091c90d47730bf284f4893eb1afb1ee.diff

[clang-tools-extra] 76a168b - [clangd] Add lit tests for remote index

2020-11-01 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2020-11-02T08:38:16+01:00 New Revision: 76a168bce01dd950852bc86effd6f379ecf78f82 URL: https://github.com/llvm/llvm-project/commit/76a168bce01dd950852bc86effd6f379ecf78f82 DIFF: https://github.com/llvm/llvm-project/commit/76a168bce01dd950852bc86effd6f379ecf78f82.diff

[clang-tools-extra] d0beda1 - [clangd] Improve remote-index test

2020-11-02 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2020-11-02T10:55:17+01:00 New Revision: d0beda1b66617cda8a1f54978fca72832496b1fb URL: https://github.com/llvm/llvm-project/commit/d0beda1b66617cda8a1f54978fca72832496b1fb DIFF: https://github.com/llvm/llvm-project/commit/d0beda1b66617cda8a1f54978fca72832496b1fb.diff

[clang] 7e5d41a - [clang] NFC: Remove else if after return

2021-01-25 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-01-25T10:58:22+01:00 New Revision: 7e5d41a68255d2a890977047be339091cc113e25 URL: https://github.com/llvm/llvm-project/commit/7e5d41a68255d2a890977047be339091cc113e25 DIFF: https://github.com/llvm/llvm-project/commit/7e5d41a68255d2a890977047be339091cc113e25.diff

[clang] c8d2ae5 - [clang] NFC: Remove else-after-return pattern from some files

2021-01-25 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-01-25T11:14:17+01:00 New Revision: c8d2ae52c15b4c886e70587cbc3f61aaa7bd6692 URL: https://github.com/llvm/llvm-project/commit/c8d2ae52c15b4c886e70587cbc3f61aaa7bd6692 DIFF: https://github.com/llvm/llvm-project/commit/c8d2ae52c15b4c886e70587cbc3f61aaa7bd6692.diff

[clang-tools-extra] 5eec9a3 - [clangd] Detect rename conflicits within enclosing scope

2021-02-04 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-02-04T09:45:42+01:00 New Revision: 5eec9a380a24bf0611c676b5da4933949c787a6b URL: https://github.com/llvm/llvm-project/commit/5eec9a380a24bf0611c676b5da4933949c787a6b DIFF: https://github.com/llvm/llvm-project/commit/5eec9a380a24bf0611c676b5da4933949c787a6b.diff

[clang-tools-extra] e8a2b7c - [clangd] Improve name conflict detection

2021-02-04 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-02-04T21:37:41+01:00 New Revision: e8a2b7c91563169b68d2a878c65deecc85ced466 URL: https://github.com/llvm/llvm-project/commit/e8a2b7c91563169b68d2a878c65deecc85ced466 DIFF: https://github.com/llvm/llvm-project/commit/e8a2b7c91563169b68d2a878c65deecc85ced466.diff

[clang-tools-extra] 0b1eff1 - [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

2021-09-27 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-09-27T17:50:53+02:00 New Revision: 0b1eff1bc5d004b1964bb9b1667e3efc034f3f62 URL: https://github.com/llvm/llvm-project/commit/0b1eff1bc5d004b1964bb9b1667e3efc034f3f62 DIFF: https://github.com/llvm/llvm-project/commit/0b1eff1bc5d004b1964bb9b1667e3efc034f3f62.diff

[clang-tools-extra] 1bcd6b5 - [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

2021-09-27 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-09-28T07:44:28+02:00 New Revision: 1bcd6b51a98263d440ff7549070060f7e7b0326a URL: https://github.com/llvm/llvm-project/commit/1bcd6b51a98263d440ff7549070060f7e7b0326a DIFF: https://github.com/llvm/llvm-project/commit/1bcd6b51a98263d440ff7549070060f7e7b0326a.diff

[clang-tools-extra] e507711 - Attempt to fix Windows builds after D110386

2021-09-27 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-09-28T08:13:01+02:00 New Revision: e50771181b7e0d96b30ee33049dc05172125b927 URL: https://github.com/llvm/llvm-project/commit/e50771181b7e0d96b30ee33049dc05172125b927 DIFF: https://github.com/llvm/llvm-project/commit/e50771181b7e0d96b30ee33049dc05172125b927.diff

[clang-tools-extra] 7394d3b - Investigate D110386 Windows failures

2021-09-28 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-09-28T09:53:01+02:00 New Revision: 7394d3ba276adeb1527428b2355a920129a2b9b1 URL: https://github.com/llvm/llvm-project/commit/7394d3ba276adeb1527428b2355a920129a2b9b1 DIFF: https://github.com/llvm/llvm-project/commit/7394d3ba276adeb1527428b2355a920129a2b9b1.diff

[clang-tools-extra] d1c6e54 - Investigate D110386 failures even further

2021-09-28 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-09-28T12:02:13+02:00 New Revision: d1c6e54930f200c40820868c086e114cee1ec693 URL: https://github.com/llvm/llvm-project/commit/d1c6e54930f200c40820868c086e114cee1ec693 DIFF: https://github.com/llvm/llvm-project/commit/d1c6e54930f200c40820868c086e114cee1ec693.diff

[clang-tools-extra] e7a5347 - Revert "[clangd] Refactor IncludeStructure: use File (unsigned) for most computations"

2021-09-28 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-09-28T13:34:42+02:00 New Revision: e7a5347b55e6050106bb61fa9a54920720806e07 URL: https://github.com/llvm/llvm-project/commit/e7a5347b55e6050106bb61fa9a54920720806e07 DIFF: https://github.com/llvm/llvm-project/commit/e7a5347b55e6050106bb61fa9a54920720806e07.diff

[clang-tools-extra] dd13f45 - [clangd] Reland D110386

2021-09-29 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-09-30T08:25:31+02:00 New Revision: dd13f45e04366cc4f648b57ec87d20a5569e27c3 URL: https://github.com/llvm/llvm-project/commit/dd13f45e04366cc4f648b57ec87d20a5569e27c3 DIFF: https://github.com/llvm/llvm-project/commit/dd13f45e04366cc4f648b57ec87d20a5569e27c3.diff

[clang-tools-extra] d084c42 - Investigate failure in rGdd13f45e04366cc4f648b57ec87d20a5569e27c3

2021-09-30 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-09-30T09:50:14+02:00 New Revision: d084c42bdfac4a5879bdabe645b14cf72f7685a7 URL: https://github.com/llvm/llvm-project/commit/d084c42bdfac4a5879bdabe645b14cf72f7685a7 DIFF: https://github.com/llvm/llvm-project/commit/d084c42bdfac4a5879bdabe645b14cf72f7685a7.diff

[clang-tools-extra] 87817bc - Fix the build after d084c42bdfac4a5879bdabe645b14cf72f7685a7

2021-09-30 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-09-30T09:53:04+02:00 New Revision: 87817bc523daba1d2bd0492144a5d6adba8a649c URL: https://github.com/llvm/llvm-project/commit/87817bc523daba1d2bd0492144a5d6adba8a649c DIFF: https://github.com/llvm/llvm-project/commit/87817bc523daba1d2bd0492144a5d6adba8a649c.diff

[clang-tools-extra] 230a6ed - Revert "[clangd] Reland D110386"

2021-09-30 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-09-30T11:37:07+02:00 New Revision: 230a6edb49c31e2c96613f5b7deefd4f4faf9a6d URL: https://github.com/llvm/llvm-project/commit/230a6edb49c31e2c96613f5b7deefd4f4faf9a6d DIFF: https://github.com/llvm/llvm-project/commit/230a6edb49c31e2c96613f5b7deefd4f4faf9a6d.diff

[clang-tools-extra] dea4807 - [clangd] Land D110386 again

2021-09-30 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-09-30T14:41:27+02:00 New Revision: dea48079b90d40f2087435b778544dffb0ab1793 URL: https://github.com/llvm/llvm-project/commit/dea48079b90d40f2087435b778544dffb0ab1793 DIFF: https://github.com/llvm/llvm-project/commit/dea48079b90d40f2087435b778544dffb0ab1793.diff

[clang-tools-extra] 38ec229 - [clangd] Update comment after dea48079b90d40f2087435b778544dffb0ab1793

2021-09-30 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-09-30T16:45:10+02:00 New Revision: 38ec2292f0c2f25062705607b92502c0f9de3678 URL: https://github.com/llvm/llvm-project/commit/38ec2292f0c2f25062705607b92502c0f9de3678 DIFF: https://github.com/llvm/llvm-project/commit/38ec2292f0c2f25062705607b92502c0f9de3678.diff

[clang-tools-extra] b06df22 - [clangd] Follow-up on rGdea48079b90d

2021-10-03 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-10-04T08:39:24+02:00 New Revision: b06df223826e7bf7da4597af30a04259975f4a6a URL: https://github.com/llvm/llvm-project/commit/b06df223826e7bf7da4597af30a04259975f4a6a DIFF: https://github.com/llvm/llvm-project/commit/b06df223826e7bf7da4597af30a04259975f4a6a.diff

Re: [PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

2021-10-05 Thread Kirill Bobyrev via cfe-commits
Ahh, sorry, I thought you meant the other one :( Apologies for confusion On Tue, Oct 5, 2021 at 9:58 AM Sam McCall via Phabricator < revi...@reviews.llvm.org> wrote: > sammccall added inline comments. > > > > Comment at: llvm/include/llvm/Support/FileSystem/UniqueID.h:17 > > +#in

[clang-tools-extra] b60428c - [clangd] Fix false positive in local rename collision detetction

2021-02-09 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-02-09T11:51:18+01:00 New Revision: b60428c7ea685e338df3369807c9b650f994554b URL: https://github.com/llvm/llvm-project/commit/b60428c7ea685e338df3369807c9b650f994554b DIFF: https://github.com/llvm/llvm-project/commit/b60428c7ea685e338df3369807c9b650f994554b.diff

[clang-tools-extra] 19db870 - [clangd] Drop template argument lists from completions followed by

2021-02-18 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-02-18T13:06:11+01:00 New Revision: 19db870a0dd1416b2d4a346e2cb17be197193a94 URL: https://github.com/llvm/llvm-project/commit/19db870a0dd1416b2d4a346e2cb17be197193a94 DIFF: https://github.com/llvm/llvm-project/commit/19db870a0dd1416b2d4a346e2cb17be197193a94.diff

[clang-tools-extra] d12000c - [clangd] Bump recommended gRPC version (1.33.2 -> 1.36.3)

2021-06-07 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-06-07T15:36:33+02:00 New Revision: d12000ca55d1cc8bc07f75457e3b4efbcd8ff657 URL: https://github.com/llvm/llvm-project/commit/d12000ca55d1cc8bc07f75457e3b4efbcd8ff657 DIFF: https://github.com/llvm/llvm-project/commit/d12000ca55d1cc8bc07f75457e3b4efbcd8ff657.diff

[clang-tools-extra] e0f2d4a - [clangd] Fix the crash in getQualification

2021-08-02 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-08-02T09:08:25+02:00 New Revision: e0f2d4af031c93b46f0920620ab6a798113b4b6e URL: https://github.com/llvm/llvm-project/commit/e0f2d4af031c93b46f0920620ab6a798113b4b6e DIFF: https://github.com/llvm/llvm-project/commit/e0f2d4af031c93b46f0920620ab6a798113b4b6e.diff

[clang-tools-extra] d1ec581 - [clangd] IncludeCleaner as a library: Find all references to symbols in the file

2021-08-18 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-08-18T10:08:35+02:00 New Revision: d1ec581ebfca9bd455ae1a467b2d4b52fc59092b URL: https://github.com/llvm/llvm-project/commit/d1ec581ebfca9bd455ae1a467b2d4b52fc59092b DIFF: https://github.com/llvm/llvm-project/commit/d1ec581ebfca9bd455ae1a467b2d4b52fc59092b.diff

[clang-tools-extra] e837ce2 - [clang-tidy] Add -line-filter to run-clang-tidy.py

2021-06-28 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-06-28T21:17:36+02:00 New Revision: e837ce2a32369b2e9e8e5d60270c072c7dd63827 URL: https://github.com/llvm/llvm-project/commit/e837ce2a32369b2e9e8e5d60270c072c7dd63827 DIFF: https://github.com/llvm/llvm-project/commit/e837ce2a32369b2e9e8e5d60270c072c7dd63827.diff

[clang-tools-extra] de8274a - [clangd] NFC: Remove outdated comment

2021-07-05 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-07-05T13:58:54+02:00 New Revision: de8274a1b912687ca7b182ce28b34b0e66b2b0e3 URL: https://github.com/llvm/llvm-project/commit/de8274a1b912687ca7b182ce28b34b0e66b2b0e3 DIFF: https://github.com/llvm/llvm-project/commit/de8274a1b912687ca7b182ce28b34b0e66b2b0e3.diff

[clang-tools-extra] c521288 - [clangd] IncludeCleaner: Don't consider the definition as usage for function forward declarations

2021-10-26 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-10-26T10:37:10+02:00 New Revision: c521288ed391bd29a37f1c444d08ae542df5341c URL: https://github.com/llvm/llvm-project/commit/c521288ed391bd29a37f1c444d08ae542df5341c DIFF: https://github.com/llvm/llvm-project/commit/c521288ed391bd29a37f1c444d08ae542df5341c.diff

[clang-tools-extra] 6d314ee - [clangd] Add a way to enable IncludeCleaner through config

2021-10-26 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-10-26T12:53:05+02:00 New Revision: 6d314ee570975610ef85e8c56659f00857b49744 URL: https://github.com/llvm/llvm-project/commit/6d314ee570975610ef85e8c56659f00857b49744 DIFF: https://github.com/llvm/llvm-project/commit/6d314ee570975610ef85e8c56659f00857b49744.diff

[clang-tools-extra] 1c2e249 - [clangd] IncludeCleaner: don't stop the traversal

2021-10-26 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-10-26T16:08:54+02:00 New Revision: 1c2e249f938c50e1b331a1f7adc83c0a381f3897 URL: https://github.com/llvm/llvm-project/commit/1c2e249f938c50e1b331a1f7adc83c0a381f3897 DIFF: https://github.com/llvm/llvm-project/commit/1c2e249f938c50e1b331a1f7adc83c0a381f3897.diff

Re: [PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

2021-10-26 Thread Kirill Bobyrev via cfe-commits
Yes, I'm aware and actively working on this one. I think I have the fix but I'm trying to run all the tests (Clang etc) to make sure it doesn't break anything else. On Tue, Oct 26, 2021 at 5:01 PM Nico Weber via Phabricator < revi...@reviews.llvm.org> wrote: > thakis added a comment. > > Follow-u

[clang] 0350672 - [clang] Do not traverse EnumDecl's type in RecursiveASTVisitor

2021-10-26 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-10-26T17:17:10+02:00 New Revision: 03506722e0c348ce52d87f7f37f024d7adec5c43 URL: https://github.com/llvm/llvm-project/commit/03506722e0c348ce52d87f7f37f024d7adec5c43 DIFF: https://github.com/llvm/llvm-project/commit/03506722e0c348ce52d87f7f37f024d7adec5c43.diff

[clang-tools-extra] e3c6090 - [clangd] IncludeCleaner: Support macros

2021-10-27 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-10-27T10:30:04+02:00 New Revision: e3c6090e597685c23e9d2aac27d45c5a35b2f9bd URL: https://github.com/llvm/llvm-project/commit/e3c6090e597685c23e9d2aac27d45c5a35b2f9bd DIFF: https://github.com/llvm/llvm-project/commit/e3c6090e597685c23e9d2aac27d45c5a35b2f9bd.diff

[clang-tools-extra] c472378 - [clangd] IncludeCleaner: Don't warn on system headers

2021-10-27 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-10-27T11:51:08+02:00 New Revision: c4723785c1902d6a53f3808fa1dabb2a97c1cc6e URL: https://github.com/llvm/llvm-project/commit/c4723785c1902d6a53f3808fa1dabb2a97c1cc6e DIFF: https://github.com/llvm/llvm-project/commit/c4723785c1902d6a53f3808fa1dabb2a97c1cc6e.diff

[clang-tools-extra] 6edc509 - [clangd] NFC: Remove single-line braces in IncludeCleaner

2021-10-27 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-10-27T13:53:30+02:00 New Revision: 6edc50971953775ab32d2bf298b4c991e8961055 URL: https://github.com/llvm/llvm-project/commit/6edc50971953775ab32d2bf298b4c991e8961055 DIFF: https://github.com/llvm/llvm-project/commit/6edc50971953775ab32d2bf298b4c991e8961055.diff

[clang-tools-extra] 22079c6 - [clangd] IncludeCleaner: Do not process locations in built-in files

2021-10-27 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-10-27T19:31:43+02:00 New Revision: 22079c61a82300a9ea89aeea58d5bf2780a296e0 URL: https://github.com/llvm/llvm-project/commit/22079c61a82300a9ea89aeea58d5bf2780a296e0 DIFF: https://github.com/llvm/llvm-project/commit/22079c61a82300a9ea89aeea58d5bf2780a296e0.diff

[clang-tools-extra] 56a8aee - [clangd] NFC: Match function signature in the header and source file

2021-10-28 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-10-28T12:13:18+02:00 New Revision: 56a8aee1000149408facdaa1825b043c08cd35ad URL: https://github.com/llvm/llvm-project/commit/56a8aee1000149408facdaa1825b043c08cd35ad DIFF: https://github.com/llvm/llvm-project/commit/56a8aee1000149408facdaa1825b043c08cd35ad.diff

[clang-tools-extra] f9201c7 - [clangd] NFC: Use more idiomatic way of checking for definition

2021-10-28 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-10-28T12:25:12+02:00 New Revision: f9201c70ad082a1c1d13b24f1c9cadab8b470e38 URL: https://github.com/llvm/llvm-project/commit/f9201c70ad082a1c1d13b24f1c9cadab8b470e38 DIFF: https://github.com/llvm/llvm-project/commit/f9201c70ad082a1c1d13b24f1c9cadab8b470e38.diff

[clang-tools-extra] 32f1029 - [clangd] Track performance of IncludeCleaner

2021-10-29 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-10-29T12:59:22+02:00 New Revision: 32f102912493db3df864cc80d5bb602962839f68 URL: https://github.com/llvm/llvm-project/commit/32f102912493db3df864cc80d5bb602962839f68 DIFF: https://github.com/llvm/llvm-project/commit/32f102912493db3df864cc80d5bb602962839f68.diff

[clang-tools-extra] f47564e - [clangd] IncludeCleaner: Skip non self-contained headers

2021-10-29 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-10-29T17:57:31+02:00 New Revision: f47564ea87a502f5fc6320ba5b57e91186751b12 URL: https://github.com/llvm/llvm-project/commit/f47564ea87a502f5fc6320ba5b57e91186751b12 DIFF: https://github.com/llvm/llvm-project/commit/f47564ea87a502f5fc6320ba5b57e91186751b12.diff

[clang-tools-extra] bff7fae - [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check.

2021-03-04 Thread Kirill Bobyrev via cfe-commits
Author: Jens Massberg Date: 2021-03-04T21:02:27+01:00 New Revision: bff7faea2034abed4535645d7c771e67c1f2bb23 URL: https://github.com/llvm/llvm-project/commit/bff7faea2034abed4535645d7c771e67c1f2bb23 DIFF: https://github.com/llvm/llvm-project/commit/bff7faea2034abed4535645d7c771e67c1f2bb23.diff

[clang-tools-extra] 8080ea4 - [clangd] Enable reflection for clangd-index-server

2021-03-10 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-03-10T09:07:39+01:00 New Revision: 8080ea4c4b8c456c72c617587cc32f174b3105c1 URL: https://github.com/llvm/llvm-project/commit/8080ea4c4b8c456c72c617587cc32f174b3105c1 DIFF: https://github.com/llvm/llvm-project/commit/8080ea4c4b8c456c72c617587cc32f174b3105c1.diff

[clang-tools-extra] 9bcf0ef - [clangd] Optionally add reflection for clangd-index-server

2021-03-15 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-03-15T21:07:25+01:00 New Revision: 9bcf0eff99a01094c685ff375a42e3f5a9166094 URL: https://github.com/llvm/llvm-project/commit/9bcf0eff99a01094c685ff375a42e3f5a9166094 DIFF: https://github.com/llvm/llvm-project/commit/9bcf0eff99a01094c685ff375a42e3f5a9166094.diff

[clang] da168dd - [clang] Allow clang-check to customize analyzer output file or dir name

2021-11-15 Thread Kirill Bobyrev via cfe-commits
Author: Ella Ma Date: 2021-11-15T16:49:41+01:00 New Revision: da168dd875bf0392e8e88834009d776bfbaae376 URL: https://github.com/llvm/llvm-project/commit/da168dd875bf0392e8e88834009d776bfbaae376 DIFF: https://github.com/llvm/llvm-project/commit/da168dd875bf0392e8e88834009d776bfbaae376.diff LOG:

[clang-tools-extra] 85e03cb - [clang-tidy] fix debug-only test failure

2021-11-19 Thread Kirill Bobyrev via cfe-commits
Author: Matt Beardsley Date: 2021-11-19T10:19:07+01:00 New Revision: 85e03cb7ebac50a13a9a9ac92a0b184a3bba9be1 URL: https://github.com/llvm/llvm-project/commit/85e03cb7ebac50a13a9a9ac92a0b184a3bba9be1 DIFF: https://github.com/llvm/llvm-project/commit/85e03cb7ebac50a13a9a9ac92a0b184a3bba9be1.diff

[clang-tools-extra] b5f2037 - [clangd] IncludeCleaner: Mark possible expr resolutions as used

2021-11-22 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-11-22T10:44:24+01:00 New Revision: b5f20372a82f72f03d47181b87fb55f62772324f URL: https://github.com/llvm/llvm-project/commit/b5f20372a82f72f03d47181b87fb55f62772324f DIFF: https://github.com/llvm/llvm-project/commit/b5f20372a82f72f03d47181b87fb55f62772324f.diff

[clang-tools-extra] 59e4a67 - [clangd] Move IncludeCleaner tracer to the actual computation

2021-11-25 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-11-25T13:19:01+01:00 New Revision: 59e4a6708152b42a55653bd8a44a6e0781fd4caf URL: https://github.com/llvm/llvm-project/commit/59e4a6708152b42a55653bd8a44a6e0781fd4caf DIFF: https://github.com/llvm/llvm-project/commit/59e4a6708152b42a55653bd8a44a6e0781fd4caf.diff

[clang] bad8977 - [clang] Change ordering of PreableCallbacks to make sure PP can be referenced in them

2021-11-26 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-11-26T10:10:52+01:00 New Revision: bad8977786382739256f4bd966fb4cdcfd50be2a URL: https://github.com/llvm/llvm-project/commit/bad8977786382739256f4bd966fb4cdcfd50be2a DIFF: https://github.com/llvm/llvm-project/commit/bad8977786382739256f4bd966fb4cdcfd50be2a.diff

[clang-tools-extra] cd0ca5a - [clangd] Record information about non self-contained headers in IncludeStructure

2021-11-26 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-11-26T14:12:54+01:00 New Revision: cd0ca5a0eaa1b75b445e82753ea093bbb8e7e85c URL: https://github.com/llvm/llvm-project/commit/cd0ca5a0eaa1b75b445e82753ea093bbb8e7e85c DIFF: https://github.com/llvm/llvm-project/commit/cd0ca5a0eaa1b75b445e82753ea093bbb8e7e85c.diff

[clang-tools-extra] 34cc210 - [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

2021-11-26 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-11-26T16:20:48+01:00 New Revision: 34cc210aa8af2fd33598e5559d0f5b51f9423dd6 URL: https://github.com/llvm/llvm-project/commit/34cc210aa8af2fd33598e5559d0f5b51f9423dd6 DIFF: https://github.com/llvm/llvm-project/commit/34cc210aa8af2fd33598e5559d0f5b51f9423dd6.diff

[clang-tools-extra] d3a4ef3 - [clangd] IncludeClenaer: Don't mark forward declarations of a class if it's declared in the main file

2021-12-02 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-12-02T10:26:08+01:00 New Revision: d3a4ef35685c6aaad74294b678e77e1b75af1918 URL: https://github.com/llvm/llvm-project/commit/d3a4ef35685c6aaad74294b678e77e1b75af1918 DIFF: https://github.com/llvm/llvm-project/commit/d3a4ef35685c6aaad74294b678e77e1b75af1918.diff

[clang-tools-extra] bab7a30 - [clangd] IncludeCleaner: Do not require forward declarations of RecordDecls when definition is available

2021-12-03 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-12-03T09:36:50+01:00 New Revision: bab7a30ab692059e5e9dc867a59b9ead47efd35c URL: https://github.com/llvm/llvm-project/commit/bab7a30ab692059e5e9dc867a59b9ead47efd35c DIFF: https://github.com/llvm/llvm-project/commit/bab7a30ab692059e5e9dc867a59b9ead47efd35c.diff

[clang-tools-extra] db3d64e - [clangd-vscode] NFC; Improve wording in documentation and update VSCode tasks

2020-04-01 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2020-04-01T14:16:55+02:00 New Revision: db3d64eebbe0aad87631c6fada01b06753377a44 URL: https://github.com/llvm/llvm-project/commit/db3d64eebbe0aad87631c6fada01b06753377a44 DIFF: https://github.com/llvm/llvm-project/commit/db3d64eebbe0aad87631c6fada01b06753377a44.diff

[clang-tools-extra] 2a095ff - [clangd] Add add commit characters to the server capabilities

2020-02-18 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2020-02-19T08:32:00+01:00 New Revision: 2a095ff6f5028b7612dae50358a2f6939b6cdc9f URL: https://github.com/llvm/llvm-project/commit/2a095ff6f5028b7612dae50358a2f6939b6cdc9f DIFF: https://github.com/llvm/llvm-project/commit/2a095ff6f5028b7612dae50358a2f6939b6cdc9f.diff

[clang-tools-extra] 4921e79 - Fix build after D74606

2020-02-19 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2020-02-19T09:19:15+01:00 New Revision: 4921e7919223a785081a13c8a08063e91bae0db8 URL: https://github.com/llvm/llvm-project/commit/4921e7919223a785081a13c8a08063e91bae0db8 DIFF: https://github.com/llvm/llvm-project/commit/4921e7919223a785081a13c8a08063e91bae0db8.diff

[clang] 6e34a9a - [OpenMP] Fix the test by generating output file in temporary directory

2020-02-26 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2020-02-26T14:07:13+01:00 New Revision: 6e34a9a838c150b968b05b76d545969d1ddeee90 URL: https://github.com/llvm/llvm-project/commit/6e34a9a838c150b968b05b76d545969d1ddeee90 DIFF: https://github.com/llvm/llvm-project/commit/6e34a9a838c150b968b05b76d545969d1ddeee90.diff

[clang] 4569b3a - Revert "Devirtualize a call on alloca without waiting for post inline cleanup and next"

2020-02-27 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2020-02-27T15:58:39+01:00 New Revision: 4569b3a86f8a4b1b8ad28fe2321f936f9d7ffd43 URL: https://github.com/llvm/llvm-project/commit/4569b3a86f8a4b1b8ad28fe2321f936f9d7ffd43 DIFF: https://github.com/llvm/llvm-project/commit/4569b3a86f8a4b1b8ad28fe2321f936f9d7ffd43.diff

Re: [clang] 4569b3a - Revert "Devirtualize a call on alloca without waiting for post inline cleanup and next"

2020-02-27 Thread Kirill Bobyrev via cfe-commits
I've messaged the author internally and pointed to the failing targets. On Thu, Feb 27, 2020 at 4:04 PM Roman Lebedev wrote: > Is there a reproducer in progress? > > On Thu, Feb 27, 2020 at 5:59 PM Kirill Bobyrev via cfe-commits > wrote: > > > > > > Autho

[clang-tools-extra] 7f0dcf6 - [clangd] Show lambda signature for lambda autocompletions

2019-11-22 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2019-11-22T12:48:06+01:00 New Revision: 7f0dcf665dd22be296805bc7a1c71a36243c4e09 URL: https://github.com/llvm/llvm-project/commit/7f0dcf665dd22be296805bc7a1c71a36243c4e09 DIFF: https://github.com/llvm/llvm-project/commit/7f0dcf665dd22be296805bc7a1c71a36243c4e09.diff

[clang-tools-extra] c547c22 - [NFC] ASSERT_EQ before accessing items in containers

2019-11-26 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2019-11-26T13:45:04+01:00 New Revision: c547c22f18973dceaf5b40dae1b4ad7d3dd4eab7 URL: https://github.com/llvm/llvm-project/commit/c547c22f18973dceaf5b40dae1b4ad7d3dd4eab7 DIFF: https://github.com/llvm/llvm-project/commit/c547c22f18973dceaf5b40dae1b4ad7d3dd4eab7.diff

[clang-tools-extra] 9091f06 - [NFC] Slightly improve wording in the comments

2019-12-03 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2019-12-03T10:12:17+01:00 New Revision: 9091f06994f09fceb079aa01e0fa3e1ea5c9e9f0 URL: https://github.com/llvm/llvm-project/commit/9091f06994f09fceb079aa01e0fa3e1ea5c9e9f0 DIFF: https://github.com/llvm/llvm-project/commit/9091f06994f09fceb079aa01e0fa3e1ea5c9e9f0.diff

[clang-tools-extra] ec61882 - [clangd] Rename constructors and destructors in cross-file case

2019-12-12 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2019-12-12T13:10:59+01:00 New Revision: ec618826dfb91c5413353ebcc54f360e43df10a0 URL: https://github.com/llvm/llvm-project/commit/ec618826dfb91c5413353ebcc54f360e43df10a0 DIFF: https://github.com/llvm/llvm-project/commit/ec618826dfb91c5413353ebcc54f360e43df10a0.diff

[clang-tools-extra] 3b9715c - [NFC] Fix typos in Clangd and Clang

2019-12-16 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2019-12-16T10:54:40+01:00 New Revision: 3b9715cb219352fb831af144fd68e14e8fd275b4 URL: https://github.com/llvm/llvm-project/commit/3b9715cb219352fb831af144fd68e14e8fd275b4 DIFF: https://github.com/llvm/llvm-project/commit/3b9715cb219352fb831af144fd68e14e8fd275b4.diff

[clang-tools-extra] a6860c1 - [clangd] Add a flag for spelled references in the Index

2020-02-05 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2020-02-06T08:18:14+01:00 New Revision: a6860c1af45776e349eaed3e8f0bb7e97abccd89 URL: https://github.com/llvm/llvm-project/commit/a6860c1af45776e349eaed3e8f0bb7e97abccd89 DIFF: https://github.com/llvm/llvm-project/commit/a6860c1af45776e349eaed3e8f0bb7e97abccd89.diff

[clang] 6bfc45c - Fix build after D72746

2020-02-05 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2020-02-06T08:55:19+01:00 New Revision: 6bfc45cf60d2a82e659d3911c26169ad02cf78c0 URL: https://github.com/llvm/llvm-project/commit/6bfc45cf60d2a82e659d3911c26169ad02cf78c0 DIFF: https://github.com/llvm/llvm-project/commit/6bfc45cf60d2a82e659d3911c26169ad02cf78c0.diff

[clang-tools-extra] 10540e4 - [clangd] Filter out implicit references while renaming

2020-02-06 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2020-02-06T11:28:23+01:00 New Revision: 10540e480dfb243d992ff77db14219f696cc774a URL: https://github.com/llvm/llvm-project/commit/10540e480dfb243d992ff77db14219f696cc774a DIFF: https://github.com/llvm/llvm-project/commit/10540e480dfb243d992ff77db14219f696cc774a.diff

[clang-tools-extra] d5e6e0a - Fix build after D74112

2020-02-06 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2020-02-06T11:41:17+01:00 New Revision: d5e6e0a58b188627084d4714a4b2862c529870f8 URL: https://github.com/llvm/llvm-project/commit/d5e6e0a58b188627084d4714a4b2862c529870f8 DIFF: https://github.com/llvm/llvm-project/commit/d5e6e0a58b188627084d4714a4b2862c529870f8.diff

[clang-tools-extra] d5e6e0a - Fix build after D74112

2020-02-06 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2020-02-06T11:41:17+01:00 New Revision: d5e6e0a58b188627084d4714a4b2862c529870f8 URL: https://github.com/llvm/llvm-project/commit/d5e6e0a58b188627084d4714a4b2862c529870f8 DIFF: https://github.com/llvm/llvm-project/commit/d5e6e0a58b188627084d4714a4b2862c529870f8.diff

[clang-tools-extra] 9f6d8de - [clangd] Support renaming designated initializers

2020-02-10 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2020-02-10T11:53:17+01:00 New Revision: 9f6d8de28ab6b3ac06658b8cb3236ef220712ed4 URL: https://github.com/llvm/llvm-project/commit/9f6d8de28ab6b3ac06658b8cb3236ef220712ed4 DIFF: https://github.com/llvm/llvm-project/commit/9f6d8de28ab6b3ac06658b8cb3236ef220712ed4.diff

[clang-tools-extra] ff7b5ba - [clangd] Expose Code Completion score to the client

2020-02-13 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2020-02-13T15:05:18+01:00 New Revision: ff7b5bac04fa4946935ea45214e29f267d6c1d7b URL: https://github.com/llvm/llvm-project/commit/ff7b5bac04fa4946935ea45214e29f267d6c1d7b DIFF: https://github.com/llvm/llvm-project/commit/ff7b5bac04fa4946935ea45214e29f267d6c1d7b.diff

[clang-tools-extra] 38bdb94 - [clangd] Fix rename for explicit destructor calls

2020-01-20 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2020-01-21T05:33:39+01:00 New Revision: 38bdb94120b76f8f79cd27d721892673e573895a URL: https://github.com/llvm/llvm-project/commit/38bdb94120b76f8f79cd27d721892673e573895a DIFF: https://github.com/llvm/llvm-project/commit/38bdb94120b76f8f79cd27d721892673e573895a.diff

Re: [PATCH] D23397: [clang-rename] cleanup `auto` usages

2016-08-15 Thread Kirill Bobyrev via cfe-commits
omtcyfz updated this revision to Diff 68104. omtcyfz added a comment. Address comments. https://reviews.llvm.org/D23397 Files: clang-rename/RenamingAction.cpp clang-rename/USRFinder.cpp clang-rename/USRFindingAction.cpp clang-rename/USRLocFinder.cpp Index: clang-rename/USRLocFinder.cpp

Re: [PATCH] D23397: [clang-rename] cleanup `auto` usages

2016-08-15 Thread Kirill Bobyrev via cfe-commits
omtcyfz marked 2 inline comments as done. Comment at: clang-rename/USRFinder.cpp:182-184 @@ -179,6 +181,5 @@ // We only want to search the decls that exist in the same file as the point. - auto Decls = Context.getTranslationUnitDecl()->decls(); - for (auto &CurrDecl : Decls)

[clang-tools-extra] r278760 - [clang-rename] cleanup `auto` usages

2016-08-15 Thread Kirill Bobyrev via cfe-commits
Author: omtcyfz Date: Mon Aug 15 18:20:05 2016 New Revision: 278760 URL: http://llvm.org/viewvc/llvm-project?rev=278760&view=rev Log: [clang-rename] cleanup `auto` usages As Alexander pointed out, LLVM Coding Standards are more conservative about using auto, i.e. it should be used in the followin

Re: [PATCH] D23397: [clang-rename] cleanup `auto` usages

2016-08-15 Thread Kirill Bobyrev via cfe-commits
This revision was automatically updated to reflect the committed changes. omtcyfz marked an inline comment as done. Closed by commit rL278760: [clang-rename] cleanup `auto` usages (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D23397?vs=68104&id=68107#toc Repository:

[clang-tools-extra] r278780 - [clang-rename] fix broken build

2016-08-15 Thread Kirill Bobyrev via cfe-commits
Author: omtcyfz Date: Tue Aug 16 01:19:06 2016 New Revision: 278780 URL: http://llvm.org/viewvc/llvm-project?rev=278780&view=rev Log: [clang-rename] fix broken build As Eric Fiselier pointed out, r278760 breaks build, because RecursiveASTVisitor doesn't have a const overload. This patch is a quic

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

2016-08-16 Thread Kirill Bobyrev via cfe-commits
omtcyfz added a subscriber: omtcyfz. Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:659 @@ +658,3 @@ + UseAfterMove Use; + if (finder.find(FunctionBody, MovingCall, MovedVariable, &Use)) { +emitDiagnostic(MovingCall, MovedVariable, Use, this, Result.Context);

[PATCH] D23651: [clang-rename] improve performance for rename-all

2016-08-18 Thread Kirill Bobyrev via cfe-commits
omtcyfz created this revision. omtcyfz added reviewers: alexfh, vmiklos. omtcyfz added a subscriber: cfe-commits. As Miklos Vajna [[ http://lists.llvm.org/pipermail/cfe-dev/2016-August/050398.html | noticed ]] `clang-rename rename-all` has significant performance problems, which exposed the fac

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

2016-08-18 Thread Kirill Bobyrev via cfe-commits
omtcyfz updated this revision to Diff 68503. omtcyfz added a comment. Prevent unnecessary `std::vector` copying. Explicitly write type. https://reviews.llvm.org/D23651 Files: clang-rename/USRFindingAction.cpp clang-rename/USRFindingAction.h clang-rename/tool/ClangRename.cpp Index: clang-

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

2016-08-18 Thread Kirill Bobyrev via cfe-commits
omtcyfz marked an inline comment as done. Comment at: clang-rename/USRFindingAction.h:38-41 @@ -37,6 +37,6 @@ private: - unsigned SymbolOffset; - std::string OldName; - std::string SpellingName; - std::vector USRs; + const std::vector &SymbolOffsets; + const std::vector &Ol

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

2016-08-18 Thread Kirill Bobyrev via cfe-commits
omtcyfz updated this revision to Diff 68511. omtcyfz added a comment. Prevent std::vector from redundant copying. https://reviews.llvm.org/D23651 Files: clang-rename/USRFindingAction.cpp clang-rename/USRFindingAction.h clang-rename/tool/ClangRename.cpp Index: clang-rename/tool/ClangRenam

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

2016-08-19 Thread Kirill Bobyrev via cfe-commits
omtcyfz updated this revision to Diff 68656. omtcyfz marked 2 inline comments as done. omtcyfz added a comment. Partly address comments. https://reviews.llvm.org/D23651 Files: clang-rename/USRFindingAction.cpp clang-rename/USRFindingAction.h clang-rename/tool/ClangRename.cpp Index: clang

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

2016-08-19 Thread Kirill Bobyrev via cfe-commits
omtcyfz marked an inline comment as done. Comment at: clang-rename/USRFindingAction.cpp:69 @@ -69,2 +68,3 @@ } -USRs->insert(USRs->end(), USRSet.begin(), USRSet.end()); +USRs.insert(USRs.end(), USRSet.begin(), USRSet.end()); +return USRs; alexfh w

[clang-tools-extra] r279226 - minor header guards and help messages cleanup

2016-08-19 Thread Kirill Bobyrev via cfe-commits
Author: omtcyfz Date: Fri Aug 19 04:36:14 2016 New Revision: 279226 URL: http://llvm.org/viewvc/llvm-project?rev=279226&view=rev Log: minor header guards and help messages cleanup Modified: clang-tools-extra/trunk/clang-rename/RenamingAction.h clang-tools-extra/trunk/clang-rename/USRFindi

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

2016-08-19 Thread Kirill Bobyrev via cfe-commits
omtcyfz marked 2 inline comments as done. Comment at: clang-rename/USRFindingAction.cpp:69 @@ -69,3 +68,3 @@ } -USRs->insert(USRs->end(), USRSet.begin(), USRSet.end()); +return std::vector(USRSet.begin(), USRSet.end()); } Ah, sure. Sorry, didn't un

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

2016-08-19 Thread Kirill Bobyrev via cfe-commits
omtcyfz updated this revision to Diff 68665. omtcyfz added a comment. Address one more comment. https://reviews.llvm.org/D23651 Files: clang-rename/USRFindingAction.cpp clang-rename/USRFindingAction.h clang-rename/tool/ClangRename.cpp Index: clang-rename/tool/ClangRename.cpp

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

2016-08-19 Thread Kirill Bobyrev via cfe-commits
omtcyfz updated this revision to Diff 68667. omtcyfz marked an inline comment as done. https://reviews.llvm.org/D23651 Files: clang-rename/USRFindingAction.cpp clang-rename/USRFindingAction.h clang-rename/tool/ClangRename.cpp Index: clang-rename/tool/ClangRename.cpp ===

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

2016-08-19 Thread Kirill Bobyrev via cfe-commits
omtcyfz updated this revision to Diff 68668. https://reviews.llvm.org/D23651 Files: clang-rename/USRFindingAction.cpp clang-rename/USRFindingAction.h clang-rename/tool/ClangRename.cpp Index: clang-rename/tool/ClangRename.cpp =

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

2016-08-19 Thread Kirill Bobyrev via cfe-commits
omtcyfz marked an inline comment as done. Comment at: clang-rename/USRFindingAction.cpp:190 @@ -175,6 +189,3 @@ + USRList.push_back(Finder.Find()); } } Yep. Makes sense. Thanks! Comment at: clang-rename/USRFindingAction.cpp:201-202 @

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

2016-08-21 Thread Kirill Bobyrev via cfe-commits
omtcyfz marked an inline comment as done. omtcyfz added a comment. In https://reviews.llvm.org/D23651#521031, @vmiklos wrote: > It is expected that either SymbolOffsets or OldNames is empty, and the size > of the non-empty container is the same as the size of the NewNames container. > So no, th

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

2016-08-25 Thread Kirill Bobyrev via cfe-commits
omtcyfz updated this revision to Diff 69214. omtcyfz marked 2 inline comments as done. omtcyfz added a comment. Address couple of comments. https://reviews.llvm.org/D23651 Files: clang-rename/USRFindingAction.cpp clang-rename/USRFindingAction.h clang-rename/tool/ClangRename.cpp Index: cl

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

2016-08-25 Thread Kirill Bobyrev via cfe-commits
omtcyfz added a comment. Actually, it might make sense to merge `rename-at` and `rename-all` after all. Passing a list of `old-name`/`offset` -> `new-name` is just easier. But that's for another patch. https://reviews.llvm.org/D23651 ___ cfe-commi

Re: [PATCH] D24002: clang-rename: improve error message when -old-name is used and could not find symbol

2016-08-29 Thread Kirill Bobyrev via cfe-commits
omtcyfz added inline comments. Comment at: clang-rename/USRFindingAction.cpp:168 @@ +167,3 @@ + } else +errs() << "clang-rename: could not find symbol named " << OldName + << ".\n"; I am not sure whether "could not find symbol **called**

Re: [PATCH] D24002: clang-rename: improve error message when -old-name is used and could not find symbol

2016-08-30 Thread Kirill Bobyrev via cfe-commits
omtcyfz accepted this revision. omtcyfz added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D24002#528556, @vmiklos wrote: > > Probably something like "could not find symbol OldName" would be > > reasonable, too. > > > OK, changed. Great! Good catch, t

Re: [PATCH] D24178: [clang-rename] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

2016-09-02 Thread Kirill Bobyrev via cfe-commits
omtcyfz accepted this revision. omtcyfz added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D24178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

2016-09-02 Thread Kirill Bobyrev via cfe-commits
omtcyfz added a comment. In https://reviews.llvm.org/D23651#531884, @vmiklos wrote: > Kirill, are you waiting for me on this one? AFAICS the patch in its current > form applies on top of current trunk, but no longer builds. Miklos, it is a bit more complicated :) Bascially, I have another pat

[PATCH] D24192: [clang-refactor] introducing clang-refactor

2016-09-02 Thread Kirill Bobyrev via cfe-commits
omtcyfz created this revision. omtcyfz added reviewers: alexfh, klimek, ioeric, bkramer. omtcyfz added a subscriber: cfe-commits. This patch basically creates `clang-refactor` binary and merges both `clang-rename rename-at` and `clang-rename rename-at` a.k.a. `clang-rename` into `clang-refactor

Re: [PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

2016-09-02 Thread Kirill Bobyrev via cfe-commits
omtcyfz added a comment. In https://reviews.llvm.org/D24183#532876, @Eugene.Zelenko wrote: > Looks like clang-refactor idea should finally go live. https://reviews.llvm.org/D24192 up for review. Repository: rL LLVM https://reviews.llvm.org/D24183

<    1   2   3   4   5   6   7   >