omtcyfz marked an inline comment as done.
================
Comment at: clang-rename/USRFindingAction.cpp:190
@@ -175,6 +189,3 @@
+ USRList.push_back(Finder.Find());
}
}
----------------
Yep. Makes sense. Thanks!
================
Comment at: clang-rename/USRFindingAction.cpp:201-202
@@ -188,10 +200,4 @@
std::unique_ptr<ASTConsumer> USRFindingAction::newASTConsumer() {
- std::unique_ptr<NamedDeclFindingConsumer> Consumer(
- new NamedDeclFindingConsumer);
- SpellingName = "";
- Consumer->SymbolOffset = SymbolOffset;
- Consumer->OldName = OldName;
- Consumer->USRs = &USRs;
- Consumer->SpellingName = &SpellingName;
- return std::move(Consumer);
+ return llvm::make_unique<NamedDeclFindingConsumer>(SymbolOffsets, OldNames,
+ SpellingNames, USRList);
}
----------------
Yes, it's way better.
https://reviews.llvm.org/D23651
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
