[PATCH] D51802: [clangd] Make advanceTo() faster on Posting Lists

This revision was automatically updated to reflect the committed changes. Closed by commit rL341781: [clangd] Make advanceTo() faster on Posting Lists (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51802?vs=16462

[PATCH] D51774: [clangd] NFC: Rename DexIndex to Dex

kbobyrev updated this revision to Diff 164629. kbobyrev marked an inline comment as done. https://reviews.llvm.org/D51774 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/SymbolYAML.cpp clang-tools-extra/clangd/index/dex/Dex.cpp clang-tools-extra/clangd/index/

[PATCH] D51774: [clangd] NFC: Rename DexIndex to Dex

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE341784: [clangd] NFC: Rename DexIndex to Dex (authored by omtcyfz, committed by ). Herald added a subscriber: mgrang. Changed prior to commit: https://reviews.llvm.org/D51774?vs=164629&id=164630#toc

[PATCH] D51852: [clangd] Implement FuzzyFindRequest JSON (de)serialization

kbobyrev created this revision. kbobyrev added reviewers: ilya-biryukov, ioeric, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. JSON (de)serialization of `FuzzyFindRequest` might be useful for both https://reviews.llvm.org/D

[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

kbobyrev updated this revision to Diff 164643. kbobyrev added a comment. Sync with HEAD. https://reviews.llvm.org/D51539 Files: clang-tools-extra/clangd/index/FileIndex.cpp clang-tools-extra/clangd/index/Index.cpp clang-tools-extra/clangd/index/Index.h clang-tools-extra/clangd/index/Mem

[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

kbobyrev updated this revision to Diff 164644. kbobyrev added a comment. Remove accidental formatting changes. https://reviews.llvm.org/D51539 Files: clang-tools-extra/clangd/index/FileIndex.cpp clang-tools-extra/clangd/index/MemIndex.cpp clang-tools-extra/clangd/index/MemIndex.h clang-

[PATCH] D51852: [clangd] Implement FuzzyFindRequest JSON (de)serialization

kbobyrev updated this revision to Diff 164648. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Revert unrelated formatting changes, simplify the comment. https://reviews.llvm.org/D51852 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clangd/index/Inde

[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

kbobyrev updated this revision to Diff 164653. kbobyrev marked 2 inline comments as done. https://reviews.llvm.org/D51539 Files: clang-tools-extra/clangd/index/FileIndex.cpp clang-tools-extra/clangd/index/MemIndex.cpp clang-tools-extra/clangd/index/MemIndex.h clang-tools-extra/clangd/inde

[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

kbobyrev marked an inline comment as done. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/Index.h:512 llvm::function_ref) const override; + void lookup(const LookupRequest &, ioeric wrote: > nit: I'd avoid irreleva

[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

This revision was automatically updated to reflect the committed changes. Closed by commit rL341800: [clangd] Add symbol slab size to index memory consumption estimates (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D51852: [clangd] Implement FuzzyFindRequest JSON (de)serialization

This revision was automatically updated to reflect the committed changes. Closed by commit rL341802: [clangd] Implement FuzzyFindRequest JSON (de)serialization (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51852

[PATCH] D51852: [clangd] Implement FuzzyFindRequest JSON (de)serialization

kbobyrev added a comment. In https://reviews.llvm.org/D51852#1228883, @yroux wrote: > Hi Kirill, > > This commit broke ARMV8 buildbots, logs are available here: > > http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/6493/steps/build%20stage%201/logs/stdio > > Thanks > Yvan Hi! A

[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

kbobyrev created this revision. kbobyrev added reviewers: ioeric, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. https://reviews.llvm.org/D51860 Files: clang-tools-extra/clangd/index/Index.cpp clang-tools-

[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

kbobyrev updated this revision to Diff 164821. kbobyrev marked an inline comment as done. https://reviews.llvm.org/D51860 Files: clang-tools-extra/clangd/index/Index.cpp clang-tools-extra/clangd/index/Index.h Index: clang-tools-extra/clangd/index/Index.h

[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/Index.h:440 /// return more than this, e.g. if it doesn't know which candidates are best. - size_t MaxCandidateCount = std::numeric_limits::max(); + uint32_t MaxCandidateCount = std::numeric_limits::m

[PATCH] D51628: [clangd] Implement a Proof-of-Concept tool for symbol index exploration

kbobyrev updated this revision to Diff 164834. kbobyrev marked 8 inline comments as done. kbobyrev added a comment. Address a round of comments; implement a dummy ad-hoc subcommand parser. https://reviews.llvm.org/D51628 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clang

[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

kbobyrev updated this revision to Diff 164836. https://reviews.llvm.org/D51860 Files: clang-tools-extra/clangd/index/Index.cpp clang-tools-extra/clangd/index/Index.h Index: clang-tools-extra/clangd/index/Index.h === --- clang-t

[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/Index.h:440 /// return more than this, e.g. if it doesn't know which candidates are best. - size_t MaxCandidateCount = std::numeric_limits::max(); + uint32_t MaxCandidateCount = std::numeric_limits::m

[PATCH] D51628: [clangd] Implement a Proof-of-Concept tool for symbol index exploration

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/dexplorer/Dexplorer.cpp:39 + +// FIXME(kbobyrev): Make this an actual REPL: probably use LLVM Command Line +// library for parsing flags and arguments. ilya-biryukov wrote: > kbobyrev wrote: > >

[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

This revision was automatically updated to reflect the committed changes. Closed by commit rL341921: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51860?vs=

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

kbobyrev updated this revision to Diff 164841. kbobyrev added a comment. Outline the structure for "Editor Integration" section which is to be filled with other options later. https://reviews.llvm.org/D51297 Files: clang-tools-extra/docs/clangd.rst Index: clang-tools-extra/docs/clangd.rst

[PATCH] D51292: [docs] Update clang-rename documentation

kbobyrev added a comment. @ioeric does it look better now? https://reviews.llvm.org/D51292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51090: [clangd] Add index benchmarks

kbobyrev updated this revision to Diff 164848. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Address few comments (not all of them for now, though). https://reviews.llvm.org/D51090 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/benchmarks/CMak

[PATCH] D51628: [clangd] Implement a Proof-of-Concept tool for symbol index exploration

kbobyrev updated this revision to Diff 164865. kbobyrev marked 19 inline comments as done. kbobyrev added a comment. Address comments. https://reviews.llvm.org/D51628 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/dex/dexp/CMakeLists.txt clang-tools-extra/cl

[PATCH] D51090: [clangd] Add index benchmarks

kbobyrev updated this revision to Diff 164881. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. The only problem left is that I'm not sure how to run binary which is not under bin (`IndexBenchmark`) using llvm-lit. https://reviews.llvm.org/D51090 Files: clang-tools-extra/

[PATCH] D51090: [clangd] Add index benchmarks

kbobyrev updated this revision to Diff 164887. kbobyrev added a comment. Find a hacky workaround to call `IndexBenchmark` binary. https://reviews.llvm.org/D51090 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/benchmarks/CMakeLists.txt clang-tools-extra/clangd/benc

[PATCH] D51628: [clangd] Implement a Proof-of-Concept tool for symbol index exploration

kbobyrev updated this revision to Diff 164893. kbobyrev marked 9 inline comments as done. kbobyrev added a comment. Address comments https://reviews.llvm.org/D51628 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/dex/dexp/CMakeLists.txt clang-tools-extra/clan

[PATCH] D51090: [clangd] Add index benchmarks

kbobyrev updated this revision to Diff 164895. kbobyrev added a comment. Add `--benchmark_min_time=0.01` to prevent testing time increase. https://reviews.llvm.org/D51090 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/benchmarks/CMakeLists.txt clang-tools-extra/cl

[PATCH] D51628: [clangd] Implement a Proof-of-Concept tool for symbol index exploration

kbobyrev updated this revision to Diff 165016. kbobyrev marked an inline comment as done. kbobyrev added a comment. Remove artifact comment. https://reviews.llvm.org/D51628 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/dex/dexp/CMakeLists.txt clang-tools-ex

[PATCH] D51628: [clangd] Implement a Proof-of-Concept tool for symbol index exploration

This revision was automatically updated to reflect the committed changes. Closed by commit rL342025: [clangd] Implement a Proof-of-Concept tool for symbol index exploration (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D51090: [clangd] Add index benchmarks

kbobyrev updated this revision to Diff 165023. kbobyrev marked an inline comment as done. https://reviews.llvm.org/D51090 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/benchmarks/CMakeLists.txt clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp clang-tools-ex

[PATCH] D51090: [clangd] Add index benchmarks

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342026: [clangd] Add index benchmarks (authored by omtcyfz, committed by ). Changed prior to commit: https://reviews.llvm.org/D51090?vs=165023&id=165024#toc Repository: rL LLVM https://reviews.llv

[PATCH] D51090: [clangd] Add index benchmarks

This revision was automatically updated to reflect the committed changes. Closed by commit rL342026: [clangd] Add index benchmarks (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51090?vs=165023&id=165025#toc Rep

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. After `FuzzyFindRequest` JSON (de)serialization was introduced, it should replace ad-hoc fuzzy-find request

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

kbobyrev added inline comments. Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:35 + + std::string TypeAndName = + VarType.getAsString(TypePrinter) + " " + D->getNameAsString(); `llvm::Twine` here? Seems like this one is used a lot for concatenation

[PATCH] D51982: [clangd] Introduce PostingList interface

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, mgorny. This patch introduces `PostingList` interface which is helpful for experiments with Spar

[PATCH] D51982: [clangd] Introduce PostingList interface

kbobyrev planned changes to this revision. kbobyrev added a comment. There is not enough documentation right now, I should fix that before patch could be reviewed. This is a preview mode. Also, Index size estimation is incorrect now and will be fixed in the next diff. https://reviews.llvm.org/

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

kbobyrev added a comment. My 2 cents: `clangd-indexer` looks great! Typing 3-token tool name is always sad for me :( It's also easier to remember/understand in the first place. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51987 _

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev planned changes to this revision. kbobyrev marked an inline comment as done. kbobyrev added a comment. Apparently, the parsing seems to be wrong; I should fix that first. https://reviews.llvm.org/D51971 ___ cfe-commits mailing list cfe-comm

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev updated this revision to Diff 165110. kbobyrev marked an inline comment as done. kbobyrev added a comment. @ilya-biryukov thanks! I was assuming that the `StringRef` constructor parses user-provided string :( `llvm::json::Array` is used now. https://reviews.llvm.org/D51971 Files: c

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

kbobyrev added a comment. I've been thinking about corner-cases (e.g. don't split `DeclStmt`s within init-statement declaration) a while and it seems that there might be many of them. I didn't notice https://reviews.llvm.org/D27621 in the first place, it seems to have a solid test suite (and i

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev updated this revision to Diff 165209. kbobyrev marked 2 inline comments as done. https://reviews.llvm.org/D51971 Files: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp clang-tools-extra/test/clangd/Inputs/requests.json clang-tools-extra/test/clangd/Inputs/requests.log clan

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:45 + if (!JSONArray) { +llvm::errs() << "Couldn't parse request.\n"; + } ilya-biryukov wrote: > Return from function after error? I thought that this should p

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

kbobyrev updated this revision to Diff 165210. kbobyrev marked an inline comment as done. https://reviews.llvm.org/D51297 Files: clang-tools-extra/docs/clangd.rst Index: clang-tools-extra/docs/clangd.rst === --- clang-tools-extra

[PATCH] D52016: [clangd] Don't create child AND and OR iterators with one posting list

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. `AND( AND( Child ) ... )` -> `AND( Child ... )` `AND( OR( Child) ... )` -> `AND( Child ... )` Th

[PATCH] D51982: [clangd] Introduce PostingList interface

kbobyrev updated this revision to Diff 165224. kbobyrev added a comment. Add documentation, don't expose `PostingList` interface implementations in the public API (similarly to `Iterator`). https://reviews.llvm.org/D51982 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/cla

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

kbobyrev updated this revision to Diff 165228. kbobyrev added a comment. Create different sections for few editors, link web page with the complete list of LSP clients. https://reviews.llvm.org/D51297 Files: clang-tools-extra/docs/clangd.rst Index: clang-tools-extra/docs/clangd.rst ===

[PATCH] D52016: [clangd] Don't create child AND and OR iterators with one posting list

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:148 + if (TrigramIterators.size() > 1) TopLevelChildren.push_back(createAnd(move(TrigramIterators))); + else if (TrigramIterators.size() == 1) ilya-biryukov wrote: > May

[PATCH] D52016: [clangd] Don't create child AND and OR iterators with one posting list

kbobyrev updated this revision to Diff 165229. kbobyrev marked an inline comment as done. https://reviews.llvm.org/D52016 Files: clang-tools-extra/clangd/index/dex/Iterator.cpp Index: clang-tools-extra/clangd/index/dex/Iterator.cpp =

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:45 + if (!JSONArray) { +llvm::errs() << "Couldn't parse request.\n"; + } ilya-biryukov wrote: > kbobyrev wrote: > > ilya-biryukov wrote: > > > Return from fun

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev updated this revision to Diff 165232. kbobyrev marked 3 inline comments as done. https://reviews.llvm.org/D51971 Files: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp clang-tools-extra/test/clangd/Inputs/requests.json clang-tools-extra/test/clangd/Inputs/requests.log clan

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev updated this revision to Diff 165234. kbobyrev added a comment. Rebase on top of https://reviews.llvm.org/rL342123. https://reviews.llvm.org/D51971 Files: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp clang-tools-extra/test/clangd/Inputs/requests.json clang-tools-extra/t

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev updated this revision to Diff 165235. kbobyrev added a comment. Fix the diff after rebase. https://reviews.llvm.org/D51971 Files: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp clang-tools-extra/test/clangd/Inputs/requests.json clang-tools-extra/test/clangd/Inputs/request

[PATCH] D52016: [clangd] Don't create child AND and OR iterators with one posting list

kbobyrev updated this revision to Diff 165236. kbobyrev marked an inline comment as done. kbobyrev added a comment. Move assertion back to ctors. https://reviews.llvm.org/D52016 Files: clang-tools-extra/clangd/index/dex/Iterator.cpp Index: clang-tools-extra/clangd/index/dex/Iterator.cpp ===

[PATCH] D52016: [clangd] Don't create child AND and OR iterators with one posting list

This revision was automatically updated to reflect the committed changes. Closed by commit rL342124: [clangd] Don't create child AND and OR iterators with one posting list (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

kbobyrev updated this revision to Diff 165238. kbobyrev marked an inline comment as done. https://reviews.llvm.org/D51297 Files: clang-tools-extra/docs/clangd.rst Index: clang-tools-extra/docs/clangd.rst === --- clang-tools-extra

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

kbobyrev added inline comments. Comment at: clang-tools-extra/docs/clangd.rst:135 + +:program:`VSCode` provides `vscode-clangd +` ilya-biryukov wrote: > Maybe menti

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev updated this revision to Diff 165240. kbobyrev added a comment. Fix empty scope in `requests.json`: `%s/"::"/""/g`. https://reviews.llvm.org/D51971 Files: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp clang-tools-extra/test/clangd/Inputs/requests.json clang-tools-extra/t

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev updated this revision to Diff 165248. kbobyrev marked 3 inline comments as done. https://reviews.llvm.org/D51971 Files: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp clang-tools-extra/clangd/index/dex/Iterator.cpp clang-tools-extra/test/clangd/Inputs/requests.json clang-

[PATCH] D51297: [docs] Provide pointers to known editor plugins and extensions

kbobyrev closed this revision. kbobyrev added a comment. Unfortunately, forgot to add the revision link in the commit message of https://reviews.llvm.org/rCTE342129. https://reviews.llvm.org/D51297 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D51982: [clangd] Introduce PostingList interface

kbobyrev updated this revision to Diff 165256. kbobyrev marked 3 inline comments as done. https://reviews.llvm.org/D51982 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/dex/Dex.cpp clang-tools-extra/clangd/index/dex/Dex.h clang-tools-extra/clangd/index/dex/I

[PATCH] D52028: [clangd] Cleanup FuzzyFindRequest filtering limit semantics

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. As discussed during https://reviews.llvm.org/D51860 review, it is better to use `llvm::Optional`

[PATCH] D51982: [clangd] Introduce PostingList interface

kbobyrev updated this revision to Diff 165268. kbobyrev marked 2 inline comments as done. https://reviews.llvm.org/D51982 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/dex/Dex.cpp clang-tools-extra/clangd/index/dex/Dex.h clang-tools-extra/clangd/index/dex/I

[PATCH] D52028: [clangd] Cleanup FuzzyFindRequest filtering limit semantics

kbobyrev updated this revision to Diff 165271. kbobyrev marked an inline comment as done. kbobyrev added a comment. Change `IndexBenchmark` accordingly, perform minor cleanup. https://reviews.llvm.org/D52028 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clangd/FindSymbo

[PATCH] D52028: [clangd] Cleanup FuzzyFindRequest filtering limit semantics

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:182 // when the requested number of items is small. - const size_t ItemsToRetrieve = 100 * Req.MaxCandidateCount; - auto Root = createLimit(move(QueryIterator), ItemsToRetrieve); -

[PATCH] D52028: [clangd] Cleanup FuzzyFindRequest filtering limit semantics

kbobyrev updated this revision to Diff 165272. kbobyrev added a comment. Don't modify benchmarks since it'd clash with the parent patch in this case. https://reviews.llvm.org/D52028 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clangd/FindSymbols.cpp clang-tools-extra

[PATCH] D52030: [clangd] Test benchmark if we can build it

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Looks good, thanks! While we're here: I'm wondering whether we should also introduce very basic test which would just run `clangd-indexer` since it doesn't depend on benchmarks and would

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev updated this revision to Diff 165276. kbobyrev marked 2 inline comments as done. https://reviews.llvm.org/D51971 Files: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp clang-tools-extra/test/clangd/Inputs/requests.json clang-tools-extra/test/clangd/Inputs/requests.log clan

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev updated this revision to Diff 165277. kbobyrev added a comment. Fix a typo in test comments. https://reviews.llvm.org/D51971 Files: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp clang-tools-extra/test/clangd/Inputs/requests.json clang-tools-extra/test/clangd/Inputs/reque

[PATCH] D51989: [clangd] dexp tool uses llvm::cl to parse its flags.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D51989#1232099, @ilya-biryukov wrote: > PS it'd be cool to have an interface to cl that does not rely on global > state... Yeah, I'm not sure if that's trivia

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev updated this revision to Diff 165280. kbobyrev marked 2 inline comments as done. https://reviews.llvm.org/D51971 Files: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp clang-tools-extra/test/clangd/Inputs/requests.json clang-tools-extra/test/clangd/Inputs/requests.log clan

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342137: [clangd] Use JSON format in benchmark requests reader (authored by omtcyfz, committed by ). Changed prior to commit: https://reviews.llvm.org/D51971?vs=165280&id=165281#toc Repository: rCTE

[PATCH] D52028: [clangd] Cleanup FuzzyFindRequest filtering limit semantics

kbobyrev updated this revision to Diff 165283. kbobyrev added a comment. Update `requests.json` to comply with the new format. https://reviews.llvm.org/D52028 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clangd/FindSymbols.cpp clang-tools-extra/clangd/index/Index.cpp

[PATCH] D52028: [clangd] Cleanup FuzzyFindRequest filtering limit semantics

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342138: [clangd] Cleanup FuzzyFindRequest filtering limit semantics (authored by omtcyfz, committed by ). Changed prior to commit: https://reviews.llvm.org/D52028?vs=165283&id=165284#toc Repository:

[PATCH] D52030: [clangd] Test benchmark if we can build it

kbobyrev added a subscriber: rnk. kbobyrev added a comment. In https://reviews.llvm.org/D52030#1233349, @sammccall wrote: > In https://reviews.llvm.org/D52030#1233323, @kbobyrev wrote: > > > Looks good, thanks! > > > > While we're here: I'm wondering whether we should also introduce very basic >

[PATCH] D52030: [clangd] Test benchmark if we can build it

kbobyrev added a comment. In https://reviews.llvm.org/D52030#1233395, @kbobyrev wrote: > In https://reviews.llvm.org/D52030#1233349, @sammccall wrote: > > > In https://reviews.llvm.org/D52030#1233323, @kbobyrev wrote: > > > > > Looks good, thanks! > > > > > > While we're here: I'm wondering wheth

[PATCH] D51982: [clangd] Introduce PostingList interface

kbobyrev updated this revision to Diff 165297. kbobyrev added a comment. Don't create abstractions for now. https://reviews.llvm.org/D51982 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/dex/Dex.cpp clang-tools-extra/clangd/index/dex/Dex.h clang-tools-extr

[PATCH] D51982: [clangd] Introduce PostingList interface

kbobyrev updated this revision to Diff 165298. kbobyrev added a comment. Remove artifacts from assertion messages. https://reviews.llvm.org/D51982 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/dex/Dex.cpp clang-tools-extra/clangd/index/dex/Dex.h clang-too

[PATCH] D51982: [clangd] Introduce PostingList interface

kbobyrev updated this revision to Diff 165318. kbobyrev marked an inline comment as done. https://reviews.llvm.org/D51982 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/dex/Dex.cpp clang-tools-extra/clangd/index/dex/Dex.h clang-tools-extra/clangd/index/dex/I

[PATCH] D51982: [clangd] Introduce PostingList interface

kbobyrev updated this revision to Diff 165320. kbobyrev added a comment. Wording: traversed *in order*. https://reviews.llvm.org/D51982 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/dex/Dex.cpp clang-tools-extra/clangd/index/dex/Dex.h clang-tools-extra/cl

[PATCH] D51982: [clangd] Introduce PostingList interface

kbobyrev marked an inline comment as done. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Iterator.h:39 #include +#include "PostingList.h" sammccall wrote: > Why this dep? Seems circular `Iterator` interface uses `DocID`, so I

[PATCH] D51982: [clangd] Introduce PostingList interface

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Iterator.h:39 #include +#include "PostingList.h" kbobyrev wrote: > sammccall wrote: > > Why this dep? Seems circular > `Iterator` interface uses `DocID`, so I guess it should depen

[PATCH] D51982: [clangd] Introduce PostingList interface

kbobyrev updated this revision to Diff 165324. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Pull `DocID` to `Iterator.h`. https://reviews.llvm.org/D51982 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/dex/Dex.cpp clang-tools-extra/cla

[PATCH] D51982: [clangd] Introduce PostingList interface

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342155: [clangd] Introduce PostingList interface (authored by omtcyfz, committed by ). Changed prior to commit: https://reviews.llvm.org/D51982?vs=165324&id=165325#toc Repository: rCTE Clang Tools

[PATCH] D52047: [clangd] Add a "benchmark" for tracking memory

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. While this looks like misuse of benchmark library, this can be still when experimenting with ind

[PATCH] D52047: [clangd] Add a "benchmark" for tracking memory

kbobyrev updated this revision to Diff 165437. kbobyrev added a comment. - Start measuring time in ms - Add Tokens' `Data` size for more precise memory usage estimation (accounts for ~1MB of Static Index in LLVM) https://reviews.llvm.org/D52047 Files: clang-tools-extra/clangd/benchmarks/Inde

[PATCH] D52047: [clangd] Add a "benchmark" for tracking memory

kbobyrev updated this revision to Diff 165440. kbobyrev added a comment. Move `vlog` message to the outer `build(...)` function: otherwise `BackingMemorySize` is not set to the correct value and log reports index overhead (instead of the complete index + slab) size. https://reviews.llvm.org/D5

[PATCH] D52083: [clangd] Store OR iterator children in heap

kbobyrev created this revision. kbobyrev added reviewers: ioeric, sammccall, ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Use min-heap invariant for OR iterator's children. This helps to avoid iterating through all chi

[PATCH] D52084: [clangd] NFC: Update documentation of Iterator's dump format

kbobyrev created this revision. kbobyrev added reviewers: ioeric, sammccall, ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Raw posting list iterator's `dump()` was changed in https://reviews.llvm.org/rCTE342155, but the

[PATCH] D52083: [clangd] Store OR iterator children in heap

kbobyrev updated this revision to Diff 165471. kbobyrev marked 3 inline comments as done. kbobyrev edited the summary of this revision. kbobyrev added a comment. Fixed the bug with incorrect assumption of `Children` being sorted (instead of being a heap). This caused a huge overhead (~30%). When

[PATCH] D49546: [clangd] Implement query iterators for Dex symbol index

kbobyrev created this revision. kbobyrev added reviewers: ioeric, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. This is a proof-of-concept implementation of query iterators. At the moment, it is pretty messy an

[PATCH] D49417: [clangd] Implement trigram generation algorithm for new symbol index

omtcyfz updated this revision to Diff 156443. omtcyfz marked 35 inline comments as done. omtcyfz added a comment. Addressed most comments (aside from reusing fuzzy matching segmentation routine and making data + hash a separate structure). Since I already submitted my next revision (https://revi

[PATCH] D49417: [clangd] Implement trigram generation algorithm for new symbol index

omtcyfz added inline comments. Comment at: clang-tools-extra/clangd/index/noctem/SearchAtom.h:53 + SearchAtom(llvm::StringRef Data, Namespace Type = Namespace::Trigram) + : Data(Data), Hash(std::hash{}(Data)), Type(Type) {} + ioeric wrote: > ioeric wrote: >

[PATCH] D49591: [clangd] Introduce search Tokens and trigram generation algorithms

kbobyrev created this revision. kbobyrev added reviewers: ioeric, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: arphaman, jkorous, MaskRay, mgorny. This patch introduces trigram generation algorithm for the symbol index proposed in a recent design document. RFC

[PATCH] D49591: [clangd] Introduce search Tokens and trigram generation algorithms

kbobyrev planned changes to this revision. kbobyrev added a comment. The upcoming changes: - Use segmentation API exposed in https://reviews.llvm.org/rL337527 - Create a separate structure for Data and Hash as suggested by Sam - Fix the bug with whole segments concatenation https://reviews.llvm

[PATCH] D49546: [clangd] Implement query iterators for Dex symbol index

kbobyrev updated this revision to Diff 156483. kbobyrev marked 9 inline comments as done. kbobyrev added a comment. - Switched from `std::shared_ptr` to `std::unique_ptr` for iterator's children: iterators own their subtrees, the lifetime should depend on the root - Store `PostingListRef`in `Docu

[PATCH] D49546: [clangd] Implement query iterators for Dex symbol index

kbobyrev planned changes to this revision. kbobyrev added a comment. Upcoming changes: - Improve debugging experience by providing `llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, std::unique_ptr Iterator` to recursively pretty print queries in human-readable format: e.g. `(& [0, 1, 2, 3]

[PATCH] D49546: [clangd] Implement query iterators for Dex symbol index

kbobyrev updated this revision to Diff 156725. kbobyrev added a comment. Herald added a subscriber: mgrang. - Implemented convenient dumping via `llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, QueryIterator &Iterator)`, which dumps iterator tree in human-readable format, e.g. `(&& [1, 2, 3

[PATCH] D49591: [clangd] Introduce search Tokens and trigram generation algorithms

kbobyrev updated this revision to Diff 156772. kbobyrev marked 19 inline comments as done. kbobyrev added a reviewer: ilya-biryukov. kbobyrev removed a subscriber: ilya-biryukov. kbobyrev added a comment. Address all comments from the last iteration. Latest changes: - Trigram generation algorith

[PATCH] D49591: [clangd] Introduce search Tokens and trigram generation algorithms

kbobyrev updated this revision to Diff 156774. kbobyrev added a comment. Wrong diff, should be correct now. https://reviews.llvm.org/D49591 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/dex/Token.cpp clang-tools-extra/clangd/index/dex/Token.h clang-tools-

<    1   2   3   4   5   6   7   8   9   10   >