This revision was automatically updated to reflect the committed changes.
Closed by commit rL341781: [clangd] Make advanceTo() faster on Posting Lists
(authored by omtcyfz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51802?vs=164623&id=164625#toc
Repository:
rL LLVM
https://reviews.llvm.org/D51802
Files:
clang-tools-extra/trunk/clangd/index/dex/Iterator.cpp
Index: clang-tools-extra/trunk/clangd/index/dex/Iterator.cpp
===================================================================
--- clang-tools-extra/trunk/clangd/index/dex/Iterator.cpp
+++ clang-tools-extra/trunk/clangd/index/dex/Iterator.cpp
@@ -38,7 +38,10 @@
/// or higher than the given one.
void advanceTo(DocID ID) override {
assert(!reachedEnd() && "DOCUMENT iterator can't advance() at the end.");
- Index = std::lower_bound(Index, std::end(Documents), ID);
+ // If current ID is beyond requested one, iterator is already in the right
+ // state.
+ if (peek() < ID)
+ Index = std::lower_bound(Index, std::end(Documents), ID);
}
DocID peek() const override {
Index: clang-tools-extra/trunk/clangd/index/dex/Iterator.cpp
===================================================================
--- clang-tools-extra/trunk/clangd/index/dex/Iterator.cpp
+++ clang-tools-extra/trunk/clangd/index/dex/Iterator.cpp
@@ -38,7 +38,10 @@
/// or higher than the given one.
void advanceTo(DocID ID) override {
assert(!reachedEnd() && "DOCUMENT iterator can't advance() at the end.");
- Index = std::lower_bound(Index, std::end(Documents), ID);
+ // If current ID is beyond requested one, iterator is already in the right
+ // state.
+ if (peek() < ID)
+ Index = std::lower_bound(Index, std::end(Documents), ID);
}
DocID peek() const override {
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
