[PATCH] D96324: [clangd] Rename references to function arguments within the same file

kbobyrev added a comment. Herald added a project: clang-tools-extra. Ping! Do you think this is a reasonable idea? I think if we just check whether there aren't any references to the function outside of the main file we should be safe enough to rename args. Repository: rG LLVM Github Monorep

[PATCH] D105426: [clangd] IWYU as a library: Find all references to symbols in the file

kbobyrev updated this revision to Diff 364714. kbobyrev added a comment. Remove some code from the next chunk of IWYU work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llvm.org/D105426 Files: clang-tools-extra/clang

[PATCH] D105426: [clangd] IWYU as a library: Find all references to symbols in the file

kbobyrev updated this revision to Diff 364735. kbobyrev added a comment. Rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llvm.org/D105426 Files: clang-tools-extra/clangd/CMakeLists.txt clang-too

[PATCH] D105426: [clangd] IWYU as a library: Find all references to symbols in the file

kbobyrev updated this revision to Diff 365094. kbobyrev marked 15 inline comments as done. kbobyrev added a comment. Thank you for the great suggestions! Indeed, we already have the confusion regarding IWYU having the CLI flag and users are thinking we provide some sort of integration/implementati

[PATCH] D105426: [clangd] Include Sanity as a library: Find all references to symbols in the file

kbobyrev updated this revision to Diff 365369. kbobyrev added a comment. Rename. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llvm.org/D105426 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd

[PATCH] D97803: [clangd] Overload bundles are only deprecated if each overloads is.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. I see, thank you very much for the explanation! Comment at: clang-tools-extra/clangd/CodeComplete.cpp:410 +if (Completion.Deprecated) { + Completion.Deprecated =

[PATCH] D105426: [clangd] IncludeCleaner as a library: Find all references to symbols in the file

kbobyrev updated this revision to Diff 366819. kbobyrev added a comment. Remove findReferencedFiles (to be introduced in the next patch) to preserve proposed granularity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llv

[PATCH] D105426: [clangd] IncludeCleaner as a library: Find all references to symbols in the file

kbobyrev updated this revision to Diff 366830. kbobyrev added a comment. Fix tests name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llvm.org/D105426 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extr

[PATCH] D105426: [clangd] IncludeCleaner as a library: Find all references to symbols in the file

kbobyrev updated this revision to Diff 366832. kbobyrev added a comment. [clangd] IncludeCleaner: Mark used headers. Follow-up on D105426 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews

[PATCH] D105426: [clangd] IncludeCleaner as a library: Find all references to symbols in the file

kbobyrev updated this revision to Diff 366833. kbobyrev added a comment. Push back to the origin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llvm.org/D105426 Files: clang-tools-extra/clangd/CMakeLists.txt clang-t

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, mgrang. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Follow-p on D

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 366835. kbobyrev added a comment. Nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/clangd/Headers.cpp clang-tools-extra/clangd/Heade

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to add some basic tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 ___ cfe-commi

[PATCH] D105426: [clangd] IncludeCleaner as a library: Find all references to symbols in the file

kbobyrev updated this revision to Diff 367138. kbobyrev marked an inline comment as done. kbobyrev added a comment. Remove unused code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llvm.org/D105426 Files: clang-tools

[PATCH] D105426: [clangd] IncludeCleaner as a library: Find all references to symbols in the file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1ec581ebfca: [clangd] IncludeCleaner as a library: Find all references to symbols in the file (authored by kbobyrev). Repository: rG LLVM Github

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 367140. kbobyrev added a comment. Rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/clangd/Headers.cpp clang-tools-

[PATCH] D104843: [clangd] Introduce a log-prefix flag to remote-index-server

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104843/new/ https://reviews.llvm.org/D104843 __

[PATCH] D104981: [clang-tidy] Add -line-filter to run-clang-tidy.py

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104981/new/ https://reviews.llvm.org/D104981 __

[PATCH] D104981: [clang-tidy] Add -line-filter to run-clang-tidy.py

kbobyrev added a comment. Do you need help landing it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104981/new/ https://reviews.llvm.org/D104981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D104981: [clang-tidy] Add -line-filter to run-clang-tidy.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGe837ce2a3236: [clang-tidy] Add -line-filter to run-clang-tidy.py (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104981/new/ https://r

[PATCH] D104981: [clang-tidy] Add -line-filter to run-clang-tidy.py

kbobyrev added a comment. In D104981#2845005 , @bansan wrote: > @kbobyrev Yes please. I downloaded arc. I created a commit where last line is > "Differential Revision: https://reviews.llvm.org/D104981";. > > I linked my github account to llvm's phabricat

[PATCH] D105426: [clangd] WIP: Unused header warnings

kbobyrev created this revision. Herald added subscribers: usaxena95, kadircet, arphaman, mgrang, mgorny. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Based on https://reviews.llvm.org/D100540.

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

kbobyrev marked 9 inline comments as done. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:215 +D.Message = "Included header is unused"; +D.Name = "clangd-include-cleaner"; +// FIXME: This range should be the whole line with tar

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

kbobyrev updated this revision to Diff 382214. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111870/new/ https://reviews.llvm.org/D111870 Files: clang-

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

kbobyrev updated this revision to Diff 382215. kbobyrev added a comment. Use IncludeCleaner to get rid of unused include in IncludeCleaner.cpp 🆒 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111870/new/ https://reviews.llvm.org/D111870 Files: cl

[PATCH] D112447: [clangd] IncludeCleaner: Support macros

kbobyrev updated this revision to Diff 382221. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Try another strategy to reduce the number of processed tokens (doesn't work in all cases). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D112447: [clangd] IncludeCleaner: Support macros

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:140 +// locations for the found macros. +void findReferencedMacros(ParsedAST &AST, ReferencedLocations &Result) { + auto Tokens = sammccall wrote: > sammccall wrote: > > can

[PATCH] D111711: [clangd] IncludeCleaner: Don't consider the definition as usage for function forward declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rGc521288ed391: [clangd] IncludeCleaner: Don't consider the definition as usage for function… (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

kbobyrev updated this revision to Diff 382242. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Resolve the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111870/new/ https://reviews.llvm.org/D111870 Files: cl

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d314ee57097: [clangd] Add a way to enable IncludeCleaner through config (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111870/new/ h

[PATCH] D112447: [clangd] IncludeCleaner: Support macros

kbobyrev updated this revision to Diff 382277. kbobyrev added a comment. Skip the tokens that are not identifiers or weren't defined as macros, attach tracer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112447/new/ https://reviews.llvm.org/D11244

[PATCH] D112447: [clangd] IncludeCleaner: Support macros

kbobyrev updated this revision to Diff 382278. kbobyrev added a comment. Rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112447/new/ https://reviews.llvm.org/D112447 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang

[PATCH] D112447: [clangd] IncludeCleaner: Support macros

kbobyrev updated this revision to Diff 382358. kbobyrev added a comment. Add an elaborate comment on potential future improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112447/new/ https://reviews.llvm.org/D112447 Files: clang-tools-ext

[PATCH] D112571: [clangd] IncludeCleaner: Don't warn on system headers

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is a temporary hack to dis

[PATCH] D112447: [clangd] IncludeCleaner: Support macros

kbobyrev updated this revision to Diff 382549. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112447/new/ https://reviews.llvm.org/D112447 Files: clang-

[PATCH] D112447: [clangd] IncludeCleaner: Support macros

kbobyrev updated this revision to Diff 382550. kbobyrev added a comment. Use IncludeCleaner to clean the includes and clean up a little. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112447/new/ https://reviews.llvm.org/D112447 Files: clang-tool

[PATCH] D112447: [clangd] IncludeCleaner: Support macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3c6090e5976: [clangd] IncludeCleaner: Support macros (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D112608: [clangd] IncludeCleaner: Do not process locations in built-in files

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Doing otherwise leads to crashi

[PATCH] D112571: [clangd] IncludeCleaner: Don't warn on system headers

kbobyrev updated this revision to Diff 382576. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112571/new/ https://reviews.llvm.org/D112571 Files: clang-t

[PATCH] D112571: [clangd] IncludeCleaner: Don't warn on system headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4723785c190: [clangd] IncludeCleaner: Don't warn on system headers (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D112608: [clangd] IncludeCleaner: Do not process locations in built-in files

kbobyrev updated this revision to Diff 382608. kbobyrev added a comment. Also handle the Command-Line defines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112608/new/ https://reviews.llvm.org/D112608 Files: clang-tools-extra/clangd/IncludeClea

[PATCH] D112608: [clangd] IncludeCleaner: Do not process locations in built-in files

kbobyrev updated this revision to Diff 382713. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112608/new/ https://reviews.llvm.org/D112608 Files: clang-

[PATCH] D112608: [clangd] IncludeCleaner: Do not process locations in built-in files

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp:245 +int y = CLI; + kadircet wrote: > you can change this to `int y = CLI + __llvm__` to explicitly check for both > CLI and built-in macros. Ahh, that's

[PATCH] D112608: [clangd] IncludeCleaner: Do not process locations in built-in files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG22079c61a823: [clangd] IncludeCleaner: Do not process locations in built-in files (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHA

[PATCH] D112608: [clangd] IncludeCleaner: Do not process locations in built-in files

kbobyrev added a comment. In D112608#3090910 , @sammccall wrote: > Sorry to be late to the party, just some efficiency concerns No problem, thank you for the comments, I'll send a follow-up! Comment at: clang-tools-extra/clangd/Includ

[PATCH] D112608: [clangd] IncludeCleaner: Do not process locations in built-in files

kbobyrev added a comment. In D112608#3090971 , @sammccall wrote: > I'll try some things out and send a patch... Oh, okay, I won't do mine then to avoid crashing into each other. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D112652: [clangd] Avoid expensive checks of buffer names in IncludeCleaner

kbobyrev added a comment. Thank you for taking care of this! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:261 +if (!FE) { + assert(isSpecialBuffer(FID, SM)); + continue; Implementation-wise, this seems like the right place to drop nonex

[PATCH] D112652: [clangd] Avoid expensive checks of buffer names in IncludeCleaner

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112652/new/ https://reviews.llvm.org/D112652 __

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Headers without include guards

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 382955. kbobyrev added a comment. Update the docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-tools

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev planned changes to this revision. kbobyrev added a comment. Aww, I think this is the wrong place to do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 __

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 382968. kbobyrev added a comment. Put the check into the right place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: clang-tools-extra/clangd/IncludeCleane

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 382969. kbobyrev added a comment. Remove redundant changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: clang-tools-extra/clangd/IncludeCleaner.cpp cl

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 382970. kbobyrev added a comment. Revert docs change that is no longer true. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: clang-tools-extra/clangd/Includ

[PATCH] D112707: [clangd] IncludeCleaner: Be more conservative in marking RecordDecl usage

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. For expression with RecordDecl t

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 383085. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: clang-

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:247 for (const Inclusion &MFI : Structure.MainFileIncludes) { // FIXME: Skip includes that are not self-contained. if (!MFI.HeaderID) { sammccall wrote: > this is

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 383086. kbobyrev added a comment. Remove stale FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-to

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 383250. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: clang-

[PATCH] D112707: [clangd] IncludeCleaner: Be more conservative in marking RecordDecl usage

kbobyrev added a comment. In D112707#3093876 , @sammccall wrote: > What's the purpose of this patch at a high level? Was it triggered by a real > example? > IIUC it's avoiding false negatives, where we're using a class and an > otherwise-unused header f

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 383253. kbobyrev added a comment. Add a header guard in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: clang-tools-extra/clangd/IncludeCleaner.cpp

[PATCH] D112783: [clangd] Track performance of IncludeCleaner

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Mon

[PATCH] D112783: [clangd] Track performance of IncludeCleaner

kbobyrev updated this revision to Diff 383278. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112783/new/ https://reviews.llvm.org/D112783 Files: clang-

[PATCH] D112783: [clangd] Track performance of IncludeCleaner

This revision was automatically updated to reflect the committed changes. Closed by commit rG32f102912493: [clangd] Track performance of IncludeCleaner (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112783/new/ https://reviews

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 383378. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: cl

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf47564ea87a5: [clangd] IncludeCleaner: Skip non self-contained headers (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D113262: [clangd] Allow IncludeCleaner to replace unused header with transitively used

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM

[PATCH] D113262: [clangd] Allow IncludeCleaner to replace unused header with transitively used

kbobyrev planned changes to this revision. kbobyrev added a comment. This is POC, I need to deal with forward decls and definitions from D112707 firs. Otherwise, this introduces too much noise (LLVM really has *lots* of forward decls that make almost no sense).

[PATCH] D113262: [clangd] Allow IncludeCleaner to replace unused header with transitively used

kbobyrev added a comment. Oh, sorry, I marked it as "changes intended" so that you could know it's not review-ready yet :) I was just playing around with it and previewing to see how it would feel to have a somewhat working solution. I didn't really implement the feature (add the proper header

[PATCH] D112707: [clangd] IncludeCleaner: Be more conservative in marking RecordDecl usage

kbobyrev planned changes to this revision. kbobyrev added a comment. Will split the patch in two, as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112707/new/ https://reviews.llvm.org/D112707

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

kbobyrev added a comment. In D96975#2594147 , @njames93 wrote: > Ping Hi Nathan! Thanks again for this patch and sorry for not taking time to review it yet. It is a busy week for me and my team, so I wasn't able to do much coding/reviewing, apologies fo

[PATCH] D97803: [clangd] Overload bundles are only deprecated if each overloads is.

kbobyrev added a comment. So, if my understanding is correct, this will make the whole bundle non-deprecated if at least one overload is not deprecated? This is probably an improvement over the existing behaviour. However, do we maybe want to split the bundles into deprecated and non-deprecated

[PATCH] D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbff7faea2034: [clang-tidy] Add options to describe individual core increments to readability… (authored by massberg, committed by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

kbobyrev added a comment. Thanks! The code looks right, my comments are mostly for the comments around to validate my mental model of the code structure and behavior. Comment at: clang/lib/Sema/SemaExpr.cpp:17413 + StringRef Separator = LSI->NumExplicitCaptures > 0 ? ", " : "

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

kbobyrev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7462 + def note_lambda_default_capture_fixit : Note< +"capture all by %select{value|reference}0">; def note_lambda_decl : Note<"lambda expression begins here">; a

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks for implementing this and apologies for the review delay (was a tough week for me & my team). The code is very easy to follow now and the only suggestions are stylistic nits.

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

kbobyrev added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17447 + if (RD->hasUserDeclaredCopyConstructor()) +for (CXXConstructorDecl *Ctor : RD->ctors()) { + if (Ctor->isCopyConstructor()) (braces are not needed here, too) Re

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

kbobyrev added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17457 + SmallString<32> FixBuffer; + StringRef Separator = LSI->NumExplicitCaptures > 0 ? ", " : ""; + if (Var->getDeclName().isIdentifier() && !Var->getName().empty()) { sammccall wrote:

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

kbobyrev added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17453 +} +return T.isPODType(Sema.getASTContext()); + }(); sammccall wrote: > POD is rarely precisely the right concept (and deprecated for that reason). > Is isTriviallyCopyableType

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev updated this revision to Diff 329312. kbobyrev added a comment. Herald added subscribers: llvm-commits, mgorny. Herald added a project: LLVM. Use reflection, improve message format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98246/new/

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev updated this revision to Diff 329553. kbobyrev marked an inline comment as done. kbobyrev added a comment. Enabled server reflection in https://github.com/llvm/llvm-project/commit/8080ea4c4b8c456c72c617587cc32f174b3105c1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev updated this revision to Diff 329865. kbobyrev marked 8 inline comments as done. kbobyrev added a comment. Address review comments. The current format is "store seconds since X event". Should we store UNIX timestamps instead? This is probably not portable until C++20, so maybe it isn't a

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, mgorny. kbobyrev requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, LLVM. This was original

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kbobyrev updated this revision to Diff 329913. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98404/new/ https://reviews.llvm.org/D98404 Files: clang-to

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/CMakeLists.txt:12 +if (ENABLE_GRPC_REFLECTION) + set(REFLECTION_LIBRARY grpc++_reflection) kadircet wrote: > can we move this piece into FindGRPC.cmake instead? Yes, but I

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kbobyrev updated this revision to Diff 330573. kbobyrev marked an inline comment as done. kbobyrev added a comment. Herald added a project: clang-tools-extra. Add the variable to Features.inc.in and canonicalize. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kbobyrev updated this revision to Diff 330589. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98404/new/ https://reviews.llvm.org/D98404 Files: clang-to

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kbobyrev updated this revision to Diff 330592. kbobyrev added a comment. Include Features.inc in Server.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98404/new/ https://reviews.llvm.org/D98404 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kbobyrev updated this revision to Diff 330675. kbobyrev added a comment. Add explicit CMake option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98404/new/ https://reviews.llvm.org/D98404 Files: clang-tools-extra/clangd/CMakeLists.txt clang-t

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev updated this revision to Diff 330681. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Herald added a project: clang-tools-extra. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98246/new/ https:/

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kbobyrev updated this revision to Diff 330772. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve post-LGTM comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98404/new/ https://reviews.llvm.org/D98404 Files: clang

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9bcf0eff99a0: [clangd] Optionally add reflection for clangd-index-server (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev updated this revision to Diff 330791. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Herald added a subscriber: jfb. Address comments, rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98246/new/ ht

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:308 + .count()); +// FIXME(kirillbobyrev): This is not really "freshness", this is just the +// time since last index reload. kadi

[PATCH] D113889: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/Protocol.h:39 +/* This file is using the LSP syntax for identifier names which is different + from the LLVM coding standard. To avoid the clang-tidy warnings, we're Nit: we're only using C-sty

[PATCH] D97265: [clang] Allow clang-check to customize analyzer output file or dir name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda168dd875bf: [clang] Allow clang-check to customize analyzer output file or dir name (authored by OikawaKirie, committed by kbobyrev). Herald added

[PATCH] D97265: [clang] Allow clang-check to customize analyzer output file or dir name

kbobyrev added a comment. Hey, I'm really sorry, I missed this, too but I just landed the patch for you, apologies for such a huge delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97265/new/ https://reviews.llvm.org/D97265 ___

[PATCH] D113974: [clangd] Put additional qualifiers to enum constants not declared as "enum class"

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is a cheap "fix" of the pro

[PATCH] D113974: [clangd] Put additional qualifiers to enum constants not declared as "enum class"

kbobyrev planned changes to this revision. kbobyrev added a comment. Actually, I'm not sure this change is worth it. Maybe the intent of not having `enum class` is actually making the constants discoverable from the outer scope. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

<    7   8   9   10   11   12   13   14   15   >