kbobyrev marked 9 inline comments as done. kbobyrev added inline comments.
================ Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:215 + D.Message = "Included header is unused"; + D.Name = "clangd-include-cleaner"; + // FIXME: This range should be the whole line with target #include. ---------------- sammccall wrote: > sammccall wrote: > > Source should be `Clangd` I think (our first?). > > > > Name should be something like "unused-include": this doesn't need to echo > > the tool name. > clangd-unused-header -> unused-header > > (there's a test, but it's stale) what do you mean by "stale"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111870/new/ https://reviews.llvm.org/D111870 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
