[PATCH] D90588: [clangd] NFC: Only pass ASTContext and TokenBuffer in getFoldingRanges API

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Follow-up on https://reviews.llvm

[PATCH] D90590: [clangd] Improve remote-index test

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https

[PATCH] D90587: [clangd] Control the delay between index hot reloading in remote-server-index

kbobyrev abandoned this revision. kbobyrev added a comment. As discussed in PM, it probably doesn't make sense right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90587/new/ https://reviews.llvm.org/D90587

[PATCH] D90376: [clangd] Add requests logging to clangd-index-server

kbobyrev abandoned this revision. kbobyrev added a comment. In favor of D90526 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90376/new/ https://reviews.llvm.org/D90376 _

[PATCH] D90376: [clangd] Add requests logging to clangd-index-server

kbobyrev reclaimed this revision. kbobyrev added a comment. Actually, maybe I should just postone and build on top of that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90376/new/ https://reviews.llvm.org/D90376 __

[PATCH] D87831: [clang] Expose helper function to turn PP keywords spelling into PPKeywordKind

kbobyrev planned changes to this revision. kbobyrev added a comment. Herald added a subscriber: dexonsmith. Not needed yet, waiting for myself to start adding some PP-based FoldingRanges to continue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87

[PATCH] D90528: [clangd] Fix check-clangd with no clang built

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90528/new/ https://reviews.llvm.org/D90528 _

[PATCH] D90590: [clangd] Improve remote-index test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0beda1b6661: [clangd] Improve remote-index test (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D90376: [clangd] Add requests logging to clangd-index-server

kbobyrev abandoned this revision. kbobyrev added a comment. Closed in favor of D90654 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90376/new/ https://reviews.llvm.org/D90376 _

[PATCH] D90654: [clangd] Add index server request logging

kbobyrev accepted this revision. kbobyrev added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:257 + + public: +TextProto(const google::protobuf::Message &M) : M(M) {} nit

[PATCH] D90588: [clangd] NFC: Only pass ASTContext and TokenBuffer in getFoldingRanges API

kbobyrev added a comment. In D90588#2368021 , @sammccall wrote: > This doesn't feel quite right to me - we're going to need to get PP > conditional regions, include blocks etc from the ParsedAST (they're not in > ASTContext). > My sense is that we'll nee

[PATCH] D90672: [clang] Simplify buildSyntaxTree API

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Follow-up on https://reviews.llvm.org/D88553#inline-837013 Repository: rG LLVM

[PATCH] D103393: [clangd] Bump recommended gRPC version (1.33.2 -> 1.36.3)

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Context: https://github.com/clan

[PATCH] D103393: [clangd] Bump recommended gRPC version (1.33.2 -> 1.36.3)

kbobyrev added a comment. I don't really know if we should do this before the buildbot update so I just wanted to know your opinion @kadircet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103393/new/ https://reviews.llvm.org/D103393

[PATCH] D103393: [clangd] Bump recommended gRPC version (1.33.2 -> 1.36.3)

kbobyrev planned changes to this revision. kbobyrev added a comment. Makes sense, thanks! Putting this on hold. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103393/new/ https://reviews.llvm.org/D103393

[PATCH] D95336: [clang] NFC: Remove else if after return

kbobyrev created this revision. kbobyrev added reviewers: kadircet, sammccall. kbobyrev requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update the code to be compatible with LLVM Coding Guidelines. Repository: rG LLVM Github Monorepo h

[PATCH] D95336: [clang] NFC: Remove else if after return

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e5d41a68255: [clang] NFC: Remove else if after return (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D95450: [clangd] Respect ReferencesParams.context.includeDeclarations

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thanks, LGTM with a couple of nits. Comment at: clang-tools-extra/clangd/XRefs.h:23 #include "clang/AST/Type.h" +#include "clang/Basic/BitmaskEnum.h" #include "clang/Fo

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This patch allows detecting conflict

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321050. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95925/new/ https://reviews.llvm.org/D95925 Files: clang-to

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:339 + if (const auto *If = ParentNode->get()) +if (const auto *Then = dyn_cast(If->getThen())) + EnclosingScope = Then; hokein wrote: > thinking more about the `if`

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321052. kbobyrev added a comment. Save few LOCs by checking for nullptr in CheckDeclStmt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95925/new/ https://reviews.llvm.org/D95925 Files: clang-tools-extra/cl

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321053. kbobyrev added a comment. Don't spell out DynTypedNodeList and don't include ParentMapContext.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95925/new/ https://reviews.llvm.org/D95925 Files: clang-

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321055. kbobyrev added a comment. Revert last change: leads to incomplete types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95925/new/ https://reviews.llvm.org/D95925 Files: clang-tools-extra/clangd/refa

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321086. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Resolve most comments but one: some comments & examples in the code incoming in the next diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:355 + // This helper checks if there is a condition variable has NewName. + auto CheckConditionVariable = [&](const auto *Scope) -> const NamedDecl * { +if (!Scope) hok

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321095. kbobyrev marked an inline comment as done. kbobyrev added a comment. Add comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95925/new/ https://reviews.llvm.org/D95925 Files: clang-tools-extra/c

[PATCH] D89870: [clangd] Drop template argument lists from completions followed by

kbobyrev added a comment. @sammccall Ping, this is a real patch :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89870/new/ https://reviews.llvm.org/D89870 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321334. kbobyrev marked 5 inline comments as done and an inline comment as not done. kbobyrev added a comment. Fix a couple problems pointed out during the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:334 + DynTypedNodeList Parents(DynTypedNode::create(RenamedDecl)); + auto GetSingleParent = [&](DynTypedNode Node) -> const DynTypedNode * { +Parents = Ctx.getParents(Node); ---

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321336. kbobyrev marked an inline comment as done. kbobyrev added a comment. Pass const ref to DynTypedNode in helper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95925/new/ https://reviews.llvm.org/D95925

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5eec9a380a24: [clangd] Detect rename conflicits within enclosing scope (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D96009: [clangd] Improve name conflict detection

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Follow-up on D95925

[PATCH] D96009: [clangd] Improve name conflict detection

kbobyrev updated this revision to Diff 321398. kbobyrev marked an inline comment as done. kbobyrev added a comment. Use FunctionProtoTypeLoc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96009/new/ https://reviews.llvm.org/D96009 Files: clang-to

[PATCH] D96009: [clangd] Improve name conflict detection

kbobyrev updated this revision to Diff 321545. kbobyrev added a comment. Can't instantiate DynTypedNode with FunctionProtoTypeLoc, has to be just TypeLoc :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96009/new/ https://reviews.llvm.org/D96009

[PATCH] D96009: [clangd] Improve name conflict detection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe8a2b7c91563: [clangd] Improve name conflict detection (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D96247: [clangd] Fix false positive in local rename collision detetction

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clan

[PATCH] D96247: [clangd] Fix false positive in local rename collision detetction

kbobyrev updated this revision to Diff 322045. kbobyrev added a comment. Fix comment formatting in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96247/new/ https://reviews.llvm.org/D96247 Files: clang-tools-extra/clangd/refactor/Rename

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 374174. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Improve structure, address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D1081

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev added a comment. Hey, sorry for the gigantic turn around. I still need to cover the code with few tests and polish it a bit more but I've updated the majority of it and pushed to get some early feedback before I do that. Please let me know if you have any concerns/see some problems wit

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 374219. kbobyrev added a comment. Populate Inclusion.ID, add a test (failing for now). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/cla

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 374226. kbobyrev added a comment. Make sure FileEntry* is not nullptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/clangd/Headers.cpp

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 374469. kbobyrev added a comment. Perform the computation in the IncludeStructure::File space. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-e

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Preparation for D108194

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev updated this revision to Diff 374806. kbobyrev marked 9 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.llvm.org/D110386 Files: clang-

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev updated this revision to Diff 374807. kbobyrev added a comment. s/ToVector/Flatten/g Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.llvm.org/D110386 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-too

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev updated this revision to Diff 374841. kbobyrev added a comment. Update non-working test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.llvm.org/D110386 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev added a comment. I resolved the comments we discussed offline, there's a weird SIGSEGV (out of boundary error) somewhere in the tests but it looks fine otherwise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.l

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev updated this revision to Diff 374853. kbobyrev added a comment. Herald added a subscriber: mgrang. Fix the last failing test. All tests are green now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.llvm.org/D1103

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev updated this revision to Diff 374863. kbobyrev added a comment. Clean tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.llvm.org/D110386 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev updated this revision to Diff 375149. kbobyrev marked 9 inline comments as done. kbobyrev added a comment. Resolve all review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.llvm.org/D110386 Files: cl

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev updated this revision to Diff 375151. kbobyrev added a comment. Rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.llvm.org/D110386 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-t

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 375153. kbobyrev added a comment. Prepare for rebase: revert Headers.cpp and Headers.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/cla

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 375154. kbobyrev added a comment. Rebase on top of D110386 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-e

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev updated this revision to Diff 375237. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Resolve all but two comments, leave the clarification questions for these two. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/n

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:205 CurrentLevel.push_back(Child); - const auto &Name = RealPathNames[Child]; // Can't include files if we don't have their real path. + if (!RealPathNames[sta

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev updated this revision to Diff 375253. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Switch to full DenseMap comparison in the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.llvm.org/

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:205 CurrentLevel.push_back(Child); - const auto &Name = RealPathNames[Child]; // Can't include files if we don't have their real path. + if (!RealPathNames[sta

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/HeadersTests.cpp:234 + auto Includes = collectIncludes(); + EXPECT_THAT(Includes.IncludeChildren[getID(MainFile)], + UnorderedElementsAreArray({getID(FooHeader), getID(BarHeader)})); ---

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev updated this revision to Diff 375277. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve the last comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.llvm.org/D110386 Files: clang-

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b1eff1bc5d0: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations (authored by kbobyrev). Repository: rG LLVM Github Mon

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 376425. kbobyrev added a comment. Rebase on top of main. Now ready for a review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/clangd/In

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 376430. kbobyrev added a comment. Fix the rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-tools-e

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 376431. kbobyrev added a comment. Tiny refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-tool

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, llvm-commits, MaskRay, ilya-biryukov. Herald added projects: LLVM, clang-tool

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

kbobyrev updated this revision to Diff 376488. kbobyrev added a comment. Get rid of SM in getOrCreateID & getID Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110925/new/ https://reviews.llvm.org/D110925 Files: clang-tools-extra/clangd/CodeComple

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

kbobyrev updated this revision to Diff 376811. kbobyrev marked 9 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110925/new/ https://reviews.llvm.org/D110925 Files: clang-

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

kbobyrev added inline comments. Comment at: llvm/include/llvm/Support/FileSystem/UniqueID.h:17 +#include "llvm/ADT/DenseMap.h" #include sammccall wrote: > you only need DenseMapInfo here I think I do need utility because I'm using `std::pair` Repository:

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

This revision was automatically updated to reflect the committed changes. Closed by commit rGb06df223826e: [clangd] Follow-up on rGdea48079b90d (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110925/new/ https://reviews.llvm.or

[PATCH] D110600: [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column from relative path

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110600/new/ https://reviews.llvm.org/D110600 _

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 377112. kbobyrev added a comment. Rebase on top of landed patches. Ping, @sammccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/clang

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 377125. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 377158. kbobyrev added a comment. Refactor FileID -> IncludeStructure::HeaderID into a separate function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: cl

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 377197. kbobyrev marked 10 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 377264. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Thank you for the review! Looks much better now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/

[PATCH] D96324: [clangd] Rename references to function arguments within the same file

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This is a fix of the problem (rather than a pa

[PATCH] D96324: [clangd] Rename references to function arguments within the same file

kbobyrev updated this revision to Diff 322321. kbobyrev added a comment. Implement constructors handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96324/new/ https://reviews.llvm.org/D96324 Files: clang-tools-extra/clangd/refactor/Rename.cp

[PATCH] D96324: [clangd] Rename references to function arguments within the same file

kbobyrev added a comment. This likely needs some further thought on conflict detection. Assume we have void foo(int Argument^); // case 1 void foo(int OhWait); // case 2 void foo(int Argument); // case 3 void foo(int AnotherOne) {} // case 4 What should we do when renaming `Argument`?

[PATCH] D96247: [clangd] Fix false positive in local rename collision detetction

kbobyrev updated this revision to Diff 322323. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96247/new/ https://reviews.llvm.org/D96247 Files: clang-too

[PATCH] D96247: [clangd] Fix false positive in local rename collision detetction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb60428c7ea68: [clangd] Fix false positive in local rename collision detetction (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D96324: [clangd] Rename references to function arguments within the same file

kbobyrev updated this revision to Diff 322382. kbobyrev added a comment. Rebase on top of D96247 , check for conflicts in specialization bodies. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96324/new/ https://revi

[PATCH] D96017: [clang-check] Add tokens-dump in clang-check.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96017/new/ https://reviews.llvm.org/D96017 __

[PATCH] D96324: [clangd] Rename references to function arguments within the same file

kbobyrev added a comment. @sammccall this is the argument renaming diff I was talking about during the standup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96324/new/ https://reviews.llvm.org/D96324 _

[PATCH] D96112: [Syntax] No crash on OpaqueValueExpr.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Sorry for the delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96112/new/ https://reviews.llvm.org/D96112 __

[PATCH] D89870: [clangd] Drop template argument lists from completions followed by

kbobyrev updated this revision to Diff 324386. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89870/new/ https://reviews.llvm.org/D89870 Files: clang-to

[PATCH] D89870: [clangd] Drop template argument lists from completions followed by

kbobyrev updated this revision to Diff 324593. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89870/new/ https://reviews.llvm.org/D89870 Files: clang-too

[PATCH] D89870: [clangd] Drop template argument lists from completions followed by

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19db870a0dd1: [clangd] Drop template argument lists from completions followed by < (authored by kbobyrev). Repository: rG LLVM Github Monorepo CH

[PATCH] D92220: [clangd] Add support for static fields in rename

kbobyrev abandoned this revision. kbobyrev added a comment. Yeah this does indeed already work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92220/new/ https://reviews.llvm.org/D92220 ___ cfe-commits ma

[PATCH] D103393: [clangd] Bump recommended gRPC version (1.33.2 -> 1.36.3)

This revision was not accepted when it landed; it landed in state "Changes Planned". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd12000ca55d1: [clangd] Bump recommended gRPC version (1.33.2 ->

[PATCH] D107047: [clangd] Fix the crash in getQualification

kbobyrev updated this revision to Diff 363383. kbobyrev added a comment. Add test, improve docs in code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107047/new/ https://reviews.llvm.org/D107047 Files: clang-tools-extra/clangd/AST.cpp clang-t

[PATCH] D106645: [clangd] Tweak constructor of dex AndIterator for performance.

kbobyrev requested changes to this revision. kbobyrev added a comment. This revision now requires changes to proceed. As discussed offline, does not yield performance improvements. Putting on "Request Changes" so that I don't miss ongoing reviews (please let me know if that's OK with you). Rep

[PATCH] D106640: [clangd] Make dex iterator peek() and reachedEnd() nonvirtual

kbobyrev requested changes to this revision. kbobyrev added a comment. This revision now requires changes to proceed. Ditto (previous performance improvement attempt). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106640/new/ https://reviews.llvm.o

[PATCH] D107047: [clangd] Fix the crash in getQualification

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0f2d4af031c: [clangd] Fix the crash in getQualification (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106792/new/ https://reviews.llvm.org/D106792

[PATCH] D105426: [clangd] WIP: Unused header warnings

kbobyrev updated this revision to Diff 364413. kbobyrev added a comment. Significantly decrease the scope of this change. Focus on "IWYU as a library", do not propagate into the other parts of clangd yet and keep the change self-contained for the most part. Repository: rG LLVM Github Monorepo

[PATCH] D105426: [clangd] WIP: Unused header warnings

kbobyrev updated this revision to Diff 364526. kbobyrev added a comment. Trim the patch even further: only extract locations, prune header marking logic etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llvm.org/D105426

[PATCH] D105426: [clangd] WIP: Unused header warnings

kbobyrev updated this revision to Diff 364610. kbobyrev added a comment. Trim the patch even further: the scope is now simply findAllReferences mechanism. Add more tests and improve functionality (handle using decls and implicit types). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D105426: [clangd] WIP: Unused header warnings

kbobyrev updated this revision to Diff 364615. kbobyrev added a comment. Add one more test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llvm.org/D105426 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-e

[PATCH] D105426: [clangd] WIP: Unused header warnings

kbobyrev updated this revision to Diff 364625. kbobyrev added a comment. Exclude std:: namespace handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llvm.org/D105426 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D105426: [clangd] IWYU as a library: Find all references to symbols in the file

kbobyrev updated this revision to Diff 364709. kbobyrev added a comment. Improve comments, refactor some pieces, add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llvm.org/D105426 Files: clang-tools-extra/

<    6   7   8   9   10   11   12   13   14   15   >