[PATCH] D58341: [clangd] Index UsingDecls

kadircet updated this revision to Diff 187376. kadircet marked an inline comment as done. kadircet added a comment. - Revert last change Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58341/new/ https://reviews.llvm.org/D58341 Files: unittests/cla

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

kadircet updated this revision to Diff 187528. kadircet marked 2 inline comments as done. kadircet added a comment. - Move `handleDecl` call to top of the loop Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58293/new/ https://reviews.llvm.org/D58293 Files: incl

[PATCH] D58133: [clangd] Testcase for bug 39811

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL354442: [clangd] Testcase for bug 39811 (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added

[PATCH] D58447: [clangd] Fix a crash in Selection

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58447/new/ https://reviews.llvm.org/D58447 ___

[PATCH] D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/index/BackgroundIndexStorage.cpp:75 llvm::SmallString<128> CDBDirectory(Directory); -llvm::sys::path::append(CDBDire

[PATCH] D58492: [clangd] Add thread priority lowering for MacOS as well

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D58492 Files: clangd/Threading.cpp Index: clangd/T

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

kadircet updated this revision to Diff 187738. kadircet added a comment. - Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58293/new/ https://reviews.llvm.org/D58293 Files: include/clang/Index/IndexingAction.h lib/Index/IndexDecl.cpp lib/Index/IndexSy

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

This revision was automatically updated to reflect the committed changes. Closed by commit rC354560: [clang][Index] Enable indexing of Template Type Parameters behind a flag (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58293?vs=187738&id=187739#toc

[PATCH] D58294: [clangd] Enable indexing of template type parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354561: [clangd] Enable indexing of template type parameters (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58294?vs=187371&id=187741#toc Repository: rCTE

[PATCH] D58495: [clangd] Only report explicitly typed symbols during code navigation

kadircet created this revision. kadircet added reviewers: ilya-biryukov, sammccall. Herald added subscribers: cfe-commits, arphaman, mgrang, jkorous, MaskRay, ioeric. Herald added a project: clang. Clangd was reporting implicit symbols, like results of implicit cast expressions during code naviga

[PATCH] D58495: [clangd] Only report explicitly typed symbols during code navigation

kadircet updated this revision to Diff 187778. kadircet marked 2 inline comments as done. kadircet added a comment. - Add more test cases - Get rid of number of parameters check in implicitness control Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58

[PATCH] D58495: [clangd] Only report explicitly typed symbols during code navigation

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: unittests/clangd/XRefsTests.cpp:469 auto AST = TestTU::withCode(T.code()).build(); // Ordered assertions are deliberate: we expect a predictable order. + EXPECT_THAT(locateSymbolAt(AST,

[PATCH] D58495: [clangd] Only report explicitly typed symbols during code navigation

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354585: [clangd] Only report explicitly typed symbols during code navigation (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58495?vs=187786&id=187788#toc Re

[PATCH] D58495: [clangd] Only report explicitly typed symbols during code navigation

kadircet updated this revision to Diff 187786. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58495/new/ https://reviews.llvm.org/D58495 Files: clangd/XRefs.cp

[PATCH] D58492: [clangd] Add thread priority lowering for MacOS as well

kadircet added a comment. This one was used in a few different places in clang, for ex: https://github.com/llvm-mirror/clang/blob/master/tools/libclang/CIndex.cpp#L8713. Therefore I've used the same funcitonality. Regarding `pthread_setschedparam` does setting prioirty to `PTHREAD_MIN_PRIORITY

[PATCH] D58492: [clangd] Add thread priority lowering for MacOS as well

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clangd/Threading.cpp:125 +#elif defined(__APPLE__) + // https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man2/getpriority.2.html + setpriority(PR

[PATCH] D58492: [clangd] Add thread priority lowering for MacOS as well

kadircet updated this revision to Diff 187908. kadircet marked an inline comment as done. kadircet added a comment. - Add required header Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58492/new/ https://reviews.llvm.org/D58492 Files: clangd/Threa

[PATCH] D58492: [clangd] Add thread priority lowering for MacOS as well

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354765: [clangd] Add thread priority lowering for MacOS as well (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58492?vs=187908&id=188106#toc Repository: r

[PATCH] D58541: [CodeComplete] Propagate preferred type for function arguments in more cases

kadircet added inline comments. Herald added a subscriber: Charusso. Comment at: clang/include/clang/Sema/Sema.h:294 + /// function_ref, clients should make sure all calls to get() with the same + /// location happen while function_ref is alive. + void enterFunctionArgument(So

[PATCH] D58341: [clangd] Index UsingDecls

kadircet updated this revision to Diff 188170. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58341/new/ https://reviews.llvm.org/D58341 Files: unittests/clang

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

kadircet updated this revision to Diff 188171. kadircet added a comment. - Add SymbolSubKind for UsingDeclarations Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58340/new/ https://reviews.llvm.org/D58340 Files: include/clang/Index/IndexSymbol.h lib/Index/Ind

[PATCH] D59407: [clangd] Add RelationSlab

kadircet accepted this revision. kadircet added a comment. Still LG, thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59407/new/ https://reviews.llvm.org/D59407 ___ cfe-commits maili

[PATCH] D62471: [clangd] SymbolCollector support for relations

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:298 + + processRelations(*ND, *ID, Relations); + nridge wrote: > kadircet wrote: > > why do we want to process these relations for references? > The `RelationBaseOf` i

[PATCH] D62459: [clangd] Serialization support for RelationSlab

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LG, thanks for the patch! Comment at: clang-tools-extra/clangd/index/Serialization.cpp:34 + switch (Role) { + case index::SymbolRole::RelationBaseOf: { +return Rela

[PATCH] D62471: [clangd] SymbolCollector support for relations

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! I suppose there are only two patches left now? - Exposing relations in `SymbolIndex`. - Implementing children resolution using that information. Repository: rG LLVM Githu

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Some custom toolchains come with their own header files and compiler drivers. Those compiler drivers implicitly kn

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet created this revision. kadircet added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62814 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet updated this revision to Diff 202739. kadircet added a comment. - Get rid of wrong check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62814/new/ https://reviews.llvm.org/D62814 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-ex

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet updated this revision to Diff 202870. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments - Handle pointer/reference types to lambdas Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62814/new/ https://revi

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet added a comment. Nice catch! I think it makes sense to show signature in those cases as well. Updating according to that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62814/new/ https://reviews.llvm.org/D62814 _

[PATCH] D62839: [WIP] [clangd] Index API and implementations for relations

kadircet added a comment. In D62839#1528597 , @nridge wrote: > For relations, should we include a copy in both the file containing the > definition of the subject, and (if different) the file containing the > definition of the object? The point of shar

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet updated this revision to Diff 202888. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62814/new/ https://reviews.llvm.org/D62814 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/cl

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet marked 4 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:819 )cpp", [](HoverInfo &HI) { HI.NamespaceScope = ""; sammccall wrote: > I'm slightly nervous abou

[PATCH] D62856: [clangd] Also apply adjustArguments when returning fallback commands

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62856 Files: clang-tools-extra/clangd/GlobalCompilationDat

[PATCH] D62856: [clangd] Also apply adjustArguments when returning fallback commands

This revision was automatically updated to reflect the committed changes. Closed by commit rL362496: [clangd] Also apply adjustArguments when returning fallback commands (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet updated this revision to Diff 202933. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62814/new/ https://reviews.llvm.org/D62814 Files: clang-tools-ex

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:831 + }; return HI; }}, ilya-biryukov wrote: > kadircet wrote: > > ilya-biryukov wrote: > > > Could you add another test with even weirder type

[PATCH] D62965: [clang][HeaderSearch] Consider all path separators equal

kadircet created this revision. kadircet added reviewers: ilya-biryukov, sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62965 Files: clang/lib/Lex/HeaderSearch.cpp clang/unittests/Lex/HeaderSea

[PATCH] D62965: [clang][HeaderSearch] Consider all path separators equal

kadircet updated this revision to Diff 203399. kadircet marked an inline comment as done. kadircet added a comment. - Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62965/new/ https://reviews.llvm.org/D62965 Files: clang/lib/Lex/He

[PATCH] D62839: [clangd] Index API and implementations for relations

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:293 + // This map is used to figure out where to store relations. + llvm::DenseMap IDsToFiles; for (const auto &Sym : *Index.Symbols) { nit: rename to `SymbolIDToFile`?

[PATCH] D62965: [clang][HeaderSearch] Consider all path separators equal

This revision was automatically updated to reflect the committed changes. Closed by commit rL362731: [clang][HeaderSearch] Consider all path separators equal (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet updated this revision to Diff 203533. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62814/new/ https://reviews.llvm.org/D62814 Files: clang-tools-ex

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:831 + }; return HI; }}, ilya-biryukov wrote: > kadircet wrote: > > ilya-biryukov wrote: > > > kadircet wrote: > > > > ilya-biryukov wrote: > >

[PATCH] D62839: [clangd] Index API and implementations for relations

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:202 + for (const auto &RelationSlab : RelationSlabs) { +for (const auto &R : *RelationSlab) { + AllRelations.push_back(R); ---

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

kadircet updated this revision to Diff 204066. kadircet marked 27 inline comments as done. kadircet added a comment. Herald added a subscriber: mgorny. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62804/new/ https://reviews.llvm

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

kadircet added a comment. In D62804#1533710 , @ilya-biryukov wrote: > Could you give more context on what the custom toolchains are? > One feasible alternative is to move this detection to clang's driver (where > the rest of include path detection lives

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

kadircet updated this revision to Diff 204243. kadircet added a comment. - Fix off-by-one bug and improve lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62804/new/ https://reviews.llvm.org/D62804 Files: clang-tools-extra/clangd/CMakeList

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

kadircet added a comment. In D62804#1538202 , @ilya-biryukov wrote: > In D62804#1538155 , @kadircet wrote: > > > For example a gcc cross compiling to arm comes with its own system includes > > and has some mechani

[PATCH] D63194: [clangd] Link in target infos and pass target and mode while invoking driver

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, mgorny. Herald added a project: clang. This enables clangd to pick up default include search and predefines for toolchains defined in clang. Repository:

[PATCH] D63194: [clangd] Link in target infos and pass target and mode while invoking driver

kadircet updated this revision to Diff 204278. kadircet marked 3 inline comments as done. kadircet added a comment. - Add comments to the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63194/new/ https://reviews.llvm.org/D63194 Files: clang-

[PATCH] D63194: [clangd] Link in target infos and pass target and mode while invoking driver

kadircet added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:36 Cmd.CommandLine = ArgsAdjuster(Cmd.CommandLine, Cmd.Filename); + tooling::addTargetAndModeForProgramName(Cmd.CommandLine, Cmd.CommandLine[0]); // Inject the resource dir.

[PATCH] D62839: [clangd] Index API and implementations for relations

kadircet added a comment. LGTM, except the batch query support. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:97 + +SymbolSlab indexHeaderSymbols(ASTContext &AST, std::shared_ptr PP, + const CanonicalIncludes &Includes) { ---

[PATCH] D58880: [clangd] Type hierarchy subtypes

kadircet added a comment. mostly LG, thanks! Comment at: clang-tools-extra/clangd/XRefs.cpp:1057 + auto &CD = S.Definition ? S.Definition : S.CanonicalDeclaration; + Start.line = CD.Start.line(); + Start.character = CD.Start.column(); nit: could we directly

[PATCH] D63222: [Clangd] Fixed clangd diagnostics priority

kadircet added a comment. Mostly LG, just a few re-orderings to make code more readable and get rid of redundant Lexer calls. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:108 + // Otherwise use zero width insertion range auto R = Lexer::makeFileCharRange(CharSource

[PATCH] D62839: [clangd] Index API and implementations for relations

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Index.h:77 +struct RelationsRequest { + SymbolID Subject; + index::SymbolRole Predicate; nridge wrote: > kadircet wrote: > > sorry for missing it in previous iteration. but this should a

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL363237: [clangd] Treat lambdas as functions when preparing hover response (authored by kadircet, committed by ). Herald ad

[PATCH] D63222: [Clangd] Fixed clangd diagnostics priority

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Also please make sure you've clang-formatted the code before you land this. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:94 } llvm::Optional

[PATCH] D63194: [clangd] Link in target infos and pass target and mode while invoking driver

kadircet added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:36 Cmd.CommandLine = ArgsAdjuster(Cmd.CommandLine, Cmd.Filename); + tooling::addTargetAndModeForProgramName(Cmd.CommandLine, Cmd.CommandLine[0]); // Inject the resource dir.

[PATCH] D63194: [clangd] Link in target infos and pass target and mode while invoking driver

kadircet updated this revision to Diff 204484. kadircet marked an inline comment as done. kadircet added a comment. - Move target name deduction into Driver Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63194/new/ https://reviews.llvm.org/D63194 F

[PATCH] D63222: [Clangd] Fixed clangd diagnostics priority

This revision was automatically updated to reflect the committed changes. Closed by commit rL363253: [Clangd] Fixed clangd diagnostics priority (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[PATCH] D63264: [clang][Driver] Deduce target triplet from clang executable name

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added a project: clang. Herald added a subscriber: cfe-commits. kadircet added a child revision: D63194: [clangd] Link in target infos and pass target and mode while invoking driver. Herald added a subscriber: ormris.

[PATCH] D63194: [clangd] Link in target infos and pass target and mode while invoking driver

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1055 + else if (ClangNameParts.TargetIsValid) +TargetTriple = ClangNameParts.TargetPrefix; + ilya-biryukov wrote: > I strongly think the driver

[PATCH] D63270: [clangd] Add include-mapping for C symbols.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/include-mapping/cppreference_parser.py:1 -#!/usr/bin/env python -#===- gen_std.py - --*- python -*--===# could we add a similar License and header comme

[PATCH] D63295: [clang][HeaderSearch] Shorten paths for includes in mainfile's directory

kadircet created this revision. kadircet added a reviewer: gribozavr. Herald added subscribers: cfe-commits, arphaman, jkorous. Herald added a project: clang. Currently HeaderSearch only looks at SearchDir's passed into it, but in addition to those paths headers can be relative to including file's

[PATCH] D63316: [clangd] Include the diagnostics's code when comparing diagnostics

kadircet added a comment. Could you also add a lit test for the case you mentioned in the github issue? You can find pointers in clang-tools-extra/clangd/test/diagnostics.test and clang-tools-extra/clangd/test/fixits-codeaction.test Comment at: clang-tools-extra/clangd/Protoc

[PATCH] D58880: [clangd] Type hierarchy subtypes

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM with a few small comments. Thanks for implementing this awesome feature! Comment at: clang-tools-extra/clangd/FindSymbols.cpp:42 +llvm::Optional symbolToLocation(

[PATCH] D62839: [clangd] Index API and implementations for relations

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62839/new/ https://reviews.llvm.org/D62839 __

[PATCH] D63270: [clangd] Add include-mapping for C symbols.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/include-mapping/gen_std.py:95 - parse_pages = [ -(cpp_root, "symbol_index.html", "std::"), -# std sub-namespace symbo

[PATCH] D63323: [clangd] Don't maintain a list of c-family extensions in vscode extension.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. could you also bump the version numbers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63323/new/ https://reviews.llvm.org/D63323 ___

[PATCH] D63330: [clangd] Add Value field to HoverInfo

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Put a symbols value information which is deduced from initializer expression into HoverInfo struct. Repository:

[PATCH] D63397: [clangd] Detect C++ for extension-less source files in vscode extension

kadircet added a comment. Could you also update summary to include a link to documentation regarding `contributes.languages` ? Comment at: clang-tools-extra/clangd/clients/clangd-vscode/package.json:55 +"id": "cpp", +"firstLine": ".*-\\*-\\s*C\\+\\+\\s*

[PATCH] D63316: [clangd] Include the diagnostics's code when comparing diagnostics

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM with one more test case request. Thanks! Comment at: clang-tools-extra/clangd/test/fixits-duplication.test:44 +--- +{"jsonrpc":"2.0","id":2,"method":"textDocument/co

[PATCH] D63425: [clangd] Perform merge for main file symbols.

kadircet added a comment. We also make use of `PickOne` in `updatePreamble` shouldn't that also cause similar troubles? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63425/new/ https://reviews.llvm.org/D63425 ___

[PATCH] D63330: [clangd] Add Value field to HoverInfo

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:733 +else + Init->printPretty(ValueOS, nullptr, Policy); + } sammccall wrote: > why not print the non-evaluated init if it's dependent? not-necessary anymore, sin

[PATCH] D63330: [clangd] Add Value field to HoverInfo

kadircet updated this revision to Diff 205530. kadircet marked 6 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63330/new/ https://reviews.llvm.org/D63330 Files: clang-tools-ex

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1238 Optional Result = - getTypeAncestors(*CXXRD, AST.getASTContext(), RPSet); + getTypeAncestors(*CXXRD, AST.getASTContext(), RPSet, ResolveParents); if (!Result) havi

[PATCH] D64712: [clangd] Refactor background-index shard loading

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64712 Files: clang-tools-extra/clangd/

[PATCH] D64718: [clangd] Triggering indexing on each translation unit with an error

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Background indexing triggers indexing only on the first TU that includes a stale dependency. This patch extends t

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:83 static bool isExtractableExpr(const clang::Expr *Expr) { if (Expr) { // FIXME: check if we need to cover any other types nit: Could you reduce nes

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:302 void f() { - int a = 5 + [[4 ^* ^xyz^()]]; + int a = 5 + [[4 * [[xyz(); // multivariable initialization kadircet wrote: > how come these ch

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:299 // return statement return ^1; } SureYeaah wrote: > kadircet wrote: > > left out this one ? > Since that's an IntegerLiteral, this patch doesn't a

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:323 while(a < ^1) -^a++; +[[a++]]; // do while SureYeaah wrote: > kadircet wrote: > > I thought extractor didn't handle this case(missing

[PATCH] D64745: [clangd] BackgroundIndex stores shards to the closest project

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Changes persistance logic to store shards at the directory of closest CDB. Previously we were storing all shards t

[PATCH] D58710: Added more detailed documentation for clangd

kadircet added inline comments. Comment at: clang-tools-extra/trunk/docs/clangd/Installation.rst:325 + + $ ln -s ~/myproject/compile_commands.json ~/myproject-build/ + thakis wrote: > Isn't the order of the arguments the wrong way round here? yeah that seems to

[PATCH] D64789: [clangd] Handle windows line endings in QueryDriver

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. fixes second case of https://github.com/clangd/clangd/issues/93 Repository: rG LLVM Github Monorepo https://r

[PATCH] D64860: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64860 Files: clang-tools-extra/clangd/GlobalCo

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64613/new/ https://reviews.llvm.org/D64613 __

[PATCH] D64712: [clangd][NFC] Refactor background-index shard loading

kadircet updated this revision to Diff 210303. kadircet added a comment. - As discussed offline, moved the "staleness" detection back to background index - A renaming within Rebuilder, "LoadedTUs -> LoadedShards" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D64789: [clangd] Handle windows line endings in QueryDriver

This revision was automatically updated to reflect the committed changes. Closed by commit rL366320: [clangd] Handle windows line endings in QueryDriver (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D64863: [clangd] Ignore diags from builtin files

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. Herald added a project: clang. This fixes a case where we show diagnostics on arbitrary lines, in an internal codebase. Open for ideas on unittesting this.

[PATCH] D64860: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase

kadircet added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:77 GlobalCompilationDatabase::getFallbackCommand(PathRef File) const { + llvm::SmallString<128> CanonPath(File); + llvm::sys::path::remove_dots(CanonPath, true);

[PATCH] D64860: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase

kadircet updated this revision to Diff 210354. kadircet marked 5 inline comments as done. kadircet added a comment. - Add removeDots helper to FS.h - Revert changes in getFallbackCommands. - Add comments for the reasoning behind removeDots calls. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:195 Intent intent() const override { return Refactor; } + // Compute the extraction context for the Selection + void computeExtractionContext(const SelectionTree::Node *N

[PATCH] D64712: [clangd] Refactor background-index shard loading

kadircet updated this revision to Diff 210511. kadircet marked 13 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64712/new/ https://reviews.llvm.org/D64712 Files: clang-tools-e

[PATCH] D64712: [clangd] Refactor background-index shard loading

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:490 + auto FS = FSProvider.getFileSystem(); + llvm::DenseSet TUsToIndex; + for (auto &SI : Result.Shards) { sammccall wrote: > nit: again, this patch is adding Path/PathR

[PATCH] D64912: [Clangd] Changed ExtractVariable to only work on non empty selections

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/Tweak.h:51 +/// The Length of the selection +unsigned SelectionLength; /// The AST nodes that were selected. maybe expose a `SourceLocation SelectionEnd` ? Repository:

[PATCH] D64912: [Clangd] Changed ExtractVariable to only work on non empty selections

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/Tweak.h:51 +/// The Length of the selection +unsigned SelectionLength; /// The AST nodes that were selected. SureYeaah wrote: > kadircet wrote: > > maybe expose a `SourceLo

[PATCH] D64712: [clangd] Refactor background-index shard loading

kadircet updated this revision to Diff 210541. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64712/new/ https://reviews.llvm.org/D64712 Files: clang-tools-ex

[PATCH] D64712: [clangd] Refactor background-index shard loading

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/BackgroundIndexLoader.cpp:93 + +void BackgroundIndexLoader::load(PathRef MainFile, + BackgroundIndexStorage *Storage) { sammccall wrote: > This handles only

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:208 const SelectionTree::Node *N = Inputs.ASTSelection.commonAncestor(); - if (!N) -return false; - Target = llvm::make_unique(N, SM, Ctx); - return Target->isExtrac

<    2   3   4   5   6   7   8   9   10   11   >