kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:299
// return statement
return ^1;
}
----------------
SureYeaah wrote:
> kadircet wrote:
> > left out this one ?
> Since that's an IntegerLiteral, this patch doesn't apply to it?
nvm this one, it was for "empyt selection triggering" case.
================
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:323
while(a < ^1)
- ^a++;
+ [[a++]];
// do while
----------------
I thought extractor didn't handle this case(missing braces).
What is the extraction in this case? Because if it is
```
auto dummy = a++;
while (a < 1)
dummy++;
```
it is not going to be semantically same.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64717/new/
https://reviews.llvm.org/D64717
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
