Re: [PATCH] D12036: We shouldn't need to pass -fno-strict-aliasing when building clang with clang.

Chris Bieneman writes: > beanz added a comment. > > dblaikie, > > I've run this through check-all with no issues. Might want to bootstrap with sanitizers or something. Strict aliasing related bugs can be subtle. ___ cfe-commits mailing list cfe-commits@

Re: [PATCH] D12036: We shouldn't need to pass -fno-strict-aliasing when building clang with clang.

Chris Bieneman writes: > Ok… I wrote some CMake goop to enable sanitizers on a bootstrap build > (I’ll clean up the patches and send those out separately). check-clang > worked with asan and ubsan enabled. > > Is that sufficient pre-commit testing? Yes, I'd expect that to shake out any problems.

Re: Second Lit tests C++11 compatibility patch: using preprocessor to filter expected-error

"Li, Charles via cfe-commits" writes: > Hi Clang developers, > > We here at Sony are continuing to update the Lit tests for C++ dialects > compatibility. > > Attached is the second patch. (As a reference, here is the link to the > discussion on the previous Lit patch. http://lists.cs.uiuc.edu/pipe

Re: r239883 - Update the intel intrinsic headers to use the target attribute support.

Eric Christopher writes: > There is nothing broken about not having the include guards there, it's just > not helpful. I'm working on the infrastructure for an error if you call a > function from within an incompatible routine at the moment (without > duplicating a lot of code it's actually a bit

Re: [PATCH] D12036: We shouldn't need to pass -fno-strict-aliasing when building clang with clang.

Chris Bieneman writes: > beanz updated this revision to Diff 32349. > beanz added a comment. > > - Adapting to r245255 which exposes a variable in autoconf for which > compiler you are building with. > - Updated the CMake to be more CMake-y > > Note: This has been tested by running a check on a st

Re: Second Lit tests C++11 compatibility patch: using preprocessor to filter expected-error

"Li, Charles" writes: > Hi Richard, > > I have modified the “expected-“ lines as you requested. > > Cheers, > > Charles > > From: meta...@gmail.com [mailto:meta...@gmail.com] On Behalf Of Richard Smith > Sent: Monday, August 17, 2015 5:41 PM > To: Li, Charles > Cc: Justin Bogner; cfe-commits@lists

r245267 - Revert "Generating assumption loads of vptr after ctor call (fixed)"

Author: bogner Date: Tue Aug 18 00:40:20 2015 New Revision: 245267 URL: http://llvm.org/viewvc/llvm-project?rev=245267&view=rev Log: Revert "Generating assumption loads of vptr after ctor call (fixed)" Bootstrap bots were failing: http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_bu

Re: r245264 - Generating assumption loads of vptr after ctor call (fixed)

Piotr Padlewski via cfe-commits writes: > Author: prazek > Date: Mon Aug 17 22:52:00 2015 > New Revision: 245264 > > URL: http://llvm.org/viewvc/llvm-project?rev=245264&view=rev > Log: > Generating assumption loads of vptr after ctor call (fixed) > > Generating call assume(icmp %vtable, %global_vt

Re: r245267 - Revert "Generating assumption loads of vptr after ctor call (fixed)"

Richard Smith writes: > Are you sure it was this change and not r245265? Pretty sure - I ran the crash repro script with tot and it repro'd, then with r245264 reverted and it didn't. That's when I pushed the revert. > On Aug 17, 2015 10:41 PM, "Justin Bogner via cf

Re: r245267 - Revert "Generating assumption loads of vptr after ctor call (fixed)"

Yep, looks like two distinct problems. I'm going to revert r245265 as well and send Piotr the crash repro for the second assertion. Piotr Padlewski writes: > Confirm, the assertions are different from the last one. > > On Mon, Aug 17, 2015 at 11:45 PM, Justin Bogner via cfe-c

Re: [clang-tools-extra] r245434 - [clang-tidy] Add use-nullptr check to clang-tidy.

Alexander Kornienko via cfe-commits writes: > Author: alexfh > Date: Wed Aug 19 08:13:12 2015 > New Revision: 245434 > > URL: http://llvm.org/viewvc/llvm-project?rev=245434&view=rev > Log: > [clang-tidy] Add use-nullptr check to clang-tidy. > > Move UseNullptr from clang-modernize to modernize mod

[clang-tools-extra] r245493 - Revert "[clang-tidy] Add use-nullptr check to clang-tidy."

Author: bogner Date: Wed Aug 19 15:30:07 2015 New Revision: 245493 URL: http://llvm.org/viewvc/llvm-project?rev=245493&view=rev Log: Revert "[clang-tidy] Add use-nullptr check to clang-tidy." The new test is failing on darwin: http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/10

Re: [clang-tools-extra] r245434 - [clang-tidy] Add use-nullptr check to clang-tidy.

Justin Bogner writes: > Alexander Kornienko via cfe-commits writes: >> Author: alexfh >> Date: Wed Aug 19 08:13:12 2015 >> New Revision: 245434 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=245434&view=rev >> Log: >> [clang-tidy] Add use-nullptr check to clang-tidy. >> >> Move UseNullptr fro

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

Locally, it seems to fail two tests now: Failing Tests (2): Clang Tools :: clang-tidy/modernize-use-nullptr-basic.cpp Clang Tools :: clang-tidy/modernize-use-nullptr.cpp I'll poke at it for a minute and see if there's something obvious I can do, but running the run line manually just seem

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

Justin Bogner writes: > Locally, it seems to fail two tests now: > > Failing Tests (2): > Clang Tools :: clang-tidy/modernize-use-nullptr-basic.cpp > Clang Tools :: clang-tidy/modernize-use-nullptr.cpp > > I'll poke at it for a minute and see if there's something obvious I can > do, but ru

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

That didn't work either - both tests are still failing. Alexander Kornienko writes: > Something weird happens with options reading. Submitted a possible workaround > in r245517. > > On Thu, Aug 20, 2015 at 12:48 AM, Justin Bogner wrote: > > Locally, it seems to fail two tests now: > >

Re: r245779 - [modules] Rearrange how redeclaration chains are loaded, to remove a walk over

Richard Smith via cfe-commits writes: > Author: rsmith > Date: Fri Aug 21 20:47:18 2015 > New Revision: 245779 > > URL: http://llvm.org/viewvc/llvm-project?rev=245779&view=rev > Log: > [modules] Rearrange how redeclaration chains are loaded, to remove a walk over > all modules and reduce the numbe

Re: r246027 - Convert a bunch of loops to ranged-for and clean up accordingly.

Eric Christopher via cfe-commits writes: > Author: echristo > Date: Wed Aug 26 03:21:55 2015 > New Revision: 246027 > > URL: http://llvm.org/viewvc/llvm-project?rev=246027&view=rev > Log: > Convert a bunch of loops to ranged-for and clean up accordingly. > > Modified: > cfe/trunk/lib/Basic/Tar

Re: r250470 - Fix the subtarget features required by some x86 builtins.

Hm. Well, supporting both "and" and "or" combinations here sounds like an unpleasant path to go down. I guess the question is, which is weirder? - With fma, we have fma4 which is basically a synonym as far as intrinsics go - some chips have 3-argument versions and some have 4, but I don't thin

Re: r250470 - Fix the subtarget features required by some x86 builtins.

Looks like we'll need "and" for ARM's builtins as well - several require things like neon+fp16 or neon+vfp4. Eric Christopher writes: > Right. My current direction is going to be: > > "foo+bar" we can represent as "and" > "foo,bar" we'll continue to represent as "or" > > this will lead to things

Re: r250473 - Add an error when calling a builtin that requires features that don't

Eric Christopher via cfe-commits writes: > Author: echristo > Date: Thu Oct 15 18:47:11 2015 > New Revision: 250473 > > URL: http://llvm.org/viewvc/llvm-project?rev=250473&view=rev > Log: > Add an error when calling a builtin that requires features that don't > match the feature set of the functio

Re: r250473 - Add an error when calling a builtin that requires features that don't

Eric Christopher writes: > Can't be. We don't know we're going to make the call until we code gen. :) Okay... but then why don't any tests fail with the attached? It looks like it does the right thing in a very cursory test, as well. commit 63d58fd0b4b77c9486901c103ec70c974d0c2553 Author: Justin

Re: r250473 - Add an error when calling a builtin that requires features that don't

Eric Christopher writes: > I'm reasonably certain you forgot to rebuild or ran make test in the wrong > directory. You're right, I did something funny there. Sorry for the noise. > Two reasons: > > a) This is pretty much my first patch. I mean, identical and I tried that. > b) I actually tried t

Re: r251385 - Create undef reference to profile hook symbol

Xinliang David Li via cfe-commits writes: > Author: davidxl > Date: Tue Oct 27 00:15:35 2015 > New Revision: 251385 > > URL: http://llvm.org/viewvc/llvm-project?rev=251385&view=rev > Log: > Create undef reference to profile hook symbol > > Create undef reference to profile hook symbol when > PGO

Re: Porting Clang to a new architecture

Ariel Arelovich via cfe-commits writes: > Great. > > So this is what I wanted to know. I think understand what you are saying. > You are saying that most of the work that I would need to do from the AST > (I'm assuming that this stands from Abstract Syntax Tree) is allready being > done by LLVM an

Re: [PATCH] D11459: [Driver] Fix handling of -fbuiltin/-fcommon when combined with -mkernel

(resending with the list address fixed) John Brawn writes: > john.brawn created this revision. > john.brawn added reviewers: ddunbar, mcrosier. > john.brawn added a subscriber: cfe-commits. > john.brawn set the repository for this revision to rL LLVM. > > -mkernel enables -fno-builtin and -fno-co

r244414 - Revert "[modules] Don't leak -M flags for dependency file generation into the module"

Author: bogner Date: Sun Aug 9 00:40:38 2015 New Revision: 244414 URL: http://llvm.org/viewvc/llvm-project?rev=244414&view=rev Log: Revert "[modules] Don't leak -M flags for dependency file generation into the module" This was failing tests on a bunch of bots: http://lab.llvm.org:8011/builders

Re: r244412 - [modules] Don't leak -M flags for dependency file generation into the module

Richard Smith via cfe-commits writes: > Author: rsmith > Date: Sat Aug 8 21:44:20 2015 > New Revision: 244412 > > URL: http://llvm.org/viewvc/llvm-project?rev=244412&view=rev > Log: > [modules] Don't leak -M flags for dependency file generation into the module > build process when we implicitly b

Re: r276716 - [Coverage] Do not write out coverage mappings with zero entries

Vedant Kumar via cfe-commits writes: > Hi Justin, > > Could you take a look at this code coverage fix? > > It skips visiting decls if they would require context from system headers to > present properly. This prevents us from writing out an empty coverage mapping > for the lambda in `assert([] { r

Re: [PATCH] D16896: [CMake] Improve the clang order-file generation workflow

Chris Bieneman writes: > beanz created this revision. > beanz added a reviewer: bogner. > beanz added a subscriber: cfe-commits. > > With this change generating clang order files using dtrace uses the > following workflow: > > # Configure LLVM & Clang using any options on a system with dtrace > cm

Re: [PATCH] D16934: [Coverage] Fix crash in VisitIfStmt

Vedant Kumar writes: > vsk created this revision. > vsk added a reviewer: bogner. > vsk added a subscriber: cfe-commits. > > When handling 'if' statements, we crash if the condition and the consequent > branch are spanned by a single macro expansion. > > The crash occurs because of a sanity 'reset

Re: [PATCH] D16999: [CMake] Improve the clang order-file generation workflow

Chris Bieneman writes: > beanz created this revision. > beanz added a reviewer: bogner. > beanz added a subscriber: cfe-commits. > > This commit re-lands r259862. The underlying cause of the build > breakage was an incorrectly written capabilities test. In > tools/Driver/CMakeLists.txt I was attem

Re: [PATCH] D19725: [Coverage] Fix an issue where a coverage region might not be created for a macro containing for or while statements.

Igor Kudrin writes: > ikudrin created this revision. > ikudrin added reviewers: bogner, davidxl, vsk. > ikudrin added a subscriber: cfe-commits. > > The situation happened when a macro contained a full loop statement, > which body ended at the end of the macro. A comment and a nitpick, then LGTM.

Re: [PATCH] D19243: [CodeGen] Move some CodeGenPGO stuff out of CodeGenFunction.h

Vedant Kumar writes: > vsk created this revision. > vsk added a reviewer: bogner. > vsk added a subscriber: cfe-commits. > > Cons: 1 extra malloc per CodeGenFunction instantiation. > > Pros: This makes incremental builds noticeably faster, especially on > my laptop. E.g with this patch there's no

Re: [PATCH] D19959: [scan-build] fix warning emitted on Clang Driver code baseFix a "logic error" warning of the type Called c++ object pointer isnull" reported by Clang Static Analyzer on the file:-

Apelete Seketeli via cfe-commits writes: > apelete created this revision. > apelete added reviewers: kevin.qin, rsmith. > apelete added a subscriber: cfe-commits. > > Signed-off-by: Apelete Seketeli > > http://reviews.llvm.org/D19959 > > Files: > lib/Driver/Tools.cpp > > Index: lib/Driver/Tools

Re: [PATCH] D18533: Fixing PR26558: the adc builtins do not require the adx target attribute

Yunzhong Gao writes: > ygao created this revision. > ygao added subscribers: craig.topper, bogner, cfe-commits. > > Hi, > The addcarry and subborrow variants of the builtins do not require the > adx target attribute. Only the addcarryx variants require them. > This patch attempts to remove the tar

Re: r264071 - StaticAnalyzer: Avoid an unintentional copy

David Blaikie writes: > On Tue, Mar 22, 2016 at 10:50 AM, Justin Bogner via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: bogner >> Date: Tue Mar 22 12:50:05 2016 >> New Revision: 264071 >> >> URL: http://llvm.org/viewvc/llvm-project?

Re: [PATCH] D18636: [PGO] Avoid instrumenting constants at value sites

Betul Buyukkurt writes: > betulb created this revision. > betulb added reviewers: davidxl, bogner. > betulb added subscribers: llvm-commits, cfe-commits. > betulb set the repository for this revision to rL LLVM. > betulb changed the visibility of this Differential Revision from > "Public (No Login

Re: [PATCH] D20715: [docs] Document the source-based code coverage feature

Vedant Kumar writes: > vsk created this revision. > vsk added a reviewer: bogner. > vsk added subscribers: kcc, cfe-commits, silvas. > > It would be helpful to have a user-friendly guide for code > coverage. There is some overlap with [1], but this document visits > issues which may affect users i

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

Taewook Oh via cfe-commits writes: > Author: twoh > Date: Fri Jun 3 13:52:51 2016 > New Revision: 271708 > > URL: http://llvm.org/viewvc/llvm-project?rev=271708&view=rev > Log: > Use the name of the file on disk to issue a new diagnostic about > non-portable #include and #import paths. > > Differ

r274560 - test: Use add_lit_testsuites so that subsets of tests can be specified

Author: bogner Date: Tue Jul 5 11:06:12 2016 New Revision: 274560 URL: http://llvm.org/viewvc/llvm-project?rev=274560&view=rev Log: test: Use add_lit_testsuites so that subsets of tests can be specified This creates make/ninja targets like check-clang-codegen and check-clang-unit, much like LLVM

r274562 - Revert "test: Use add_lit_testsuites so that subsets of tests can be specified"

Author: bogner Date: Tue Jul 5 11:14:58 2016 New Revision: 274562 URL: http://llvm.org/viewvc/llvm-project?rev=274562&view=rev Log: Revert "test: Use add_lit_testsuites so that subsets of tests can be specified" This reverts r274560. It's breaking a bunch of bots due to a directory with a space

r274565 - Re-apply "test: Use add_lit_testsuites so that subsets of tests can be specified"

Author: bogner Date: Tue Jul 5 12:54:40 2016 New Revision: 274565 URL: http://llvm.org/viewvc/llvm-project?rev=274565&view=rev Log: Re-apply "test: Use add_lit_testsuites so that subsets of tests can be specified" This version should actually remove the empty directories I removed all of the fi

r274663 - NVPTX: Rename __builtin_ptx_shfl -> __nvvm_shfl

Author: bogner Date: Wed Jul 6 14:52:32 2016 New Revision: 274663 URL: http://llvm.org/viewvc/llvm-project?rev=274663&view=rev Log: NVPTX: Rename __builtin_ptx_shfl -> __nvvm_shfl To match "NVPTX: Make the llvm.nvvm.shfl intrinsics and builtin names consistent" in LLVM. Modified: cfe/trunk/

Re: r274663 - NVPTX: Rename __builtin_ptx_shfl -> __nvvm_shfl

Justin Bogner via cfe-commits writes: > Author: bogner > Date: Wed Jul 6 14:52:32 2016 > New Revision: 274663 > > URL: http://llvm.org/viewvc/llvm-project?rev=274663&view=rev > Log: > NVPTX: Rename __builtin_ptx_shfl -> __nvvm_shfl > > To match "NVPTX:

r274770 - NVPTX: Use the nvvm builtins to read SRegs rather than the legacy ptx ones

Author: bogner Date: Thu Jul 7 11:41:08 2016 New Revision: 274770 URL: http://llvm.org/viewvc/llvm-project?rev=274770&view=rev Log: NVPTX: Use the nvvm builtins to read SRegs rather than the legacy ptx ones The ptx spellings were removed from LLVM in r274769. Modified: cfe/trunk/include/cla

r263909 - AST: Fix some bogus indentation. NFC

Author: bogner Date: Sun Mar 20 11:58:03 2016 New Revision: 263909 URL: http://llvm.org/viewvc/llvm-project?rev=263909&view=rev Log: AST: Fix some bogus indentation. NFC Noticed by Liu Xin. Thanks! Modified: cfe/trunk/lib/AST/ASTImporter.cpp Modified: cfe/trunk/lib/AST/ASTImporter.cpp URL:

r264071 - StaticAnalyzer: Avoid an unintentional copy

Author: bogner Date: Tue Mar 22 12:50:05 2016 New Revision: 264071 URL: http://llvm.org/viewvc/llvm-project?rev=264071&view=rev Log: StaticAnalyzer: Avoid an unintentional copy The range here isn't over references, so using `auto &` here incites a copy. Switching to `auto *` would do, but we migh

Re: [PATCH] D15584: [CMake] Support a simple case for bootstrap builds to generate PGO data

Chris Bieneman writes: > beanz updated this revision to Diff 43192. > beanz added a comment. > > One more dependency hookup fix, this one makes it so that stage2 > doesn't depend on the stage2-instrumented compiler-rt, and avoids > building it when you invoke the 'stage2' target. Please update th

Re: [PATCH] D16564: Fix an issue where backend crashes after frontend emits an error message

Manman Ren via cfe-commits writes: > manmanren created this revision. > manmanren added reviewers: echristo, rafael, ahatanak. > manmanren added a subscriber: cfe-commits. > > It can happen that frontend emits error message when releasing the > builder. When that happens, we emit the error message

r253104 - Revert "[AArch64] Unconditionally pass subtarget feature reserve-x18 on Darwin."

Author: bogner Date: Fri Nov 13 17:07:31 2015 New Revision: 253104 URL: http://llvm.org/viewvc/llvm-project?rev=253104&view=rev Log: Revert "[AArch64] Unconditionally pass subtarget feature reserve-x18 on Darwin." This reverts r243310, which is redundant as of r253102. Conflicts: lib/Dri

Re: [PATCH] D14847: Support CMake's clang_rt.profile library naming scheme

Chris Bieneman writes: > beanz created this revision. > beanz added a reviewer: bogner. > beanz added a subscriber: cfe-commits. > > This code is a bit undesirable, but it gets clang to work with the > autoconf and cmake-built libclang_rt.profile libraries. Yeah, this is a bit awkward, but it mak

r254173 - docs: Remove references to the long-defunct LLVM_USED_LIBS

Author: bogner Date: Thu Nov 26 13:52:24 2015 New Revision: 254173 URL: http://llvm.org/viewvc/llvm-project?rev=254173&view=rev Log: docs: Remove references to the long-defunct LLVM_USED_LIBS LLVM_USED_LIBS hasn't done anything since 2012, stop telling people to set it in the docs. Modified:

Re: [PATCH] D15158: [PGO] Instrument only base constructors and destructors.

Serge Pavlov writes: > sepavloff created this revision. > sepavloff added a reviewer: bogner. > sepavloff added subscribers: cfe-commits, silvas. > > Constructors and destructors may be represented by several functions > in IR. Only the base structors correspond to source code, others > are small

Re: [PATCH] D15158: [PGO] Instrument only base constructors and destructors.

Serge Pavlov writes: > sepavloff updated this revision to Diff 41744. > sepavloff added a comment. > > Changes according to reviewer's notes. LGTM. > > http://reviews.llvm.org/D15158 > > Files: > lib/CodeGen/CGBlocks.cpp > lib/CodeGen/CGObjC.cpp > lib/CodeGen/CGStmt.cpp > lib/CodeGen/CGS

r254935 - AST: defer to TypeLoc::copy in TypeLoc::initializeFullCopy

Author: bogner Date: Mon Dec 7 14:04:57 2015 New Revision: 254935 URL: http://llvm.org/viewvc/llvm-project?rev=254935&view=rev Log: AST: defer to TypeLoc::copy in TypeLoc::initializeFullCopy If we're initializing a TypeLoc from one that's been allocated with different alignment, memcpy will get

r255297 - www: Mention -DGCC_INSTALL_PREFIX instead of --with-gcc-toolchain

Author: bogner Date: Thu Dec 10 14:52:59 2015 New Revision: 255297 URL: http://llvm.org/viewvc/llvm-project?rev=255297&view=rev Log: www: Mention -DGCC_INSTALL_PREFIX instead of --with-gcc-toolchain Since the instructions use cmake, we should probably refer to the cmake flags and not the configur

Re: [PATCH] D15163: Attach maximum function count to Module when using PGO mode.

Easwaran Raman writes: > eraman added a comment. > > I have reverted the commit in r255416 because the test failed in many > architectures. You also committed without waiting for further review, despite that David said "LGTM but please wait for other reviewers". Please don't do that in the future

Re: [PATCH] D15163: Attach maximum function count to Module when using PGO mode.

Easwaran Raman writes: > eraman updated this revision to Diff 42549. > eraman added a comment. > > Added a test case. > > > Repository: > rL LLVM > > http://reviews.llvm.org/D15163 > > Files: > lib/CodeGen/CodeGenModule.cpp > test/CodeGen/pgo-max-function-count.c > > Index: test/CodeGen/pgo-

Re: [PATCH] D15463: [Objective-c] Fix a crash

Akira Hatanaka via cfe-commits writes: > ahatanak created this revision. > ahatanak added a subscriber: cfe-commits. > > This patch fixes a crash that occurs when __kindof is incorrectly used > in the type parameter list of an interface. The crash occurs because > ObjCTypeParamList::back() is call

Re: [PATCH] D14938: Fix implicit conversion from _Nullable to _Nonnull warnings in C++

George Burgess IV via cfe-commits writes: > george.burgess.iv created this revision. > george.burgess.iv added a reviewer: doug.gregor. > george.burgess.iv added subscribers: cfe-commits, doug.gregor. > > Currently, code like this compiles cleanly in C++, but with warnings > (as it should) in C:

Re: [PATCH] D15463: [Objective-c] Fix a crash

Akira Hatanaka writes: > On Mon, Dec 14, 2015 at 10:39 AM, Justin Bogner > wrote: > >> Akira Hatanaka via cfe-commits writes: >> > ahatanak created this revision. >> > ahatanak added a subscriber: cfe-commits. >> > >> > This patch fixes a crash that occurs when __kindof is incorrectly used >> >

Re: [PATCH] D15462: [CMake] Add support for generating profdata for clang from training files

Sean Silva writes: > silvas added a comment. > > Thanks. This LGTM but I'd wait for Duncan or Justin to sign off on it; > they're likely to have more higher-level thoughts. I'm fine with the concept and Sean's LGTM should cover the details :) > > > Comment at: utils/perf-trainin

Re: [PATCH] D15463: [Objective-c] Fix a crash

Akira Hatanaka writes: > On Tue, Dec 15, 2015 at 12:55 PM, Justin Bogner > wrote: > >> Akira Hatanaka writes: >> > On Mon, Dec 14, 2015 at 10:39 AM, Justin Bogner >> > wrote: >> > >> >> Akira Hatanaka via cfe-commits writes: >> >> > ahatanak created this revision. >> >> > ahatanak added a subs

Re: [PATCH] D15163: Attach maximum function count to Module when using PGO mode.

Easwaran Raman writes: > eraman added a comment. > > Justin, does this patch look ok? Sure. > > Repository: > rL LLVM > > http://reviews.llvm.org/D15163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [PATCH] D15584: [CMake] Support a simple case for bootstrap builds to generate PGO data

Chris Bieneman writes: > beanz created this revision. > beanz added reviewers: bogner, silvas, chandlerc. > beanz added a subscriber: cfe-commits. > > This patch adds support for the clang multi-stage bootstrapping to > support PGO profdata generation, and can build a 2 or 3 stage > compiler. > >

[clang] [HLSL] Vector standard conversions (PR #71098)

https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/71098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Vector standard conversions (PR #71098)

https://github.com/bogner approved this pull request. Looks good barring a few minor comments https://github.com/llvm/llvm-project/pull/71098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [HLSL] Vector standard conversions (PR #71098)

@@ -123,84 +123,83 @@ CompareDerivedToBaseConversions(Sema &S, SourceLocation Loc, /// GetConversionRank - Retrieve the implicit conversion rank /// corresponding to the given implicit conversion kind. ImplicitConversionRank clang::GetConversionRank(ImplicitConversionKind Kind

[clang] [HLSL] Vector standard conversions (PR #71098)

@@ -4772,6 +4788,76 @@ Sema::PerformImplicitConversion(Expr *From, QualType ToType, llvm_unreachable("Improper second standard conversion"); } + if (SCS.Element != ICK_Identity) { +// If SCS.Element is not ICK_Identity the To and From types must be HLSL +// vec

[clang] [HLSL] Vector standard conversions (PR #71098)

@@ -6432,7 +6432,7 @@ void InitializationSequence::InitializeFrom(Sema &S, // For HLSL ext vector types we allow list initialization behavior for C++ // constructor syntax. This is accomplished by converting initialization // arguments an InitListExpr late. - if (S.getLa

[clang] [HLSL] Vector standard conversions (PR #71098)

@@ -4772,6 +4788,76 @@ Sema::PerformImplicitConversion(Expr *From, QualType ToType, llvm_unreachable("Improper second standard conversion"); } + if (SCS.Element != ICK_Identity) { +// If SCS.Element is not ICK_Identity the To and From types must be HLSL +// vec

[clang] [HLSL] Vector standard conversions (PR #71098)

@@ -113,30 +115,12 @@ float2 HowManyFloats(float V) { // up nicely too. // CHECK-LABEL: AllRighty -// CHECK: [[XTmp:%.*]] = alloca <1 x double>, align 8 -// CHECK: [[YTmp:%.*]] = alloca <1 x double>, align 8 -// CHECK: [[ZTmp:%.*]] = alloca <1 x double>, align 8 - -// CHECK: s

[clang] [HLSL] Expose `half` types and intrinsics always (PR #81782)

https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/81782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] add BuiltinsHLSL and set it up as target builtins. (PR #81902)

https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/81902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] add BuiltinsHLSL and set it up as target builtins. (PR #81902)

https://github.com/bogner requested changes to this pull request. Hm, on further thought tying the "HLSL" intrinsics to the DirectX backend as target intrinsics like this is probably going to shoot us in the foot with respect to SPIR-V. I think we need to rethink this, and if we are going with

[clang] [HLSL][Doc] Add doc about expected differences (PR #82395)

https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/82395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL][Doc] Add doc about expected differences (PR #82395)

https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/82395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL][Doc] Add doc about expected differences (PR #82395)

@@ -0,0 +1,108 @@ + +Expected Differences vs DXC and FXC +=== + +.. contents:: + :local: + +Introduction + + +HLSL currently has two reference compilers, the `DirectX Shader Compiler (DXC) +

[clang] [HLSL][Doc] Add doc about expected differences (PR #82395)

@@ -0,0 +1,108 @@ + +Expected Differences vs DXC and FXC +=== + +.. contents:: + :local: + +Introduction + + +HLSL currently has two reference compilers, the `DirectX Shader Compiler (DXC) +

[clang] [HLSL][clang][Driver] Fix error when using the option -fcgl in --driver-mode=dxc. (PR #97001)

https://github.com/bogner approved this pull request. We may need to revisit the whole `ForwardedArguments` thing in general, as there are a few funny things going on looking at the `-cc1` options coming out of dxc - for example, before this change `-S` actually shows up twice sometimes. In an

[clang-tools-extra] Fix Default Asset File locator for clang docs (PR #97505)

https://github.com/bogner requested changes to this pull request. I don't think this is the right fix. The Release/Debug directories only exist in the build tree, so this is incurring an unnecessary cost in an installed clang-doc. Further, this won't work for configs like RelWithDebInfo. Proba

[clang-tools-extra] Fix Default Asset File locator for clang docs (PR #97505)

https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/97505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add basic e2e test (PR #93928)

bogner wrote: This test fails on multi-config cmake generators (`cmake -G 'Visual Studio` etc), exposing an existing bug in clang-doc. Since binaries end up under a subdirectory like `build/Release/bin` but the default json and such end up in `build/share/clang-doc`, running `clang-doc` from t

[clang-tools-extra] Fix Default Asset File locator for clang docs (PR #97505)

bogner wrote: > Updated the description. In my tests, there are at least 5 copies of this > file in the overall build output directory: > > ``` > //Debug/share/clang-doc > //Release/share/clang-doc > //MinSizeRel/share/clang-doc > //RelWithDebInfo/share/clang-doc > //share/clang-doc > ``` > >

[clang] [HLSL] Rework implicit conversion sequences (PR #96011)

https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/96011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Rework implicit conversion sequences (PR #96011)

https://github.com/bogner approved this pull request. It's a bit unfortunate that we need so many HLSL specific ImplicitConversionKinds, but I do think that the logic is easier to follow this way so it's probably the right thing to do. https://github.com/llvm/llvm-project/pull/96011 __

[clang] [HLSL] Rework implicit conversion sequences (PR #96011)

@@ -4361,6 +4361,21 @@ Sema::PerformImplicitConversion(Expr *From, QualType ToType, return From; } +// GetIntermediateVectorType - Compute the intermediate cast type casting +// elements of the from type to the elements of the to type without resizing the +// vector. +stat

[clang] [lldb] [HLSL] Implement intangible AST type (PR #97362)

@@ -115,6 +116,18 @@ GlobalVariable *replaceBuffer(CGHLSLRuntime::Buffer &Buf) { } // namespace +llvm::Type *CGHLSLRuntime::convertHLSLSpecificType(const Type *T) { + assert(T->isHLSLSpecificType() && "Not an HLSL specific type!"); + + // Check if the target has a specific

[clang] [HLSL] Apply resource attributes to the resource type rather than the handle member (PR #107160)

@@ -2062,6 +2066,7 @@ void TypePrinter::printBTFTagAttributedAfter(const BTFTagAttributedType *T, void TypePrinter::printHLSLAttributedResourceBefore( const HLSLAttributedResourceType *T, raw_ostream &OS) { printBefore(T->getWrappedType(), OS); + printAfter(T->getWrappe

[clang] [HLSL] Apply resource attributes to the resource type rather than the handle member (PR #107160)

@@ -12364,6 +12364,7 @@ def err_hlsl_packoffset_cross_reg_boundary : Error<"packoffset cannot cross regi def err_hlsl_packoffset_alignment_mismatch : Error<"packoffset at 'y' not match alignment %0 required by %1">; def err_hlsl_pointers_unsupported : Error< "%select{pointe

[clang] [HLSL] Apply resource attributes to the resource type rather than the handle member (PR #107160)

@@ -556,46 +562,120 @@ void SemaHLSL::handleShaderAttr(Decl *D, const ParsedAttr &AL) { D->addAttr(NewAttr); } -void SemaHLSL::handleResourceClassAttr(Decl *D, const ParsedAttr &AL) { - if (!AL.isArgIdent(0)) { -Diag(AL.getLoc(), diag::err_attribute_argument_type) -

[clang] [HLSL] Apply resource attributes to the resource type rather than the handle member (PR #107160)

@@ -556,46 +562,120 @@ void SemaHLSL::handleShaderAttr(Decl *D, const ParsedAttr &AL) { D->addAttr(NewAttr); } -void SemaHLSL::handleResourceClassAttr(Decl *D, const ParsedAttr &AL) { - if (!AL.isArgIdent(0)) { -Diag(AL.getLoc(), diag::err_attribute_argument_type) -

[clang] [HLSL] Apply resource attributes to the resource type rather than the handle member (PR #107160)

@@ -556,46 +562,120 @@ void SemaHLSL::handleShaderAttr(Decl *D, const ParsedAttr &AL) { D->addAttr(NewAttr); } -void SemaHLSL::handleResourceClassAttr(Decl *D, const ParsedAttr &AL) { - if (!AL.isArgIdent(0)) { -Diag(AL.getLoc(), diag::err_attribute_argument_type) -

[clang] [HLSL] Apply resource attributes to the resource type rather than the handle member (PR #107160)

@@ -556,46 +562,120 @@ void SemaHLSL::handleShaderAttr(Decl *D, const ParsedAttr &AL) { D->addAttr(NewAttr); } -void SemaHLSL::handleResourceClassAttr(Decl *D, const ParsedAttr &AL) { - if (!AL.isArgIdent(0)) { -Diag(AL.getLoc(), diag::err_attribute_argument_type) -

[clang] [HLSL] Apply resource attributes to the resource type rather than the handle member (PR #107160)

@@ -556,46 +562,120 @@ void SemaHLSL::handleShaderAttr(Decl *D, const ParsedAttr &AL) { D->addAttr(NewAttr); } -void SemaHLSL::handleResourceClassAttr(Decl *D, const ParsedAttr &AL) { - if (!AL.isArgIdent(0)) { -Diag(AL.getLoc(), diag::err_attribute_argument_type) -

[clang] [HLSL] Remove variables that are used only in assert (PR #107299)

https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/107299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/101989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Apply resource attributes to the resource type rather than the handle member (PR #107160)

@@ -556,46 +562,120 @@ void SemaHLSL::handleShaderAttr(Decl *D, const ParsedAttr &AL) { D->addAttr(NewAttr); } -void SemaHLSL::handleResourceClassAttr(Decl *D, const ParsedAttr &AL) { - if (!AL.isArgIdent(0)) { -Diag(AL.getLoc(), diag::err_attribute_argument_type) -

[clang] [HLSL] Apply resource attributes to the resource type rather than the handle member (PR #107160)

https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/107160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   6   7   8   9   10   >