================
@@ -4772,6 +4788,76 @@ Sema::PerformImplicitConversion(Expr *From, QualType 
ToType,
     llvm_unreachable("Improper second standard conversion");
   }
 
+  if (SCS.Element != ICK_Identity) {
+    // If SCS.Element is not ICK_Identity the To and From types must be HLSL
+    // vectors or matrices. HLSL matrices aren't yet supported so this code 
only
+    // handles vectors for now.
----------------
bogner wrote:

The comment about matrices should probably be a `TODO:`, and it might even be 
worth a separate assert that says "not implemented yet" for clarity

https://github.com/llvm/llvm-project/pull/71098
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to