[clang] [Clang][OpenMP] Check if value is contained in array, not if it's contained in the first element (PR #69462)

https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/69462 None From c388e5f65d3dfc8fc193686e182e74c3dcfb27e1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20MARTINEZ=20CAAMA=C3=91O?= Date: Wed, 18 Oct 2023 15:32:22 +0200 Subject: [PATCH] [Clang][OpenMP] Che

[clang] [NFC] Remove unused variable "AOBFileNames" (PR #69463)

https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/69463 None From d616ff33ba0b1db6ac8f9fd3cd1b0e2a3c1a544a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20MARTINEZ=20CAAMA=C3=91O?= Date: Wed, 18 Oct 2023 15:45:07 +0200 Subject: [PATCH] [NFC] Remove unused

[clang] [Clang][OpenMP] Check if value is contained in array, not if it's contained in the first element (PR #69462)

jmmartinez wrote: Hello @saiislam ! Can I bother you with a review of this patch? https://github.com/llvm/llvm-project/pull/69462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Remove unused variable "AOBFileNames" (PR #69463)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/69463 From aff47154ae4d45c2852382aed034ea44df4886d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20MARTINEZ=20CAAMA=C3=91O?= Date: Wed, 18 Oct 2023 15:45:07 +0200 Subject: [PATCH 1/3] [NFC][Clang] Remove u

[clang] [NFC] Remove unused variable "AOBFileNames" (PR #69463)

https://github.com/jmmartinez edited https://github.com/llvm/llvm-project/pull/69463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] GetSDLFromOffloadArchive and SDLSearch (PR #69463)

https://github.com/jmmartinez edited https://github.com/llvm/llvm-project/pull/69463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Make GetSDLFromOffloadArchive and SDLSearch static and avoid useless copies in their arguments (PR #69463)

https://github.com/jmmartinez edited https://github.com/llvm/llvm-project/pull/69463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Make GetSDLFromOffloadArchive and SDLSearch static and avoid useless copies in their arguments (PR #69463)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/69463 From aff47154ae4d45c2852382aed034ea44df4886d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20MARTINEZ=20CAAMA=C3=91O?= Date: Wed, 18 Oct 2023 15:45:07 +0200 Subject: [PATCH 1/3] [NFC][Clang] Remove u

[clang] [Clang][OpenMP] Check if value is contained in array, not if it's contained in the first element (PR #69462)

https://github.com/jmmartinez closed https://github.com/llvm/llvm-project/pull/69462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 16fe53c - [NFC][Clang] Remove unused variable "AOBFileNames"

Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2023-10-24T18:28:33+02:00 New Revision: 16fe53c47e3a83bfca9795e59aa664976620c034 URL: https://github.com/llvm/llvm-project/commit/16fe53c47e3a83bfca9795e59aa664976620c034 DIFF: https://github.com/llvm/llvm-project/commit/16fe53c47e3a83bfca9795e59aa6649

[clang] [NFC][Clang] Make GetSDLFromOffloadArchive and SDLSearch static and avoid useless copies in their arguments (PR #69463)

https://github.com/jmmartinez closed https://github.com/llvm/llvm-project/pull/69463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Make GetSDLFromOffloadArchive and SDLSearch static (PR #70201)

https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/70201 Make GetSDLFromOffloadArchive and SDLSearch functions static since they are used only in the file where they are defined. The aim is to ease refactoring/modifying the declarations of these functions in the fu

[clang] [NFC][Clang] Make GetSDLFromOffloadArchive and SDLSearch static (PR #70201)

https://github.com/jmmartinez closed https://github.com/llvm/llvm-project/pull/70201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7c94603 - [NFC][Clang] Make read-only arguments of GetSDLFromOffloadArchive and SDLSearch read-only references instead of copying them

Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2023-10-25T15:57:22+02:00 New Revision: 7c946031b2f4e8b2e0cf23af503a25a2c92be1a0 URL: https://github.com/llvm/llvm-project/commit/7c946031b2f4e8b2e0cf23af503a25a2c92be1a0 DIFF: https://github.com/llvm/llvm-project/commit/7c946031b2f4e8b2e0cf23af503a25a

[clang] 6687c57 - [NFC][Clang] Make GetSDLFromOffloadArchive return void

Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2023-10-25T15:57:22+02:00 New Revision: 6687c5725cd51ff5c69a8ed90dceaf86c361ae6d URL: https://github.com/llvm/llvm-project/commit/6687c5725cd51ff5c69a8ed90dceaf86c361ae6d DIFF: https://github.com/llvm/llvm-project/commit/6687c5725cd51ff5c69a8ed90dceaf8

[clang] 1118ee0 - [Clang][CGDebugInfo][ObjC] Mark objc bitfields with the DIFlagBitfield flag

Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2022-12-21T04:00:40-05:00 New Revision: 1118ee04fc7c09bb54128bcaef4bd82835dcbafd URL: https://github.com/llvm/llvm-project/commit/1118ee04fc7c09bb54128bcaef4bd82835dcbafd DIFF: https://github.com/llvm/llvm-project/commit/1118ee04fc7c09bb54128bcaef4bd82

[clang] [NFC][Clang] Address reviews about overrideFunctionFeaturesWithTargetFeatures (PR #65938)

jmmartinez wrote: @yxsamliu Is it ok if I merge this patch? https://github.com/llvm/llvm-project/pull/65938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Address reviews about overrideFunctionFeaturesWithTargetFeatures (PR #65938)

https://github.com/jmmartinez closed https://github.com/llvm/llvm-project/pull/65938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d60c474 - [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2023-09-08T11:20:16+02:00 New Revision: d60c47476dde601f1e48d44717ef23b7f1006fe6 URL: https://github.com/llvm/llvm-project/commit/d60c47476dde601f1e48d44717ef23b7f1006fe6 DIFF: https://github.com/llvm/llvm-project/commit/d60c47476dde601f1e48d44717ef23b

[clang] [Clang] Drop functions with incompatible target-features when using mlink-builtin-bitcode (PR #65737)

https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/65737: Differential Revision: https://reviews.llvm.org/D159257 From 1c2c8c7045d7298644f08833d3b2cdec694ea91d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20MARTINEZ=20CAAMA=C3=91O?= Date: Fri, 8 Sep 2023

[clang] [Clang] Drop functions with incompatible target-features when using mlink-builtin-bitcode (PR #65737)

https://github.com/jmmartinez review_requested https://github.com/llvm/llvm-project/pull/65737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Drop functions with incompatible target-features when using mlink-builtin-bitcode (PR #65737)

https://github.com/jmmartinez labeled https://github.com/llvm/llvm-project/pull/65737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Drop functions with incompatible target-features when using mlink-builtin-bitcode (PR #65737)

https://github.com/jmmartinez review_requested https://github.com/llvm/llvm-project/pull/65737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] overrideFunctionFeaturesWithTargetFeatures (PR #65938)

https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/65938: Addressing remarks after merge of D159257 * Add comment * Remove irrelevant CHECKs from test * Simplify function * Use llvm::sort before setting target-features as it is done in CodeGenModeule From bd46d855b

[clang] [NFC][Clang] overrideFunctionFeaturesWithTargetFeatures (PR #65938)

https://github.com/jmmartinez review_requested https://github.com/llvm/llvm-project/pull/65938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] overrideFunctionFeaturesWithTargetFeatures (PR #65938)

https://github.com/jmmartinez labeled https://github.com/llvm/llvm-project/pull/65938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] overrideFunctionFeaturesWithTargetFeatures (PR #65938)

https://github.com/jmmartinez review_requested https://github.com/llvm/llvm-project/pull/65938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] overrideFunctionFeaturesWithTargetFeatures (PR #65938)

https://github.com/jmmartinez labeled https://github.com/llvm/llvm-project/pull/65938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Address reviews about overrideFunctionFeaturesWithTargetFeatures (PR #65938)

https://github.com/jmmartinez edited https://github.com/llvm/llvm-project/pull/65938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Address reviews about overrideFunctionFeaturesWithTargetFeatures (PR #65938)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/65938: From 7051cbfdd484dcb02c786876599820f8d669348e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20MARTINEZ=20CAAMA=C3=91O?= Date: Mon, 11 Sep 2023 11:00:34 +0200 Subject: [PATCH] [NFC][Clang] Address rev

[clang] [NFC][Clang] Address reviews about overrideFunctionFeaturesWithTargetFeatures (PR #65938)

@@ -43,7 +43,7 @@ int bar() { return no_attr() + attr_in_target() + attr_not_in_target() + attr_in // CHECK-LABEL: @attr_incompatible // CHECK-SAME: () #[[ATTR_INCOMPATIBLE:[0-9]+]] { -// CHECK: attributes #[[ATTR_BAR]] = { noinline nounwind optnone "no-trapping-math"="true"

[clang] [Clang] Drop functions with incompatible target-features when using mlink-builtin-bitcode (PR #65737)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/65737: From 112dd3c57c28b467463ef39dfbc33560b652b1c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20MARTINEZ=20CAAMA=C3=91O?= Date: Fri, 8 Sep 2023 11:25:44 +0200 Subject: [PATCH] [Clang] Drop functions wi

[clang] [Clang] Drop functions with incompatible target-features when using mlink-builtin-bitcode (PR #65737)

@@ -375,6 +375,11 @@ class ReturnValueSlot { bool isExternallyDestructed() const { return IsExternallyDestructed; } }; +/// If \p F "target-features" are incompatible with the \p TargetOpts features, jmmartinez wrote: I've updated the comment but I've reali

[clang] b63c6e5 - [NFC][Clang] Add missing & to function argument

Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2023-08-29T13:59:17+02:00 New Revision: b63c6e585d8662b67b38988f0cd38a0bd6e0d38a URL: https://github.com/llvm/llvm-project/commit/b63c6e585d8662b67b38988f0cd38a0bd6e0d38a DIFF: https://github.com/llvm/llvm-project/commit/b63c6e585d8662b67b38988f0cd38a0

[clang] 9b35254 - [NFC][Clang] Remove unused function `CodeGenModule::addDefaultFunctionDefinitionAttributes`

Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2023-08-30T10:32:51+02:00 New Revision: 9b352540184e181d2a38423d352c5d5e2142839e URL: https://github.com/llvm/llvm-project/commit/9b352540184e181d2a38423d352c5d5e2142839e DIFF: https://github.com/llvm/llvm-project/commit/9b352540184e181d2a38423d352c5d5

[clang] 19550e7 - [NFC][Clang] Remove redundant function definitions

Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2023-08-31T14:47:42+02:00 New Revision: 19550e79b50f0689404309a2c6091f0b53770e08 URL: https://github.com/llvm/llvm-project/commit/19550e79b50f0689404309a2c6091f0b53770e08 DIFF: https://github.com/llvm/llvm-project/commit/19550e79b50f0689404309a2c6091f0

[clang] 488185c - [Clang][DebugInfo][AMDGPU] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2023-03-28T10:07:32+02:00 New Revision: 488185cca3871a0ef2ec3b9b4c642dc6db6eeea5 URL: https://github.com/llvm/llvm-project/commit/488185cca3871a0ef2ec3b9b4c642dc6db6eeea5 DIFF: https://github.com/llvm/llvm-project/commit/488185cca3871a0ef2ec3b9b4c642dc

[clang] a446827 - [NFC][Clang][Driver][AMDGPU] Avoid temporary copies of std::string by using Twine and StringRef

Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2022-12-05T07:27:10-06:00 New Revision: a446827249bdeb2f27e55a9f4942bd7425ecb0ff URL: https://github.com/llvm/llvm-project/commit/a446827249bdeb2f27e55a9f4942bd7425ecb0ff DIFF: https://github.com/llvm/llvm-project/commit/a446827249bdeb2f27e55a9f4942bd7

[clang] 3f65691 - [NFC] Remove const from return value of function

Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2022-12-06T04:46:33-05:00 New Revision: 3f65691737641c3b46bee11c9cf0e52046af3a49 URL: https://github.com/llvm/llvm-project/commit/3f65691737641c3b46bee11c9cf0e52046af3a49 DIFF: https://github.com/llvm/llvm-project/commit/3f65691737641c3b46bee11c9cf0e52

[clang] [Clang][Driver][AMDGPU] Add missing space in missing device-libs error message (PR #121335)

https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/121335 Before/After: cannot find ROCm device **libraryfor** ABI version 6 cannot find ROCm device **library for** ABI version 6 From b43f459b681c88e697cdd18a9836e967ffe83733 Mon Sep 17 00:00:00 2001 From: =

[clang] [Clang][Driver][AMDGPU] Add missing space in missing device-libs error message (PR #121335)

https://github.com/jmmartinez edited https://github.com/llvm/llvm-project/pull/121335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver][AMDGPU] Add missing space in missing device-libs error message (PR #121335)

https://github.com/jmmartinez closed https://github.com/llvm/llvm-project/pull/121335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OffloadBundler] Expose function to parse compressed bundle headers (PR #130284)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/130284 From 27adc9ef08bf2ac98319885fb461975f37a98bc2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Fri, 7 Mar 2025 12:29:31 +0100 Subject: [PATCH 1/2] [OffloadBundler] Expo

[clang] [llvm] [Clang][AMDGPU] Expose buffer load lds as a clang builtin (PR #132048)

https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/132048 CK is using either inline assembly or inline LLVM-IR builtins to generate buffer_load_dword lds instructions. This patch exposes this instruction as a Clang builtin. Limitations in this patch: these instruc

[clang] [flang] [llvm] [Clang][AMDGPU] Expose buffer load lds as a clang builtin (PR #132048)

@@ -162,6 +162,8 @@ BUILTIN(__builtin_amdgcn_raw_buffer_load_b64, "V2UiQbiiIi", "n") BUILTIN(__builtin_amdgcn_raw_buffer_load_b96, "V3UiQbiiIi", "n") BUILTIN(__builtin_amdgcn_raw_buffer_load_b128, "V4UiQbiiIi", "n") +TARGET_BUILTIN(__builtin_amdgcn_raw_ptr_buffer_load_lds, "v

[clang] [flang] [llvm] [Clang][AMDGPU] Expose buffer load lds as a clang builtin (PR #132048)

@@ -43,7 +43,7 @@ int bar() { return no_attr() + attr_in_target() + attr_not_in_target() + attr_in // CHECK-LABEL: @attr_incompatible // CHECK-SAME: () #[[ATTR_INCOMPATIBLE:[0-9]+]] { -// CHECK: attributes #[[ATTR_BAR]] = { {{.*}} "target-cpu"="gfx90a" "target-features"="+16

[clang] [flang] [llvm] [Clang][AMDGPU] Expose buffer load lds as a clang builtin (PR #132048)

jmmartinez wrote: > > I've also seen that gfx11 seem to have some kind of BUFFER_LOAD_LDS_(SIZE) > > instruction (different from the BUFFER_LOAD_(SIZE)_LDS instructions > > associated with this builtin). > > However, I'm not sure they actually exists: we do not have any test where > > we gener

[clang] [flang] [llvm] [Clang][AMDGPU] Expose buffer load lds as a clang builtin (PR #132048)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/132048 From f7df0f882bb2062fa63111d07aca3c91d0805904 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Thu, 20 Mar 2025 13:23:25 +0100 Subject: [PATCH 1/6] [AMDGPU] Add "lds-bu

[clang] [OffloadBundler] Expose function to parse compressed bundle headers (PR #130284)

https://github.com/jmmartinez closed https://github.com/llvm/llvm-project/pull/130284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OffloadBundler] Expose function to parse compressed bundle headers (PR #130284)

jmmartinez wrote: Thanks for the review ! https://github.com/llvm/llvm-project/pull/130284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [AMDGPU] Use a target feature to enable __builtin_amdgcn_global_load_lds on gfx9/10 (PR #133055)

jmmartinez wrote: I've added a commit to have a common attribute that we could use for both, global-load-lds and buffer-load-lds builtins. https://github.com/llvm/llvm-project/pull/133055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [llvm] [Clang][AMDGPU] Expose buffer load lds as a clang builtin (PR #132048)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/132048 From 27b90ab19cc8c8694784b41b53b2623c718071ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Thu, 20 Mar 2025 13:23:25 +0100 Subject: [PATCH 1/3] [AMDGPU] Add "lds-bu

[clang] [llvm] [Clang][AMDGPU] Add __builtin_amdgcn_cvt_off_f32_i4 (PR #133741)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/133741 From 41af38793161b0f1535c98c4695c36e081ef2f67 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Thu, 27 Mar 2025 17:46:34 +0100 Subject: [PATCH 01/10] [Clang][AMDGPU] Ad

[clang] [flang] [llvm] [AMDGPU] Add "lds-buffer-load-insts" attribute for all targets < gfx11 (PR #133055)

jmmartinez wrote: > > Global load lds is available on gfx9 and gfx10. > > However, the __builtin_amdgcn_global_load_lds builtin is restricted to > > platforms with the attribute gfx940-insts; while it could be available on > > gfx90a for example. > > This doesn't sound right, it was new in 940

[clang] [flang] [llvm] [AMDGPU] Add "lds-buffer-load-insts" attribute for all targets < gfx11 (PR #133055)

jmmartinez wrote: > At the hardware level, GFX11 removed the ability for buffer, **scratch** and > **global** instructions to return directly to LDS. So can we use one > attribute that covers all three of those? I've been "grep"ping in upstream (but not yet downstream): * Scratch load lds are

[clang] [flang] [llvm] [AMDGPU] Add "lds-buffer-load-insts" attribute for all targets < gfx11 (PR #133055)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/133055 From eae04b28a010045bdd7fcd03f84c952abeed3ff6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Thu, 20 Mar 2025 13:23:25 +0100 Subject: [PATCH 1/2] [AMDGPU] Add "lds-bu

[clang] [flang] [llvm] [Clang][AMDGPU] Expose buffer load lds as a clang builtin (PR #132048)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/132048 From eae04b28a010045bdd7fcd03f84c952abeed3ff6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Thu, 20 Mar 2025 13:23:25 +0100 Subject: [PATCH 1/2] [AMDGPU] Add "lds-bu

[clang] [flang] [llvm] [AMDGPU] Add "lds-buffer-load-insts" attribute for all targets < gfx11 (PR #133055)

https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/133055 This are used to restrict the availability of buffer_load_lds intrinsics to targets that actually have this instructions. From eae04b28a010045bdd7fcd03f84c952abeed3ff6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?

[clang] [flang] [llvm] [AMDGPU] Add "lds-buffer-load-insts" attribute for all targets < gfx11 (PR #133055)

jmmartinez wrote: Squashed first commit from https://github.com/llvm/llvm-project/pull/132048 https://github.com/llvm/llvm-project/pull/133055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [flang] [llvm] [Clang][AMDGPU] Expose buffer load lds as a clang builtin (PR #132048)

jmmartinez wrote: Squashed and split in 2: https://github.com/llvm/llvm-project/pull/133055 https://github.com/llvm/llvm-project/pull/132048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [flang] [llvm] [AMDGPU] Add "lds-buffer-load-insts" attribute for all targets < gfx11 (PR #133055)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/133055 From eae04b28a010045bdd7fcd03f84c952abeed3ff6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Thu, 20 Mar 2025 13:23:25 +0100 Subject: [PATCH 1/2] [AMDGPU] Add "lds-bu

[clang] [flang] [llvm] [AMDGPU] Add "lds-buffer-load-insts" attribute for all targets < gfx11 (PR #133055)

@@ -3368,7 +3368,8 @@ bool AMDGPUInstructionSelector::selectG_INSERT_VECTOR_ELT( } bool AMDGPUInstructionSelector::selectBufferLoadLds(MachineInstr &MI) const { - assert(!AMDGPU::isGFX12Plus(STI)); + if (!Subtarget->hasLDSBufferLoad()) jmmartinez wrote: Tha

[clang] [flang] [llvm] [AMDGPU] Use a target feature to enable __builtin_amdgcn_global_load_lds on gfx9/10 (PR #133055)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/133055 From bf3f06cc99a1ac2460ffea741c0fe495f0778e70 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Thu, 20 Mar 2025 13:23:25 +0100 Subject: [PATCH 1/3] [AMDGPU] Add "lds-bu

[clang] [Clang][AMDGPU] Accept builtins in lambda declarations (PR #135027)

https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/135027 `Sema::getCurFunctionDecl(AllowLambda = false)` returns a nullptr when the lambda declaration is outside a function (for example, when assigning a lambda to a static constexpr variable). This triggered an a

[clang] [Clang][AMDGPU] Accept builtins in lambda declarations (PR #135027)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/135027 From 4e5736d1b90ae477642ea03dcf39231f5f0a8e59 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Wed, 9 Apr 2025 15:11:19 +0200 Subject: [PATCH 1/4] [Clang][AMDGPU] Accep

[clang] [Clang][AMDGPU] Accept builtins in lambda declarations (PR #135027)

@@ -0,0 +1,24 @@ +// REQUIRES: amdgpu-registered-target +// RUN: %clang_cc1 -std=c++20 -triple amdgcn -target-cpu tahiti -fsyntax-only -fcuda-is-device -verify=expected -o - %s +// RUN: %clang_cc1 -std=c++20 -triple amdgcn -target-cpu gfx950 -fsyntax-only -fcuda-is-device -o - %

[clang] [llvm] [Clang][AMDGPU] Add __builtin_amdgcn_cvt_off_f32_i4 (PR #133741)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/133741 From 41af38793161b0f1535c98c4695c36e081ef2f67 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Thu, 27 Mar 2025 17:46:34 +0100 Subject: [PATCH 1/9] [Clang][AMDGPU] Add

[clang] [llvm] [Clang][AMDGPU] Add __builtin_amdgcn_cvt_off_f32_i4 (PR #133741)

@@ -729,6 +729,25 @@ GCNTTIImpl::instCombineIntrinsic(InstCombiner &IC, IntrinsicInst &II) const { break; } + case Intrinsic::amdgcn_cvt_off_f32_i4: { +Value* Arg = II.getArgOperand(0); +Type *Ty = II.getType(); + +if (isa(Arg)) + return IC.replaceInst

[clang] [OffloadBundler] Expose function to parse compressed bundle headers (PR #130284)

@@ -1121,13 +1122,116 @@ CompressedOffloadBundle::compress(llvm::compression::Params P, llvm::StringRef(FinalBuffer.data(), FinalBuffer.size())); } +// Use packed structs to avoid padding, such that the structs map the serialized +// format. +LLVM_PACKED_START +union R

[clang] [Clang][AMDGPU] Accept builtins in lambda declarations (PR #135027)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/135027 From a22e56d063e91df667d89ed5238bd886ce10bd0a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Wed, 9 Apr 2025 15:11:19 +0200 Subject: [PATCH] [Clang][AMDGPU] Accept bu

[clang] [Clang][AMDGPU] Accept builtins in lambda declarations (PR #135027)

jmmartinez wrote: > IIRC there were bugs when you try to use lambda in conjunction with the > target attribute. Can you add a test where you try to use a builtin that > depends on a subtarget feature, in a function marked with the target > attribute (and not available in the main compile targe

[clang] [llvm] [AMDGPU] Incoherence between TargetParser and AMDGPU.td (PR #135376)

https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/135376 The vmem-to-lds-loads-insts feature is only available on gfx9/10. While target-parser was also enabling it for gfx6,7,8. From 90c95af57317103f399ee4059a4e4ec01ddc98de Mon Sep 17 00:00:00 2001 From: =?UTF-8?q

[clang] [llvm] [AMDGPU] vmem-to-lds-load-insts incoherence between TargetParser and AMDGPU.td (PR #135376)

https://github.com/jmmartinez edited https://github.com/llvm/llvm-project/pull/135376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] vmem-to-lds-load-insts incoherence between TargetParser and AMDGPU.td (PR #135376)

https://github.com/jmmartinez closed https://github.com/llvm/llvm-project/pull/135376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU] Accept builtins in lambda declarations (PR #135027)

https://github.com/jmmartinez closed https://github.com/llvm/llvm-project/pull/135027 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix wait_for_event argument address space with -fdeclare-opencl-builtins (PR #134598)

https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/134598 The pointer argument for `wait_for_event(int, event_t*)` should take the default address space: generic if available, otherwise private. Before this patch it would always be generic with `-fdeclare-opencl-bu

[clang] [Clang][OpenCL] Fix wait_for_event argument address space with -fdeclare-opencl-builtins (PR #134598)

jmmartinez wrote: Thanks for the quick review ! https://github.com/llvm/llvm-project/pull/134598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenCL] Fix wait_for_event argument address space with -fdeclare-opencl-builtins (PR #134598)

https://github.com/jmmartinez edited https://github.com/llvm/llvm-project/pull/134598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenCL] Fix wait_for_event argument address space with -fdeclare-opencl-builtins (PR #134598)

https://github.com/jmmartinez closed https://github.com/llvm/llvm-project/pull/134598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] Add a __device__ version of std::__glibcxx_assert_fail() (PR #136133)

@@ -0,0 +1,35 @@ +// libstdc++ uses the non-constexpr function std::__glibcxx_assert_fail() +// to trigger compilation errors when the __glibcxx_assert(cond) macro +// is used in a constexpr context. +// Compilation fails when using code from the libstdc++ (such as std::array) on

[clang] [CUDA][HIP] Add a __device__ version of std::__glibcxx_assert_fail() (PR #136133)

https://github.com/jmmartinez edited https://github.com/llvm/llvm-project/pull/136133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] Add a __device__ version of std::__glibcxx_assert_fail() (PR #136133)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/136133 From b98abc3e1b1ca6c81509e310b6df1f7f7cfd10b9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Thu, 17 Apr 2025 13:41:55 +0200 Subject: [PATCH] [CUDA][HIP] Add a __devi

[clang] [Preprocessor] Do not expand macros if the input is already preprocessed (PR #137665)

https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/137665 This is a draft while I'm trying to figure out what's left to do. This has issues with the test `Modules/initializers.cpp`. The function `CompilerInstance::createModuleFromSource` creates a `FrontendInput`

[clang] [AMDGPU] Support the OpenCL generic addrspace feature by default (PR #137636)

@@ -155,3 +155,11 @@ #endif #pragma OPENCL EXTENSION cl_amd_media_ops2: enable +#if (__OPENCL_C_VERSION__ >= 300) jmmartinez wrote: Thanks ! You're right. It's available by default on OpenCL C 2 but not 3. https://github.com/llvm/llvm-project/pull/137636 ___

[clang] [AMDGPU] Support the OpenCL generic addrspace feature by default (PR #137636)

@@ -155,3 +155,11 @@ #endif #pragma OPENCL EXTENSION cl_amd_media_ops2: enable +#if (__OPENCL_C_VERSION__ >= 300) jmmartinez wrote: I don't understand, isn't `__opencl_c_generic_address_space` available by default with `OPENCL_C_VERSION >= 200` (from reading

[clang] [CUDA][HIP] Add a __device__ version of std::__glibcxx_assert_fail() (PR #136133)

@@ -0,0 +1,35 @@ +// libstdc++ uses the non-constexpr function std::__glibcxx_assert_fail() +// to trigger compilation errors when the __glibcxx_assert(cond) macro +// is used in a constexpr context. +// Compilation fails when using code from the libstdc++ (such as std::array) on

[clang] [CUDA][HIP] Add a __device__ version of std::__glibcxx_assert_fail() (PR #136133)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/136133 From b433add1b7c2027b89cdd9be11680c0a9a59e807 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Thu, 17 Apr 2025 13:41:55 +0200 Subject: [PATCH] [CUDA][HIP] Add a __devi

[clang] [Clang][Driver] Fix condition in combineBackendCompile when using -no-integrated-cpp (PR #136853)

https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/136853 When using -no-integrated-cpp, before, the driver won't collapse actions when the input was not llvm-ir or it would collapse them too aggressively with -save-temps The original code was checking the action t

[clang] [CUDA][HIP] Add a __device__ version of std::__glibcxx_assert_fail() (PR #136133)

@@ -0,0 +1,35 @@ +// libstdc++ uses the non-constexpr function std::__glibcxx_assert_fail() +// to trigger compilation errors when the __glibcxx_assert(cond) macro +// is used in a constexpr context. +// Compilation fails when using code from the libstdc++ (such as std::array) on

[clang] [CUDA][HIP] Add a __device__ version of std::__glibcxx_assert_fail() (PR #136133)

https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/136133 libstdc++ 15 uses the non-constexpr function std::__glibcxx_assert_fail() to trigger compilation errors when the __glibcxx_assert(cond) macro is used in a constantly evaluated context. Compilation fails when

[clang] [CUDA][HIP] Add a __device__ version of std::__glibcxx_assert_fail() (PR #136133)

jmmartinez wrote: This patch is cruelly missing some tests. Is there a place for tests of this kind? I haven't found an obvious one for other headers. https://github.com/llvm/llvm-project/pull/136133 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [CUDA][HIP] Add a __device__ version of std::__glibcxx_assert_fail() (PR #136133)

jmmartinez wrote: See https://github.com/gcc-mirror/gcc/blob/c237297ee596545552f48ec9582d7d16703d8949/libstdc%2B%2B-v3/include/bits/c%2B%2Bconfig#L645-L659 for the problematic libstdc++ snippet https://github.com/llvm/llvm-project/pull/136133 ___ cfe

[clang] [Clang] Do not warn for serialized builtin or command-line definitions (PR #137306)

https://github.com/jmmartinez closed https://github.com/llvm/llvm-project/pull/137306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Do not warn for serialized builtin or command-line definitions (PR #137306)

jmmartinez wrote: Thanks ! https://github.com/llvm/llvm-project/pull/137306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Fix condition in combineBackendCompile when using -no-integrated-cpp (PR #136853)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/136853 From 1acf00c794bddd5aed30670915a83db5b243b7ff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Wed, 16 Apr 2025 14:20:53 +0200 Subject: [PATCH 1/2] Pre-commit test: [Cl

[clang] [Clang] Do not warn for serialized builtin or command-line definitions (PR #137306)

https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/137306 When using `-dD` to generate a preprocessed output, the `#define` directives are preserved. This includes built-in and command-line definitions. Before, clang would warn for reserved identifiers for serialize

[clang] [ObjectiveC] -rewrite-objc was treating inputs as preprocessed files (PR #137623)

https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/137623 `-rewrite-objc` passes `-x objective-c++-cpp-output` as input type to the preprocessor job. This is not correct since we would be preprocessing a preprocessed file. The correct input type is `objective-c++`.

[clang] [CUDA][HIP] Add a __device__ version of std::__glibcxx_assert_fail() (PR #136133)

jmmartinez wrote: I've added a verbose version of the assertion that uses `__builtin_printf` (I could not figure out a way to correctly emit something to `stderr` from device code in a generic way without including `cstdio`. ```cpp #ifdef _GLIBCXX_VERBOSE_ASSERT __attribute__((device, noreturn

[clang] [CUDA][HIP] Add a __device__ version of std::__glibcxx_assert_fail() (PR #136133)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/136133 From a602d4f56993c2fc2825997a367b4551fcd54817 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Thu, 17 Apr 2025 13:41:55 +0200 Subject: [PATCH] [CUDA][HIP] Add a __devi

[clang] [CUDA][HIP] Add a __device__ version of std::__glibcxx_assert_fail() (PR #136133)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/136133 From 2136a05f0b8a0f2db0f9506a78ebf8f41c0f4d2f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Thu, 17 Apr 2025 13:41:55 +0200 Subject: [PATCH] [CUDA][HIP] Add a __devi

  1   2   3   >