https://github.com/jmmartinez created
https://github.com/llvm/llvm-project/pull/121335
Before/After:
cannot find ROCm device **libraryfor** ABI version 6
cannot find ROCm device **library for** ABI version 6
From b43f459b681c88e697cdd18a9836e967ffe83733 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= <juama...@amd.com>
Date: Mon, 30 Dec 2024 14:23:29 +0100
Subject: [PATCH] [Clang][Driver][AMDGPU] Add missing space in missing
device-libs error message
Before/After:
cannot find ROCm device **libraryfor** ABI version 6
cannot find ROCm device **library for** ABI version 6
---
clang/include/clang/Basic/DiagnosticDriverKinds.td | 2 +-
clang/test/Driver/hip-device-libs.hip | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/clang/include/clang/Basic/DiagnosticDriverKinds.td
b/clang/include/clang/Basic/DiagnosticDriverKinds.td
index 5155b23d151c04..42c39ac6606c7f 100644
--- a/clang/include/clang/Basic/DiagnosticDriverKinds.td
+++ b/clang/include/clang/Basic/DiagnosticDriverKinds.td
@@ -67,7 +67,7 @@ def err_drv_no_cuda_libdevice : Error<
"libdevice">;
def err_drv_no_rocm_device_lib : Error<
- "cannot find ROCm device library%select{| for %1|for ABI version %1}0;
provide its path via "
+ "cannot find ROCm device library%select{| for %1| for ABI version %1}0;
provide its path via "
"'--rocm-path' or '--rocm-device-lib-path', or pass '-nogpulib' to build "
"without ROCm device library">;
def err_drv_no_hip_runtime : Error<
diff --git a/clang/test/Driver/hip-device-libs.hip
b/clang/test/Driver/hip-device-libs.hip
index 6f1d31508e3302..317fd792426972 100644
--- a/clang/test/Driver/hip-device-libs.hip
+++ b/clang/test/Driver/hip-device-libs.hip
@@ -253,5 +253,5 @@
// NOABI4-NOT: error:
// NOABI4-NOT: "-mlink-builtin-bitcode" "{{.*}}oclc_abi_version_400.bc"
// NOABI4-NOT: "-mlink-builtin-bitcode" "{{.*}}oclc_abi_version_500.bc"
-// NOABI5: error: cannot find ROCm device libraryfor ABI version 5; provide
its path via '--rocm-path' or '--rocm-device-lib-path', or pass '-nogpulib' to
build without ROCm device library
-// NOABI6: error: cannot find ROCm device libraryfor ABI version 6; provide
its path via '--rocm-path' or '--rocm-device-lib-path', or pass '-nogpulib' to
build without ROCm device library
+// NOABI5: error: cannot find ROCm device library for ABI version 5; provide
its path via '--rocm-path' or '--rocm-device-lib-path', or pass '-nogpulib' to
build without ROCm device library
+// NOABI6: error: cannot find ROCm device library for ABI version 6; provide
its path via '--rocm-path' or '--rocm-device-lib-path', or pass '-nogpulib' to
build without ROCm device library
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
