Author: jmgao
Date: Tue Aug 1 12:18:05 2017
New Revision: 309725
URL: http://llvm.org/viewvc/llvm-project?rev=309725&view=rev
Log:
Thread Safety Analysis: fix assert_capability.
Summary:
Previously, the assert_capability attribute was completely ignored by
thread safety analysis.
Reviewers: del
Author: jmgao
Date: Tue Aug 1 12:53:31 2017
New Revision: 309731
URL: http://llvm.org/viewvc/llvm-project?rev=309731&view=rev
Log:
Revert "Thread Safety Analysis: fix assert_capability."
This reverts commit rL309725.
Broke test/Sema/attr-capabilities.c.
Modified:
cfe/trunk/include/clang/Ba
Author: jmgao
Date: Tue Aug 8 12:44:34 2017
New Revision: 310402
URL: http://llvm.org/viewvc/llvm-project?rev=310402&view=rev
Log:
Reland "Thread Safety Analysis: fix assert_capability."
Delete the test that was broken by rL309725, and add it back in a
follow up commit. Also, improve the tests a
Author: jmgao
Date: Tue Aug 8 12:44:35 2017
New Revision: 310403
URL: http://llvm.org/viewvc/llvm-project?rev=310403&view=rev
Log:
Thread Safety Analysis: warn on nonsensical attributes.
Add warnings in cases where an implicit `this` argument is expected to
attributes because either `this` doesn
n Wed, Aug 9, 2017 at 4:45 AM Josh Gao via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: jmgao
>> Date: Tue Aug 8 12:44:35 2017
>> New Revision: 310403
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=310403&view=rev
>> Log:
&g
Author: jmgao
Date: Fri Aug 11 00:54:35 2017
New Revision: 310698
URL: http://llvm.org/viewvc/llvm-project?rev=310698&view=rev
Log:
Revert "Thread Safety Analysis: warn on nonsensical attributes."
This reverts commit rL310403, which caused spurious warnings in libc++,
because it didn't properly h
ng.
>>
>> http://bb.pgr.jp/builders/bootstrap-clang-libcxx-lld-i686-
>> linux/builds/758
>>
>>
>> On Wed, Aug 9, 2017 at 4:45 AM Josh Gao via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author: jmgao
>>> Date: Tue
jmgao updated this revision to Diff 32736.
jmgao added a comment.
Uploading diff with arcanist.
http://reviews.llvm.org/D12181
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGExprScalar.cpp
lib/CodeGen/CodeGenFunction
jmgao marked 8 inline comments as done.
Comment at: tools/clang/lib/CodeGen/CGExpr.cpp:2388
@@ +2387,3 @@
+ }
+ return EmitTrapCheck(Checked);
+}
samsonov wrote:
> This is confusing. So, you have the following behavior whenever you need to
> emit a check for `-
jmgao updated this revision to Diff 32755.
jmgao marked 2 inline comments as done.
jmgao added a comment.
Address comments
http://reviews.llvm.org/D12181
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CGExpr.cpp
lib/Code
jmgao updated this revision to Diff 32756.
jmgao added a comment.
Improve comment
http://reviews.llvm.org/D12181
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
lib/Frontend/Comp
jmgao added a comment.
In http://reviews.llvm.org/D12181#229467, @rsmith wrote:
> In http://reviews.llvm.org/D12181#229358, @rsmith wrote:
>
> > Can you please give a brief description of the motivation for this change?
> > When would it be appropriate to use this rather than `-ftrap-function`?
jmgao updated this revision to Diff 32768.
jmgao added a comment.
Make option fit in 80 cols
http://reviews.llvm.org/D12181
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
lib/Fr
jmgao updated this revision to Diff 32769.
jmgao added a comment.
Doc fix, 80 col
http://reviews.llvm.org/D12181
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
lib/Frontend/Comp
jmgao updated this revision to Diff 32776.
jmgao marked 2 inline comments as done.
jmgao added a comment.
Make methods private
http://reviews.llvm.org/D12181
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CGExpr.cpp
lib/
jmgao updated this revision to Diff 32788.
jmgao marked 7 inline comments as done.
jmgao added a comment.
clang-format, remove \brief from modified doxygen comments.
http://reviews.llvm.org/D12181
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOp
jmgao updated this revision to Diff 32833.
jmgao added a comment.
Remove more `\brief`s
http://reviews.llvm.org/D12181
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
lib/Fronten
jmgao marked an inline comment as done.
Comment at: lib/CodeGen/CGExpr.cpp:2303
@@ -2302,4 +2302,3 @@
- if (TrapCond)
-EmitTrapCheck(TrapCond);
+ if (TrapCond) EmitSanitizeTrapCheck(TrapCond);
if (!FatalCond && !RecoverableCond)
Yes
http://reviews.llv
jmgao marked 4 inline comments as done.
jmgao added a comment.
http://reviews.llvm.org/D12181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jmgao added a comment.
Ping, I think @samsonov was waiting on @rsmith's feedback on the following:
In http://reviews.llvm.org/D12181#229493, @jmgao wrote:
> In http://reviews.llvm.org/D12181#229467, @rsmith wrote:
>
> > In http://reviews.llvm.org/D12181#229358, @rsmith wrote:
> >
> > > Can you p
jmgao added a comment.
With #1, it seems unfortunate to not be able to distinguish between a sanitize
inserted __builtin_trap and code manually calling it. (Would there be an
-fsanitize-trap=trap? :-)
With #2, we're worried about the generated code being noticeably worse in the
unexceptional ca
jmgao created this revision.
jmgao added reviewers: srhines, danalbert.
jmgao added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer, aemerson.
Android target triples can include a version number in the abi field
(e.g. 'aarch64-linux-android21'), used for checki
jmgao updated this revision to Diff 60294.
jmgao added a comment.
Add test.
http://reviews.llvm.org/D21163
Files:
lib/Driver/Driver.cpp
test/Driver/Inputs/android_triple_version/bin/arm-linux-androideabi-ld
test/Driver/Inputs/android_triple_version/bin/arm-linux-androideabi-ld.exe
test/
jmgao added a comment.
Thanks for the review!
http://reviews.llvm.org/D21163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272413: Strip Android version when looking up toolchain
paths. (authored by jmgao).
Changed prior to commit:
http://reviews.llvm.org/D21163?vs=60294&id=60379#toc
Repository:
rL LLVM
http://reviews.l
Author: jmgao
Date: Fri Jun 10 13:30:33 2016
New Revision: 272413
URL: http://llvm.org/viewvc/llvm-project?rev=272413&view=rev
Log:
Strip Android version when looking up toolchain paths.
Summary:
Android target triples can include a version number in the abi field
(e.g. 'aarch64-linux-android21')
this is because using PATH in this way as part of a test doesn't
> work well, but I'll let you look at what the best option is for fixing
> this. For now I've reverted it in
>
> Please watch the bots when committing in the future.
>
> -Chandler
>
> On Fri, Jun 10,
27 matches
Mail list logo
