jmgao added a comment. Ping, I think @samsonov was waiting on @rsmith's feedback on the following:
In http://reviews.llvm.org/D12181#229493, @jmgao wrote: > In http://reviews.llvm.org/D12181#229467, @rsmith wrote: > > > In http://reviews.llvm.org/D12181#229358, @rsmith wrote: > > > > > Can you please give a brief description of the motivation for this > > > change? When would it be appropriate to use this rather than > > > `-ftrap-function`? > > > > > > I'd still like an answer to this. It's not clear to me what the purpose of > > this is, and why you'd want a custom runtime hook for sanitizer traps but > > not other traps. The only time we emit a trap using `-ftrap-function` where > > there is no corresponding sanitizer is for `__builtin_trap()`; is the > > intention that you still want a normal trap for that builtin? > > > The goal is to be able to give a useful fsanitize-specific error message > ("fsanitize trap occurred"), while not lying and saying this for non-sanitize > traps. http://reviews.llvm.org/D12181 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
