[PATCH] D134550: [Clang] Make Clang driver suggest '-Xclang' for CC1 options passed to the driver

jhuber6 added a comment. In D134550#3816239 , @aaron.ballman wrote: > In terms of this patch -- is there sentiment to revert (even temporarily > while we discuss)? I think alternatively we could just change the message to mention that the provided fla

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 updated this revision to Diff 463042. jhuber6 added a comment. Adding test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130096/new/ https://reviews.llvm.org/D130096 Files: clang/lib/CodeGen/CodeGenAction.cpp clang/lib/CodeGen/CodeGenM

[PATCH] D134660: [LinkerWrapper] Fix optimized debugging builds for NVPTX LTO

This revision was automatically updated to reflect the committed changes. Closed by commit rGf50a7c7a26e0: [LinkerWrapper] Fix optimized debugging builds for NVPTX LTO (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134660/new/

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130096/new/ https://reviews.llvm.org/D130096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl, tianshilei1992, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-com

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added inline comments. Comment at: clang/test/CodeGen/amdgcn-link-control-constants.c:2-3 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --function-signature --check-globals --include-generated-funcs --global-value-regex "__oclc

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added inline comments. Comment at: clang/test/CodeGen/amdgcn-link-control-constants.c:2-3 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --function-signature --check-globals --include-generated-funcs --global-value-regex "__oclc

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

This revision was automatically updated to reflect the committed changes. Closed by commit rG11adae50892e: [Clang] Make offloading flags accept '-' and '--' (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135076/new/ https://rev

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

jhuber6 added a comment. In D135076#3830914 , @MaskRay wrote: > Single-dash long options starting with `-o` conflict with the short option > `-o` so I am unsure I like this direction. > >> However, if a user uses a single dash it will instead name a file

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

jhuber6 added a comment. In D135076#3830972 , @MaskRay wrote: > There are traditionally some single-dash long options (perhaps classical Mac > OS style) which conflict with short options. I think nowadays we try to avoid > such single-dash short options

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

jhuber6 added a comment. In D135076#3831298 , @MaskRay wrote: > We really want these `--offload-*` users to stick with one canonical form, > not `-offload-*` in some places while `--offload-*` in other places. > > Another angle is that people find `-offl

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

jhuber6 added a comment. In D135076#3831340 , @MaskRay wrote: > In D135076#3831307 , @jhuber6 wrote: > >> In D135076#3831298 , @MaskRay >> wrote: >> >>> We really want th

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

jhuber6 added a comment. In D135076#3831363 , @MaskRay wrote: > My idea is to just disallow `Joined` `-o` when targeting a specific > environment (e.g. when offloading toolchain is used). This seems difficult as we only know which offloading toolchains

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 updated this revision to Diff 464767. jhuber6 added a comment. Moving test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130096/new/ https://reviews.llvm.org/D130096 Files: clang/lib/CodeGen/CodeGenAction.cpp clang/lib/CodeGen/CodeGenM

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added inline comments. Comment at: clang/test/CodeGen/amdgcn-control-constants.c:8 + +// GFX90A: @__oclc_daz_opt = linkonce_odr hidden local_unnamed_addr addrspace(4) constant i8 0, align 1 +// GFX90A: @__oclc_wavefrontsize64 = linkonce_odr hidden local_unnamed_addr add

[PATCH] D135285: [OpenMP] Make the exec_mode global have protected visibility

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, ronlieb, ABataev. Herald added subscribers: mattd, asavonic, guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl. Herald added a subscriber: inglorion. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The new driv

[PATCH] D135285: [OpenMP] Make the exec_mode global have protected visibility

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8ec170e01dd: [OpenMP] Make the exec_mode global have protected visibility (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135285/new/

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

jhuber6 added a comment. In D135305#3838412 , @yaxunl wrote: > should we test with -ccc-print-phases instead? It is not clear what actions > are produced by driver. Of the four run lines added, three use `-ccc-print-phases`. The last uses just `-###` b

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

jhuber6 added a comment. In D135305#3838412 , @yaxunl wrote: > should we test with -ccc-print-phases instead? It is not clear what actions > are produced by driver. Ah, realized you meant with phases. This is good enough for NVPTX as there is no explic

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

jhuber6 added a comment. In D135305#3838490 , @yaxunl wrote: > In D135305#3838435 , @jhuber6 wrote: > >> In D135305#3838412 , @yaxunl wrote: >> >>> should we test with -cc

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

jhuber6 updated this revision to Diff 465584. jhuber6 added a comment. Changing two tests to use phases instead to illustrate the `lto-bc` usage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135305/new/ https://reviews.llvm.org/D135305 Files: c

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

jhuber6 added inline comments. Comment at: clang/test/Driver/hip-phases.hip:553 +// +// RUN: %clang -### --target=x86_64-linux-gnu --offload-new-driver -ccc-print-phases \ +// RUN:--offload-arch=gfx90a --offload-arch=gfx908 -foffload-lto -fgpu-rdc -c %s 2>&1 \ -

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGac135f9ee574: [Clang] Fix using LTO with the new driver in RDC-mode (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135305/new/ https:/

[PATCH] D135374: [OpenMP][AMDGPU] Add 'uniform-work-group' attribute to OpenMP kernels

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ronlieb, yaxunl, arsenm. Herald added subscribers: kosarev, guansong, t-tye, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-

[PATCH] D135374: [OpenMP][AMDGPU] Add 'uniform-work-group' attribute to OpenMP kernels

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9424-9431 const bool IsHIPKernel = M.getLangOpts().HIP && FD && FD->hasAttr(); + const bool IsOpenMPkernel = + M.getLangOpts().OpenMPIsDevice && + (F->getCallingConv() == llvm::Callin

[PATCH] D135374: [OpenMP][AMDGPU] Add 'uniform-work-group' attribute to OpenMP kernels

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9424-9431 const bool IsHIPKernel = M.getLangOpts().HIP && FD && FD->hasAttr(); + const bool IsOpenMPkernel = + M.getLangOpts().OpenMPIsDevice && + (F->getCallingConv() == llvm::Callin

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, jyknight, MaskRay, yaxunl, aaron.ballman, ronlieb. Herald added a subscriber: StephenFan. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a s

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 updated this revision to Diff 465862. jhuber6 added a comment. Adjusting check to ensure that this only applies for an edit length of zero once the `-` is added. Also adding a negative check line for other inputs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 marked 2 inline comments as done. jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:337 +std::string Nearest; +if (getOpts().findNearest("-" + ArgString, Nearest, IncludedFlagsBitmask, + ExcludedFlagsBitmask) == 1)

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 updated this revision to Diff 465876. jhuber6 marked an inline comment as done. jhuber6 added a comment. Changing test to just check that we emit to warnings in a separate run line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135389/new/

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 added inline comments. Comment at: clang/test/Driver/unknown-arg.c:74 + +// RUN: %clang -### --offload-arch=sm_70 -o ffload-device-only -Werror=unknown-argument %s tra wrote: > Has this patch been updated with incomplete changes? This RUN line seems to

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 updated this revision to Diff 465883. jhuber6 added a comment. Apparently `-###` prevents `clang` from returning a non-zero error code. Fixing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135389/new/ https://reviews.llvm.org/D135389 File

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 added inline comments. Comment at: clang/test/Driver/unknown-arg.c:74 + +// RUN: %clang -### --offload-arch=sm_70 -o ffload-device-only -Werror=unknown-argument %s tra wrote: > jhuber6 wrote: > > tra wrote: > > > Has this patch been updated with incomple

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 updated this revision to Diff 465894. jhuber6 added a comment. Using the implicit check suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135389/new/ https://reviews.llvm.org/D135389 Files: clang/include/clang/Basic/DiagnosticDri

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG5aba68960719: [Clang] Emit a warning for ambiguous joined '-o' arguments (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135389/new/ ht

[PATCH] D135374: [OpenMP][AMDGPU] Add 'uniform-work-group' attribute to OpenMP kernels

This revision was automatically updated to reflect the committed changes. Closed by commit rG4aa87a131f93: [OpenMP][AMDGPU] Add 'uniform-work-group' attribute to OpenMP kernels (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D135374?vs=465769&id=465923#toc Repository:

[PATCH] D135614: [OpenMP][CUDA][AMDGPU] Accept case insensitive subarchitecture names

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, yaxunl, tra. Herald added subscribers: kosarev, mattd, guansong, hiraditya, t-tye, tpr, dstuttard, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-co

[PATCH] D135614: [OpenMP][CUDA][AMDGPU] Accept case insensitive subarchitecture names

jhuber6 added a comment. In D135614#3847775 , @tra wrote: > Is that really something we need/want to do? I've never seen anyone > complaining about this particular issue. > > clang/gcc are case-sensitive for similar options, like `-march`: > https://god

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added a comment. I don't like the fact that we need to have two different kinds of control constants, one per-TU and others per-link job. I'm wondering how difficult it would be to make the fast versions of the math calls use different entry points. That way we could handle this in the

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added a comment. In D130096#3850628 , @arsenm wrote: > In D130096#3850550 , @b-sumner > wrote: > >> There's the "small matter" of implementing the new device library functions. >> Why is all that more l

[PATCH] D135715: [Clang] Do not build the OffloadActionBuilder when using the new driver

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, yaxunl, tra. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The Offloading toolchain currently has two methods

[PATCH] D135715: [Clang] Do not build the OffloadActionBuilder when using the new driver

jhuber6 added a comment. Thanks for the quick review. Comment at: clang/lib/Driver/Driver.cpp:3987-3988 // required. if (!UseNewOffloadingDriver) - if (OffloadBuilder.addHostDependenceToDeviceActions(Current, InputArg)) + if (OffloadBuilder->addHostDependenc

[PATCH] D135715: [Clang] Do not build the OffloadActionBuilder when using the new driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadf36ea32891: [Clang] Do not build the OffloadActionBuilder when using the new driver (authored by jhuber6). Repository: rG LLVM Github Monorepo

[PATCH] D135791: [Clang] Do not crash when an invalid offload architecture is set

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. If an invalid architecture is set we currently ret

[PATCH] D135791: [Clang] Do not crash when an invalid offload architecture is set

jhuber6 updated this revision to Diff 467188. jhuber6 added a comment. Fix missing `None` return on HIP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135791/new/ https://reviews.llvm.org/D135791 Files: clang/lib/Driver/Driver.cpp clang/test/D

[PATCH] D135791: [Clang] Do not crash when an invalid offload architecture is set

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4191 /// or CUDA architecture. -static StringRef getCanonicalArchString(Compilation &C, -const llvm::opt::DerivedArgList &Args, -

[PATCH] D135791: [Clang] Do not crash when an invalid offload architecture is set

jhuber6 updated this revision to Diff 467199. jhuber6 added a comment. Making suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135791/new/ https://reviews.llvm.org/D135791 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/cu

[PATCH] D135791: [Clang] Do not crash when an invalid offload architecture is set

jhuber6 updated this revision to Diff 467204. jhuber6 added a comment. Making suggested changes, Early exists is part of the LLVM style so it's definitely better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135791/new/ https://reviews.llvm.org/D

[PATCH] D135791: [Clang] Do not crash when an invalid offload architecture is set

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d72f445f799: [Clang] Do not crash when an invalid offload architecture is set (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135791/ne

[PATCH] D136100: [clang-format] Do not parse certain characters in pragma directives

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ronlieb, MyDeveloperDay, owenpan, HazardyKnusperkeks, curdeius, wanders. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a proje

[PATCH] D136111: [OpenMP] Make device functions have hidden visibility

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, saiislam, JonChesterfield, ABataev, tianshilei1992, RaviNarayanaswamy, gregrodgers. Herald added subscribers: mattd, asavonic, guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added s

[PATCH] D136111: [OpenMP] Make device functions have hidden visibility

jhuber6 updated this revision to Diff 468328. jhuber6 added a comment. We can't make every function hidden for non-GPU offloading. So we only apply it to the functions inside the `declare target` clause there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

jhuber6 added a comment. In D140226#4003781 , @keryell wrote: > I wonder whether we could not factorize some code/attribute/logic with AMDGPU > or SYCL. > Is the use case to have for example CUDA+HIP+SYCL in the same TU and thus > there is a need for di

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

jhuber6 added a comment. In D140226#4003788 , @tschuett wrote: > There are already SYCL specific attributes: https://reviews.llvm.org/D60455 We could potentially merge these all into some generic attribute since they all do the same thing on a conceptua

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

jhuber6 added a comment. In D140226#4003826 , @tschuett wrote: > But then you are maybe mixing two concepts. `kernel` is source code or AST > feature. nvptx or AMDGPU are command line flags. > > CUDA, Sycl, nvtx, and AMDGPU are modes or calling conventio

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

jhuber6 added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1198 -def CUDAGlobal : InheritableAttr { - let Spellings = [GNU<"global">, Declspec<"__global__">]; +def CUDAGlobal : InheritableAttr, TargetSpecificAttr { + let Spellings = [GNU<"global">, Declspec<

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, tra, yaxunl, jdoerfert, tianshilei1992, MaskRay. Herald added subscribers: kosarev, mattd, gchakrabarti, asavonic, StephenFan, tpr. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscri

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

jhuber6 added inline comments. Comment at: clang/tools/nvptx-arch/NVPTXArch.cpp:63 + +printf("sm_%d%d\n", Major, Minor); + } tianshilei1992 wrote: > Do we want to include device number here? For `amdgpu-arch` and here we just have it implicitly in the order,

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

jhuber6 updated this revision to Diff 484594. jhuber6 added a comment. Change header I copied from the AMD implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140433/new/ https://reviews.llvm.org/D140433 Files: clang/tools/CMakeLists.t

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

jhuber6 updated this revision to Diff 484637. jhuber6 added a comment. Print to `stderr` and only return `1` if thre was an actual error. A lack of devices is considered a success and we print nothing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D140155: [Clang][OpenMP] Allow host call to nohost function with host variant

jhuber6 added a comment. In D140155#4016274 , @mgorny wrote: > In D140155#4004505 , @doru1004 > wrote: > >> Commit 658ed9547cdd6657895339a6c390c31aa77a5698 >>

[PATCH] D140155: [Clang][OpenMP] Allow host call to nohost function with host variant

jhuber6 added a comment. In D140155#4016274 , @mgorny wrote: > In D140155#4004505 , @doru1004 > wrote: > >> Commit 658ed9547cdd6657895339a6c390c31aa77a5698 >>

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5a5ee856e7c: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140433/new/

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

jhuber6 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:276-277 + + StringRef RawData(CGOutputBuffer.begin(), CGOutputBuffer.size()); + return MemoryBuffer::getMemBufferCopy(RawData); +} tianshilei1992 wrot

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

jhuber6 added inline comments. Comment at: clang/tools/nvptx-arch/CMakeLists.txt:19 +if (NOT CUDA_FOUND OR NOT cuda-library) + message(STATUS "Not building nvptx-arch: cuda runtime not found") + return() tra wrote: > Nit: libcuda.so is part of the NVIDIA driver

[PATCH] D141051: [CUDA]HIP] Add support for `--offload-arch=native` to CUDA and refactor

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, yaxunl, MaskRay. Herald added subscribers: kosarev, mattd, carlosgalvezp, asavonic, StephenFan, kerbowa, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, s

[PATCH] D141078: [CUDA][HIP] Support '--offload-arch=native' for the new driver

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, tra, yaxunl. Herald added subscribers: kosarev, mattd, asavonic, kerbowa, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Her

[PATCH] D141078: [CUDA][HIP] Support '--offload-arch=native' for the new driver

jhuber6 added inline comments. Comment at: clang/test/Driver/amdgpu-hip-system-arch.c:17 // RUN: | FileCheck %s --check-prefix=NO-OUTPUT-ERROR +// RUN: %clang -### --target=x86_64-unknown-linux-gnu -nogpulib --offload-arch=native --offload-new-driver --amdgpu-arch-tool=%t/

[PATCH] D141078: [CUDA][HIP] Support '--offload-arch=native' for the new driver

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4275 +TC->getDriver().Diag(diag::err_drv_undetermined_gpu_arch) +<< (TC->getTriple().isNVPTX() ? "NVPTX" : "AMDGPU") +<< llvm::toString(GPUsOrErr.takeError()) << "--

[PATCH] D141051: [CUDA][HIP] Add support for `--offload-arch=native` to CUDA and refactor

jhuber6 updated this revision to Diff 486739. jhuber6 added a comment. Change error to print canonical arch name from Triple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141051/new/ https://reviews.llvm.org/D141051 Files: clang/include/clang/B

[PATCH] D141078: [CUDA][HIP] Support '--offload-arch=native' for the new driver

jhuber6 updated this revision to Diff 486741. jhuber6 added a comment. Change error to use canonical arch string from the triple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141078/new/ https://reviews.llvm.org/D141078 Files: clang/lib/Driver/

[PATCH] D141105: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, tra, yaxunl. Herald added a subscriber: guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a pro

[PATCH] D141105: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading

jhuber6 added a comment. In D141105#4031103 , @JonChesterfield wrote: > Possible naming hazard here. march=native means target the local processor > architecture, zen2 or whatever, and we have the host CPU as an offloading > target already. So what I'd

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

jhuber6 added a comment. In D139287#4031469 , @hbae wrote: > Looks like GCC 7.5 cannot build LLVM after this change. Could you please take > a look? > > In file included from > /localdisk/hbae/LLVM/llvm-base/openmp/libomptarget/plugins-nextgen/common/

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

jhuber6 added a comment. In D139287#4031503 , @hbae wrote: > In D139287#4031473 , @jhuber6 wrote: > >> In D139287#4031469 , @hbae wrote: >> >>> Looks like GCC 7.5 cannot b

[PATCH] D141105: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading

jhuber6 updated this revision to Diff 486901. jhuber6 added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141105/new/ https://reviews.llvm.org/D141105 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Driver.cpp

[PATCH] D141158: [OpenMP] Introduce '-f[no]-openmp-target-jit' flag to control JIT for offloading

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, MaskRay, ggeorgakoudis, tianshilei1992. Herald added subscribers: StephenFan, guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan

[PATCH] D141158: [OpenMP] Introduce '-f[no]-openmp-target-jit' flag to control JIT for offloading

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:730 + ? LTOK_Full + : OffloadLTOMode; } jdoerfert wrote: > Should we overwrite unconditionally or warn/error if the combination is > nonsensic

[PATCH] D141158: [OpenMP] Introduce '-f[no]-openmp-target-jit' flag to control JIT for offloading

jhuber6 updated this revision to Diff 486991. jhuber6 added a comment. Adding an error print and some tests for it. We error if the user specified any `-foffload-lto` optoins that don't result in full LT.O Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D141158: [OpenMP] Introduce '-f[no-]openmp-target-jit' flag to control JIT for offloading

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5f746f1efd4: [OpenMP] Introduce '-f[no-]openmp-target-jit' flag to control JIT for offloading (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D141158: [OpenMP] Introduce '-f[no-]openmp-target-jit' flag to control JIT for offloading

jhuber6 added a comment. In D141158#4035875 , @gribozavr2 wrote: > The newly added test fails when `tools/clang/include/clang/Config/config.h` > is configured with `#define CLANG_DEFAULT_OPENMP_RUNTIME "libgomp"`. Please > fix. Thanks! Should be fixed

[PATCH] D141051: [CUDA][HIP] Add support for `--offload-arch=native` to CUDA and refactor

jhuber6 added inline comments. Comment at: clang/test/Driver/amdgpu-hip-system-arch.c:24 + +// case when amdgpu_arch does not return anything with successful execution +// RUN: %clang -### --target=x86_64-unknown-linux-gnu -nogpulib --offload-arch=native --amdgpu-arch-tool=%t/

[PATCH] D141051: [CUDA][HIP] Add support for `--offload-arch=native` to CUDA and refactor

jhuber6 updated this revision to Diff 487503. jhuber6 added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141051/new/ https://reviews.llvm.org/D141051 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include

[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

jhuber6 created this revision. jhuber6 added reviewers: arsenm, jdoerfert, tianshilei1992, yaxunl, JonChesterfield. Herald added subscribers: kosarev, kerbowa, guansong, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscri

[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4411 ++TCAndArch; } } JonChesterfield wrote: > Why is rdc involved here? HIP goes straight through a separate linker phase in non-RDC mode. Setting the type here would pr

[PATCH] D141105: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:894 +return; + } + jdoerfert wrote: > Does this necessarily mean we failed with `=native`, if so it's ok. Just > didn't follow the logic

[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

jhuber6 updated this revision to Diff 488187. jhuber6 added a comment. I realized that if I fix up how we propagate the ToolChains I can use it in `ConstructPhaseAction`. Should be cleaner this way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141

[PATCH] D141105: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading

jhuber6 updated this revision to Diff 488193. jhuber6 added a comment. Change to `SuppressError` and make`--offload-arch=` just default to native. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141105/new/ https://reviews.llvm.org/D141105 Files:

[PATCH] D141078: [CUDA][HIP] Support '--offload-arch=native' for the new driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGfada90286008: [CUDA][HIP] Support '--offload-arch=native' for the new driver (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D141078?vs=486741&id=488237#toc Repository: rG LL

[PATCH] D141051: [CUDA][HIP] Add support for `--offload-arch=native` to CUDA and refactor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56ebfca4bcc0: [CUDA][HIP] Add support for `--offload-arch=native` to CUDA and refactor (authored by jhuber6). Repository: rG LLVM Github Monorepo

[PATCH] D141105: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa17ab7aa3be0: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading (authored by jhuber6). Repository: rG LLVM Github Monorepo CH

[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d9afee3d159: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode (authored by jhuber6). Repository: rG LLVM Github Monorep

[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

jhuber6 added a comment. In D141440#4044300 , @Jake-Egan wrote: > Getting a build failure on AIX, could you take a look please? > > > /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/clang/lib/Driver/Driver.cpp:5715:37: > error: la

[PATCH] D137180: [LinkerWrapper] report on missing libraries

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1278 + if (identify_magic((*BufferOrErr)->getBuffer()) != file_magic::archive) +continue; + jdoerfert wrote: > So if the library is found but not an ar

[PATCH] D137180: [LinkerWrapper] report on missing libraries

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1278 + if (identify_magic((*BufferOrErr)->getBuffer()) != file_magic::archive) +continue; + jdoerfert wrote: > jhuber6 wrote: > > jdoerfert wrote: > >

[PATCH] D137180: [LinkerWrapper] report on missing libraries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9ee2acc9c5c: [LinkerWrapper] report on missing libraries (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D137180?vs=4723

[PATCH] D136796: [llvm-objdump][Offload] Use common offload extraction method

jhuber6 added a comment. Is this good to land now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136796/new/ https://reviews.llvm.org/D136796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D136796: [llvm-objdump][Offload] Use common offload extraction method

jhuber6 added a comment. In D136796#3904512 , @jhenderson wrote: > In D136796#3903393 , @jhuber6 wrote: > >> Is this good to land now? > > The LLVM community practice is to wait a week between pings unless there'

[PATCH] D136796: [llvm-objdump][Offload] Use common offload extraction method

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3384f05a2cdb: [llvm-objdump][Offload] Use common offload extraction method (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SIN

<    3   4   5   6   7   8   9   10   11   12   >