[PATCH] D117049: [OpenMP] Add support for embedding bitcode images in wrapper tool

jhuber6 updated this revision to Diff 404785. jhuber6 added a comment. Removing clang flag because LTO won't be supported when these land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117049/new/ https://reviews.llvm.org/D117049 Files: clang/li

[PATCH] D116545: [OpenMP] Add support for extracting device code in linker wrapper

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb8239af0eeed: [OpenMP] Add support for extracting device code in linker wrapper (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D116627: [Clang] Initial support for linking offloading code in tool

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0744585f9ea: [Clang] Initial support for linking offloading code in tool (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org

[PATCH] D116675: [OpenMP] Search for static libraries in offload linker tool

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e82c7553be9: [OpenMP] Search for static libraries in offload linker tool (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D116975: [OpenMP] Initial Implementation of LTO and bitcode linking in linker wrapper

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc732c3df749b: [OpenMP] Initial Implementation of LTO and bitcode linking in linker wrapper (authored by jhuber6). Changed prior to commit: https:/

[PATCH] D117048: [OpenMP] Link the bitcode library late for device LTO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3762111aa960: [OpenMP] Link the bitcode library late for device LTO (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D117049: [OpenMP] Add support for embedding bitcode images in wrapper tool

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf28c3153ee6d: [OpenMP] Add support for embedding bitcode images in wrapper tool (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D117156: [OpenMP] Add extra flag handling to linker wrapper

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jhuber6 marked an inline comment as done. Closed by commit rGcb7cfaec7185: [OpenMP] Add extra flag handling to linker wrapper (authored by jhuber6). Repository: rG L

[PATCH] D117246: [OpenMP] Add support for linking AMDGPU images

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce16ca3c7419: [OpenMP] Add support for linking AMDGPU images (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118155: [OpenMP] Improve symbol resolution for OpenMP Offloading LTO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46d019041cd9: [OpenMP] Improve symbol resolution for OpenMP Offloading LTO (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D118197: [OpenMP] Replace sysmtem call to `llc` with target machine

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb6ddf288cd0: [OpenMP] Replace sysmtem call to `llc` with target machine (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D118198: [OpenMP] Remove call to 'clang-offload-wrapper' binary

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19fac745e322: [OpenMP] Remove call to 'clang-offload-wrapper' binary (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D118

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

jhuber6 added a comment. In D116541#3287330 , @thakis wrote: > Tests have been failing on Mac for over 20 hours now. Time to revert and fix > async? > >% bin/clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda > -fopenmp-new-driver -no-c

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

jhuber6 added a comment. In D116541#3287379 , @thakis wrote: > Just build and run tests on any mac. This fails on 3 different macs I tried > (2x arm, 1x intel), in a bunch of different build configs. > > For the particular build I sent the output from, t

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

jhuber6 added a comment. Removed the two lines in rG28c15341368b , let me know if this lets the tests pass. I'll look into getting an access somehow so I can reproduce this and figure it out. Repository: rG LLVM Github Mon

[PATCH] D118815: [Clang][Docs] Add documentino for new OpenMP offloading driver

jhuber6 created this revision. jhuber6 added reviewers: tianshilei1992, jdoerfert, JonChesterfield, ronlieb, ye-luo. Herald added subscribers: arphaman, guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Thi

[PATCH] D118815: [Clang][Docs] Add documentino for new OpenMP offloading driver

jhuber6 updated this revision to Diff 405331. jhuber6 added a comment. Forgot to include new file in index. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118815/new/ https://reviews.llvm.org/D118815 Files: clang/docs/ClangCommandLineReference.rs

[PATCH] D118815: [Clang][Docs] Add documention for new OpenMP offloading driver

jhuber6 added inline comments. Comment at: clang/docs/OffloadingDesign.rst:25 +Clang supports OpenMP target offloading to several different architectures such +as NVPTX, AMDGPU, and X86_64. Offloading code is generated by Clang and then +executed using the ``libomptarget`` runtim

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992. Herald added subscribers: dexonsmith, dang, guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added projects: clang, OpenMP. The run

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jhuber6 updated this revision to Diff 409845. jhuber6 added a comment. Making suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120106/new/ https://reviews.llvm.org/D120106 Files: clang/include/clang/Basic/LangOptions.def clang/

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jhuber6 updated this revision to Diff 409847. jhuber6 added a comment. Change name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120106/new/ https://reviews.llvm.org/D120106 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jhuber6 updated this revision to Diff 409850. jhuber6 added a comment. Changing assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120106/new/ https://reviews.llvm.org/D120106 Files: clang/include/clang/Basic/LangOptions.def clang/include/cl

[PATCH] D120106: [OpenMP] Add flag for disabling thread state in runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rG0870a4f59aef: [OpenMP] Add flag for disabling thread state in runtime (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120106/new/ https

[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield. Herald added subscribers: ormris, guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Currently we use the `-fembed-offload-o

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the offload kind to the embedded section name in preparation for offloading

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl. Herald added a subscriber: carlosgalvezp. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the basic support fo

[PATCH] D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. After basic support for embedding and handling

[PATCH] D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

jhuber6 updated this revision to Diff 410370. jhuber6 added a comment. Make sure we don't pass PTX to nvlink. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120273/new/ https://reviews.llvm.org/D120273 Files: clang/tools/clang-linker-wrapper/Clan

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jhuber6 added a comment. In D120271#3336277 , @jdoerfert wrote: > The failing test needs to be adjusted, right? Yes, forgot about that. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:187 +return LHS.OffloadKin

[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

jhuber6 added a comment. In D120270#3336272 , @jdoerfert wrote: > Can we have a test for this? Sure. Comment at: clang/include/clang/CodeGen/BackendUtil.h:48 - void EmbedObject(llvm::Module *M, const CodeGenOptions &CGOpts,

[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

jhuber6 updated this revision to Diff 410405. jhuber6 added a comment. Removing unrelated changes and adding test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120270/new/ https://reviews.llvm.org/D120270 Files: clang/lib/CodeGen/CodeGenModule.

[PATCH] D120288: [OpenMP] Implement dense map info for device file

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch implements a DenseMap info struct fo

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jhuber6 updated this revision to Diff 410413. jhuber6 added a comment. Updating after moving dense map implementation out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120271/new/ https://reviews.llvm.org/D120271 Files: clang/lib/Driver/ToolCha

[PATCH] D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

jhuber6 updated this revision to Diff 410414. jhuber6 added a comment. Changing after rebasing previous commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120273/new/ https://reviews.llvm.org/D120273 Files: clang/tools/clang-linker-wrapper/C

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jhuber6 added a comment. In D120271#3338034 , @saiislam wrote: > Will it be possible to use Bundle Entry ID format [1] for naming sections and > being sort of the the primary key to refer an offload object? > The arch string following the triple will be

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, ABataev. Herald added subscribers: dexonsmith, dang, guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Curr

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

jhuber6 added a comment. In D120353#3338589 , @ABataev wrote: >> This is necessary for implementing features like conditional offloading and >> ensuring that unhandled pragmas don't result in missing symbols. > > This behavior is part of the standard. I

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

jhuber6 added a comment. In D120353#3338718 , @ABataev wrote: > In D120353#3338647 , @jhuber6 wrote: > >> But the main reason I made this patch is for interoperability. Without this >> if you want to call a CUDA

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

jhuber6 added a comment. In D120353#3340533 , @ABataev wrote: > In D120353#3338770 , @jhuber6 wrote: > >> In D120353#3338718 , @ABataev >> wrote: >> >>> In D120353#333864

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

jhuber6 added a comment. In D120353#3340606 , @ABataev wrote: > In D120353#3340596 , @jhuber6 wrote: > >> If we have `#pragma omp target if (...)` then that requires a host fallback >> and violates the assertion

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

jhuber6 updated this revision to Diff 410846. jhuber6 added a comment. Adding test case to check `if` codegen for unreachables, and an extra function to show that it is not created for the host while the other is. Also added an error message when the user specified offloading is mandatory but co

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

jhuber6 added a comment. In D120353#3340744 , @ABataev wrote: > Could you add a test with the device clause too? Which clause exactly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120353/new/ https://rev

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

jhuber6 updated this revision to Diff 410851. jhuber6 added a comment. Adding test function with device clause Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120353/new/ https://reviews.llvm.org/D120353 Files: clang/include/clang/Basic/LangOption

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

jhuber6 added a comment. In D120353#3340775 , @ABataev wrote: > I assume it would be good to notify the user somehow about target regions, > which may require execution on the host. Maybe add a note during the codegen > phase? Technically all of them m

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

jhuber6 added a comment. In D120353#3340863 , @JonChesterfield wrote: > Thanks! Seems a good thing to add to the offloading test runner, preferably > in a separate change to avoid reverting this in case of unforeseen problems Could definitely do that,

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

jhuber6 updated this revision to Diff 410919. jhuber6 added a comment. Guarding where we set attrs in the case that it's not a valid function now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120353/new/ https://reviews.llvm.org/D120353 Files:

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b97b16f294a: [OpenMP] Add option to make offloading mandatory (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

jhuber6 updated this revision to Diff 412810. jhuber6 added a comment. Herald added a project: All. Updating to use fatbinaries and fatbinary magic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120273/new/ https://reviews.llvm.org/D120273 Files:

[PATCH] D120934: [OpenMP][NFC] Refactor new driver to be more general

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This path refactor

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 412812. jhuber6 added a comment. Herald added a subscriber: dang. Herald added a project: All. Updating, embed fatbinaries now and small changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https:

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 412816. jhuber6 added a comment. Adding comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/i

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 412821. jhuber6 added a comment. Adding test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/inclu

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4099-4102 + for (auto &Arg : Args.getAllArgValues(options::OPT_offload_arch_EQ)) +Archs.insert(getCanonicalArchString(C, Args, Arg, Kind)); + for (auto &Arg : Args.getAllArgValues(options::OPT_no_offload

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 412908. jhuber6 added a comment. Correctly handle offloading architecture options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/Basic/

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 412996. jhuber6 added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 413087. jhuber6 added a comment. Herald added a subscriber: dexonsmith. Addressing nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4132-4134 + Archs.insert(CudaArchToString(CudaArch::SM_35)); +else if (Kind == Action::OFK_HIP) + Archs.insert(CudaArchToString(CudaArch::GFX803)); tra wrote: > JonChesterfield w

[PATCH] D101564: [OpenMP] Fix second debug name from map clause

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101564/new/ https://reviews.llvm.org/D101564

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jhuber6 updated this revision to Diff 343469. jhuber6 added a comment. Rebasing. The previous change to the test files required massive changes that made the file size too big to upload, so context is limited. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jhuber6 updated this revision to Diff 344538. jhuber6 added a comment. Fixing tests again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97680/new/ https://reviews.llvm.org/D97680 Files: clang/include/clang/Basic/LangOptions.def clang/include/

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb. Herald added subscribers: ormris, dexonsmith, dang, guansong, hiraditya, yaxunl, mgorny. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

jhuber6 updated this revision to Diff 397089. jhuber6 added a comment. Updating to only contain this commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116541/new/ https://reviews.llvm.org/D116541 Files: clang/include/clang/Driver/Driver.h

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb. Herald added subscribers: ormris, dexonsmith, dang, guansong, hiraditya, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald

[PATCH] D116543: [OpenMP] Embed device files into the host IR

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds support f

[PATCH] D116544: [Clang] Introduce Clang Linker Wrapper Tool

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb. Herald added a subscriber: mgorny. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch introduces a linker wra

[PATCH] D116545: [OpenMP] Add support for extracting device code in linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb. Herald added subscribers: guansong, yaxunl, mgorny. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patchs add s

[PATCH] D116627: [Clang] Initial support for linking offloading code in tool

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb. Herald added subscribers: pengfei, tpr. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the initial s

[PATCH] D116627: [Clang] Initial support for linking offloading code in tool

jhuber6 updated this revision to Diff 397589. jhuber6 added a comment. Small changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116627/new/ https://reviews.llvm.org/D116627 Files: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp Inde

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

jhuber6 updated this revision to Diff 397590. jhuber6 added a comment. Clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116542/new/ https://reviews.llvm.org/D116542 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clan

[PATCH] D116627: [Clang] Initial support for linking offloading code in tool

jhuber6 updated this revision to Diff 397593. jhuber6 added a comment. Need to tell llc to make position independent code so we can link it properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116627/new/ https://reviews.llvm.org/D116627 Files:

[PATCH] D116675: [OpenMP] Search for static libraries in offload linker tool

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds support f

[PATCH] D116975: [OpenMP] Initial Implementation of LTO and bitcode linking in linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb. Herald added subscribers: guansong, hiraditya, inglorion, yaxunl, mgorny. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added

[PATCH] D116975: [OpenMP] Initial Implementation of LTO and bitcode linking in linker wrapper

jhuber6 updated this revision to Diff 398748. jhuber6 added a comment. Undoing accidental clang format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116975/new/ https://reviews.llvm.org/D116975 Files: clang/lib/Driver/Driver.cpp clang/lib/Dri

[PATCH] D116975: [OpenMP] Initial Implementation of LTO and bitcode linking in linker wrapper

jhuber6 updated this revision to Diff 398821. jhuber6 added a comment. Herald added subscribers: ormris, steven_wu. Fix tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116975/new/ https://reviews.llvm.org/D116975 Files: clang/lib/Driver/Dri

[PATCH] D117048: [OpenMP] Link the bitcode library late for device LTO

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, ronlieb, gregrodgers, JonChesterfield. Herald added subscribers: kerbowa, guansong, inglorion, yaxunl, nhaehnle, jvesely. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a pr

[PATCH] D117049: [OpenMP] Add support for embedding bitcode images in wrapper tool

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, ronlieb, gregrodgers, JonChesterfield. Herald added subscribers: ormris, dang, steven_wu, guansong, hiraditya, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald

[PATCH] D117048: [OpenMP] Link the bitcode library late for device LTO

jhuber6 added a comment. In D117048#3235763 , @JonChesterfield wrote: > Do we have a hook where we could link it at, uh, link time on nvtptx without > LTO? Amdgpu had a llvm-link already there. Always bothered me a little that > we link a copy per TU t

[PATCH] D117048: [OpenMP] Link the bitcode library late for device LTO

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8159 + std::string BitcodeSuffix; + if (TCArgs.hasFlag(options::OPT_fopenmp_target_new_runtime, + options::OPT_fno_openmp_target_new_runtime, true))

[PATCH] D117049: [OpenMP] Add support for embedding bitcode images in wrapper tool

jhuber6 updated this revision to Diff 399373. jhuber6 added a comment. Update approach, improve LTO file handling for multiple outputs and don't change the LTO config. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117049/new/ https://reviews.llvm.

[PATCH] D117049: [OpenMP] Add support for embedding bitcode images in wrapper tool

jhuber6 updated this revision to Diff 399460. jhuber6 added a comment. Forgot to use hook. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117049/new/ https://reviews.llvm.org/D117049 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td cla

[PATCH] D117156: [OpenMP] Add extra flag handling to linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ronlieb. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds support for a few extr

[PATCH] D117246: [OpenMP] Add support for linking AMDGPU images

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstef

[PATCH] D117320: [OpenMP] Mark device RTL variables as hidden

jhuber6 updated this revision to Diff 400137. jhuber6 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix test and add the fact that its hidden to the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117

[PATCH] D117362: [OpenMP] Remove hidden visibility for declare target variables

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch changes the visiblity of variables de

[PATCH] D117362: [OpenMP] Remove hidden visibility for declare target variables

jhuber6 updated this revision to Diff 400292. jhuber6 added a comment. Changing method to use an early exit, previously visibility would still be hidden for some constructs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117362/new/ https://reviews

[PATCH] D117362: [OpenMP] Remove hidden visibility for declare target variables

jhuber6 updated this revision to Diff 400328. jhuber6 added a comment. Updating again, wasn't handling static variables declared in a record context properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117362/new/ https://reviews.llvm.org/D11736

[PATCH] D115157: [openmp] Default to new rtl for amdgpu

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. If it works on your end it's good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115157/new/ https://reviews.llvm.org/D115157 ___

[PATCH] D113623: [OpenMP][FIX] Pass the num_threads value directly to parallel_51

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc9c4d7216a5: [OpenMP][FIX] Pass the num_threads value directly to parallel_51 (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113623/ne

[PATCH] D115888: [Attributor][Fix] Add alignment return attribute to HeapToStack

jhuber6 added a comment. I will split this into two revisions, one handling the return alignment attribute in the Attributor, and one adding alignment information to the `__kmpc_alloc_shared` OpenMP runtime call, turning it into an aligned allocation. Comment at: clang/lib/C

[PATCH] D115888: [Attributor][Fix] Add alignment return attribute to HeapToStack

jhuber6 updated this revision to Diff 395182. jhuber6 added a comment. Removing OpenMP code, only adding support for return alignments. Fixing OpenMP will occur in a following patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115888/new/ https:/

[PATCH] D115888: [Attributor][Fix] Add alignment return attribute to HeapToStack

jhuber6 updated this revision to Diff 395187. jhuber6 added a comment. Removing else if, we should be able to check for all allocations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115888/new/ https://reviews.llvm.org/D115888 Files: llvm/lib/T

[PATCH] D115888: [Attributor][Fix] Add alignment return attribute to HeapToStack

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG38fc89623b3e: [Attributor][Fix] Add alignment return attribute to

[PATCH] D99681: [OpenMP] Pass mapping names to add components in a user defined mapper

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Currently the mapping names are not passed to the mapper compon

[PATCH] D99681: [OpenMP] Pass mapping names to add components in a user defined mapper

jhuber6 updated this revision to Diff 334768. jhuber6 added a comment. Adding test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99681/new/ https://reviews.llvm.org/D99681 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMP

[PATCH] D99681: [OpenMP] Pass mapping names to add components in a user defined mapper

This revision was automatically updated to reflect the committed changes. Closed by commit rG69ca50bd7dfd: [OpenMP] Pass mapping names to add components in a user defined mapper (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D996

[PATCH] D93785: [OpenMP][FIX] Ensure the isa trait is evaluated last

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93785/new/ https://reviews.llvm.org/D93785 ___

[PATCH] D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled

jhuber6 updated this revision to Diff 314899. jhuber6 retitled this revision from "[NVPTX] Strip debugging symbols for optimized NVPTX targets." to "[NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled". jhuber6 edited the summary of this revision. jhuber6 added a

[PATCH] D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ca5e68aa07e: [NVPTX] Fix debugging information being added to NVPTX target if remarks are… (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D94806: [OpenMP] Add support for mapping names in mapper API

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, sstefan1. Herald added projects: clang, OpenMP, LLVM. The custom mapper AP

[PATCH] D94806: [OpenMP] Add support for mapping names in mapper API

jhuber6 updated this revision to Diff 317038. jhuber6 added a comment. Fixed test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94806/new/ https://reviews.llvm.org/D94806 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_m

<    10   11   12   13   14   15   16   >