jhuber6 added a comment.

In D120270#3336272 <https://reviews.llvm.org/D120270#3336272>, @jdoerfert wrote:

> Can we have a test for this?

Sure.



================
Comment at: clang/include/clang/CodeGen/BackendUtil.h:48
 
-  void EmbedObject(llvm::Module *M, const CodeGenOptions &CGOpts,
                    DiagnosticsEngine &Diags);
----------------
jdoerfert wrote:
> Seems unrelated, please remove it from this patch.
Yeah this is unrelated somewhat, just felt like changing it after doing another 
pass through. I can probably just commit this separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120270/new/

https://reviews.llvm.org/D120270

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to