[PATCH] D129383: [LinkerWrapper] Fix use of string savers and correctly pass bitcode libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rGd36b96afb224: [LinkerWrapper] Fix use of string savers and correctly pass bitcode libraries (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D129393: [Clang] Fix the wrong features being derivec in the offload packager

This revision was automatically updated to reflect the committed changes. Closed by commit rG24849c9eb504: [Clang] Fix the wrong features being derivec in the offload packager (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12939

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jhuber6 added a comment. In D102107#3640198 , @dhruvachak wrote: > Thanks. I followed the above steps and regenerated a couple of the AST tests > but they still fail. Perhaps I am missing some options? > > I currently have a handful of clang test failur

[PATCH] D129423: [LinkerWrapper] Fix errors not exiting inside of the LTO pipeline

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, ye-luo. Herald added a subscriber: inglorion. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The LTO pipeline handles i

[PATCH] D129423: [LinkerWrapper] Fix errors not exiting inside of the LTO pipeline

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbd3ade17bc1: [LinkerWrapper] Fix errors not exiting inside of the LTO pipeline (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129423/n

[PATCH] D129424: [LinkerWrapper] Forward `-mllvm` options to the linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, ye-luo, JonChesterfield, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This p

[PATCH] D129424: [LinkerWrapper] Forward `-mllvm` options to the linker wrapper

jhuber6 updated this revision to Diff 443464. jhuber6 added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129424/new/ https://reviews.llvm.org/D129424 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Drive

[PATCH] D129424: [LinkerWrapper] Forward `-mllvm` options to the linker wrapper

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG22a01b860b90: [LinkerWrapper] Forward `-mllvm` options to the linker wrapper (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D129435: [Clang] Parse toolchain-specific offloading arguments directly

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl, MaskRay. Herald added subscribers: kosarev, StephenFan, tpr. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a proje

[PATCH] D122069: [Clang] Add binary format for bundling offloading metadata

jhuber6 updated this revision to Diff 417685. jhuber6 added a comment. Updating to use path instead of generic cmdline, makes it a lot easier to pass it. Also just adding a reserved field in case I want to add the cmdline back. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122352: [OpenMP] Do not create offloading entries for internal or hidden symbols

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ronlieb, ABataev. Herald added subscribers: asavonic, guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project

[PATCH] D122352: [OpenMP] Do not create offloading entries for internal or hidden symbols

jhuber6 updated this revision to Diff 417751. jhuber6 added a comment. Adding new test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122352/new/ https://reviews.llvm.org/D122352 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/de

[PATCH] D122352: [OpenMP] Do not create offloading entries for internal or hidden symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rG0d16c23af1da: [OpenMP] Do not create offloading entries for internal or hidden symbols (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D122089: [CUDA] Add getTargetFeatures for the NVPTX toolchain

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:648 +#define CASE_CUDA_VERSION(CUDA_VER, PTX_VER) \ + case CudaVersion::CUDA_##CUDA_VER: \ +PtxFeature = "+ptx" #PTX_

[PATCH] D122403: [OpenMP] Add a sematnic check for updating hidden or internal values

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, ABataev. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: c

[PATCH] D122443: [OpenMP] Replace device kernel linkage with weak_odr

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield. Herald added subscribers: asavonic, guansong, yaxunl, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a

[PATCH] D122403: [OpenMP] Add a semantic check for updating hidden or internal values

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfda79341bb5: [OpenMP] Add a semantic check for updating hidden or internal values (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D122403?vs=417932&id=418078#toc Repository:

[PATCH] D122069: [Clang] Add binary format for bundling offloading metadata

jhuber6 updated this revision to Diff 418227. jhuber6 added a comment. Splitting this out into a patch for the format. Adding a unit test and changing strings to now be an arbitrary string map. Hopefully the move to LLVM proper won't draw ire for creating another binary format in LLVM. Repositor

[PATCH] D122443: [OpenMP] Replace device kernel linkage with weak_odr

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9f67d44ba37: [OpenMP] Replace device kernel linkage with weak_odr (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122443/new/ https://

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

jhuber6 updated this revision to Diff 418255. jhuber6 added a comment. Changing test, `uniform_int_distribution` doesn't support `char` or `uint8_t` according to the standard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122069/new/ https://revie

[PATCH] D122504: [OpenMP] Make Ctor / Dtor functions have external visibility

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ronlieb, ABataev. Herald added subscribers: asavonic, guansong, tpr, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a pr

[PATCH] D122504: [OpenMP] Make Ctor / Dtor functions have external visibility

jhuber6 updated this revision to Diff 418321. jhuber6 added a comment. Herald added a subscriber: jvesely. Changing approach, we should optionally use internal linkage for the ctor creation function since it's not correct to add the internal linkage attributes and then make it external. Also remov

[PATCH] D122504: [OpenMP] Make Ctor / Dtor functions have external visibility

jhuber6 added a comment. In D122504#3408947 , @JonChesterfield wrote: > Nice, thanks. Wonder if we want protected visibility as well. I'm not actually sure what having protected visibility would do considering it's not applied with `-fvisibility=protec

[PATCH] D122515: [OpenMP] Add AMDGPU calling convention to ctor / dtor functions

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, ronlieb. Herald added subscribers: guansong, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: openm

[PATCH] D122515: [OpenMP] Add AMDGPU calling convention to ctor / dtor functions

jhuber6 updated this revision to Diff 418354. jhuber6 added a comment. Making test better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122515/new/ https://reviews.llvm.org/D122515 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenM

[PATCH] D122515: [OpenMP] Add AMDGPU calling convention to ctor / dtor functions

jhuber6 updated this revision to Diff 418355. jhuber6 added a comment. Remove leftover code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122515/new/ https://reviews.llvm.org/D122515 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/Ope

[PATCH] D122515: [OpenMP] Add AMDGPU calling convention to ctor / dtor functions

jhuber6 updated this revision to Diff 418365. jhuber6 added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122515/new/ https://reviews.llvm.org/D122515 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/amdgcn_ta

[PATCH] D122504: [OpenMP] Make Ctor / Dtor functions have external visibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c6d32ec6cdb: [OpenMP] Make Ctor / Dtor functions have external visibility (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D122515: [OpenMP] Add AMDGPU calling convention to ctor / dtor functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d3550c51733: [OpenMP] Add AMDGPU calling convention to ctor / dtor functions (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D122444: [Driver][Linux] Remove D.Dir+"/../lib" from default search paths for LLVM_ENABLE_RUNTIMES builds

jhuber6 added a comment. This change broke finding the OpenMP runtime libraries when using the LLVM runtimes build. clang foo.c -fopenmp -fopenmp-targets=nvptx64 /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: cannot find -lomp /usr/lib64/gcc/x86_64-suse-linux/7/.

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ye-luo, MaskRay. Herald added subscribers: StephenFan, guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a projec

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jhuber6 updated this revision to Diff 418617. jhuber6 added a comment. IncludePath -> LibraryPath Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122592/new/ https://reviews.llvm.org/D122592 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clan

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jhuber6 added a comment. In D122592#3411741 , @MaskRay wrote: > Another idea is to refactor `tools::addOpenMPRuntime` to use the full path of > `libomp.so` or `libomp.a` instead of `-LXXX -lomp`. > The two ways have identical semantics when `libomp.so` h

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jhuber6 updated this revision to Diff 418628. jhuber6 added a comment. Add test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122592/new/ https://reviews.llvm.org/D122592 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/Tool

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jhuber6 updated this revision to Diff 418638. jhuber6 added a comment. Making suggested changes to test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122592/new/ https://reviews.llvm.org/D122592 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

jhuber6 added a comment. In D122592#3411877 , @jdoerfert wrote: > In D122592#3411812 , @MaskRay wrote: > >> In D122592#3411795 , @ye-luo wrote: >> using the multiarch

[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfceea4e11028: [OpenMP] Fix library path missing when using OpenMP (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

jhuber6 added a comment. In D122069#3413960 , @JonChesterfield wrote: > Added some reviewers. I'd much prefer this used an existing binary format, > DIY is prone to errors and maintenance hassles down the road. Don't care as > much about which format a

[PATCH] D122679: [OpenMP] Use offload bundler when outputting textual formats with new driver

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, saiislam. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang.

[PATCH] D122679: [OpenMP] Use offload bundler when outputting textual formats with new driver

jhuber6 added inline comments. Comment at: clang/test/Driver/openmp-offload-gpu.c:350 + +// RUN: %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda -Xopenmp-target=nvptx64-nvida-cuda -march=sm_70 \ +// RUN: --libomptarget-nvptx-bc-path=%S/Inputs/libompt

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield. Herald added subscribers: ormris, dexonsmith, guansong, hiraditya, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits,

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

jhuber6 added a comment. In D122069#3416694 , @saiislam wrote: > Hey @jhuber6 , as discussed in multi-company meeting, I think that we will > need at least an arch field somewhere in this. We would like to create > multi-arch binaries so that runtime ca

[PATCH] D122760: [OpenMP] Add OpenMP variant extension to keep the unmangled name

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: asavonic, dexonsmith, guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang,

[PATCH] D122760: [OpenMP] Add OpenMP variant extension to keep the unmangled name

jhuber6 added a comment. The test currently fails because we don't do the stripping when we emit the precompiled header, it will simply be imported using the mangled version and it will not have in the original input info associated with it. I will need to figure out where we emit the PCH defin

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, grokos, ABataev, ronlieb, tianshilei1992, saiislam. Herald added subscribers: asavonic, kerbowa, guansong, yaxunl, mgorny, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald add

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jhuber6 updated this revision to Diff 419490. jhuber6 added a comment. Fixing unrelated formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122683/new/ https://reviews.llvm.org/D122683 Files: clang/include/clang/Basic/CodeGenOption

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

jhuber6 added a comment. In D122831#3419768 , @jdoerfert wrote: > I feel we should port some of the clang driver tests rather than running them > only for the old one. > The old one is on its way out, so ... I tried to keep it where it worked, most of t

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

jhuber6 added a comment. Ping, I'd like to finalize the new driver in time for the GPU newsletter and the LLVM Performance Workshop at CGO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122069/new/ https://reviews.llvm.org/D122069 ___

[PATCH] D122760: [OpenMP] Add OpenMP variant extension to keep the unmangled name

jhuber6 updated this revision to Diff 419567. jhuber6 added a comment. Herald added a reviewer: aaron.ballman. Updating to use an attribute instead to get around the loss of the identifier info when using PCH. Unfortunately this still causes problems when using PCH. Repository: rG LLVM Github

[PATCH] D122760: [OpenMP] Add OpenMP variant extension to keep the unmangled name

jhuber6 updated this revision to Diff 420604. jhuber6 added a comment. Updating to stop erroring if a function with the same mangled error exists, but is never emitted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122760/new/ https://reviews.llvm

[PATCH] D122760: [OpenMP] Add OpenMP variant extension to keep the unmangled name

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3062 +if (auto *A = Global->getAttr()) + VariantGlobalsEmitted.insert(A->getFunction()); } jdoerfert wrote: > This looks like you

[PATCH] D122760: [OpenMP] Add OpenMP variant extension to keep the unmangled name

jhuber6 updated this revision to Diff 420608. jhuber6 added a comment. Make suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122760/new/ https://reviews.llvm.org/D122760 Files: clang/include/clang/Basic/Attr.td clang/include/cl

[PATCH] D129694: [OPENMP] Make declare target static global externally visible

jhuber6 added a comment. I still think we shouldn't bother making all the noise containing the original name. Just mangle it and treat it like every other declare target variable without introducing any extra complexity. These symbols never should've been emitted in the first place so I'm not c

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

jhuber6 added a comment. In D128441#3702800 , @tra wrote: > This change breaks `clang++ --cuda-device-only` compilation. Clang does not > create any output in this case. Reverting the change fixes the problem. > > Reproducible with: > > echo '__global

[PATCH] D131278: [CUDA] Fix output name being replaced in device-only mode

jhuber6 created this revision. jhuber6 added a reviewer: tra. Herald added subscribers: mattd, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. When performing device only compilation, the

[PATCH] D131278: [CUDA] Fix output name being replaced in device-only mode

jhuber6 added inline comments. Comment at: clang/test/Driver/cuda-bindings.cu:148 +// RUN: | FileCheck -check-prefix=D_ONLY %s +// D_ONLY: "foo.o" tra wrote: > Ideally we want to test that the output file actually survives the > compilation. It's traky to do for

[PATCH] D131278: [CUDA] Fix output name being replaced in device-only mode

jhuber6 added inline comments. Comment at: clang/test/Driver/cuda-bindings.cu:148 +// RUN: | FileCheck -check-prefix=D_ONLY %s +// D_ONLY: "foo.o" tra wrote: > jhuber6 wrote: > > tra wrote: > > > Ideally we want to test that the output file actually survives the

[PATCH] D131278: [CUDA] Fix output name being replaced in device-only mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b52341116b7: [CUDA] Fix output name being replaced in device-only mode (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131278/new/ htt

[PATCH] D129694: [OPENMP] Make declare target static global externally visible

jhuber6 added a comment. In D129694#3708214 , @ssquare08 wrote: > If that's the preference I can make changes as suggested. You mentioned CUDA > and HIP mangle the declaration directly. To me it looks like they mangle it > on host and device separately.

[PATCH] D131455: [Driver] Add -Xclang= as an alias for -Xclang

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LG `-Xopenmp-target=` is somewhat different. The first joined argument is used to select a toolchain and the second, separate argument is the argument to pass. So something like `-Xopenmp-t

[PATCH] D131639: [OpenMP] Remove 'stdbool.h' from OpenMP header wrappers

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Th

[PATCH] D105898: [OpenMP] Rework OpenMP remarks

jhuber6 updated this revision to Diff 359319. jhuber6 added a comment. Small changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105898/new/ https://reviews.llvm.org/D105898 Files: clang/test/OpenMP/remarks_parallel_in_multiple_target_state_m

[PATCH] D105898: [OpenMP] Rework OpenMP remarks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeef6601b0fb6: [OpenMP] Rework OpenMP remarks (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D105898?vs=359319&id=359390#

[PATCH] D105939: [OpenMP] Add IDs to OpenMP remarks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c31d5ebfbbb: [OpenMP] Add IDs to OpenMP remarks (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D105939?vs=358461&id=359

[PATCH] D106496: [OpenMP] Change `__kmpc_free_shared` to include the paired allocation size

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, hiraditya, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, sstefan1. Herald added projects: clang, OpenMP, LLVM. This patc

[PATCH] D106496: [OpenMP] Change `__kmpc_free_shared` to include the paired allocation size

jhuber6 updated this revision to Diff 360610. jhuber6 added a comment. Fixing free shared expecting the incorrect number of args. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106496/new/ https://reviews.llvm.org/D106496 Files: clang/lib/CodeGen

[PATCH] D106496: [OpenMP] Change `__kmpc_free_shared` to include the paired allocation size

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG754eb1c210d8: [OpenMP] Change `__kmpc_free_shared` to include the paired allocation size (authored by jhuber6). Changed prior to commit: https://r

[PATCH] D106793: [OpenMP] Add a driver flag to enable the new device runtime library

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992. Herald added subscribers: dexonsmith, dang, kerbowa, guansong, yaxunl, nhaehnle, jvesely. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. T

[PATCH] D106793: [OpenMP] Add a driver flag to enable the new device runtime library

jhuber6 updated this revision to Diff 361667. jhuber6 added a comment. Adding test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106793/new/ https://reviews.llvm.org/D106793 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/

[PATCH] D106799: [OpenMP] Always inline the OpenMP outlined function

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the always inline attribute to the outlined fun

[PATCH] D106793: [OpenMP] Add a driver flag to enable the new device runtime library

jhuber6 added a comment. In D106793#2904661 , @ye-luo wrote: > Not clear from the summary what is the new driver option. It's a rewrite of the current device runtime. This option will enable it. In D106793#2904771

[PATCH] D106799: [OpenMP] Always inline the OpenMP outlined function

jhuber6 updated this revision to Diff 361764. jhuber6 added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106799/new/ https://reviews.llvm.org/D106799 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/nvptx_target

[PATCH] D106793: [OpenMP] Add a driver flag to enable the new device runtime library

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2972116923a: [OpenMP] Add a driver flag to enable the new device runtime library (authored by jhuber6). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D106799: [OpenMP] Always inline the OpenMP outlined function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf000197c421: [OpenMP] Always inline the OpenMP outlined function (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1601 + CGM.getModule(), OMPRTL___kmpc_free_shared), + V); +} This needs to include the size of the accompanying push afte

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 414371. jhuber6 added a comment. Herald added subscribers: abrachet, phosek. Fix architecture parsing and still include the GPU binary so cuobjcopy can use them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D121466: [OpenMP] Replace math headers with OpenMP wrapper calls

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, tianshilei1992, jdoerfert, ggeorgakoudis. Herald added subscribers: asavonic, dang, guansong, yaxunl, mgorny. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sste

[PATCH] D121468: [OpenMP] Add linking of OpenMP math library

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, tianshilei1992, jdoerfert, ggeorgakoudis. Herald added subscribers: asavonic, dang, kerbowa, guansong, yaxunl, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-com

[PATCH] D121468: [OpenMP] Add linking of OpenMP math library

jhuber6 added inline comments. Comment at: clang/include/clang/Driver/Options.td:1056 +def libomptarget_nvptx_math_bc_path_EQ : Joined<["--"], "libomptarget-nvptx-math-bc-path=">, + Group, HelpText<"Path to libomptarget-nvptx math bitcode library">; def dD : Flag<["-"], "dD">,

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jhuber6 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120271/new/ https://reviews.llvm.org/D120271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

This revision was automatically updated to reflect the committed changes. Closed by commit rG806bbc49dc07: [OpenMP] Try to embed offloading objects after codegen (authored by jhuber6). Herald added a project: All. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D120288: [OpenMP] Implement dense map info for device file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG06b336c4cd2c: [OpenMP] Implement dense map info for device file (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f89769cd775: [Clang] Add offload kind to embedded offload object (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D120934: [OpenMP][NFC] Refactor new driver to be more general

This revision was automatically updated to reflect the committed changes. Closed by commit rG23d885b3a2e8: [OpenMP][NFC] Refactor new driver to be more general (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120934/new/ https://

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 415439. jhuber6 added a comment. We shouldn't need to restrict this to RDC only if implemented properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clan

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 415460. jhuber6 added a comment. Accidentally clang formatted an entire file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/Basic/Cuda.

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 415622. jhuber6 added a comment. Fix wrong condition for picking up input. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/Basic/Cuda.h

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 added inline comments. Comment at: clang/include/clang/Basic/Cuda.h:105-107 +constexpr CudaArch DefaultCudaArch = CudaArch::SM_35; +constexpr CudaArch DefaultHIPArch = CudaArch::GFX803; + tra wrote: > Nit: those could be just enum values. > ``` > ... >

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 416292. jhuber6 added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/Basic/Cuda.h clang/include/clang/D

[PATCH] D122069: [Clang] Add binary format for bundling offloading metadata

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield. Herald added subscribers: ormris, dexonsmith, hiraditya, mgorny. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added pr

[PATCH] D122069: [Clang] Add binary format for bundling offloading metadata

jhuber6 added inline comments. Comment at: clang/include/clang/Basic/Offloading.h:1 +//===--- Offloading.h - Utilities for handling offloading code -*- C++ -*-===// +// Not sure if this should live in Clang or LLVM. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D122069: [Clang] Add binary format for bundling offloading metadata

jhuber6 updated this revision to Diff 416713. jhuber6 added a comment. Update alignment to worse-case padding of 16. I'm not sure if there's a bette solution for preventing the linker from adding padding between these sections if they are combined. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D122069: [Clang] Add binary format for bundling offloading metadata

jhuber6 updated this revision to Diff 416719. jhuber6 added a comment. Fix test after increasing alignment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122069/new/ https://reviews.llvm.org/D122069 Files: clang/include/clang/Basic/CodeGenOption

[PATCH] D122089: [CUDA] Add getTargetFeatures for the NVPTX toolchain

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, tianshilei1992, yaxunl. Herald added a subscriber: asavonic. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The NVPTX too

[PATCH] D122069: [Clang] Add binary format for bundling offloading metadata

jhuber6 updated this revision to Diff 416749. jhuber6 added a comment. Changing to add alignment to the global variable. Should ensure that the section alignment is correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122069/new/ https://reviews.

[PATCH] D122133: [LTO] Add configuartion option to use default optimization pipeline

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan

[PATCH] D122089: [CUDA] Add getTargetFeatures for the NVPTX toolchain

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:635 + const llvm::opt::ArgList &Args, + std::vector &Features, + Optional CudaVersion) { -

[PATCH] D122069: [Clang] Add binary format for bundling offloading metadata

jhuber6 added a comment. In D122069#3397373 , @tra wrote: >> I decided to use a custom format rather than using an existing format (ELF, >> JSON, etc) because of the specialty use-case of this. > > Will we ever need to process the files with tools built

[PATCH] D122089: [CUDA] Add getTargetFeatures for the NVPTX toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3248e4b28ce: [CUDA] Add getTargetFeatures for the NVPTX toolchain (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122089/new/ https://

[PATCH] D122069: [Clang] Add binary format for bundling offloading metadata

jhuber6 added a comment. In D122069#3397867 , @tra wrote: > In D122069#3397560 , @jhuber6 wrote: > >> I was definitely thinking about a lot of alternatives to making yet another >> on-disk binary format. I had a

<    1   2   3   4   5   6   7   8   9   10   >