Re: Fix for the issue 12176

+silvas On 9/28/17 2:19 PM, Oscar Forner Martinez via cfe-commits wrote: Hi, Please find attached a diff to fix the issue 12176. Link for the lazy: llvm.org/PR12176 Let me know if there is anything any improvements you can think of. Best regards, Oscar Extract-getDepthAndIndex-issue-1

r303873 - Don't defer to the GCC driver for linking arm-baremetal

Author: jroelofs Date: Thu May 25 10:42:13 2017 New Revision: 303873 URL: http://llvm.org/viewvc/llvm-project?rev=303873&view=rev Log: Don't defer to the GCC driver for linking arm-baremetal Also comes with a cmake cache for building the runtime bits: $ cmake \ -DBAREMETAL_ARMV6M_SYSROOT=/p

r303880 - Relax testcase to appease buildbots

Author: jroelofs Date: Thu May 25 11:20:51 2017 New Revision: 303880 URL: http://llvm.org/viewvc/llvm-project?rev=303880&view=rev Log: Relax testcase to appease buildbots When lld isn't built, the tests as they were previously, were too picky about the path to the linker. Modified: cfe/trunk

r303898 - Appease more buildbots about r303873

Author: jroelofs Date: Thu May 25 13:55:22 2017 New Revision: 303898 URL: http://llvm.org/viewvc/llvm-project?rev=303898&view=rev Log: Appease more buildbots about r303873 Modified: cfe/trunk/lib/Driver/ToolChains/BareMetal.cpp Modified: cfe/trunk/lib/Driver/ToolChains/BareMetal.cpp URL: ht

Re: r303873 - Don't defer to the GCC driver for linking arm-baremetal

Thanks Galina On Thu, May 25, 2017 at 8:42 AM, Jonathan Roelofs via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: jroelofs Date: Thu May 25 10:42:13 2017 New Revision: 303873 URL: http://llvm.org/viewvc/llvm-project?rev=303873&view=rev <ht

Re: r303873 - Don't defer to the GCC driver for linking arm-baremetal

On 5/25/17 2:41 PM, Hans Wennborg wrote: The test was failing on Windows; r303910 for that. Oh yuk.. thanks for fixing that. Jon On Thu, May 25, 2017 at 11:55 AM, Jonathan Roelofs via cfe-commits wrote: On 5/25/17 11:39 AM, Galina Kistanova wrote: Hello Jonathan, This commit broke

[libcxx] r321563 - Update CREDITS.txt with personal email

Author: jroelofs Date: Fri Dec 29 11:15:20 2017 New Revision: 321563 URL: http://llvm.org/viewvc/llvm-project?rev=321563&view=rev Log: Update CREDITS.txt with personal email Modified: libcxx/trunk/CREDITS.TXT Modified: libcxx/trunk/CREDITS.TXT URL: http://llvm.org/viewvc/llvm-project/libcxx

[libcxxabi] r321564 - Update CREDITS.txt with personal email address

Author: jroelofs Date: Fri Dec 29 11:16:12 2017 New Revision: 321564 URL: http://llvm.org/viewvc/llvm-project?rev=321564&view=rev Log: Update CREDITS.txt with personal email address Modified: libcxxabi/trunk/CREDITS.TXT Modified: libcxxabi/trunk/CREDITS.TXT URL: http://llvm.org/viewvc/llvm-

[libcxxabi] r321569 - Try again, this time with the correct address

Author: jroelofs Date: Fri Dec 29 11:26:28 2017 New Revision: 321569 URL: http://llvm.org/viewvc/llvm-project?rev=321569&view=rev Log: Try again, this time with the correct address Modified: libcxxabi/trunk/CREDITS.TXT Modified: libcxxabi/trunk/CREDITS.TXT URL: http://llvm.org/viewvc/llvm-p

[libcxx] r321570 - Try again, this time with the correct address

Author: jroelofs Date: Fri Dec 29 11:26:53 2017 New Revision: 321570 URL: http://llvm.org/viewvc/llvm-project?rev=321570&view=rev Log: Try again, this time with the correct address Modified: libcxx/trunk/CREDITS.TXT Modified: libcxx/trunk/CREDITS.TXT URL: http://llvm.org/viewvc/llvm-project

r312651 - Fix ARM bare metal driver to support atomics

Author: jroelofs Date: Wed Sep 6 10:09:25 2017 New Revision: 312651 URL: http://llvm.org/viewvc/llvm-project?rev=312651&view=rev Log: Fix ARM bare metal driver to support atomics The new bare metal support only supports the single thread model. This causes the builtin atomic functions (e.g.: __a

r312748 - Fix validation of the -mthread-model flag in the Clang driver

Author: jroelofs Date: Thu Sep 7 15:01:25 2017 New Revision: 312748 URL: http://llvm.org/viewvc/llvm-project?rev=312748&view=rev Log: Fix validation of the -mthread-model flag in the Clang driver The ToolChain class validates the -mthread-model flag in the constructor which doesn't work correctl

Re: [PATCH] D24770: [libcxxabi] cleanup the use of LIBCXXABI_HAS_NO_THREADS macro (NFC)

jroelofs added a subscriber: jroelofs. jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D24770 ___ cfe-commits mailing list

[clang-tools-extra] 3486cc0 - [clang-tidy] Generalize HeaderFileExtensions.{h,cpp}. NFC

Author: Jonathan Roelofs Date: 2020-03-09T11:32:44-06:00 New Revision: 3486cc014b208df3897cf5656db0d0fdeae26d6b URL: https://github.com/llvm/llvm-project/commit/3486cc014b208df3897cf5656db0d0fdeae26d6b DIFF: https://github.com/llvm/llvm-project/commit/3486cc014b208df3897cf5656db0d0fdeae26d6b.di

[clang-tools-extra] 47caa69 - [clang-tidy] Use ; as separator for HeaderFileExtensions

Author: Jonathan Roelofs Date: 2020-03-09T11:32:44-06:00 New Revision: 47caa69120e582bf1b795ec646f069c83b0e9456 URL: https://github.com/llvm/llvm-project/commit/47caa69120e582bf1b795ec646f069c83b0e9456 DIFF: https://github.com/llvm/llvm-project/commit/47caa69120e582bf1b795ec646f069c83b0e9456.di

[clang-tools-extra] c71ef7a - Drop HEADER_ per review feedback on D74669

Author: Jonathan Roelofs Date: 2020-03-09T12:14:22-06:00 New Revision: c71ef7a85d2447903ff9240aff649a57d70b050d URL: https://github.com/llvm/llvm-project/commit/c71ef7a85d2447903ff9240aff649a57d70b050d DIFF: https://github.com/llvm/llvm-project/commit/c71ef7a85d2447903ff9240aff649a57d70b050d.di

[clang-tools-extra] 1e0669b - [clang-tidy] New check: bugprone-suspicious-include

Author: Jonathan Roelofs Date: 2020-03-09T15:54:32-06:00 New Revision: 1e0669bfe05f0f48ee88152c4a1d581f484f8d67 URL: https://github.com/llvm/llvm-project/commit/1e0669bfe05f0f48ee88152c4a1d581f484f8d67 DIFF: https://github.com/llvm/llvm-project/commit/1e0669bfe05f0f48ee88152c4a1d581f484f8d67.di

[clang-tools-extra] 698a127 - release notes: fix new check name

Author: Jonathan Roelofs Date: 2020-03-09T16:11:35-06:00 New Revision: 698a12712920c214e39bb215fe26fad2e099425b URL: https://github.com/llvm/llvm-project/commit/698a12712920c214e39bb215fe26fad2e099425b DIFF: https://github.com/llvm/llvm-project/commit/698a12712920c214e39bb215fe26fad2e099425b.di

[clang-tools-extra] 2e9d33b - Add missing list.rst entry

Author: Jonathan Roelofs Date: 2020-03-09T16:27:35-06:00 New Revision: 2e9d33bccd587763fc284098b5cc60cfb9c25251 URL: https://github.com/llvm/llvm-project/commit/2e9d33bccd587763fc284098b5cc60cfb9c25251 DIFF: https://github.com/llvm/llvm-project/commit/2e9d33bccd587763fc284098b5cc60cfb9c25251.di

[clang-tools-extra] 52bbdad - [clang-tidy][docs] Post-commit feedback on D74669

Author: Jonathan Roelofs Date: 2020-03-09T16:51:41-06:00 New Revision: 52bbdad7d63fd060d102b3591b433d116a982255 URL: https://github.com/llvm/llvm-project/commit/52bbdad7d63fd060d102b3591b433d116a982255 DIFF: https://github.com/llvm/llvm-project/commit/52bbdad7d63fd060d102b3591b433d116a982255.di

[clang-tools-extra] 2c9cf9f - [clang-tidy] New check: bugprone-suspicious-include

Author: Jonathan Roelofs Date: 2020-03-12T09:59:28-06:00 New Revision: 2c9cf9f4ddd01ae9eb47522266a6343104f9d0b5 URL: https://github.com/llvm/llvm-project/commit/2c9cf9f4ddd01ae9eb47522266a6343104f9d0b5 DIFF: https://github.com/llvm/llvm-project/commit/2c9cf9f4ddd01ae9eb47522266a6343104f9d0b5.di

[clang] 39fe440 - [clang] Fix EOL whitespace. NFC

Author: Jonathan Roelofs Date: 2020-01-28T08:47:37-07:00 New Revision: 39fe44024689cf6d10b249db8694efbdcc6afc14 URL: https://github.com/llvm/llvm-project/commit/39fe44024689cf6d10b249db8694efbdcc6afc14 DIFF: https://github.com/llvm/llvm-project/commit/39fe44024689cf6d10b249db8694efbdcc6afc14.di

r290390 - Fix example: byref struct's init was incorrect, and the block literal's holder should point to it.

Author: jroelofs Date: Thu Dec 22 17:48:23 2016 New Revision: 290390 URL: http://llvm.org/viewvc/llvm-project?rev=290390&view=rev Log: Fix example: byref struct's init was incorrect, and the block literal's holder should point to it. Modified: cfe/trunk/docs/Block-ABI-Apple.rst Modified: cf

Re: [PATCH] D27123: Add AVR target and toolchain to Clang

On 1/4/17 2:52 AM, Dylan McKay wrote: I've just raised a bug here https://llvm.org/bugs/show_bug.cgi?id=31530 > What's necessary for sign-off? Should I ping the reviewer (Richard Smith) again? I think so long as Richard or someone else who actively works on Clang signs off. Perhaps somebo

Re: [PATCH] D23524: [libc++abi] Fix backtrace_test.pass.cpp failure seemingly caused by inlining differences.

jroelofs added a comment. I'm not sure that's guaranteed behavior either. That being said, I don't see a more robust way to write this test. https://reviews.llvm.org/D23524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D23420: libcxx: Fix libcxx test on aarch64 with libunwind

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D23420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

jroelofs added a comment. In https://reviews.llvm.org/D21803#532309, @EricWF wrote: > `__thread` > > What do you think of this idea? You'll have to guard it against all the platforms that don't support TLS. Darwin 10.6 is one of them. https://reviews.llvm.org/D21803 __

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

jroelofs added a comment. In https://reviews.llvm.org/D21803#532382, @EricWF wrote: > In https://reviews.llvm.org/D21803#532347, @jroelofs wrote: > > > In https://reviews.llvm.org/D21803#532309, @EricWF wrote: > > > > > `__thread` > > > > > > What do you think of this idea? > > > > > > You'll hav

Re: [PATCH] trivial documentation fix regarding Obj-C ARC objc_arc_weak_reference_unavailable

On 9/2/16 9:26 AM, Sean McBride via cfe-commits wrote: Friendly ping... this is a very trivial documentation patch... LGTM On Wed, 10 Aug 2016 13:57:07 -0400, Sean McBride via cfe-commits said: Fixed incorrect docs that referred to: objc_arc_weak_unavailable when it should be: objc_arc_

r281227 - Trivial documentation fix regarding Obj-C ARC objc_arc_weak_reference_unavailable

Author: jroelofs Date: Mon Sep 12 11:14:52 2016 New Revision: 281227 URL: http://llvm.org/viewvc/llvm-project?rev=281227&view=rev Log: Trivial documentation fix regarding Obj-C ARC objc_arc_weak_reference_unavailable Fixed incorrect docs that referred to: objc_arc_weak_unavailable when it shou

r297756 - Fix misspelled enum

Author: jroelofs Date: Tue Mar 14 12:29:33 2017 New Revision: 297756 URL: http://llvm.org/viewvc/llvm-project?rev=297756&view=rev Log: Fix misspelled enum https://reviews.llvm.org/D30945 Modified: cfe/trunk/include/clang/Parse/Parser.h cfe/trunk/lib/Parse/ParseOpenMP.cpp cfe/trunk/li

r298275 - Fix some sphinx -Werror's

Author: jroelofs Date: Mon Mar 20 12:07:49 2017 New Revision: 298275 URL: http://llvm.org/viewvc/llvm-project?rev=298275&view=rev Log: Fix some sphinx -Werror's ... mostly having to do with code blocks which the syntax highlighter chokes on Modified: cfe/trunk/docs/ClangFormatStyleOptions.rs

Re: [PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

On 3/21/17 1:53 PM, Christian Bruel via Phabricator wrote: chrib added a comment. In https://reviews.llvm.org/D31140#706411, @jroelofs wrote: Can you clarify the logic here? It's my understanding that: `-fno-exceptions` does *not* imply `-fno-unwind-tables` however: `-fno-unwind-tables` *

r298549 - Actually install scan-build / ccc-analyzer / c++-analyzer on windows

Author: jroelofs Date: Wed Mar 22 16:13:49 2017 New Revision: 298549 URL: http://llvm.org/viewvc/llvm-project?rev=298549&view=rev Log: Actually install scan-build / ccc-analyzer / c++-analyzer on windows Before, we were only installing the wrappers... oops. Modified: cfe/trunk/tools/scan-bui

Re: [PATCH] Use the correct ObjC++ personality

On 3/26/17 10:13 AM, Jonathan Schleifer via cfe-commits wrote: Use the correct EH personality for ObjC++ code. Previously, it would just always use the ObjC DWARF personality, even with SjLj or SEH exceptions. diff --git a/lib/CodeGen/CGException.cpp b/lib/CodeGen/CGException.cpp index 228ef

[libunwind] r298922 - [libunwind] Add sphinx docs

Author: jroelofs Date: Tue Mar 28 10:21:43 2017 New Revision: 298922 URL: http://llvm.org/viewvc/llvm-project?rev=298922&view=rev Log: [libunwind] Add sphinx docs https://reviews.llvm.org/D31375 Added: libunwind/trunk/docs/ libunwind/trunk/docs/BuildingLibunwind.rst libunwind/trunk/d

[libunwind] r299381 - Try to trigger the new docs builder. NFC

Author: jroelofs Date: Mon Apr 3 14:23:11 2017 New Revision: 299381 URL: http://llvm.org/viewvc/llvm-project?rev=299381&view=rev Log: Try to trigger the new docs builder. NFC Modified: libunwind/trunk/docs/index.rst Modified: libunwind/trunk/docs/index.rst URL: http://llvm.org/viewvc/llvm-

r292375 - Warn when calling a non interrupt function from an interrupt on ARM

Author: jroelofs Date: Wed Jan 18 09:31:11 2017 New Revision: 292375 URL: http://llvm.org/viewvc/llvm-project?rev=292375&view=rev Log: Warn when calling a non interrupt function from an interrupt on ARM The idea for this originated from a really tricky bug: ISRs on ARM don't automatically save of

[libcxxabi] r292418 - Revert r286788

Author: jroelofs Date: Wed Jan 18 12:12:39 2017 New Revision: 292418 URL: http://llvm.org/viewvc/llvm-project?rev=292418&view=rev Log: Revert r286788 The Itanium ABI [1] specifies that __cxa_demangle accept either: 1) symbol names, which start with "_Z" 2) type manglings, which do not star

Re: [libcxxabi] r292418 - Revert r286788

On 1/18/17 11:26 AM, Richard Smith via cfe-commits wrote: On 18 January 2017 at 10:12, Jonathan Roelofs via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: jroelofs Date: Wed Jan 18 12:12:39 2017 New Revision: 292418 URL: http://llvm.org/viewvc/llvm-proje

Re: Add warning for c++ member variable shadowing

On 1/24/17 8:10 PM, Saleem Abdulrasool via cfe-commits wrote: Don't use the cast for the check, use isa. Although, since you use the value later, it is probably better to write this as: if (const auto *RD = cast(CurContext)) CheckShadowInheritedVariabless(Loc, Name.getAsString(), RD

Re: Add warning for c++ member variable shadowing

On 2/7/17 7:30 PM, Saleem Abdulrasool wrote: On Tue, Feb 7, 2017 at 1:09 PM, Jonathan Roelofs mailto:jonat...@codesourcery.com>> wrote: On 1/24/17 8:10 PM, Saleem Abdulrasool via cfe-commits wrote: Don't use the cast for the check, use isa. Although, since you use t

[libunwind] r307266 - Add a test harness

Author: jroelofs Date: Thu Jul 6 08:20:12 2017 New Revision: 307266 URL: http://llvm.org/viewvc/llvm-project?rev=307266&view=rev Log: Add a test harness Mostly cargo-culted from libcxxabi, since the unwinder was forked from there in the first place. There may still be cruft that's only applicabl

[libunwind] r309147 - Partial fix for PR33858

Author: jroelofs Date: Wed Jul 26 11:13:57 2017 New Revision: 309147 URL: http://llvm.org/viewvc/llvm-project?rev=309147&view=rev Log: Partial fix for PR33858 https://reviews.llvm.org/D35848 Modified: libunwind/trunk/test/CMakeLists.txt libunwind/trunk/test/lit.site.cfg.in Modified: lib

Re: [PATCH] [analyzer] Fix -x language argument for C preprocessed sources

LGTM. Would you like me to commit it for you? Jon On 1/14/18 3:50 AM, Paul Fertser wrote: clang's -x option doesn't accept c-cpp-output as a language (even though 463eb6ab was merged, the driver still doesn't handle that). This bug prevents testing C language projects when ccache is used. F

Re: [PATCH] [scan-build] Add an option to skip overriding CC and CXX make vars

LGTM. Would you like me to commit it for you? Jon On 1/14/18 9:22 AM, Paul Fertser wrote: Autoconf and some other systems tend to add essential compilation options to CC (e.g. -std=gnu99). When running such an auto-generated makefile, scan-build does not need to change CC and CXX as they are

r323664 - [analyzer] Fix -x language argument for C preprocessed sources

Author: jroelofs Date: Mon Jan 29 08:37:53 2018 New Revision: 323664 URL: http://llvm.org/viewvc/llvm-project?rev=323664&view=rev Log: [analyzer] Fix -x language argument for C preprocessed sources clang's -x option doesn't accept c-cpp-output as a language (even though 463eb6ab was merged, the d

r323665 - [scan-build] Add an option to skip overriding CC and CXX make vars

Author: jroelofs Date: Mon Jan 29 08:49:34 2018 New Revision: 323665 URL: http://llvm.org/viewvc/llvm-project?rev=323665&view=rev Log: [scan-build] Add an option to skip overriding CC and CXX make vars Autoconf and some other systems tend to add essential compilation options to CC (e.g. -std=gnu9

r323864 - Fix typo. NFC

Author: jroelofs Date: Wed Jan 31 04:06:15 2018 New Revision: 323864 URL: http://llvm.org/viewvc/llvm-project?rev=323864&view=rev Log: Fix typo. NFC Modified: cfe/trunk/www/analyzer/scan-build.html Modified: cfe/trunk/www/analyzer/scan-build.html URL: http://llvm.org/viewvc/llvm-project/cfe

Re: [PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

On 2/24/17 1:30 PM, Eric Fiselier via Phabricator wrote: EricWF added a comment. In https://reviews.llvm.org/D30339#685921, @jroelofs wrote: In https://reviews.llvm.org/D30339#685919, @rmaprath wrote: Perhaps change `config.h` and remove the definition there and adjust other places accord

Re: [PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

On 2/24/17 1:48 PM, Eric Fiselier wrote: Inserting arbitrary feature macros into CMake should not be a supported scenario because it results is macros, such as this one, which are seemingly dead. Good point. Jon /Eric On Fri, Feb 24, 2017 at 1:44 PM, Jonathan Roelofs mailto:jonat...@c

Re: [libcxxabi] r296940 - Fix PR25874 - Detect features required for cxa_thread_atexit_test.pass.cpp

On 3/3/17 6:26 PM, Eric Fiselier via cfe-commits wrote: Author: ericwf Date: Fri Mar 3 19:26:41 2017 New Revision: 296940 URL: http://llvm.org/viewvc/llvm-project?rev=296940&view=rev Log: Fix PR25874 - Detect features required for cxa_thread_atexit_test.pass.cpp Modified: libcxxabi/trunk

Re: [libcxxabi] r296940 - Fix PR25874 - Detect features required for cxa_thread_atexit_test.pass.cpp

On 3/3/17 7:45 PM, Eric Fiselier wrote: LIBCXXABI_HAS_CXA_THREAD_ATEXIT_IMPL should be set by `check_library_exists` at the bottom of `config-ix.cmake`. Ah, cool. Jon On Fri, Mar 3, 2017 at 7:22 PM, Jonathan Roelofs mailto:jonat...@codesourcery.com>> wrote: On 3/3/17 6:26 PM, Eri

[PATCH] D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux)

jroelofs added a comment. Testcase? https://reviews.llvm.org/D26796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux)

jroelofs added inline comments. Comment at: test/Driver/print-libgcc-file-name-clangrt.c:11 // RUN: | FileCheck --check-prefix=CHECK-CLANGRT-I686 %s -// CHECK-CLANGRT-I686: libclang_rt.builtins-i686.a +// CHECK-CLANGRT-I686: libclang_rt.builtins-i386.a This CH

[PATCH] D27005: [lit] Support custom parsers in parseIntegratedTestScript

jroelofs added a comment. Should probably add a testcase in lit/tests that exercises the new CUSTOM parser stuff, so people working on LIT don't have to build/test libc++ in order to know whether they've broken its testsuite. https://reviews.llvm.org/D27005 _

[PATCH] D27005: [lit] Support custom parsers in parseIntegratedTestScript

jroelofs added a comment. In https://reviews.llvm.org/D27005#603979, @EricWF wrote: > In https://reviews.llvm.org/D27005#603692, @jroelofs wrote: > > > Should probably add a testcase in lit/tests that exercises the new CUSTOM > > parser stuff, so people working on LIT don't have to build/test li

r288444 - Delete tautological assertion.

Author: jroelofs Date: Thu Dec 1 18:51:58 2016 New Revision: 288444 URL: http://llvm.org/viewvc/llvm-project?rev=288444&view=rev Log: Delete tautological assertion. After r256463, both the LHS and RHS now refer to the same variable. Before, they referred to the member, the parameter respectively

r288818 - Fix doc string typo: s/@__yes/@__objc_yes/

Author: jroelofs Date: Tue Dec 6 09:45:41 2016 New Revision: 288818 URL: http://llvm.org/viewvc/llvm-project?rev=288818&view=rev Log: Fix doc string typo: s/@__yes/@__objc_yes/ Modified: cfe/trunk/include/clang/AST/ExprObjC.h Modified: cfe/trunk/include/clang/AST/ExprObjC.h URL: http://llv

r302207 - Document that Multilib flags must be actual flags

Author: jroelofs Date: Thu May 4 19:18:27 2017 New Revision: 302207 URL: http://llvm.org/viewvc/llvm-project?rev=302207&view=rev Log: Document that Multilib flags must be actual flags This is because -print-multi-lib depends on them being flags for correctness. Fixes a case of this in the arm-a

r302296 - Multilib: add dump methods

Author: jroelofs Date: Fri May 5 16:30:13 2017 New Revision: 302296 URL: http://llvm.org/viewvc/llvm-project?rev=302296&view=rev Log: Multilib: add dump methods Modified: cfe/trunk/include/clang/Driver/Multilib.h cfe/trunk/lib/Driver/Multilib.cpp Modified: cfe/trunk/include/clang/Driver

r302443 - Fix grammar in comment. NFC

Author: jroelofs Date: Mon May 8 12:06:17 2017 New Revision: 302443 URL: http://llvm.org/viewvc/llvm-project?rev=302443&view=rev Log: Fix grammar in comment. NFC Modified: cfe/trunk/test/Misc/warning-flags.c Modified: cfe/trunk/test/Misc/warning-flags.c URL: http://llvm.org/viewvc/llvm-pro

Re: [PATCH] D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors

jroelofs added a subscriber: jroelofs. jroelofs added a comment. A testcase would be good, regardless of which of the proposed fixes ends up being chosen. http://reviews.llvm.org/D12689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

Re: [PATCH] D12996: Driver: support ARM/HF on a single toolchain

jroelofs added a subscriber: jroelofs. jroelofs added a comment. You'll also need a corresponding patch for compiler-rt to make it use the new name appropriately. http://reviews.llvm.org/D12996 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

Re: [PATCH] D13051: Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available.

jroelofs added a comment. In http://reviews.llvm.org/D13051#250836, @EricWF wrote: > Does armv4 need lib calls for atomic operations on "unsigned long"? IIRC, yes. http://reviews.llvm.org/D13051 ___ cfe-commits mailing list cfe-commits@lists.llvm

Re: [PATCH] D13051: Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available.

jroelofs added a comment. In http://reviews.llvm.org/D13051#250910, @EricWF wrote: > @jroelofs @dim, could we fallback to the __sync_* builtins on arm? @dim would need armv4-flavored implementations of them in compiler-rt (if that's what he's using)... the existing ones use instructions that v

Re: [PATCH] D12996: Driver: support ARM/HF on a single toolchain

jroelofs added a comment. Won't it break hf-only builds, if you don't do both commits at the same time? http://reviews.llvm.org/D12996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12996: Driver: support ARM/HF on a single toolchain

jroelofs added a comment. Oh, yeah, true. http://reviews.llvm.org/D12996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12996: Driver: support ARM/HF on a single toolchain

jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. This revision is now accepted and ready to land. Now that you've got http://reviews.llvm.org/D13155 squared away, LGTM. http://reviews.llvm.org/D12996 __

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

jroelofs added a comment. Design doc looks good! I think it captures all the design constraints well, and the proposed solution satisfies those constraints as far as I am concerned. Thumbs up from me... but I'll still defer the final 'LGTM' to @mclow.lists. http://reviews.llvm.org/D13407 __

Re: [PATCH] D13465: Add SafeStack support for test-suite.

jroelofs added a subscriber: jroelofs. jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13465 ___ cfe-commits mailing list

Re: [PATCH] D13465: Add SafeStack support for test-suite.

jroelofs added a comment. In http://reviews.llvm.org/D13465#260628, @tharvik wrote: > When running the test suite, it gives a bunch of `undefined reference to > '__safestack_unsafe_stack_ptr'`. > See regression results . Sounds like it's missing the safestack run

Re: [libcxx] r249475 - Remove unnecessary inline functions capturing the contents of C library macros.

On 10/6/15 4:03 PM, Richard Smith via cfe-commits wrote: Author: rsmith Date: Tue Oct 6 17:03:22 2015 New Revision: 249475 URL: http://llvm.org/viewvc/llvm-project?rev=249475&view=rev Log: Remove unnecessary inline functions capturing the contents of C library macros. The C standard requires

Re: [PATCH] D11781: Refactored pthread usage in libcxx

jroelofs added inline comments. Comment at: include/__config:742 @@ +741,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) || \ +defined(__NetBSD__) || \ @espositofulvio: @ed meant this: ``` #ifndef _WIN32 # include # if _POSIX_THREADS > 0 ..

Re: [PATCH] D11781: Refactored pthread usage in libcxx

jroelofs added inline comments. Comment at: include/__config:742 @@ +741,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) || \ +defined(__NetBSD__) || \ jroelofs wrote: > @espositofulvio: @ed meant this: > > ``` > #ifndef _WIN32 > # include >

Re: [PATCH] D11781: Refactored pthread usage in libcxx

jroelofs added inline comments. Comment at: include/__config:742 @@ +741,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) || \ +defined(__NetBSD__) || \ espositofulvio wrote: > jroelofs wrote: > > jroelofs wrote: > > > @espositofulvio: @ed meant

Re: [PATCH] D11781: Refactored pthread usage in libcxx

jroelofs added a subscriber: EricWF. Comment at: include/__config:742 @@ +741,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) || \ +defined(__NetBSD__) || \ espositofulvio wrote: > theraven wrote: > > espositofulvio wrote: > > > jroelofs wrote:

Re: [PATCH] D11781: Refactored pthread usage in libcxx

jroelofs added inline comments. Comment at: include/__config:742 @@ +741,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) || \ +defined(__NetBSD__) || \ jroelofs wrote: > espositofulvio wrote: > > theraven wrote: > > > espositofulvio wrote: > >

Re: [PATCH] D11781: Refactored pthread usage in libcxx

jroelofs added inline comments. Comment at: include/__config:744 @@ +743,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# ifndef _LIBCPP_THREAD_API +# error "No thread API" The reason to use `CMAKE_BINARY_DIR` over `CMAKE_CURRENT_SOURCE_DIR` as the location for this buil

[PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs created this revision. jroelofs added reviewers: mclow.lists, danalbert. jroelofs added subscribers: EricWF, ed, espositofulvio, cfe-commits, mclow.lists. This also means that we no longer have to teach lit how to define them when running tests. I have a corresponding patch for libcxxa

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs updated this revision to Diff 31878. jroelofs added a comment. fix typo http://reviews.llvm.org/D11963 Files: CMakeLists.txt include/CMakeLists.txt include/__config test/libcxx/test/config.py test/std/atomics/libcpp-has-no-threads.pass.cpp test/std/utilities/date.time/teste

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs updated this revision to Diff 31885. jroelofs added a comment. @danalbert: sigh, yes. http://reviews.llvm.org/D11963 Files: CMakeLists.txt include/CMakeLists.txt include/__config include/__config_site.in test/libcxx/test/config.py test/std/atomics/libcpp-has-no-threads.pass

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs added inline comments. Comment at: include/__config:19 @@ -18,1 +18,3 @@ +#include <__config_site> + #ifdef __GNUC__ espositofulvio wrote: > mclow.lists wrote: > > I'm reluctant to do this; because every include file slows down compilation > > - for eve

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs added inline comments. Comment at: include/__config:19 @@ -18,1 +18,3 @@ +#include <__config_site> + #ifdef __GNUC__ jroelofs wrote: > mclow.lists wrote: > > espositofulvio wrote: > > > mclow.lists wrote: > > > > I'm reluctant to do this; because every i

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs updated this revision to Diff 31949. jroelofs added a comment. Add license text to the new file, and move the two has-no-threads tests to test/libcxx. http://reviews.llvm.org/D11963 Files: CMakeLists.txt include/CMakeLists.txt include/__config include/__config_site.in test/l

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs added a comment. In http://reviews.llvm.org/D11963#227444, @EricWF wrote: > I also just realized that this change will currently likely play havoc with > how libc++ and libc++abi build together. In order to build libc++ and > libc++abi together we would need to > > 1. Configure libc++

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs added a comment. In http://reviews.llvm.org/D11963#227441, @EricWF wrote: > @jroelofs What do you think of an approach like this? Having two copies of the __config_site file makes me uncomfortable, but I could put up with that given that they're effectively the same for 99% of people

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs added a comment. In http://reviews.llvm.org/D11963#228024, @EricWF wrote: > Wouldn't it still be a mess if you build both libc++ and libc++abi > out-of-tree? The user would have to be aware of these weird requirements. Oh, yeah, true. Do we have any out-of-tree builders to make sure t

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. Both styles look ok to me, with a slight preference toward matching clang's. Comment at: docs/BuildingLibcxx.rst:56 @@ +55,3 @@ +Mac users, remember to be careful when rep

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

jroelofs added inline comments. Comment at: docs/BuildingLibcxx.rst:57 @@ +56,3 @@ + select a safe place to install libc++. + + * ``make install-libcxx install-libcxxabi`` --- Will install the libraries and the headers I feel like a warning is not enough... per

Re: [PATCH] D12209: [libcxx] Remove installation rules on Darwin when it would overwrite the system installation.

jroelofs added a comment. I like it! http://reviews.llvm.org/D12209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D12294: Misc cleanups re-commandeered from D11963.

jroelofs created this revision. jroelofs added a reviewer: EricWF. jroelofs added a subscriber: cfe-commits. This separates out the bits of D11963 which were drive-by fixes, which aren't really relevant to the __config_site part of that change. http://reviews.llvm.org/D12294 Files: CMakeLists

Re: [PATCH] D12294: Misc cleanups re-commandeered from D11963.

jroelofs updated this revision to Diff 32996. jroelofs added a comment. The diff uploaded strangely... trying again. http://reviews.llvm.org/D12294 Files: CMakeLists.txt test/libcxx/atomics/libcpp-has-no-threads.fail.cpp test/libcxx/atomics/libcpp-has-no-threads.pass.cpp test/std/atomic

Re: [PATCH] D12294: Misc cleanups re-commandeered from D11963.

jroelofs closed this revision. jroelofs added a comment. r245876 http://reviews.llvm.org/D12294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r245876 - Misc drive-by cleanups. NFC

Author: jroelofs Date: Mon Aug 24 16:20:07 2015 New Revision: 245876 URL: http://llvm.org/viewvc/llvm-project?rev=245876&view=rev Log: Misc drive-by cleanups. NFC http://reviews.llvm.org/D12294 Added: libcxx/trunk/test/libcxx/atomics/ libcxx/trunk/test/libcxx/atomics/libcpp-has-no-thread

Re: [PATCH] D12209: [libcxx] Remove installation rules on Darwin when it would overwrite the system installation.

jroelofs accepted this revision. This revision is now accepted and ready to land. Comment at: CMakeLists.txt:105 @@ +104,3 @@ +if (${CMAKE_SYSTEM_NAME} MATCHES "Darwin" AND NOT LIBCXX_OVERRIDE_DARWIN_INSTALL) + if ("${CMAKE_INSTALL_PREFIX}" STREQUAL "/usr") +message(WARNING

Re: [PATCH] D12209: [libcxx] Remove installation rules on Darwin when it would overwrite the system installation.

jroelofs added a comment. Ah, I only tested it by editing the CMakeCache.txt manually... ship it! http://reviews.llvm.org/D12209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11333: [libcxx] Add special warning flag detection logic to compiler.py

jroelofs added a comment. the `addWarningFlagIfSupported` part of this patch LGTM. Comment at: test/libcxx/compiler.py:88 @@ -87,1 +87,3 @@ +def compileString(self, source, out=None, flags=[], env=None, cwd=None): +cmd = self.compileCmd('-', out, flags) ---

Re: [PATCH] D11333: [libcxx] Add special warning flag detection logic to compiler.py

jroelofs added a comment. I'd say put them in when you have actual uses for them http://reviews.llvm.org/D11333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11333: [libcxx] Add special warning flag detection logic to compiler.py

jroelofs added inline comments. Comment at: test/libcxx/compiler.py:195 @@ +194,3 @@ +cmd.remove('-v') +out, err, rc = lit.util.executeCommand(cmd, input='#error\n') +assert rc != 0 ... you could at least use `compileString` here. htt

  1   2   3   >