jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land.
Both styles look ok to me, with a slight preference toward matching clang's. ================ Comment at: docs/BuildingLibcxx.rst:56 @@ +55,3 @@ +Mac users, remember to be careful when replacing the system's libc++. +**Your system will not be able to boot without a functioning libc++.** + ---------------- Is there a way to make this more prominent, perhaps by putting it in a red box? This is a very important detail that is very painful to recover from if you miss it. ================ Comment at: docs/BuildingLibcxx.rst:243 @@ +242,3 @@ + +Note the first two entries happen to be what we are looking for. This +may not be correct on other platforms. ---------------- s/Note the/Note that the/ ================ Comment at: docs/index.rst:87 @@ +86,3 @@ +============ ==================== ============ ======================== +OS Arch Compilers ABI Library +============ ==================== ============ ======================== ---------------- Should we mention the unwinders used/supported here too? http://reviews.llvm.org/D12129 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
