Hahnfeld added inline comments.
Comment at: lib/Driver/ToolChains.cpp:4704
+ GetRuntimeLibType(Args) == ToolChain::RLT_CompilerRT)
+CmdArgs.push_back("-lunwind");
+}
mgorny wrote:
> Hahnfeld wrote:
> > As just written in D25008: This will probably result
Hahnfeld added a comment.
`LIBCXXABI_USE_LLVM_UNWINDER` implies to me: "Use LLVM's `libunwind` whenever
you use `libc++abi`". This has worked until now and I would vote for this to be
the right thing to do.
Repository:
rL LLVM
https://reviews.llvm.org/D25008
_
Hahnfeld added inline comments.
Comment at: lib/Driver/ToolChains.cpp:4704
+ GetRuntimeLibType(Args) == ToolChain::RLT_CompilerRT)
+CmdArgs.push_back("-lunwind");
+}
mgorny wrote:
> Hahnfeld wrote:
> > mgorny wrote:
> > > Hahnfeld wrote:
> > > > As just
Hahnfeld added a comment.
gentle ping
https://reviews.llvm.org/D25669
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
any progress?
https://reviews.llvm.org/D22452
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added inline comments.
Comment at: lib/Driver/ToolChain.cpp:553-559
+ // "platform" is only used in tests to override CLANG_DEFAULT_CXX_STDLIB
+ if (LibName == "libc++")
+return ToolChain::CST_Libcxx;
+ else if (LibName == "libstdc++")
+return ToolChain::CST_L
Hahnfeld added a comment.
I think these changes have been contributed to trunk in multiple commits so
this can be closed?
https://reviews.llvm.org/D9888
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Hahnfeld added a comment.
What are the possibilities to proceed here?
Repository:
rL LLVM
https://reviews.llvm.org/D25008
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
Please disregard the noise, I think the error lays in the testing of
`compiler-rt` which clears `LIBRARY_PATH` and therefore doesn't find the right
`libunwind`!
Repository:
rL LLVM
https://reviews.llvm.org/D25008
___
c
Hahnfeld created this revision.
Hahnfeld added reviewers: mgorny, rsmith, EricWF.
Hahnfeld added a subscriber: cfe-commits.
This is for example needed to make sure we get LLVM's `libunwind.so.1` and
don't end up with the system default non-GNU `libunwind.so.8` as reported in
https://reviews.llvm
Hahnfeld added a comment.
Can I commit this as-is for now and we can think about `StringSwitch` in the
driver later on?
https://reviews.llvm.org/D25669
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Hahnfeld added a comment.
I have two high level remarks here:
1. `CLANG_DEFAULT_LINKER` should override whatever the platform default is. So
`ToolChain::getDefaultLinker()` should return `ld` as the variable
`DefaultLinker` currently says and the logic should be in
`ToolChain::GetLinkerPath()`
Hahnfeld added a comment.
ping
https://reviews.llvm.org/D25669
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
ping
https://reviews.llvm.org/D26244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
Currently trying to test, but
1. Offloading to the same target isn't supported (`x86_64-unknown-linux-gnu` as
host and device) - this was working with `clang-omp`
The produced IR isn't showing any calls to the target library and on linkage it
complains:
undefined r
Hahnfeld added a comment.
Needs two small changes to work with current trunk
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:2135-2136
@@ +2134,4 @@
+ const Expr *IfCond = nullptr;
+ if (auto C = S.getSingleClause(OMPC_if)) {
+IfCond = cast(C)->getCondition();
+ }
--
Hahnfeld added a comment.
I think this has to be updated for the current trunk...
http://reviews.llvm.org/D9888
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
In http://reviews.llvm.org/D9888#262389, @sfantao wrote:
> [...]
>
> I assume you were trying this using the diff in
> http://reviews.llvm.org/D12614. There was an inconsistency in the names of
> the ELF sections and symbols defined by the linker script in these two
>
Author: hahnfeld
Date: Mon Jul 25 03:04:26 2016
New Revision: 276618
URL: http://llvm.org/viewvc/llvm-project?rev=276618&view=rev
Log:
Update description for CLANG_DEFAULT_CXX_STDLIB and add comment. NFC
We agreed to call it "platform default" instead of "architecture default".
(see D17286)
Modi
Hahnfeld requested changes to this revision.
Hahnfeld added a comment.
This revision now requires changes to proceed.
In general the idea looks good and takes this point off my personal todo list
:-)
With the changes applied and configured with `CLANG_DEFAULT_RTLIB=compiler-rt`
some tests fail
Hahnfeld added a comment.
In https://reviews.llvm.org/D22663#495728, @zlei wrote:
> In https://reviews.llvm.org/D22663#494460, @Hahnfeld wrote:
>
> > With the changes applied and configured with
> > `CLANG_DEFAULT_RTLIB=compiler-rt` some tests fail so you may have to adapt
> > the idea of `-rtl
Hahnfeld added inline comments.
Comment at: CMakeLists.txt:210
@@ -202,3 +209,3 @@
set(CLANG_VENDOR ${PACKAGE_VENDOR} CACHE STRING
"Vendor-specific text for showing with version information.")
zlei wrote:
> I think the original code for resetting `CLANG_DEFA
Hahnfeld added a comment.
There is also the other way round: `CLANG_DEFAULT_RTLIB=libgcc` shows that
Darwin doesn't support that and gets a `SIGSEGV` (because it doesn't expect it
to be `libgcc` without an option to be set, hehe)
Based on some `GetCXXStdlibType` for toolchains that only support
Hahnfeld accepted this revision.
Hahnfeld added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for this work!
Can you commit the patch yourself or should I do that for you?
https://reviews.llvm.org/D22663
___
cfe-commits m
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276848: Support setting default value for -rtlib at build
time (authored by Hahnfeld).
Changed prior to commit:
https://reviews.llvm.org/D22663?vs=65643&id=65678#toc
Repository:
rL LLVM
https://revi
Author: hahnfeld
Date: Wed Jul 27 03:15:54 2016
New Revision: 276848
URL: http://llvm.org/viewvc/llvm-project?rev=276848&view=rev
Log:
Support setting default value for -rtlib at build time
This patch introduces a new cmake variable: CLANG_DEFAULT_RTLIB, thru
which we can specify a default value
Hahnfeld added a subscriber: Hahnfeld.
Hahnfeld added a comment.
In https://reviews.llvm.org/D18172#500029, @sfantao wrote:
> Any more comments on this patch or depending ones?
>
> Thanks!
> Samuel
I can report that the latest patches are working for me and that they fix all
points that I prev
Hahnfeld added a comment.
Any chance we can get this fixed?
Comment at:
test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:89-95
@@ +88,9 @@
+}
+if (ec) {
+assert(old_write_time == new_write_time);
+return false;
Hahnfeld accepted this revision.
Hahnfeld added a reviewer: Hahnfeld.
Hahnfeld added a comment.
This revision is now accepted and ready to land.
LGTM with only some minor nits on some of the comments and a CMake question
Comment at: test/CMakeLists.txt:27-33
@@ -26,8 +26,9 @@
Hahnfeld accepted this revision.
Hahnfeld added a reviewer: Hahnfeld.
Hahnfeld added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: tools/clang-offload-bundler/ClangOffloadBundler.cpp:432
@@ +431,3 @@
+
+return;
+ }
Unnecessary
Author: hahnfeld
Date: Fri Aug 12 05:36:04 2016
New Revision: 278497
URL: http://llvm.org/viewvc/llvm-project?rev=278497&view=rev
Log:
Fix cuda-detect.cu when CLANG_DEFAULT_CXX_STDLIB is set
Reported by Ismail Donmez!
Modified:
cfe/trunk/test/Driver/cuda-detect.cu
Modified: cfe/trunk/test/D
Hahnfeld added a comment.
ping
http://reviews.llvm.org/D15920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld updated this revision to Diff 47441.
Hahnfeld added a comment.
Address reviewers' comments:
- check for valid `CLANG_DEFAULT_CXX_STDLIB`
- generalize for `Darwin` and `Bitrig` by introducing `GetDefaultCXXStdlibType`
- fallback to `CLANG_DEFAULT_CXX_STDLIB` if user choice is incorrect
Hahnfeld marked an inline comment as done.
Hahnfeld added a comment.
In http://reviews.llvm.org/D15920#347352, @beanz wrote:
> Is it correct to assume that all the test case changes are needed just to
> make the tests pass if you set CLANG_DEFAULT_CXX_STDLIB=libc++?
>
> [...]
Yes, most of the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260662: [CMake] Add option to switch default C++ stdlib
(authored by Hahnfeld).
Changed prior to commit:
http://reviews.llvm.org/D15920?vs=47441&id=47770#toc
Repository:
rL LLVM
http://reviews.llvm.
Author: hahnfeld
Date: Fri Feb 12 01:48:37 2016
New Revision: 260662
URL: http://llvm.org/viewvc/llvm-project?rev=260662&view=rev
Log:
[CMake] Add option to switch default C++ stdlib
With this option one can optionally override the architecture dependent
default library to use if no -stdlib= is p
Author: hahnfeld
Date: Fri Feb 12 01:48:28 2016
New Revision: 260661
URL: http://llvm.org/viewvc/llvm-project?rev=260661&view=rev
Log:
tests: Add explicit -stdlib=libstdc++ to tests that require it
This will be needed for the next commit that allows to switch the default
C++ library which would o
Hahnfeld added a comment.
In http://reviews.llvm.org/D15920#350401, @beanz wrote:
> Can you commit the test changes in a separate commit before committing the
> other changes? That way if something goes wrong the diff for the meat of the
> patch is a small diff.
Committed seperately in http:/
Hahnfeld added a comment.
@rsmith could you possibly take a look at this one? It has been around for
roughly 8 months now and hasn't received much feedback
http://reviews.llvm.org/D9888
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
Hahnfeld created this revision.
Hahnfeld added reviewers: rsmith, t.p.northover.
Hahnfeld added a subscriber: cfe-commits.
Herald added a subscriber: emaste.
Also introduce `-stdlib=default` to override the configured value and use it to
make the tests always pass.
http://reviews.llvm.org/D17286
Hahnfeld added a subscriber: Hahnfeld.
Hahnfeld added a comment.
Is there any progress on this one?
http://reviews.llvm.org/D18170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
@tra any more comments on this?
http://reviews.llvm.org/D18170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
Hi Carlo,
I think these tests are not yet committed, right?
Thanks,
Jonas
Repository:
rL LLVM
http://reviews.llvm.org/D18286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Hahnfeld added inline comments.
Comment at: tools/clang-offload-bundler/ClangOffloadBundler.cpp:477-490
@@ +476,16 @@
+
+// Do the incremental linking. We write to the output file directly. So, we
+// close it and use the name to pass down to clang.
+OS.close();
+S
Hahnfeld added a comment.
Hi Samuel,
this looks pretty good overall!
I've only encountered one issue which I don't really know is caused by which
patch: I can't use the (exact) same triple for offloading and the host when
compiling separately. I found out that the device object file is taken a
Hahnfeld added a comment.
Another overall question: Back in February you said that it would be possible
to have a "default" object that can be taken without knowledge of the bundler
(see http://lists.llvm.org/pipermail/cfe-dev/2016-February/047555.html).
In my tests with the patch, this has not
Hahnfeld added a comment.
In http://reviews.llvm.org/D21851#479042, @sfantao wrote:
> That was probably not the reason why you were getting the failure, but the
> bundler was not prepared to bundle files if the host was not the first input.
> I fixed that.
This was indeed the problem, this no
Hahnfeld created this revision.
Hahnfeld added a reviewer: EricWF.
Hahnfeld added a subscriber: cfe-commits.
man page for mkdir says: `If the parent directory has the set-group-ID bit set,
then so will the newly created directory.`
http://reviews.llvm.org/D22265
Files:
test/std/experimental/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275760: [libcxx][filesystem] Remove setgid from parent
before testing permissions (authored by Hahnfeld).
Changed prior to commit:
https://reviews.llvm.org/D22265?vs=63672&id=64275#toc
Repository:
rL
Author: hahnfeld
Date: Mon Jul 18 01:06:50 2016
New Revision: 275760
URL: http://llvm.org/viewvc/llvm-project?rev=275760&view=rev
Log:
[libcxx][filesystem] Remove setgid from parent before testing permissions
man page for mkdir says: "If the parent directory has the set-group-ID bit set,
then so
Hahnfeld added a subscriber: Hahnfeld.
Comment at:
test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:113-119
@@ -80,1 +112,9 @@
+}
+if (ec) {
+assert(new_write_time == old_write_time);
+return false;
+} else {
Hahnfeld added inline comments.
Comment at:
test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:89-95
@@ +88,9 @@
+}
+if (ec) {
+assert(old_write_time == new_write_time);
+return false;
+} else {
+assert(
Hahnfeld added a comment.
Gentle ping
http://reviews.llvm.org/D17286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
In http://reviews.llvm.org/D17286#364353, @joerg wrote:
> I dislike the value `default`, since with `CLANG_DEFAULT_CXX_STDLIB` it is
> not. Otherwise, it should be fine.
Hmm, had this feeling as well... What about `-stdlib=test` as I only plan to
use this for the tes
Hahnfeld added a comment.
In http://reviews.llvm.org/D17286#364544, @joerg wrote:
> I was thinking about something like `-stdlib=platform` to reflect that it is
> the target choice.
Ah yes, that was the term I was missing, `architecture` wasn't actually correct
http://reviews.llvm.org/D17286
Hahnfeld updated the summary for this revision.
Hahnfeld updated this revision to Diff 49459.
Hahnfeld added a comment.
Rename option to `-stdlib=platform`
http://reviews.llvm.org/D17286
Files:
lib/Driver/ToolChain.cpp
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
test/Driver/freebs
Hahnfeld added a comment.
More comments on this?
Thanks, Jonas
http://reviews.llvm.org/D17286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
In http://reviews.llvm.org/D17286#372290, @dim wrote:
> If nobody objects, I will commit this.
I can do so myself but would would like to hear from @joerg first
http://reviews.llvm.org/D17286
___
cfe-commits mailing list
Author: hahnfeld
Date: Mon Mar 14 09:34:10 2016
New Revision: 263435
URL: http://llvm.org/viewvc/llvm-project?rev=263435&view=rev
Log:
Fix some more tests with CLANG_DEFAULT_CXX_STDLIB
Also use -stdlib=platform instead of -stdlib=libstdc++ when testing if Clang
chooses the correct default for the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263434: Make FreeBSD and NetBSD use CLANG_DEFAULT_CXX_STDLIB
(authored by Hahnfeld).
Changed prior to commit:
http://reviews.llvm.org/D17286?vs=49459&id=50592#toc
Repository:
rL LLVM
http://reviews.
Author: hahnfeld
Date: Mon Mar 14 09:34:04 2016
New Revision: 263434
URL: http://llvm.org/viewvc/llvm-project?rev=263434&view=rev
Log:
Make FreeBSD and NetBSD use CLANG_DEFAULT_CXX_STDLIB
Also introduce -stdlib=platform to override the configured value
and use it to make the tests always pass.
D
Hahnfeld created this revision.
Hahnfeld added a reviewer: EricWF.
Hahnfeld added a subscriber: cfe-commits.
Commit `f49839299a085505eb673544744b61d2d9cdd1db` in glibc-2.14 changed the
locales to the currently required format. However, they were again changed in
commit `55bdd2866f23b28422d969060
Author: hahnfeld
Date: Tue Mar 15 10:55:58 2016
New Revision: 263554
URL: http://llvm.org/viewvc/llvm-project?rev=263554&view=rev
Log:
[libcxx] Remove localization tests for Russian month names
Commit f49839299a085505eb673544744b61d2d9cdd1db in glibc-2.14 changed the
locales to the currently requ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263554: [libcxx] Remove localization tests for Russian month
names (authored by Hahnfeld).
Changed prior to commit:
http://reviews.llvm.org/D18187?vs=50738&id=50742#toc
Repository:
rL LLVM
http://re
Hahnfeld created this revision.
Hahnfeld added reviewers: EricWF, danalbert.
Hahnfeld added a subscriber: cfe-commits.
The feature check is already in place when building the library but wasn't
honored for the tests.
http://reviews.llvm.org/D18205
Files:
test/CMakeLists.txt
test/cxa_thread_
Hahnfeld added inline comments.
Comment at: test/libcxxabi/test/config.py:38
@@ +37,3 @@
+super(Configuration, self).configure_features()
+if self.get_lit_bool('thread_atexit', False):
+self.config.available_features.add('thread_atexit')
---
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263699: [libcxxabi] Disable cxa_thread_atexit_test if
unavailable (authored by Hahnfeld).
Changed prior to commit:
http://reviews.llvm.org/D18205?vs=50805&id=50916#toc
Repository:
rL LLVM
http://rev
Hahnfeld created this revision.
Hahnfeld added reviewers: ABataev, hfinkel, carlo.bertolli, sfantao.
Hahnfeld added a subscriber: cfe-commits.
Pointer dereference is equal to access of first array element which is already
allowed for the `reduction` clause.
While at it also add test for CodeGen
Author: hahnfeld
Date: Thu Mar 17 05:00:24 2016
New Revision: 263699
URL: http://llvm.org/viewvc/llvm-project?rev=263699&view=rev
Log:
[libcxxabi] Disable cxa_thread_atexit_test if unavailable
The feature check is already in place when building the library but wasn't
honored for the tests.
Diffe
Hahnfeld abandoned this revision.
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:913-929
@@ -912,9 +912,19 @@
});
- } else if (auto *ASE = dyn_cast(IRef)) {
-auto *Base = ASE->getBase()->IgnoreParenImpCasts();
-while (auto *TempASE = dyn_cast(Base))
-
Hahnfeld added inline comments.
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:3074-3078
@@ +3073,7 @@
+
+ if (getLangOpts().OpenMPIsDevice && (
+ CGM.getTarget().getTriple().getArch() == llvm::Triple::nvptx ||
+ CGM.getTarget().getTriple().getArch() == llvm::Triple::nvptx64)
Hahnfeld added a comment.
In http://reviews.llvm.org/D18286#382698, @carlo.bertolli wrote:
> Hi Jonas
>
> Thanks for your comment. That scheme would not work for #parallel on the gpu
> in case we do not want to inline the parallel region.
> There are patches coming in which that is going to hap
Hahnfeld created this revision.
Hahnfeld added reviewers: chandlerc, mclow.lists, beanz.
Hahnfeld added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
With this option one can set the default library to use if no `-stdlib=` is
provided on compiler invocation
Hahnfeld added a comment.
Will this somewhen receive a final review and get merged?
http://reviews.llvm.org/D9888
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a reviewer: mcrosier.
Hahnfeld added a comment.
Any comments on this change?
http://reviews.llvm.org/D15920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
Is anyone feeling responsible for a final go / review? It would be great for
our research project to have at least basic offloading support in 3.8...
http://reviews.llvm.org/D12614
___
cfe-commits mailing list
cfe-commits@
Hahnfeld created this revision.
Hahnfeld added reviewers: ABataev, hfinkel, kkwli0, rjmccall.
Hahnfeld added a subscriber: cfe-commits.
`#pragma omp parallel` needs an implicit barrier that is currently done by an
explicit call to `__kmpc_barrier`. However, the runtime already ensures a
barrier
Hahnfeld added a comment.
I didn't adjust the tests, I'm sorry! Will do so if the change is acceptable in
general...
http://reviews.llvm.org/D15561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
hahnjo wrote:
> But my point is that we can't land that if we don't understand what's going
> wrong without that patch.
We understand that very well and it's described in
https://reviews.llvm.org/D153003 as well as the surrounding discussions:
because of the way that `ODRHash` works, template
https://github.com/hahnjo closed
https://github.com/llvm/llvm-project/pull/102450
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hahnjo wrote:
Quick question for my understanding: With `spr` we don't get meaningful commit
messages anymore? That's quite unfortunate...
https://github.com/llvm/llvm-project/pull/102859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:/
hahnjo wrote:
> > Quick question for my understanding: With `spr` we don't get meaningful
> > commit messages anymore? That's quite unfortunate...
>
> Can you please clarify?
The commit messages in this PR are `initial version` and `Update const.cpp`,
which is totally useless if I came across
https://github.com/hahnjo created
https://github.com/llvm/llvm-project/pull/103028
When instantiating a delayed template, the recorded token stream is passed to
`Parser::ParseLateTemplatedFuncDef` which will append the current token "so it
doesn't get lost". With incremental extensions enabled
hahnjo wrote:
> > BTW, the delayed template parsing is a deprecated technique. Both clang and
> > MSVC won't enable this after C++20 and we think it is the root of many bugs.
>
> I agree. It was needed in the past to parse the MSVC stdlib, let's check if
> we still need it:
> [root-project/ro
https://github.com/hahnjo closed
https://github.com/llvm/llvm-project/pull/103028
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Stefan =?utf-8?q?Gr=C3=A4nitz?=
Message-ID:
In-Reply-To:
@@ -14,7 +14,7 @@ struct A { int a; A(int a) : a(a) {} virtual ~A(); };
// PartialTranslationUnit.
inline A::~A() { printf("~A(%d)\n", a); }
-// Create one instance with new and delete it.
+// Create one instance with
@@ -224,11 +228,8 @@ IncrementalParser::IncrementalParser(Interpreter &Interp,
return; // PTU.takeError();
}
- if (CodeGenerator *CG = getCodeGen()) {
-std::unique_ptr M(CG->ReleaseModule());
-CG->StartModule("incr_module_" + std::to_string(P
@@ -364,6 +365,19 @@ IncrementalParser::Parse(llvm::StringRef input) {
std::unique_ptr IncrementalParser::GenModule() {
static unsigned ID = 0;
if (CodeGenerator *CG = getCodeGen()) {
+// Clang's CodeGen is designed to work with a single llvm::Module. In many
+// ca
https://github.com/hahnjo closed https://github.com/llvm/llvm-project/pull/76473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hahnjo created
https://github.com/llvm/llvm-project/pull/102450
When incremental processing is enabled, the Parser will never report `tok::eof`
but `tok::annot_repl_input_end`. However, that case is already taken care of in
`IncrementalParser::ParseOrWrapTopLevelDecl()` so t
hahnjo wrote:
> Your reasoning sounds right to me. Can we make sure we are not breaking
> `clang -fincremental-extensions`, too?
As far as I can tell, `-fincremental-extensions` should set the language option
`IncrementalExtensions` which in turn is the default for
`Preprocessor::IncrementalP
Author: Jonas Hahnfeld
Date: 2021-08-25T09:31:22+02:00
New Revision: ea08c4cd1c0869ec5024a8bb3f5cdf06ab03ae83
URL:
https://github.com/llvm/llvm-project/commit/ea08c4cd1c0869ec5024a8bb3f5cdf06ab03ae83
DIFF:
https://github.com/llvm/llvm-project/commit/ea08c4cd1c0869ec5024a8bb3f5cdf06ab03ae83.diff
https://github.com/hahnjo created
https://github.com/llvm/llvm-project/pull/104964
None
>From dc37b356fb9527c3b4cf6b31f55d2dd5067fc29d Mon Sep 17 00:00:00 2001
From: Jonas Hahnfeld
Date: Tue, 20 Aug 2024 16:25:15 +0200
Subject: [PATCH 1/2] [clang-repl] Fix printing preprocessed tokens
---
cl
https://github.com/hahnjo closed
https://github.com/llvm/llvm-project/pull/104964
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hahnjo wrote:
I believe
https://github.com/llvm/llvm-project/commit/30ea0f0ce476bf4c12684a9a514af2ca660bbe44
already addresses the cast. The bots are just slow...
https://github.com/llvm/llvm-project/pull/119333
___
cfe-commits mailing list
cfe-commi
https://github.com/hahnjo created
https://github.com/llvm/llvm-project/pull/133057
* Hash inner template arguments: The code is applied from `ODRHash::AddDecl`
with the reasoning given in the comment, to reduce collisions. This was
particularly visible with STL types templated on `std::pair`
hahnjo wrote:
### Performance measurements with LLVM
I tested these patches for building LLVM itself with modules
(`LLVM_ENABLE_MODULES=ON`). To work around
https://github.com/llvm/llvm-project/issues/130795, I apply
https://github.com/llvm/llvm-project/pull/131354 before building Clang. In
hahnjo wrote:
> While I may not able to look into them in detail recently, it may be helpful
> to split this into seperate patches to review and to land.
I initially considered this, but @vgvassilev said in
https://github.com/root-project/root/pull/17722#issuecomment-2706555950 he
prefers a s
hahnjo wrote:
Hi @emaxx-google, any updates on the second minimization run?
https://github.com/llvm/llvm-project/pull/133057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hahnjo wrote:
> The simplified script: https://pastebin.com/udVTaPYV
Aaaah, the important line is `EXTRA_CFLAGS='-Xclang
-fallow-pcm-with-compiler-errors -ferror-limit=0'`. With that I indeed get the
following diff between logs from `main` and a rebased version of this branch:
```diff
--- main
201 - 300 of 312 matches
Mail list logo
