[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

Hahnfeld added a comment. In https://reviews.llvm.org/D45212#1066842, @rjmccall wrote: > I'd still prefer if someone with more driver-design expertise weighed in, but > we might not have any specialists there. I think you should at least give @tra the possibility to take a look. Last time we

[PATCH] D42922: [CUDA] Register relocatable GPU binaries

Hahnfeld added a comment. Ping https://reviews.llvm.org/D42922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42922: [CUDA] Register relocatable GPU binaries

Hahnfeld updated this revision to Diff 143136. Hahnfeld marked 2 inline comments as done. Hahnfeld added a comment. Move `FunctionType`s to methods and change test prefixes. https://reviews.llvm.org/D42922 Files: lib/CodeGen/CGCUDANV.cpp test/CodeGenCUDA/device-stub.cu Index: test/CodeGenC

[PATCH] D42922: [CUDA] Register relocatable GPU binaries

Hahnfeld added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:283-285 + llvm::FunctionType *RegisterGlobalsFnTy; + llvm::FunctionType *RegisterLinkedBinaryFnTy; + llvm::Function *DummyCallback; tra wrote: > Instead of tracking these through the conditio

[PATCH] D42922: [CUDA] Register relocatable GPU binaries

Hahnfeld updated this revision to Diff 143145. Hahnfeld marked an inline comment as done. Hahnfeld added a comment. Move module ID to corresponding `else` branch. https://reviews.llvm.org/D42922 Files: lib/CodeGen/CGCUDANV.cpp test/CodeGenCUDA/device-stub.cu Index: test/CodeGenCUDA/device-

[PATCH] D42922: [CUDA] Register relocatable GPU binaries

This revision was automatically updated to reflect the committed changes. Closed by commit rC330425: [CUDA] Register relocatable GPU binaries (authored by Hahnfeld, committed by ). Repository: rC Clang https://reviews.llvm.org/D42922 Files: lib/CodeGen/CGCUDANV.cpp test/CodeGenCUDA/device

[PATCH] D45449: [CUDA] Document recent changes

This revision was automatically updated to reflect the committed changes. Closed by commit rC330426: [CUDA] Document recent changes (authored by Hahnfeld, committed by ). Repository: rC Clang https://reviews.llvm.org/D45449 Files: docs/ReleaseNotes.rst include/clang/Driver/Options.td In

[PATCH] D48615: [CUDA] Place all CUDA sections in __NV_CUDA segment on Mac.

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LGTM. These were the section names I suspected, but I wasn't able to verify back then. https://reviews.llvm.org/D48615 ___ cfe-commits maili

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

Hahnfeld added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:84-85 OMPRTL_NVPTX__kmpc_data_sharing_init_stack, + /// Call to void __kmpc_data_sharing_init_stack_spmd(); + OMPRTL_NVPTX__kmpc_data_sharing_init_stack_spmd, /// Call to void* __kmpc_data_sh

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

Hahnfeld added a comment. This is definitely not NFC and breaks ABI compatibility (but apparently nobody cares anymore). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83268/new/ https://reviews.llvm.org/D83268 __

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

Hahnfeld added a comment. In D83268#2135930 , @JonChesterfield wrote: > Aside from the API stability concern this looks uncontentious. Removes dead > arguments, generally makes things simpler. Thus LGTM. > > @Hahnfeld @ABataev - are you sufficiently pers

[PATCH] D40354: [OpenMP] Adjust arguments of nvptx runtime functions

Hahnfeld created this revision. Herald added a subscriber: jholewinski. In the future the compiler will analyze whether the OpenMP runtime needs to be (fully) initialized and avoid that overhead if possible. The functions already take an argument to transfer that information to the runtime, so pas

[PATCH] D40354: [OpenMP] Adjust arguments of nvptx runtime functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL318836: [OpenMP] Adjust arguments of nvptx runtime functions (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D40354?vs=123930&id=123934#toc Repository: rL LLVM https://revi

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

Hahnfeld added reviewers: tra, jlebar. Hahnfeld added a comment. The change looks good in general and is small enough and last in the candidates list to not break working setups. What concerns me is that we have to do the same for every distribution (I know that Arch Linux for example has CUDA

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

Hahnfeld added a comment. In that case I don't see a way to be "clever", so we have to add the static candidate. I'll let @tra or @jlebar have a final look. https://reviews.llvm.org/D40453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D40275: [CUDA] Report "unsupported VLA" errors only on device side.

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. I'm fine if @rjmccall is fine - but looks like I need to accept this revision because I requested changes in the past? https://reviews.llvm.org/D40275 _

[PATCH] D40572: [OpenMP] Make test robust against quotation, NFC.

Hahnfeld created this revision. This is needed to not break with an upcoming change in LLVM to use dollar signs (which need to be quoted) instead of dots for generating unique names. https://reviews.llvm.org/D40572 Files: test/OpenMP/nvptx_parallel_codegen.cpp Index: test/OpenMP/nvptx_parall

[PATCH] D39114: [XRay][compiler-rt][Darwin] Minimal XRay build support in Darwin

Hahnfeld added a comment. I'm getting "multiple definition" errors on powerpc64le when linking the unit tests, for example `XRayBufferQueueTest`: src/projects/compiler-rt/lib/xray/xray_utils.cc:34: multiple definition of `__xray::retryingWriteAll(int, char*, char*)' src/projects/compiler-rt

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

Hahnfeld added a comment. On a related note please add context to your patch as described here: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface https://reviews.llvm.org/D40453 ___ cfe-commits mailing list cfe-commit

[PATCH] D40577: Clang support for simd functions

Hahnfeld added a reviewer: ABataev. Hahnfeld added a comment. This should add or extend a regression test https://reviews.llvm.org/D40577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D40572: [OpenMP] Make test robust against quotation, NFC.

Hahnfeld abandoned this revision. Hahnfeld added a comment. Not needed anymore for the accepted patch which gets rid of the separator completely. https://reviews.llvm.org/D40572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D39005: [OpenMP] Clean up variable and function names for NVPTX backend

Hahnfeld removed a reviewer: Hahnfeld. Hahnfeld added a comment. Fixed differently in https://reviews.llvm.org/rL319657. Repository: rL LLVM https://reviews.llvm.org/D39005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D40911: [OpenMP] Fix PR35542: Correct adjusting of private reduction variable

Hahnfeld created this revision. Herald added a subscriber: cfe-commits. The adjustment is calculated with CreatePtrDiff() which returns the difference in (base) elements. This is passed to CreateGEP() so make sure that the GEP base has the correct pointer type: It needs to be a pointer to the base

[PATCH] D40911: [OpenMP] Fix PR35542: Correct adjusting of private reduction variable

Hahnfeld added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1110 +PrivateAddr.getPointer(), +SharedAddresses[N].first.getPointer()->getType()); +llvm::Value *Ptr = CGF.Builder.CreateGEP(PrivatePointer, Adjustment); ABat

[PATCH] D40911: [OpenMP] Fix PR35542: Correct adjusting of private reduction variable

Hahnfeld updated this revision to Diff 125768. Hahnfeld marked 3 inline comments as done. Hahnfeld added a comment. Get type from `Address`. https://reviews.llvm.org/D40911 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/for_reduction_codegen.cpp test/OpenMP/for_reduction_codegen_UDR.c

[PATCH] D40911: [OpenMP] Fix PR35542: Correct adjusting of private reduction variable

This revision was automatically updated to reflect the committed changes. Closed by commit rL319931: Fix PR35542: Correct adjusting of private reduction variable (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D40911?vs=125768&id=125770#toc Repository: rL LLVM http

[PATCH] D40911: [OpenMP] Fix PR35542: Correct adjusting of private reduction variable

This revision was automatically updated to reflect the committed changes. Closed by commit rC319931: Fix PR35542: Correct adjusting of private reduction variable (authored by Hahnfeld). Repository: rC Clang https://reviews.llvm.org/D40911 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP

[PATCH] D40948: Switch Clang's default C++ language target to C++14

Hahnfeld added a reviewer: ABataev. Hahnfeld added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1732 case InputKind::ObjCXX: // The PS4 uses C++11 as the default C++ standard. + LangStd = LangStandard::lang_gnucxx14; Thi

[PATCH] D41012: [OpenMP] Further adjustments of nvptx runtime functions

Hahnfeld created this revision. Herald added subscribers: cfe-commits, jholewinski. Pass in default value of 1, similar to previous commit https://reviews.llvm.org/rL318836. Repository: rC Clang https://reviews.llvm.org/D41012 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp test/OpenMP/nvpt

[PATCH] D128853: [Interpreter] Pass target features to JIT

Hahnfeld created this revision. Hahnfeld added a reviewer: v.g.vassilev. Herald added subscribers: luke957, luismarques, s.egerton, PkmX, simoncook, arichardson. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D128853: [Interpreter] Pass target features to JIT

Hahnfeld added a comment. In D128853#3620342 , @v.g.vassilev wrote: > Looks good to me but can we add a test? Do we have builders with that target? In principle, this is visible in *every* usage of `clang-repl`, including the existing tests such as `cl

[PATCH] D128589: [clang-repl] Support destructors of global objects.

Hahnfeld added inline comments. Comment at: clang/test/Interpreter/execute.cpp:22-23 +struct D { float f = 1.0; D *m = nullptr; D(){} ~D() { printf("D[f=%f, m=0x%llx]\n", f, reinterpret_cast(m)); }} d; +// CHECK: D[f=1.00, m=0x0] + I think it would be bett

[PATCH] D128853: [Interpreter] Pass target features to JIT

Hahnfeld added inline comments. Comment at: clang/lib/Interpreter/IncrementalExecutor.h:34 struct PartialTranslationUnit; +struct TargetInfo; That's wrong, should be `class TargetInfo`. I'll fix this before landing if my other tests go well... Repository:

[PATCH] D128853: [Interpreter] Pass target features to JIT

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf22795de683d: [Interpreter] Pass target features to JIT (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D128853?vs=44115

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

Hahnfeld added a comment. FWIW this also causes a `static_assert` failure while building ROOT : In file included from /home/jhahnfel/ROOT/src/tmva/tmva/src/DNN/Architectures/Cpu/CpuBuffer.cxx:17: In file included from /opt/rh/gcc-toolset-11/root/usr/l

[PATCH] D123370: [CUDA/HIP] Remove argument from module ctor/dtor signatures

Hahnfeld created this revision. Hahnfeld added reviewers: tra, yaxunl. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In theory, constructors can take arguments when called via `.init_array` where at l

[PATCH] D123370: [CUDA/HIP] Remove argument from module ctor/dtor signatures

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4903d8be399: [CUDA/HIP] Remove argument from module ctor/dtor signatures (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123370/new/

[PATCH] D67031: [Clang][Bundler] Error reporting improvements [NFC]

Hahnfeld added a comment. This changes error messages, so I'd say it's not NFC. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44 -#include -#include -#include -#include The code still uses (in the order of marked includes) * `std

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

Hahnfeld added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44 -#include -#include -#include -#include sdmitriev wrote: > Hahnfeld wrote: > > The code still uses (in the order of marked includes) > > * `std::uniqu

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

Hahnfeld added a comment. Also, there should be a summary of the changes in here. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44 -#include -#include -#include -#include sdmitriev wrote: > Hahnfeld wrote: > > sdmitriev wrote: > >

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

Hahnfeld added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44 -#include -#include -#include -#include sdmitriev wrote: > Hahnfeld wrote: > > sdmitriev wrote: > > > Hahnfeld wrote: > > > > sdmitriev wrote: > > > >

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

Hahnfeld added a comment. In https://reviews.llvm.org/D29660#839736, @alekseyshl wrote: > In https://reviews.llvm.org/D29660#839728, @alekseyshl wrote: > > > Bad news, the bot is still red: > > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7114 > > > Disabled openmp-offloa

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

Hahnfeld added inline comments. Comment at: lib/Driver/ToolChain.cpp:851 + XOpenMPTargetArg->setBaseArg(A); + A = XOpenMPTargetArg.release(); + DAL->append(A); This is a memory leak that is currently triggered in `tests/Driver/openmp-offload-gpu.c

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

Hahnfeld added a comment. In D89974#2347938 , @tra wrote: > One concern I have is that the path we configure during clang's build is not > necessarily the right choice for the user of clang we build. It's likely that > the clang in the end will be used o

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

Hahnfeld added a comment. In D89974#2347979 , @Hahnfeld wrote: > In D89974#2347938 , @tra wrote: > >> I think the default should still let clang search for CUDA or require the >> user to provide correct CUDA path.

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

Hahnfeld added a comment. In D89974#2348124 , @jdoerfert wrote: > I thought, right now we would configure clang with a cuda path XYZ If you speak of the current state in the repository, AFAICT, Clang doesn't know about a CUDA installation that CMake may

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

Hahnfeld added a comment. In D89974#2348176 , @tra wrote: > CUDA path is sort of a global configuration parameter for all CUDA > compilations. Perhaps we should consider allowing the user to specify a CUDA > search path candidate via environment variable

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

Hahnfeld added a comment. In D96033#2767884 , @teemperor wrote: > In D96033#2766502 , @phosek wrote: > >> In D96033#2766372 , @v.g.vassilev >> wrote: >> >>> In D96033#276633

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

Hahnfeld added a comment. My proposal would be to cache the return value of the three routines in `ToolChain`. This has the advantage that the values get parsed only once and there is at most one warning. I don't know how this plays with parallelization efforts, but I don't think we should worr

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

Hahnfeld added a comment. In D95915#2541132 , @tbaeder wrote: > That's what I was looking at right now as well, since using > `std::call_once()` already means the methods can't be `const` anymore anyway. > Might as well just cache the value. You can mak

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

Hahnfeld added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:169-177 + mutable bool isCXXStdlibTypeCached; + mutable CXXStdlibType cxxStdlibType; + + mutable bool isRuntimeLibTypeCached; + mutable RuntimeLibType runtimeLibType; + + mutable bool isUnwind

[PATCH] D77670: [CUDA] Add partial support for recent CUDA versions.

Hahnfeld added a comment. Herald added a subscriber: dexonsmith. Herald added a project: LLVM. @tra The split between `LATEST` and `LATEST_SUPPORTED` leads to very weird warning and error messages: clang-14: warning: unknown CUDA version: cuda.h: CUDA_VERSION=11040.; assuming the latest suppo

[PATCH] D77670: [CUDA] Add partial support for recent CUDA versions.

Hahnfeld added a comment. In D77670#2944192 , @tra wrote: > In D77670#2943753 , @Hahnfeld wrote: > >> @tra The split between `LATEST` and `LATEST_SUPPORTED` leads to very weird >> warning and error messages: > > Ag

[PATCH] D108235: [CUDA] Bump default GPU architecture to sm_35.

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108235/new/ https://reviews.llvm.org/D108235 ___

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

Hahnfeld added inline comments. Comment at: clang/test/Driver/cuda-version-check.cu:75 -// UNKNOWN_VERSION_V: unknown CUDA version: version.txt:{{.*}}; assuming the latest supported version -// UNKNOWN_VERSION_H: unknown CUDA version: cuda.h: CUDA_VERSION={{.*}}; assuming the

[PATCH] D108248: [CUDA] Bump the latest supported CUDA version to 11.4.

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LG, should land after the other revisions are in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108248/new/ https://reviews.llvm.org/D108248

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. Otherwise LGTM Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:103-104 +std::string VersionString = CudaVersionToString(Version); +if (!VersionString.empty()) +

[PATCH] D108235: [CUDA] Bump default GPU architecture to sm_35.

Hahnfeld added a comment. (might be good to have an entry in the release notes?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108235/new/ https://reviews.llvm.org/D108235 ___ cfe-commits mailing list cf

[PATCH] D108239: [CUDA] Add support for CUDA-11.4.

Hahnfeld added a comment. I didn't follow the recent CUDA support in Clang very closely, but this makes sense to me. Comment at: clang/lib/Basic/Targets/NVPTX.cpp:48-49 PTXVersion = llvm::StringSwitch(Feature) + .Case("+ptx72", 74) +

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

Hahnfeld added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:209-211 + Version = FS.exists(LibDevicePath + "/libdevice.10.bc") +? Version = CudaVersion::NEW +: Version = CudaVersion::CUDA_70; The co

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

Hahnfeld added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:209-211 + Version = FS.exists(LibDevicePath + "/libdevice.10.bc") +? Version = CudaVersion::NEW +: Version = CudaVersion::CUDA_70; tra wr

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

Hahnfeld added a comment. I'm not sure if it's actually correct to advertise full support for CUDA 11.5, but I didn't look into exact changes since 11.4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113249/new/ https://reviews.llvm.org/D113249 __

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

Hahnfeld added a comment. Experimental support for `__int128` is new in CUDA 11.5, not sure if Clang enables this for CUDA. The release notes also specify > `builtin_assume` can now be used to specify address space to allow for > efficient loads and stores. The docs are very scarce on this, I

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

Hahnfeld added a comment. In D113249#3117541 , @carlosgalvezp wrote: > @Hahnfeld Are you satisfied with the replies to your questions? If so I can > go ahead and merge. Yes yes, I'm happy if @tra is happy :) CHANGES SINCE LAST ACTION https://review

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

Hahnfeld added inline comments. Comment at: clang/tools/nvptx-arch/CMakeLists.txt:28 + +clang_target_link_libraries(nvptx-arch PRIVATE ${cuda-library}) This broke my build with `CLANG_LINK_CLANG_DYLIB`; we must use the standard CMake `target_link_libraries` for

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

Hahnfeld created this revision. Hahnfeld added reviewers: v.g.vassilev, mantognini, ChuanqiXu, Bigcheese. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the `Decl` pointers are not identical, `decla

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

Hahnfeld added a comment. This fixes the assertion for a downstream case in ROOT/Cling with the involvement of modules. If anyone has ideas how to test this, please let me know... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137787/new/ https://

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

Hahnfeld added a comment. I've trimmed the failing code down to #include #include #include template struct SO { void a() { struct SI { std::vector v; }; SI s; SI m(std::move(s)); } void g() { std::vector v{"a"}; } }; in

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

Hahnfeld added a comment. > Is it the reproducer? No, as I wrote: > Sadly this works fine in standalone Clang... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137787/new/ https://reviews.llvm.org/D137787 _

[PATCH] D137927: Adapt unittests for isSelfContainedHeader to API

Hahnfeld created this revision. Hahnfeld added reviewers: hokein, kadircet. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The function now takes a FileEntry instead of a FileID. Repository: rG LLV

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

Hahnfeld added a comment. @hokein it seems the unit test wasn't updated for the last-minute API change, which breaks `check-all` for me. I've posted https://reviews.llvm.org/D137927, could you take a look if that change is correct? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D137927: Adapt unittests for isSelfContainedHeader to API

Hahnfeld abandoned this revision. Hahnfeld added a comment. Fixed in https://reviews.llvm.org/rG5c4ae8a86a865e622e2c663666c0c139334b5da2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137927/new/ https://reviews.llvm.org/D137927 ___

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

Hahnfeld added a comment. No worries, thanks for fixing so quickly! I just happened to pull in the wrong moment... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137697/new/ https://reviews.llvm.org/D137697

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

Hahnfeld added a comment. > Sorry, I don't understand well. Could you rewrite the reproducer in the style > I wrote? And in what cases it works fine? Okay, let me try to restate: I can reproduce the problem in ROOT/Cling which is an *interpreter* built on top of LLVM and CLang. The moment I put

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

Hahnfeld added a comment. Yes, I fully agree that having a test is desirable, I just didn't manage so far. Maybe it takes somebody with deep AST knowledge to explain under what circumstances `DtorDecl->getParent()` is *not* the canonical `Decl`. Maybe this could help crafting a test case, even

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

Hahnfeld added a comment. In D137787#3924857 , @v.g.vassilev wrote: > - Is the failure also not reproducible with clang9 (on which is based cling)? > - Is the failure also not reproducible with clang9 built on top of the > downstream patches? The failu

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Hahnfeld marked an inline comment as done. Closed by commit rG01eb01c7fd7a: [clang][Lex] Add back PPCallbacks::FileNotFound (authored by Hahnfeld). Repository: rG LL

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld added a comment. I checked a second time and couldn't find other API docs. I've now pushed this change for now (also to get it included in `release/16.x`), but please let me know for any follow-ups. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld added a comment. In D142196#4077708 , @jansvoboda11 wrote: > Yes, I meant the `pp-trace` docs. Why would "we didn't find the included > file" not be a traceable event? My thinking is the following: If the preprocessor cannot find the included

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

Hahnfeld reopened this revision. Hahnfeld added a comment. This broke `clang/test/Driver/rocm-detect.hip` on a number of platforms (including the pre-merge checks on this PR), I've reverted for now in b5ee4f755fcff56243f6ff0cea9e7a722259304a

[PATCH] D141380: [clang-repl] XFAIL riscv targets in simple-exception test case

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. Yes, this is correct: The JITLink backend for RISC-V doesn't (yet) register the eh frames into libunwind, so throwing and catching exceptions through JITted code doesn't work (yet). I know

[PATCH] D119708: [clang][lex] Remove `PPCallbacks::FileNotFound()`

Hahnfeld added subscribers: v.g.vassilev, Hahnfeld. Hahnfeld added a comment. Herald added a subscriber: ributzka. Herald added a project: All. Hello, sorry for the late heads-up, but this functionality is used by ROOT: https://github.com/root-project/root/blob/f58cccf5ce7fd67894c7fd9e9e74d3f37bc

[PATCH] D119708: [clang][lex] Remove `PPCallbacks::FileNotFound()`

Hahnfeld added a comment. In D119708#4060336 , @jansvoboda11 wrote: > In D119708#4059254 , @Hahnfeld > wrote: > >> Hello, sorry for the late heads-up, but this functionality is used by ROOT: >> https://github.c

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld created this revision. Hahnfeld added reviewers: jansvoboda11, ahoppen. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This callback was r

[PATCH] D119708: [clang][lex] Remove `PPCallbacks::FileNotFound()`

Hahnfeld added a comment. In D119708#4062632 , @jansvoboda11 wrote: > If the plan is to eventually upstream that part of Cling, I'm fine with > re-adding a safe version of this API. I'll be honest here and say that I personally find it unlikely that th

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld added a comment. I just checked and this "simplified" version of the callback would give us enough information to implement all we need in ROOT (plus some, the `bool` return value is nicer than temporarily playing with `SuppressIncludeNotFoundError`). For an upstream test, I could impl

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld updated this revision to Diff 491095. Hahnfeld added a comment. Add unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142196/new/ https://reviews.llvm.org/D142196 Files: clang/include/clang/Lex/PPCallbacks.h clang/lib/Lex/PPDirectives.cpp clang/unittests/Lex/PPCal

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld updated this revision to Diff 491522. Hahnfeld added a comment. Update comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142196/new/ https://reviews.llvm.org/D142196 Files: clang/include/clang/Lex/PPCallbacks.h clang/lib/Lex/PPDirectives.cpp clang/unittests/Lex/PPCa

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld marked an inline comment as done. Hahnfeld added a comment. In D142196#4074249 , @jansvoboda11 wrote: > Also I think we should mention this API in our docs, right where the removed > original used to be. Which API docs are you referring to? I'

[PATCH] D126672: [Driver] Add multiarch path for RISC-V

Hahnfeld created this revision. Hahnfeld added a reviewer: sylvestre.ledru. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, arichardson. Herald added a project: All. Hahnfeld requested re

[PATCH] D126672: [Driver] Add multiarch path for RISC-V

Hahnfeld added a comment. In D126672#3546773 , @MaskRay wrote: > This needs a test. There are no tests for any of the other architectures. > Can Debian's riscv GCC be fixed to use a normalized triple for library and > include paths? This is not specif

[PATCH] D126672: [Driver] Add multiarch path for RISC-V

Hahnfeld added a comment. In D126672#3546782 , @Hahnfeld wrote: > In D126672#3546773 , @MaskRay wrote: > >> This needs a test. > > There are no tests for any of the other architectures. @MaskRay is this ok to lan

[PATCH] D126672: [Driver] Add multiarch path for RISC-V

This revision was automatically updated to reflect the committed changes. Closed by commit rG0d2186373f73: [Driver] Add multiarch path for RISC-V (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126672/new/ https://reviews.llvm.

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

Hahnfeld added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158413/new/ https://reviews.llvm.org/D158413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158414: [LexerTest] Use LexTokensUntilEOF() in StringifyArgs

Hahnfeld added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158414/new/ https://reviews.llvm.org/D158414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

Hahnfeld updated this revision to Diff 557603. Hahnfeld marked an inline comment as done. Hahnfeld added a comment. Address minor naming convention nit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158413/new/ https://reviews.llvm.org/D158413 Files: clang/include/clang/Lex/Preproces

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

Hahnfeld added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:1000 + std::vector toks; + while (1) { +Token tok; v.g.vassilev wrote: > Hahnfeld wrote: > > aaron.ballman wrote: > > > v.g.vassilev wrote: > > > > aaron.ballman wrote: > > > > > Hah

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3116d60494f2: [Lex] Introduce Preprocessor::LexTokensUntilEOF() (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexTokensUntilEOF()

This revision was automatically updated to reflect the committed changes. Closed by commit rGabb9eb2778dc: [Lex] Handle repl_input_end in Preprocessor::LexTokensUntilEOF() (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D158415?vs=556849&id=557607#toc Repository: rG

[PATCH] D154328: [AST] Add API to iterate already loaded specializations

Hahnfeld added a comment. gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154328/new/ https://reviews.llvm.org/D154328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

<    1   2   3   4   5   6   >