Hahnfeld added reviewers: tra, jlebar. Hahnfeld added a comment. The change looks good in general and is small enough and last in the candidates list to not break working setups.
What concerns me is that we have to do the same for every distribution (I know that Arch Linux for example has CUDA installed in `/opt/cuda`, see https://www.archlinux.org/packages/community/x86_64/cuda/). In addition many HPC systems use the modules system to install multiple versions in parallel. As such we should make the installation detection smarter: 1. We could have an environment variable that systems can set to the appropriate directory. 2. We could try to automatically deduce the install path: If we find `ptxas` in the `PATH` and it is in a directory `bin`, its parent is a good candidate to start searching. I think 2. would work for Arch Linux which adds `/opt/cuda/bin` to `PATH` IIRC. I'm not sure about Debian though, @sylvestre.ledru? If that doesn't work, we have to add the candidate statically anyway... https://reviews.llvm.org/D40453 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
