[PATCH] D148723: [clang] Enforce internal linkage for inline builtin

jyu2 added a comment. I think something like #ifdef RINZOCORE_SHARED #define RINZO_LIB __declspec(dllexport) #else #define RINZO_LIB __declspec(dllimport) #endif RINZO_LIB inline func() {} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148723/new/

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

jyu2 added a comment. If it is okay with is_divece_ptr. I am okay with it. Please add a lit test for this? Thanks. Jennifer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141627/new/ https://reviews.llvm.org/D141627 __

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

jyu2 updated this revision to Diff 481319. jyu2 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139166/new/ https://reviews.llvm.org/D139166 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:334 llvm::Value *emitUpdateLocation(CodeGenFunction &CGF, SourceLocation Loc, - unsigned Flags = 0); + unsigned Flags = 0, bool EmitLoc

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf781f704239: [OPENMP51]Codegen for error directive. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D34671: This is to address more command from Richard Smith for my change of https://reviews.llvm.org/D33333

jyu2 added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6356-6357 +: Warning< + "%0 has a non-throwing exception specification but can " "still " + "throw">, + InGro

[PATCH] D34671: This is to address more command from Richard Smith for my change of https://reviews.llvm.org/D33333

jyu2 updated this revision to Diff 104959. jyu2 added a comment. Hi Aaron, Thank you so much for your review. I just update change to address your comments. Let me kwon if you see more problems. Thanks again. Jennifer Repository: rL LLVM https://reviews.llvm.org/D34671 Files: include/

[PATCH] D34671: This is to address more command from Richard Smith for my change of https://reviews.llvm.org/D33333

jyu2 updated this revision to Diff 104966. jyu2 added a comment. Hi Richard, Thank you so much for your review. I just update patch to address you new comment. Please let me know if you see more problems. Thanks. Jennifer Repository: rL LLVM https://reviews.llvm.org/D34671 Files: incl

[PATCH] D34671: This is to address more command from Richard Smith for my change of https://reviews.llvm.org/D33333

jyu2 added inline comments. Comment at: lib/Sema/AnalysisBasedWarnings.cpp:409 +<< (Ty->hasExceptionSpec() ? FD->getExceptionSpecSourceRange() + : FD->getSourceRange()); +} else rsmith wrote: > Underlining th

[PATCH] D33537: [clang-tidy] Exception Escape Checker

jyu2 added a comment. In https://reviews.llvm.org/D33537#771274, @aaron.ballman wrote: > In https://reviews.llvm.org/D33537#771159, @baloghadamsoftware wrote: > > > In https://reviews.llvm.org/D33537#770264, @aaron.ballman wrote: > > > > > I think we should try to get as much of this functionalit

[PATCH] D27358: V-base dtor called more than needed when throw happens in v-base ctor in window. Need add "complete object flag" check in eh cleanup code.

jyu2 created this revision. jyu2 added reviewers: cfe-commits, erichkeane, majnemer, rnk. jyu2 set the repository for this revision to rL LLVM. jyu2 added a project: clang-c. The problem only happen on window ( A MSVC compatibility issues) The nature of the problem is virtual base dtor called mor

[PATCH] D27358: [MS-ABI]V-base dtor called more than needed when throw happens in v-base ctor in window. Need add "complete object flag" check in eh cleanup code.

jyu2 removed rL LLVM as the repository for this revision. jyu2 updated this revision to Diff 80459. jyu2 added a comment. Update patch to address Reid's suggestion https://reviews.llvm.org/D27358 Files: lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGenCXX/microsoft-abi-eh-cleanups.cpp Index: li

[PATCH] D27358: [MS-ABI]V-base dtor called more than needed when throw happens in v-base ctor in window. Need add "complete object flag" check in eh cleanup code.

jyu2 added a comment. Hi Reid, I know some problems(ms compatibility) when throw inside destructor. I have not yet look like those problems. I am new for clang. I need sometime to catch up. -:) Thank you so much for your code review. I had add new patch to address your suggestion. Pleas

[PATCH] D27358: [MS-ABI]V-base dtor called more than needed when throw happens in v-base ctor in window. Need add "complete object flag" check in eh cleanup code.

jyu2 set the repository for this revision to rL LLVM. jyu2 updated this revision to Diff 80462. jyu2 added a comment. A typo. Repository: rL LLVM https://reviews.llvm.org/D27358 Files: lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGenCXX/microsoft-abi-eh-cleanups.cpp Index: lib/CodeGen/Micro

[PATCH] D27358: [MS-ABI]V-base dtor called more than needed when throw happens in v-base ctor in window. Need add "complete object flag" check in eh cleanup code.

jyu2 added a comment. I changed! Thank you do much. Upload new patch. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1530-1532 +const CXXRecordDecl *ClassDecl = + cast(CGF.CurCodeDecl)->getParent(); +if (ClassDecl != nullptr && ClassDecl->getNumVBases())

[PATCH] D27358: [MS-ABI]V-base dtor called more than needed when throw happens in v-base ctor in window. Need add "complete object flag" check in eh cleanup code.

jyu2 updated this revision to Diff 80487. jyu2 added a comment. Remove unnecessary check. Repository: rL LLVM https://reviews.llvm.org/D27358 Files: CodeGen/MicrosoftCXXABI.cpp Index: CodeGen/MicrosoftCXXABI.cpp === --- Code

[PATCH] D27358: [MS-ABI]V-base dtor called more than needed when throw happens in v-base ctor in window. Need add "complete object flag" check in eh cleanup code.

jyu2 updated this revision to Diff 80491. jyu2 added a comment. last one missing test part diff. Sorry for that Repository: rL LLVM https://reviews.llvm.org/D27358 Files: lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGenCXX/microsoft-abi-eh-cleanups.cpp Index: lib/CodeGen/MicrosoftCXXABI.cp

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 created this revision. Throwing in the destructor is not good (C++11 change try to not allow see below). But in reality, those codes are exist. C++11 [class.dtor]p3: A declaration of a destructor that does not have an exception-specification is implicitly considered to have the same e

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 updated this revision to Diff 99517. jyu2 added a comment. Reid, Thank you so much for your comments. I upload new patch to address your suggestion. 1> Emit warning for throw exception in all noexcept function. And special diagnostic note for destructor and delete operators. 2> Silence th

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 added a comment. In https://reviews.llvm.org/D3#760149, @aaron.ballman wrote: > As an FYI, there is a related check currently under development in > clang-tidy; we probably should not duplicate this functionality in both > places. See https://reviews.llvm.org/D19201 for the other rev

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 added a comment. In https://reviews.llvm.org/D3#760431, @aaron.ballman wrote: > In https://reviews.llvm.org/D3#760419, @jyu2 wrote: > > > In https://reviews.llvm.org/D3#760149, @aaron.ballman wrote: > > > > > As an FYI, there is a related check currently under development in > >

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 added a comment. In https://reviews.llvm.org/D3#761233, @aaron.ballman wrote: > In https://reviews.llvm.org/D3#761224, @rnk wrote: > > > Re: clang-tidy, I would rather implement this as a traditional compiler > > warning. > > > > In https://reviews.llvm.org/D3#761208, @aaron.bal

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 updated this revision to Diff 99802. jyu2 added a comment. This is new version should address all @Aaron's commands, but CFG part. I would not think we should go that far in the compiler for this. Thanks. https://reviews.llvm.org/D3 Files: include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 updated this revision to Diff 99857. jyu2 added a comment. I missed two place which Aaron point out. 1> using isNothrow function instead NR_Nothrow. 2> A format problem. Changed. Thanks. https://reviews.llvm.org/D3 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Se

[PATCH] D101781: Fix assert on the variable which is used in omp clause is not marked as used

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert, mikerice. jyu2 added a project: clang. jyu2 requested review of this revision. Herald added a subscriber: sstefan1. The problem only happens with constexpr variable, for constexpr variable, variable is not marked during parser e

[PATCH] D101781: Fix assert on the variable which is used in omp clause is not marked as used

This revision was automatically updated to reflect the committed changes. Closed by commit rG5285748c2c76: Fix assert on the variable which is used in omp clause is not marked (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101781/n

[PATCH] D116764: [clang][OpenMP5.1] Initial parsing/sema for 'indirect' clause

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added a project: clang. Herald added subscribers: guansong, yaxunl. Herald added a reviewer: aaron.ballman. Herald added a project: Flang. jyu2 requested review of this revision. Herald added subscribers: llvm-comm

[PATCH] D116764: [clang][OpenMP5.1] Initial parsing/sema for 'indirect' clause

jyu2 updated this revision to Diff 398043. jyu2 added a comment. Address Alexey's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116764/new/ https://reviews.llvm.org/D116764 Files: clang/include/clang/Basic/Attr.td clang/include/clang

[PATCH] D116764: [clang][OpenMP5.1] Initial parsing/sema for 'indirect' clause

jyu2 added a comment. Thanks Alexey for the code review. Comment at: clang/include/clang/Sema/Sema.h:10338 +Expr *IndirectExpr = nullptr; +bool IsIndirect = false; + ABataev wrote: > Can you use `Optional` instead of `Expr *` and `bool`? Good to know.

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

jyu2 accepted this revision. jyu2 added a comment. Looks good to me. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116059/new/ https://reviews.llvm.org/D116059 ___ cfe-commits mailing list cfe-c

[PATCH] D116764: [clang][OpenMP5.1] Initial parsing/sema for 'indirect' clause

jyu2 updated this revision to Diff 398249. jyu2 added a comment. Fix format problem. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116764/new/ https://reviews.llvm.org/D116764 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticParseKinds.td clang/include

[PATCH] D116764: [clang][OpenMP5.1] Initial parsing/sema for 'indirect' clause

This revision was automatically updated to reflect the committed changes. Closed by commit rG140a6b1e5c68: [clang][OpenMP5.1] Initial parsing/sema for 'indirect' clause (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116764/new/ ht

[PATCH] D98812: [OPENMP]Map data field with l-value reference types.

jyu2 accepted this revision. jyu2 added a comment. This revision is now accepted and ready to land. Thanks Alexey for adding this! The changes LGTM, but I'm not super well-versed with this. You may wait a bit for other reviewers to weigh in before landing. Repository: rG LLVM Github Monorepo

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

jyu2 created this revision. jyu2 added reviewers: mikerice, ABataev, jdoerfert. jyu2 added projects: LLVM, clang. Herald added subscribers: arphaman, guansong, yaxunl. Herald added a reviewer: sscalpone. jyu2 requested review of this revision. Herald added a subscriber: sstefan1. Added basic parsi

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

jyu2 updated this revision to Diff 334956. jyu2 added a comment. Fix format problem as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99679/new/ https://reviews.llvm.org/D99679 Files: clang/include/clang/AST/OpenMPClause.h clang/incl

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

jyu2 updated this revision to Diff 334969. jyu2 added a comment. Thank you, Alexey for the review!!! This changes have been addressed as you suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99679/new/ https://reviews.llvm.org/D99679 Files:

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:13567-13568 +case OMPD_dispatch: + CaptureRegion = OMPD_task; + break; +default: ABataev wrote: > What about other directives? Hi Alexey, As of now "novariants" clause only a

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

jyu2 closed this revision. jyu2 added a comment. cb424fee3d6b27dbd38de666382b702100935286 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99679/new/ https://reviews.llvm.org/D9967

[PATCH] D99848: [OPENMP51]Initial support for nocontext clause

jyu2 created this revision. jyu2 added reviewers: mikerice, ABataev, jdoerfert. Herald added subscribers: arphaman, guansong, yaxunl. Herald added a reviewer: sscalpone. jyu2 requested review of this revision. Herald added a subscriber: sstefan1. Herald added projects: clang, LLVM. Added basic par

[PATCH] D99848: [OPENMP51]Initial support for nocontext clause

jyu2 updated this revision to Diff 335272. jyu2 added a comment. Fix formatting problem and address Alexey's comment. Thanks Alexey for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99848/new/ https://reviews.llvm.org/D99848 Files:

[PATCH] D99848: [OPENMP51]Initial support for nocontext clause

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:14908 llvm::MapVector Captures; + ValExpr = tryBuildCapture(*this, ValExpr, Captures).get(); HelperValStmt = buildPreInits(Context, Captures); ABataev wrote: > This must be f

[PATCH] D99848: [OPENMP51]Initial support for nocontext clause

This revision was automatically updated to reflect the committed changes. jyu2 marked an inline comment as done and an inline comment as not done. Closed by commit rG7078ef472250: [OPENMP51]Initial support for nocontext clause. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D100055: Fix missing generate capture expression for novariants's condition

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice. jyu2 requested review of this revision. Herald added a project: clang. This is fix missing capture expression for novariants's condition Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100055 Files: clang/li

[PATCH] D100055: Fix missing generate capture expression for novariants's condition

jyu2 closed this revision. jyu2 added a comment. committed rGebf2dc33287e : Fix missing generate capture expression for novariants condition. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D100187: [OPENMP]Fix PR49115: Incorrect results for scan directive.

jyu2 accepted this revision. jyu2 added a comment. This revision is now accepted and ready to land. The change looks good to me. I am new to this. You may want to give more time for others Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100187/new/

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

jyu2 updated this revision to Diff 377288. jyu2 added a comment. Thanks Alexey's review. This patch is address Alexe's comments by adding new field LambdasMap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15/new/ https://reviews.llvm.org/D11

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8923-8937 +// Extract map information. +for (const auto *C : Dir.getClausesOfKind()) { + if (C->getMapType() != OMPC_MAP_to) +continue; + for (auto L : C->component_lists()) {

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

jyu2 updated this revision to Diff 377344. jyu2 added a comment. Address Alexey's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15/new/ https://reviews.llvm.org/D15 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/Open

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

jyu2 updated this revision to Diff 377357. jyu2 added a comment. Thanks Alexey! Fix missing Modifiers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15/new/ https://reviews.llvm.org/D15 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clan

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

jyu2 updated this revision to Diff 377421. jyu2 added a comment. Adding check for map type in test. Thanks Alexey. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15/new/ https://reviews.llvm.org/D15 Files: clang/lib/CodeGen/CGOpenMPRunti

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4743eba3c13: Fix assert of "Unable to find base lambda address" from (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15/new/ https://

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added projects: clang, OpenMP. Herald added subscribers: guansong, yaxunl. jyu2 requested review of this revision. Herald added a subscriber: sstefan1. Loop iteration var with threadprivate is predetermined as thr

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

jyu2 added a comment. Hi Alexey, Thanks for review. Comment at: clang/lib/Sema/SemaOpenMP.cpp:8653 ? (DSAStack->hasMutipleLoops() ? OMPC_lastprivate : OMPC_linear) -: OMPC_private; -if (((isOpenMPSimdDirective(DKind) && DVar.CKind != OM

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:8653 ? (DSAStack->hasMutipleLoops() ? OMPC_lastprivate : OMPC_linear) -: OMPC_private; -if (((isOpenMPSimdDirective(DKind) && DVar.CKind != OMPC_unknown && -

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

jyu2 updated this revision to Diff 381564. jyu2 edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112292/new/ https://reviews.llvm.org/D112292 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/distribute_parallel_for_simd_loop_messages.cpp clan

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:8653 ? (DSAStack->hasMutipleLoops() ? OMPC_lastprivate : OMPC_linear) -: OMPC_private; -if (((isOpenMPSimdDirective(DKind) && DVar.CKind != OMPC_unknown && -

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

jyu2 added a comment. In D112292#3080945 , @lebedev.ri wrote: > In which standard version was that rule introduced, is this missing some > checks for the OpenMP version? I check back to omp 45, the rule was there. CHANGES SINCE LAST ACTION https://

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

jyu2 updated this revision to Diff 381604. jyu2 added a comment. fix format problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112292/new/ https://reviews.llvm.org/D112292 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/distribute_p

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

jyu2 added a comment. Good point. I did not find that. At this point, I don't know if we need this change. I checked gnu, gnu allow this :-( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112292/new/ https://reviews.llvm.org/D112292 ___

<    1   2   3   4