jyu2 added inline comments.
================ Comment at: lib/Sema/AnalysisBasedWarnings.cpp:409 + << (Ty->hasExceptionSpec() ? FD->getExceptionSpecSourceRange() + : FD->getSourceRange()); + } else ---------------- rsmith wrote: > Underlining the entire function is probably not useful; I would just use > `FD->getExceptionSpecSourceRange()` here -- that way you just won't get any > highlighting if there isn't an explicit exception spec. Good point. Changed. Repository: rL LLVM https://reviews.llvm.org/D34671 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits