[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86790/new/ https://reviews.llvm.org/D86790 ___ cfe-commits mailing list cfe-commit

[PATCH] D88260: [NFC][FE] Replace TypeSize with StorageUnitSize

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1749-1750 -// Otherwise, allocate just the number of bytes required to store -// the bitfield. + //

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu created this revision. jasonliu added reviewers: hubert.reinterpretcast, daltenty, sfertile, Xiangling_L, DiggerLin. Herald added subscribers: dang, dexonsmith, steven_wu, hiraditya, arichardson, sbc100, emaste. Herald added a reviewer: espindola. Herald added a reviewer: MaskRay. jasonl

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu added a comment. Not sure if there is a better way to do this. But I have to admit this approach along with D88493 is a bit fragile. If plug-in writer forgets to set `HasExplicitDataSections` to true, then the final result that TargetMachine give for `

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:47 +CODEGENOPT(DataSections , 1, 0) ///< Set by default, or when -f[no-]data-sections. +CODEGENOPT(HasExplicitDataSections, 1, 0) ///< Set when -f[no-]data-sections is set. CODEGENOPT

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:47 +CODEGENOPT(DataSections , 1, 0) ///< Set by default, or when -f[no-]data-sections. +CODEGENOPT(HasExplicitDataSections, 1, 0) ///< Set when -f[no-]data-sections is set. CODEGENOPT

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu updated this revision to Diff 295950. jasonliu added a comment. Herald added subscribers: llvm-commits, nemanjai. Herald added a project: LLVM. An update follows up with the idea in D88748 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88737/new

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu marked an inline comment as done. jasonliu added inline comments. Comment at: clang/test/Driver/aix-data-sections.c:7 +// RUN: | FileCheck %s +// CHECK: "-fdata-sections" DiggerLin wrote: > may be good to check the whether other OS platform behavior be

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu updated this revision to Diff 296665. jasonliu added a comment. Change lld's forwarder function's signature to match LLVM style. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88737/new/ https://reviews.llvm.org/D88737 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test

[PATCH] D87451: add new option -mignore-xcoff-visibility

jasonliu added inline comments. Comment at: llvm/include/llvm/Target/TargetOptions.h:126 FunctionSections(false), DataSections(false), - UniqueSectionNames(true), UniqueBasicBlockSectionNames(false), - TrapUnreachable(false), NoTrapAfterNoreturn(false

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu updated this revision to Diff 296965. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88737/new/ https://reviews.llvm.org/D88737 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/aix-data-sections.c clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp lld/Comm

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu added inline comments. Comment at: lld/Common/TargetOptionsCommandFlags.cpp:17 +llvm::TargetOptions +lld::initTargetOptionsFromCodeGenFlags(const llvm::Triple &TheTriple) { + return llvm::codegen::InitTargetOptionsFromCodeGenFlags(TheTriple); MaskRay wr

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

jasonliu added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:340 +LANGOPT(AIXPragmaPack, 1, 0, "AIX #pragma pack handling") + Not sure if AIXPragmaPack is the best name here. It's more like IBM xl pragma pack handling on AIX. Would it

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu added a comment. In D88737#2321921 , @MaskRay wrote: > A less intrusive approach is to not touch the existing > InitTargetOptionsFromCodeGenFlags without parameters. You can add an > `initTargetOptionsFromCodeGenFlags` with `const Tripe &` as it

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu added a comment. Hi Fangrui(@MaskRay), are you okay with this patch to land as is? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88737/new/ https://reviews.llvm.org/D88737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rGf85bcc21ddad: [AIX] Turn -fdata-sections on by default in Clang (authored by jasonliu). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D88737?vs=296965&id=298160#toc R

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

jasonliu added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:889 + CompactUnwindSection = + Ctx->getXCOFFSection(".eh_info_table", XCOFF::StorageMappingClass::XMC_RW, + XCOFF::XTY_SD, SectionKind::getData()); dalte

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

jasonliu added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:889 + CompactUnwindSection = + Ctx->getXCOFFSection(".eh_info_table", XCOFF::StorageMappingClass::XMC_RW, + XCOFF::XTY_SD, SectionKind::getData()); dalte

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

jasonliu added a comment. In D91455#2424584 , @hubert.reinterpretcast wrote: >> 2. AIX uses a new personality routine, named __xlcxx_personality_v1. It >> doesn't use the GCC personality rountine, because the intractability is not >> there yet on AIX. >

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

jasonliu updated this revision to Diff 308653. jasonliu added a comment. Address comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91455/new/ https://reviews.llvm.org/D91455 Files: clang/lib/CodeGen/CGCleanup.h clang/lib/CodeGen/CGException.cpp clang/test/CodeGenCXX/personal

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

jasonliu added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AIXException.cpp:68 +Per = dyn_cast(F.getPersonalityFn()->stripPointerCasts()); + bool EmitEHBlock = + HasLandingPads || (F.hasPersonalityFn() && daltenty wrote: > This logic seems

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

jasonliu updated this revision to Diff 308752. jasonliu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91455/new/ https://reviews.llvm.org/D91455 Files: clang/lib/CodeGen/CGCleanup.h clang/lib/CodeGen/CGException.cpp clang/test/CodeGenCXX/persona

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

jasonliu marked 2 inline comments as done. jasonliu added inline comments. Comment at: llvm/test/CodeGen/PowerPC/aix-exception.ll:108-109 +; ASM: .byte 255 # @LPStart Encoding = omit +; ASM32: .byte 187 #

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rGa65d8c5d720d: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX (authored by jasonliu). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D91455?vs=308752&

[PATCH] D89897: [AIX] Emit error for -G option on AIX

jasonliu added a comment. Could we add some rationale to the patch summary about why we would want to deliberately emitting an error for AIX? Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4924 + if (RawTriple.isOSAIX()) +if (Arg *A = Args.getLastArg(options::OPT_G))

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

jasonliu added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:520 Options.DataSections = CodeGenOpts.DataSections; - Options.IgnoreXCOFFVisibility = CodeGenOpts.IgnoreXCOFFVisibility; Options.UniqueSectionNames = CodeGenOpts.UniqueSectionNames;

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

jasonliu added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:520 Options.DataSections = CodeGenOpts.DataSections; - Options.IgnoreXCOFFVisibility = CodeGenOpts.IgnoreXCOFFVisibility; Options.UniqueSectionNames = CodeGenOpts.UniqueSectionNames;

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

jasonliu added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:520 Options.DataSections = CodeGenOpts.DataSections; - Options.IgnoreXCOFFVisibility = CodeGenOpts.IgnoreXCOFFVisibility; Options.UniqueSectionNames = CodeGenOpts.UniqueSectionNames;

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

jasonliu added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:520 Options.DataSections = CodeGenOpts.DataSections; - Options.IgnoreXCOFFVisibility = CodeGenOpts.IgnoreXCOFFVisibility; Options.UniqueSectionNames = CodeGenOpts.UniqueSectionNames;

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM with minor nit. Comment at: clang/lib/AST/Decl.cpp:1481 LinkageInfo LinkageComputer::getDeclLinkageAndVisibility(const NamedDecl *D) { - return getLVForDecl(D, -

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

jasonliu added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4964 if (!RawTriple.isOSDarwin() && !RawTriple.isNVPTX() && - !RawTriple.isAMDGPU() && !RawTriple.isOSAIX()) + !RawTriple.isAMDGPU()) CmdArgs.push_back("-mconstructor-aliases"); --

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102724/new/ https://reviews.llvm.org/D102724 __

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

jasonliu added a comment. Good idea, fyi, this is the patch: https://reviews.llvm.org/D83252 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102724/new/ https://reviews.llvm.org/D102724 ___ cfe-commits mai

[PATCH] D102813: [AIX] Add -lc++abi and -lunwind for linking

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7922ff601094: [AIX] Add -lc++abi and -lunwind for linking (authored by jasonliu). Herald added a project: clang. Herald added a subscriber: cfe-commi

[PATCH] D104314: [AIX] Remove --as-needed passing into aix linker

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e2aee8d3bab: [AIX] Remove --as-needed passing into aix linker (authored by jasonliu). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

jasonliu added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7091 + +static const MCPhysReg Gpr_32[] = {PPC::R3, PPC::R4, PPC::R5, PPC::R6, + PPC::R7, PPC::R8, PPC::R9, PPC::R10}; I'd prefer us

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

jasonliu added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4205 -CharUnits PPC32_SVR4_ABIInfo::getParamTypeAlignment(QualType Ty) const { +CharUnits PowerPC32ABIInfo::getParamTypeAlignment(QualType Ty) const { // Complex types are passed just like their ele

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

jasonliu added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4205 -CharUnits PPC32_SVR4_ABIInfo::getParamTypeAlignment(QualType Ty) const { +CharUnits PowerPC32ABIInfo::getParamTypeAlignment(QualType Ty) const { // Complex types are passed just like their ele

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

jasonliu added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10019 + return SetCGInfo( + new PPCAIX32TargetCodeGenInfo(Types, CodeGenOpts.FloatABI == "soft")); return SetCGInfo( Does AIX have soft Float? If not, do we want to a

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1498 + } + emitLinkage(&F, Name); + continue; jasonliu wrote: > I'm surprised we do not enter here for `foo_ext_weak()`. The result of that > is we need to do s

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1492 + +if (MAI->hasDotExternDirective()) { + MCSymbol *Name = getSymbol(&F); This query asked if the target supports .extern. However, .extern is not the only direct

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1548 + + if (XCOFFSym->hasContainingCsect()) { +MCSymbolXCOFF *QualName = I hope we can find a better solution here. IMO, we don't even want to override this function in t

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1589 : getObjFileLowering().getSectionForFunctionDescriptor(F, TM)); - +if (F->isDeclaration()) { + MCSymbolXCOFF *FSym = cast(getSymbol(F)); If it's possi

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

jasonliu added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10019 + return SetCGInfo( + new PPCAIX32TargetCodeGenInfo(Types, CodeGenOpts.FloatABI == "soft")); return SetCGInfo( ZarkoCA wrote: > jasonliu wrote: > > Does AIX hav

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

jasonliu added inline comments. Comment at: llvm/test/CodeGen/PowerPC/aix32-cc-abi-vaarg.ll:8 + + target datalayout = "E-m:e-p:32:32-i64:64-n32" + target triple = "powerpc-ibm-aix-xcoff" minor nit: I don't think these target datalayout and triple are necessary.

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76932/new/ https://reviews.llvm.org/D76932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1486 // Emit visibility info for declarations for (const Function &F : M) { Comment should change to something similar to: `Emit linkage(XCOFF) and visibility info for

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:407 case GlobalValue::WeakAnyLinkage: case GlobalValue::WeakODRLinkage: if (MAI->hasWeakDefDirective()) { Could we verify if these Linkage should also always emit .w

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

jasonliu added a comment. Just kindly reminder that you might want to update the Summary in the commit message to reflect the new name we picked. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74015/new/ https://reviews.llvm.org/D74015 _

[PATCH] D70675: [AIX] Disable clang python binding tests

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70675/new/ https://reviews.llvm.org/D70675 __

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX in 32-bit mode.

jasonliu added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:373 +// This is the ELF definition, and is overridden by the Darwin and AIX +// sub-target return TargetInfo::PowerABIBuiltinVaList; nit: add '.' to the comment while we are at

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

jasonliu added inline comments. Comment at: clang/test/CodeGen/aix-vararg.c:10 + va_arg(arg, int); + va_end(arg); +} As part of a "va_..." family, do we also want to test va_copy? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

jasonliu added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7076 +static const MCPhysReg GPR_64[] = {PPC::X3, PPC::X4, PPC::X5, PPC::X6, + PPC::X7, PPC::X8, PPC::X9, PPC::X10}; +unsigned const NumGPArgRegs

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

jasonliu added inline comments. Comment at: llvm/test/CodeGen/PowerPC/aix-cc-abi-va_args-32.ll:1 +; RUN: llc -O2 -mtriple powerpc-ibm-aix-xcoff -stop-after=machine-cp -mattr=-altivec -verify-machineinstrs < %s | \ +; RUN: FileCheck --check-prefixes=CHECK,32BIT %s ---

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

jasonliu added inline comments. Comment at: llvm/test/CodeGen/PowerPC/aix-cc-abi-va_args-32.ll:7 +; RUN: FileCheck --check-prefixes=CHECKASM,ASM32PWR4 %s + +declare void @llvm.lifetime.start.p0i8(i64 immarg, i8* nocapture) A general comment about how to test va_a

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

jasonliu added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7014 if (VA.isRegLoc()) { MVT::SimpleValueType SVT = ValVT.getSimpleVT().SimpleTy; Do we need `&& !VA.needsCustom() ` here? Repository: rG LLVM Github Monor

[PATCH] D72644: [clang] Add -fignore-exceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rG55e2678fcd4d: [clang] Add -fignore-exceptions (authored by jasonliu). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D72644?vs=2

[PATCH] D72644: [clang] Add -fignore-exceptions

jasonliu added a comment. In D72644#1868812 , @aaron.ballman wrote: > Sorry about the delayed review. I think this patch basically LG, thank you! Thanks Aaron. Addressed your comments in the commits. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D72644: [clang] Add -fignore-exceptions

jasonliu added a comment. In D72644#1871662 , @lebedev.ri wrote: > This review omitted cfe-commits list Didn't realized that. Since this is approved and committed, I guess I will keep monitor messages in this review, and address any post-commit comments

[PATCH] D34649: Remove addtional parameters in function std::next() and std::prev()

jasonliu created this revision. Creating a function pointer with proper parameters pointing to std::next() or std::prev() should work. This change moves the invented paramater for enable_if over to the return type to resolve this QoI issue. https://reviews.llvm.org/D34649 Files: include/ite

[PATCH] D99291: [AIX] Support init priority attribute

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:663 + // Create our global prioritized cleanup function. + if (!PrioritizedCXXStermFinalizers.empty()) { ---

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

jasonliu accepted this revision. jasonliu added a comment. LGTM with minor nits. Comment at: clang/lib/Sema/SemaAttr.cpp:74 return; - // The #pragma align/pack affected a record in an included file, so Clang - // should warn when that the pragma was written in a file tha

[PATCH] D107941: Fix assertion when passing function into inline asm's input operand

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe177a1773e4: Fix assertion when passing function into inline asm's input operand (authored by jasonliu). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Githu

<    1   2