jasonliu added inline comments.

================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1548
+
+  if (XCOFFSym->hasContainingCsect()) {
+    MCSymbolXCOFF *QualName =
----------------
I hope we can find a better solution here. IMO, we don't even want to override 
this function in this patch. 
GVSym should be the right one from what caller passed in. It's caller's 
responsibility to pass in the right GVSym. 
When caller calls emitLinkage, we should emitLinkage. It's weird when 
emitLinkage is called, but none is emitted (when hasContainingCsect() returns 
false).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76932/new/

https://reviews.llvm.org/D76932



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to