Re: r291871 - Update C++ status pages for Clang 4 branch:

2017-01-13 Thread Hans Wennborg via cfe-commits
On Thu, Jan 12, 2017 at 4:57 PM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Thu Jan 12 18:57:54 2017 > New Revision: 291871 > > URL: http://llvm.org/viewvc/llvm-project?rev=291871&view=rev > Log: > Update C++ status pages for Clang 4 branch: > > * Update version number in DR te

Re: r291877 - [Sema] Restrict explicit instantation definition dllexport

2017-01-13 Thread Hans Wennborg via cfe-commits
Merged in r291943. Thanks, Hans On Thu, Jan 12, 2017 at 5:58 PM, Shoaib Meenai wrote: > Requesting a merge to the 4.0 branch. This is a pretty small change, and it > fixes an assertion failure on Windows (see PR31608 for details). > > On 1/12/17, 5:28 PM, "cfe-commits on behalf of Shoaib Meenai

Re: r291907 - Revert "Support for Python 3 in libclang python bindings"

2017-01-13 Thread Hans Wennborg via cfe-commits
On Fri, Jan 13, 2017 at 8:06 AM, Jonathan Coe via cfe-commits wrote: > Author: jbcoe > Date: Fri Jan 13 10:06:59 2017 > New Revision: 291907 > > URL: http://llvm.org/viewvc/llvm-project?rev=291907&view=rev > Log: > Revert "Support for Python 3 in libclang python bindings" > > This reverts commit 4

Re: r290392 - Make '-disable-llvm-optzns' an alias for '-disable-llvm-passes'.

2017-01-13 Thread Hans Wennborg via cfe-commits
Merged in r291951. Thanks, Hans On Fri, Jan 13, 2017 at 11:46 AM, Chandler Carruth wrote: > Also need to pull in r291881. Sorry about that. > > > On Thu, Jan 12, 2017 at 3:42 PM Hans Wennborg wrote: >> >> On Thu, Jan 12, 2017 at 3:01 PM, Chandler Carruth >> wrote: >> >> This isn't quite right,

Re: r291879 - Add a necessary newline for diagnose_if documentation.

2017-01-13 Thread Hans Wennborg via cfe-commits
Merged in r291952. Thanks, Hans On Thu, Jan 12, 2017 at 5:52 PM, Eric Christopher via cfe-commits wrote: > Author: echristo > Date: Thu Jan 12 19:52:04 2017 > New Revision: 291879 > > URL: http://llvm.org/viewvc/llvm-project?rev=291879&view=rev > Log: > Add a necessary newline for diagnose_if do

Re: r291964 - PR31631: fix bad CFG (and bogus warnings) when an if-statement has an init-statement and has binary operator as its condition.

2017-01-13 Thread Hans Wennborg via cfe-commits
Merged in r291978. (Please keep the list cc'd on merge requests.) Thanks, Hans On Fri, Jan 13, 2017 at 2:28 PM, Richard Smith wrote: > Seems sensible to put this in clang 4. > > -- Forwarded message -- > From: Richard Smith via cfe-commits > Date: 13 January 2017 at 14:16 > Sub

r292265 - UsersManual.rst: add missing newline

2017-01-17 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Jan 17 15:31:57 2017 New Revision: 292265 URL: http://llvm.org/viewvc/llvm-project?rev=292265&view=rev Log: UsersManual.rst: add missing newline Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL: http://llvm.org/viewvc/llvm-project/

Re: r291963 - [clang] Emit `diagnose_if` warnings from system headers

2017-01-17 Thread Hans Wennborg via cfe-commits
Richard, what do you think? On Fri, Jan 13, 2017 at 3:16 PM, Eric Fiselier wrote: > I would love to see this merged. It would make it easier to write libc++ > tests if the tests didn't have to worry about the old 4.0 behavior. > > CC'ing Richard: Would merging this be OK? > > On Fri, Jan 13, 2017

Re: [libcxx] r292013 - Fix last_write_time tests for filesystems that don't support negative and very large times

2017-01-17 Thread Hans Wennborg via cfe-commits
Yes, go ahead. Apologies for the delay. - Hans On Sat, Jan 14, 2017 at 5:54 AM, Eric Fiselier wrote: > +1 from me. @Hans am I OK to merge this? > > On Sat, Jan 14, 2017 at 4:53 AM, Hahnfeld, Jonas > wrote: >> >> Hi Hans, >> >> can this be merged for 4.0? Eric suggested this in >> https://revi

Re: r292032 - Fix PR31644 introduced by r287138 and add a regression test.

2017-01-17 Thread Hans Wennborg via cfe-commits
On Sat, Jan 14, 2017 at 1:26 PM, Dimitry Andric wrote: > On 14 Jan 2017, at 22:12, Yaron Keren via cfe-commits > wrote: >> Author: yrnkrn >> Date: Sat Jan 14 15:12:08 2017 >> New Revision: 292032 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=292032&view=rev >> Log: >> Fix PR31644 introduced

Re: r292052 - [code-completion] Fix crash when trying to do postfix completion of instance member inside a static function.

2017-01-17 Thread Hans Wennborg via cfe-commits
Merged in r292313. Thanks, Hans On Tue, Jan 17, 2017 at 8:56 AM, Argyrios Kyrtzidis wrote: > Hi Hans, > > Could this go into the stable branch ? > > On Sat, Jan 14, 2017 at 10:11 PM, Argyrios Kyrtzidis via cfe-commits > wrote: >> >> Author: akirtzidis >> Date: Sun Jan 15 00:11:04 2017 >> New Re

Re: r291955 - PR31606: Generalize our tentative DR resolution for inheriting copy/move

2017-01-17 Thread Hans Wennborg via cfe-commits
What do you think; time to merge it? On Fri, Jan 13, 2017 at 1:21 PM, Richard Smith wrote: > I'd like to wait a bit to see how the dust settles on this one, but this is > a bugfix for a previous bugfix for a standard change, and we've had several > user complaints requesting that we fix the bug i

[libcxx] r292341 - Merging r292013:

2017-01-17 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Jan 17 23:07:58 2017 New Revision: 292341 URL: http://llvm.org/viewvc/llvm-project?rev=292341&view=rev Log: Merging r292013: r292013 | hahnfeld | 2017-01-14 03:35:15 -0800 (Sat, 14 Jan 2017) | 6 lines

Re: [libcxx] r292013 - Fix last_write_time tests for filesystems that don't support negative and very large times

2017-01-17 Thread Hans Wennborg via cfe-commits
I went ahead and merged it in r292341. On Tue, Jan 17, 2017 at 4:26 PM, Eric Fiselier wrote: > @Jonas please go ahead and merge this patch. > > On Tue, Jan 17, 2017 at 5:24 PM, Hans Wennborg wrote: >> >> Yes, go ahead. >> >> Apologies for the delay. >> >> - Hans >> >> On Sat, Jan 14, 2017 at 5:

[libcxx] r292384 - Creating release directory for release_400.

2017-01-18 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 18 09:32:11 2017 New Revision: 292384 URL: http://llvm.org/viewvc/llvm-project?rev=292384&view=rev Log: Creating release directory for release_400. Added: libcxx/tags/RELEASE_400/ ___ cfe-commits mailing list cfe-commits@

[libcxxabi] r292386 - Creating release directory for release_400.

2017-01-18 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 18 09:32:16 2017 New Revision: 292386 URL: http://llvm.org/viewvc/llvm-project?rev=292386&view=rev Log: Creating release directory for release_400. Added: libcxxabi/tags/RELEASE_400/ ___ cfe-commits mailing list cfe-commi

[libcxx] r292385 - Creating release candidate rc1 from release_400 branch

2017-01-18 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 18 09:32:14 2017 New Revision: 292385 URL: http://llvm.org/viewvc/llvm-project?rev=292385&view=rev Log: Creating release candidate rc1 from release_400 branch Added: libcxx/tags/RELEASE_400/rc1/ (props changed) - copied from r292384, libcxx/branches/release_

[libcxxabi] r292387 - Creating release candidate rc1 from release_400 branch

2017-01-18 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 18 09:32:18 2017 New Revision: 292387 URL: http://llvm.org/viewvc/llvm-project?rev=292387&view=rev Log: Creating release candidate rc1 from release_400 branch Added: libcxxabi/tags/RELEASE_400/rc1/ - copied from r292386, libcxxabi/branches/release_40/ ___

[libunwind] r292399 - Creating release candidate rc1 from release_400 branch

2017-01-18 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 18 09:32:46 2017 New Revision: 292399 URL: http://llvm.org/viewvc/llvm-project?rev=292399&view=rev Log: Creating release candidate rc1 from release_400 branch Added: libunwind/tags/RELEASE_400/rc1/ - copied from r292398, libunwind/branches/release_40/ ___

[libunwind] r292398 - Creating release directory for release_400.

2017-01-18 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 18 09:32:43 2017 New Revision: 292398 URL: http://llvm.org/viewvc/llvm-project?rev=292398&view=rev Log: Creating release directory for release_400. Added: libunwind/tags/RELEASE_400/ ___ cfe-commits mailing list cfe-commi

Re: r291955 - PR31606: Generalize our tentative DR resolution for inheriting copy/move

2017-01-18 Thread Hans Wennborg via cfe-commits
Merged in r292463. Cheers, Hans On Tue, Jan 17, 2017 at 9:25 PM, Richard Smith wrote: > Yes, let's. > > On 17 Jan 2017 9:11 pm, "Hans Wennborg" wrote: > > What do you think; time to merge it? > > On Fri, Jan 13, 2017 at 1:21 PM, Richard Smith > wrote: >> I'd like to wait a bit to see how the d

[libcxx] r292494 - Merging r292091:

2017-01-19 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jan 19 10:50:46 2017 New Revision: 292494 URL: http://llvm.org/viewvc/llvm-project?rev=292494&view=rev Log: Merging r292091: r292091 | marshall | 2017-01-15 19:02:10 -0800 (Sun, 15 Jan 2017) | 1 line I

Re: [libcxx] r292091 - Implement the missing constexpr stuff in . Fixes PR#31645.

2017-01-19 Thread Hans Wennborg via cfe-commits
Merged to 4.0 in r292494 as requested. On Sun, Jan 15, 2017 at 7:02 PM, Marshall Clow via cfe-commits wrote: > Author: marshall > Date: Sun Jan 15 21:02:10 2017 > New Revision: 292091 > > URL: http://llvm.org/viewvc/llvm-project?rev=292091&view=rev > Log: > Implement the missing constexpr stuff i

[libcxxabi] r292495 - Merging r292135:

2017-01-19 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jan 19 10:52:39 2017 New Revision: 292495 URL: http://llvm.org/viewvc/llvm-project?rev=292495&view=rev Log: Merging r292135: r292135 | marshall | 2017-01-16 07:28:03 -0800 (Mon, 16 Jan 2017) | 1 line M

Re: Commits to be merged for 4.0

2017-01-19 Thread Hans Wennborg via cfe-commits
On Tue, Jan 17, 2017 at 9:48 PM, Marshall Clow wrote: > One is for libc++abi: r292135 Merged in r292495. > The other two are for libc++: > r292276 Eric merged this one. > r292091 Merged in r292494. Cheers, Hans ___ cfe-commits mailing list

r292522 - Don't inline dllimport functions referencing non-imported methods

2017-01-19 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jan 19 15:33:13 2017 New Revision: 292522 URL: http://llvm.org/viewvc/llvm-project?rev=292522&view=rev Log: Don't inline dllimport functions referencing non-imported methods This is another follow-up to r246338. I had assumed methods were already handled by the AST visitor,

[libcxxabi] r292524 - Merging r292418:

2017-01-19 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jan 19 15:57:56 2017 New Revision: 292524 URL: http://llvm.org/viewvc/llvm-project?rev=292524&view=rev Log: Merging r292418: r292418 | jroelofs | 2017-01-18 10:12:39 -0800 (Wed, 18 Jan 2017) | 15 lines

Re: r292497 - [Sema] Fix PR28181 by avoiding calling BuildOverloadedBinOp in C mode

2017-01-19 Thread Hans Wennborg via cfe-commits
Richard, what do you think? On Thu, Jan 19, 2017 at 9:34 AM, Alex L wrote: > Hi Hans, > > Would it be possible to merge this for 4.0? > > Cheers, > Alex > > On 19 January 2017 at 17:17, Alex Lorenz via cfe-commits > wrote: >> >> Author: arphaman >> Date: Thu Jan 19 11:17:57 2017 >> New Revision:

Re: r292555 - P0426: Make the library implementation of constexpr char_traits a little easier

2017-01-23 Thread Hans Wennborg via cfe-commits
r292807. Thanks, Hans On Thu, Jan 19, 2017 at 5:22 PM, Richard Smith wrote: > Hans, can we get this onto the Clang 4 release branch (along with the > documentation added in r292558 and fixed in r292559)? This will allow us to > avoid libc++ carrying a version test for Clang, and allow it to clea

Re: [libcxx] r292564 - Disable aligned new/delete on Apple platforms without posix_memalign

2017-01-23 Thread Hans Wennborg via cfe-commits
Thanks! On Thu, Jan 19, 2017 at 6:07 PM, Eric Fiselier wrote: > Merged. > > Relevant commits: > > * r292566 - Merge r292564 > * r292565 - Merge r292560 > > /Eric ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

Re: r292497 - [Sema] Fix PR28181 by avoiding calling BuildOverloadedBinOp in C mode

2017-01-23 Thread Hans Wennborg via cfe-commits
On Thu, Jan 19, 2017 at 6:25 PM, Richard Smith wrote: > On 19 January 2017 at 15:52, Hans Wennborg wrote: >> >> Richard, what do you think? > > > Yes, let's merge this. r292808. Cheers, Hans >> On Thu, Jan 19, 2017 at 9:34 AM, Alex L wrote: >> > Hi Hans, >> > >> > Would it be possible to merg

Re: [libcxx] r292607 - Don't default older GCC's to C++17, but C++14 or C++11 instead

2017-01-23 Thread Hans Wennborg via cfe-commits
Sounds good to me. On Fri, Jan 20, 2017 at 11:38 AM, Eric Fiselier wrote: > We should merge this patch into the 4.0 release branch. It is needed to make > "check-all" pass when using GCC 4, 5 and 6. > > /Eric > > On Fri, Jan 20, 2017 at 5:54 AM, Eric Fiselier via cfe-commits > wrote: >> >> Autho

Re: r292800 - [analyzer] Fix memory space of static locals seen from nested blocks.

2017-01-23 Thread Hans Wennborg via cfe-commits
Sounds good to me. Anna, you're the code owner here. Ok to merge this? Thanks, Hans On Mon, Jan 23, 2017 at 10:37 AM, Artem Dergachev wrote: > Hans, > > Could we merge this one into the 4.0.0 release branch? It's a recent bugfix > for the analyzer. > > Thanks, > Artem. > > > > On 1/23/17 7:57 P

Re: [libcxx] r292830 - Fix GCC C++03 build by hiding default template argument in C++03

2017-01-23 Thread Hans Wennborg via cfe-commits
We merged the first one, so I suppose we better fix it :-) Sounds good to me. On Mon, Jan 23, 2017 at 1:37 PM, Eric Fiselier wrote: > This patch should be merge into the 4.0 branch. > > It fixes a bug introduced to the 4.0 branch in r292354 > (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=21

Re: [libcxx] r292822 - Fixed a typo in __config that prevented the aligned new/delete tests from passing on Mac OS.

2017-01-23 Thread Hans Wennborg via cfe-commits
Ok, go ahead. On Mon, Jan 23, 2017 at 1:54 PM, Eric Fiselier wrote: > This patch needs to get merged into 4.0 since the offending commit with the > misspelling is in the 4.0 branch. > > /Eric > > > On Mon, Jan 23, 2017 at 12:51 PM, Marshall Clow via cfe-commits > wrote: >> >> Author: marshall >>

Re: [clang-tools-extra] r291892 - Fix the build of the include-fixer plugin for some shared cmake builds and MSVC.

2017-01-23 Thread Hans Wennborg via cfe-commits
I've merged this to the release branch in r292834. Thanks, Hans On Fri, Jan 13, 2017 at 2:14 AM, Benjamin Kramer via cfe-commits wrote: > Author: d0k > Date: Fri Jan 13 04:14:07 2017 > New Revision: 291892 > > URL: http://llvm.org/viewvc/llvm-project?rev=291892&view=rev > Log: > Fix the build of

r292856 - Re-commit "Don't inline dllimport functions referencing non-imported methods"

2017-01-23 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Jan 23 17:57:50 2017 New Revision: 292856 URL: http://llvm.org/viewvc/llvm-project?rev=292856&view=rev Log: Re-commit "Don't inline dllimport functions referencing non-imported methods" This re-commits r292522 with the addition that it also handles calls through pointer to

Re: r292522 - Don't inline dllimport functions referencing non-imported methods

2017-01-23 Thread Hans Wennborg via cfe-commits
it in r292643. > > On Thu, Jan 19, 2017 at 1:33 PM, Hans Wennborg via cfe-commits > wrote: >> >> Author: hans >> Date: Thu Jan 19 15:33:13 2017 >> New Revision: 292522 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=292522&view=rev >> Log: &

Re: r292800 - [analyzer] Fix memory space of static locals seen from nested blocks.

2017-01-23 Thread Hans Wennborg via cfe-commits
Merged in r292858. Thanks, Hans On Mon, Jan 23, 2017 at 4:15 PM, Anna Zaks wrote: > Yes, ok to merge! > Thank you. > > Sent from my iPhone > >> On Jan 23, 2017, at 1:50 PM, Hans Wennborg wrote: >> >> Sounds good to me. >> >> Anna, you're the code owner here. Ok to merge this? >> >> Thanks, >> H

Re: [libcxx] r292833 - Manually force the use of __decltype in C++03 with Clang 3.4.

2017-01-23 Thread Hans Wennborg via cfe-commits
Sounds good to me. On Mon, Jan 23, 2017 at 1:56 PM, Eric Fiselier wrote: > This patch should be merge into 4.0 since it is needed to fix compile time > regressions in when using Clang 3.4 and C++03. > > See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216054 for more info. > > /Eric > > On

Re: r292847 - PR31692: Don't mark a declaration as invalid if we haven't necessarily emitted a (user-visible) error.

2017-01-23 Thread Hans Wennborg via cfe-commits
Thanks! r292859. On Mon, Jan 23, 2017 at 3:26 PM, Richard Smith wrote: > Hans, this should go into Clang 4. > > On 23 January 2017 at 15:14, Richard Smith via cfe-commits > wrote: >> >> Author: rsmith >> Date: Mon Jan 23 17:14:23 2017 >> New Revision: 292847 >> >> URL: http://llvm.org/viewvc/llv

Re: r291963 - [clang] Emit `diagnose_if` warnings from system headers

2017-01-23 Thread Hans Wennborg via cfe-commits
Ping? On Tue, Jan 17, 2017 at 4:16 PM, Hans Wennborg wrote: > Richard, what do you think? > > On Fri, Jan 13, 2017 at 3:16 PM, Eric Fiselier wrote: >> I would love to see this merged. It would make it easier to write libc++ >> tests if the tests didn't have to worry about the old 4.0 behavior. >

Re: r292800 - [analyzer] Fix memory space of static locals seen from nested blocks.

2017-01-24 Thread Hans Wennborg via cfe-commits
Thanks for letting me know! I've merged your revert to the branch in r292947. Please let me know if there is any more follow-up. On Mon, Jan 23, 2017 at 6:30 PM, Devin Coughlin wrote: > FYI, I reverted r292800 from trunk in r292874. It was causing our internal > validation bots to have false pos

Re: [libcxx] r292990 - Change the return type of emplace_[front|back] back to void when building with C++14 or before. Resolves PR31680.

2017-01-25 Thread Hans Wennborg via cfe-commits
Should we merge this to 4.0? On Tue, Jan 24, 2017 at 3:09 PM, Marshall Clow via cfe-commits wrote: > Author: marshall > Date: Tue Jan 24 17:09:12 2017 > New Revision: 292990 > > URL: http://llvm.org/viewvc/llvm-project?rev=292990&view=rev > Log: > Change the return type of emplace_[front|back] ba

Re: r292991 - PR31742: Don't emit a bogus "zero size array" extwarn when initializing a

2017-01-25 Thread Hans Wennborg via cfe-commits
Thanks! r293072. On Tue, Jan 24, 2017 at 6:03 PM, Richard Smith wrote: > Hi Hans, > > This is relatively minor, but it's safe and fixes a rejects-valid regression > in some configurations. Might be worth taking for Clang 4. > > On 24 January 2017 at 15:18, Richard Smith via cfe-commits > wrote:

[libcxx] r293192 - Merging r292990:

2017-01-26 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jan 26 11:51:25 2017 New Revision: 293192 URL: http://llvm.org/viewvc/llvm-project?rev=293192&view=rev Log: Merging r292990: r292990 | marshall | 2017-01-24 15:09:12 -0800 (Tue, 24 Jan 2017) | 1 line C

Re: [libcxx] r292990 - Change the return type of emplace_[front|back] back to void when building with C++14 or before. Resolves PR31680.

2017-01-26 Thread Hans Wennborg via cfe-commits
On Thu, Jan 26, 2017 at 6:05 AM, Marshall Clow wrote: > On Wed, Jan 25, 2017 at 9:11 AM, Hans Wennborg wrote: >> >> Should we merge this to 4.0? > > > Yes, please. r293192. Cheers, Hans ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[libcxx] r293193 - Merging r293154:

2017-01-26 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jan 26 11:55:46 2017 New Revision: 293193 URL: http://llvm.org/viewvc/llvm-project?rev=293193&view=rev Log: Merging r293154: r293154 | marshall | 2017-01-25 22:58:29 -0800 (Wed, 25 Jan 2017) | 1 line U

Re: [libcxx] r293154 - Use the new __has_feature(cxx_constexpr_string_builtins) for detection of the C-string intrinsics for constexpr support in std::char_traits. Thanks to Richard for the intrisic s

2017-01-26 Thread Hans Wennborg via cfe-commits
On Thu, Jan 26, 2017 at 6:08 AM, Marshall Clow wrote: > On Wed, Jan 25, 2017 at 10:58 PM, Marshall Clow via cfe-commits > wrote: >> >> Author: marshall >> Date: Thu Jan 26 00:58:29 2017 >> New Revision: 293154 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=293154&view=rev >> Log: >> Use the n

Re: [libunwind] r292723 - X86: swap EBP, ESP on !APPLE

2017-01-26 Thread Hans Wennborg via cfe-commits
Michał suggested on the PR that this should be merged to the release branch. Saleem, what do you think? On Sat, Jan 21, 2017 at 8:22 AM, Saleem Abdulrasool via cfe-commits wrote: > Author: compnerd > Date: Sat Jan 21 10:22:59 2017 > New Revision: 292723 > > URL: http://llvm.org/viewvc/llvm-proje

Re: r291963 - [clang] Emit `diagnose_if` warnings from system headers

2017-01-26 Thread Hans Wennborg via cfe-commits
Ping? On Mon, Jan 23, 2017 at 4:27 PM, Hans Wennborg wrote: > Ping? > > On Tue, Jan 17, 2017 at 4:16 PM, Hans Wennborg wrote: >> Richard, what do you think? >> >> On Fri, Jan 13, 2017 at 3:16 PM, Eric Fiselier wrote: >>> I would love to see this merged. It would make it easier to write libc++ >

Re: [libcxx] r292607 - Don't default older GCC's to C++17, but C++14 or C++11 instead

2017-01-26 Thread Hans Wennborg via cfe-commits
What's the status here? Waiting for Marshall? On Mon, Jan 23, 2017 at 10:20 AM, Hans Wennborg wrote: > Sounds good to me. > > On Fri, Jan 20, 2017 at 11:38 AM, Eric Fiselier wrote: >> We should merge this patch into the 4.0 release branch. It is needed to make >> "check-all" pass when using GCC

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

2017-01-26 Thread Hans Wennborg via cfe-commits
On Fri, Jan 20, 2017 at 1:52 PM, Renato Golin wrote: > On 20 January 2017 at 19:46, Eric Fiselier wrote: >> This patch fixes a libc++abi test failure when compiled with GCC 5, 6, or 7. >> We should merge this into 4.0 to help get `check-all` clean. > > Hi Eric, > > All good on my side, pass with

Re: r292590 - [OPENMP] Fix for PR31643: Clang crashes when compiling code on Windows

2017-01-26 Thread Hans Wennborg via cfe-commits
Should we merge this to the release branch? On Fri, Jan 20, 2017 at 12:57 AM, Alexey Bataev via cfe-commits wrote: > Author: abataev > Date: Fri Jan 20 02:57:28 2017 > New Revision: 292590 > > URL: http://llvm.org/viewvc/llvm-project?rev=292590&view=rev > Log: > [OPENMP] Fix for PR31643: Clang cr

Re: r292194 - [AST] AttributedType should derive type properties from the EquivalentType

2017-01-26 Thread Hans Wennborg via cfe-commits
Should we merge this to the release branch? On Mon, Jan 16, 2017 at 8:14 PM, David Majnemer via cfe-commits wrote: > Author: majnemer > Date: Mon Jan 16 22:14:25 2017 > New Revision: 292194 > > URL: http://llvm.org/viewvc/llvm-project?rev=292194&view=rev > Log: > [AST] AttributedType should deriv

Re: r292561 - PR31701: Fix crash on invalid caused by parsing a dependent initializer when we

2017-01-26 Thread Hans Wennborg via cfe-commits
A candidate for clang 4? On Thu, Jan 19, 2017 at 5:19 PM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Thu Jan 19 19:19:46 2017 > New Revision: 292561 > > URL: http://llvm.org/viewvc/llvm-project?rev=292561&view=rev > Log: > PR31701: Fix crash on invalid caused by parsing a depen

Re: r292561 - PR31701: Fix crash on invalid caused by parsing a dependent initializer when we

2017-01-27 Thread Hans Wennborg via cfe-commits
r293297. Cheers, Hans On Thu, Jan 26, 2017 at 4:45 PM, Richard Smith wrote: > Sure, why not. > > On 26 January 2017 at 15:56, Hans Wennborg wrote: >> >> A candidate for clang 4? >> >> On Thu, Jan 19, 2017 at 5:19 PM, Richard Smith via cfe-commits >> wrote: >> > Author: rsmith >> > Date: Thu Ja

[libunwind] r293298 - Merging r292723:

2017-01-27 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Jan 27 10:27:43 2017 New Revision: 293298 URL: http://llvm.org/viewvc/llvm-project?rev=293298&view=rev Log: Merging r292723: r292723 | compnerd | 2017-01-21 08:22:59 -0800 (Sat, 21 Jan 2017) | 17 lines

Re: [libunwind] r292723 - X86: swap EBP, ESP on !APPLE

2017-01-27 Thread Hans Wennborg via cfe-commits
r293298. Thanks, Hans On Thu, Jan 26, 2017 at 6:38 PM, Saleem Abdulrasool wrote: > I think that this is safe enough and does make libunwind work on x86 Linux, > so lets go for it. > > On Thu, Jan 26, 2017 at 10:10 AM, Hans Wennborg wrote: >> >> Michał suggested on the PR that this should be mer

[libcxx] r293301 - Merging r292607:

2017-01-27 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Jan 27 10:41:31 2017 New Revision: 293301 URL: http://llvm.org/viewvc/llvm-project?rev=293301&view=rev Log: Merging r292607: r292607 | ericwf | 2017-01-20 04:54:45 -0800 (Fri, 20 Jan 2017) | 1 line Don

Re: [libcxx] r292607 - Don't default older GCC's to C++17, but C++14 or C++11 instead

2017-01-27 Thread Hans Wennborg via cfe-commits
On Thu, Jan 26, 2017 at 6:09 PM, Marshall Clow wrote: > On Thu, Jan 26, 2017 at 10:22 AM, Hans Wennborg wrote: >> >> What's the status here? Waiting for Marshall? > > > I'm fine with merging this to the 4.0 branch Merged in r293301. Thanks, Hans ___ c

Re: r292590 - [OPENMP] Fix for PR31643: Clang crashes when compiling code on Windows

2017-01-27 Thread Hans Wennborg via cfe-commits
I've got it. Merged in r293302. Thanks, Hans On Fri, Jan 27, 2017 at 4:49 AM, Alexey Bataev wrote: > Yes. Could you do it yourself or you want me to do it? > > - > Best regards, > Alexey Bataev > > 27.01.2017 2:33, Hans Wennborg пишет: >> Should we merge this to the release branch? >

Re: r293134 - [index] When indexing an ObjC method declaration use its base name for the location.

2017-01-27 Thread Hans Wennborg via cfe-commits
Merged in r293303. Thanks, Hans On Fri, Jan 27, 2017 at 8:19 AM, Argyrios Kyrtzidis via cfe-commits wrote: > *bump* > >> On Jan 25, 2017, at 6:36 PM, Argyrios Kyrtzidis wrote: >> >> Hi Hans, >> >> Could this go into the stable branch ? >> >>> On Jan 25, 2017, at 6:11 PM, Argyrios Kyrtzidis via

r293305 - clang-cl: Warn about /U flags that look like filenames (PR31662)

2017-01-27 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Jan 27 11:09:41 2017 New Revision: 293305 URL: http://llvm.org/viewvc/llvm-project?rev=293305&view=rev Log: clang-cl: Warn about /U flags that look like filenames (PR31662) Both on Mac and Windows, it's common to have a 'Users' directory in the root of the filesystem, so on

Re: [libcxx] r291928 - Update version to 5.0

2017-01-27 Thread Hans Wennborg via cfe-commits
Thanks! I tried to update all version numbers I could find, but I obviously missed this one :-) On Fri, Jan 13, 2017 at 10:29 AM, Eric Fiselier via cfe-commits wrote: > Author: ericwf > Date: Fri Jan 13 12:29:56 2017 > New Revision: 291928 > > URL: http://llvm.org/viewvc/llvm-project?rev=291928&v

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

2017-01-27 Thread Hans Wennborg via cfe-commits
On Fri, Jan 27, 2017 at 2:55 PM, David Blaikie wrote: > > > On Fri, Jan 27, 2017 at 2:51 PM Mehdi Amini wrote: >> >> On Jan 27, 2017, at 2:43 PM, David Blaikie wrote: >> >> >> >> On Fri, Jan 27, 2017 at 2:13 PM Mehdi Amini wrote: >>> >>> CC Hans. >>> >>> This is not a regression (AFAICT), but t

[libcxx] r293645 - Merging r293581:

2017-01-31 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Jan 31 10:40:22 2017 New Revision: 293645 URL: http://llvm.org/viewvc/llvm-project?rev=293645&view=rev Log: Merging r293581: r293581 | bogner | 2017-01-30 17:26:09 -0800 (Mon, 30 Jan 2017) | 12 lines R

Re: [libcxx] r293581 - Revert "Adorn __call_once_proxy with `inline` and `_LIBCPP_INLINE_VISIBILITY`"

2017-01-31 Thread Hans Wennborg via cfe-commits
Merged to 4.0 as discussed on PR31782. On Mon, Jan 30, 2017 at 5:26 PM, Justin Bogner via cfe-commits wrote: > Author: bogner > Date: Mon Jan 30 19:26:09 2017 > New Revision: 293581 > > URL: http://llvm.org/viewvc/llvm-project?rev=293581&view=rev > Log: > Revert "Adorn __call_once_proxy with `inl

Re: r293416 - [c-index-test] Provide capability for 'c-index-test core' to dump symbol information from a PCH/module file.

2017-01-31 Thread Hans Wennborg via cfe-commits
Hi Argyrios, Can you provide more background on what this does. Is it fixing an existing issue or doing something new? r293461 is making changes beyond Index/ so I'd like Richard to take a look too. Thanks, Hans On Mon, Jan 30, 2017 at 8:18 AM, Argyrios Kyrtzidis wrote: > Hi Hans, > > Could th

Re: r293596 - Handle ObjCEncodeExpr in extractStringLiteralCharacter.

2017-01-31 Thread Hans Wennborg via cfe-commits
Merged in r293653. Thanks, Hans On Mon, Jan 30, 2017 at 7:16 PM, Akira Hatanaka wrote: > Hans, can this be merged to 4.0? This fixes a regression from 3.9 (the part I > touched was committed a few years ago, but didn’t cause an assert until > recently). > >> On Jan 30, 2017, at 6:31 PM, Akira

Re: r291963 - [clang] Emit `diagnose_if` warnings from system headers

2017-01-31 Thread Hans Wennborg via cfe-commits
Ping? On Thu, Jan 26, 2017 at 10:21 AM, Hans Wennborg wrote: > Ping? > > On Mon, Jan 23, 2017 at 4:27 PM, Hans Wennborg wrote: >> Ping? >> >> On Tue, Jan 17, 2017 at 4:16 PM, Hans Wennborg wrote: >>> Richard, what do you think? >>> >>> On Fri, Jan 13, 2017 at 3:16 PM, Eric Fiselier wrote:

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

2017-01-31 Thread Hans Wennborg via cfe-commits
On Thu, Jan 26, 2017 at 10:23 AM, Hans Wennborg wrote: > On Fri, Jan 20, 2017 at 1:52 PM, Renato Golin wrote: >> On 20 January 2017 at 19:46, Eric Fiselier wrote: >>> This patch fixes a libc++abi test failure when compiled with GCC 5, 6, or 7. >>> We should merge this into 4.0 to help get `check

Re: r292194 - [AST] AttributedType should derive type properties from the EquivalentType

2017-01-31 Thread Hans Wennborg via cfe-commits
Ping? On Thu, Jan 26, 2017 at 3:42 PM, Hans Wennborg wrote: > Should we merge this to the release branch? > > On Mon, Jan 16, 2017 at 8:14 PM, David Majnemer via cfe-commits > wrote: >> Author: majnemer >> Date: Mon Jan 16 22:14:25 2017 >> New Revision: 292194 >> >> URL: http://llvm.org/viewvc/l

Re: r292194 - [AST] AttributedType should derive type properties from the EquivalentType

2017-01-31 Thread Hans Wennborg via cfe-commits
r293702. On Tue, Jan 31, 2017 at 11:12 AM, Richard Smith wrote: > Sure, let's take this for Clang 4. > > On 31 January 2017 at 10:39, Hans Wennborg wrote: >> >> Ping? >> >> On Thu, Jan 26, 2017 at 3:42 PM, Hans Wennborg wrote: >> > Should we merge this to the release branch? >> > >> > On Mon, J

Re: [PATCH] D24969: [Sema] Use the instantiated name of destructors in FindInstantiatedDecl and RebuildMemberExpr

2017-01-31 Thread Hans Wennborg via cfe-commits
Richard, what do you think? I don't believe this fixes a 3.9 regression, but the fix looks small, so it might be worth it. On Tue, Jan 31, 2017 at 12:07 PM, Akira Hatanaka wrote: > Thanks for the review. r293678. > > Should this be merged to 4.0? > >> On Jan 31, 2017, at 12:04 PM, Akira Hatanaka

r293732 - clang-cl: Evaluate arguments left-to-right in constructor call with initializer list (PR31831)

2017-01-31 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Jan 31 20:21:07 2017 New Revision: 293732 URL: http://llvm.org/viewvc/llvm-project?rev=293732&view=rev Log: clang-cl: Evaluate arguments left-to-right in constructor call with initializer list (PR31831) clang-cl would evaluate the arguments right-to-left (see PR), and for

Re: r291963 - [clang] Emit `diagnose_if` warnings from system headers

2017-01-31 Thread Hans Wennborg via cfe-commits
I'm Ok with taking the larger patch (r293360 + r293369) too. It's been in tree for a bit, there is still a number of weeks before the release, and IIUC the major risk is that diagnose_if itself turns out to be broken, not that we'd miscompile anything? On Tue, Jan 31, 2017 at 11:11 AM, Richard Smi

r293735 - Follow-up to r293732: add a proper triple to the test

2017-01-31 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Jan 31 20:48:02 2017 New Revision: 293735 URL: http://llvm.org/viewvc/llvm-project?rev=293735&view=rev Log: Follow-up to r293732: add a proper triple to the test Modified: cfe/trunk/test/CodeGenCXX/initializer-list-ctor-order.cpp Modified: cfe/trunk/test/CodeGenCXX/ini

Re: [PATCH] D24969: [Sema] Use the instantiated name of destructors in FindInstantiatedDecl and RebuildMemberExpr

2017-02-01 Thread Hans Wennborg via cfe-commits
On Tue, Jan 31, 2017 at 3:23 PM, Richard Smith wrote: > On 31 January 2017 at 14:49, Hans Wennborg wrote: >> >> Richard, what do you think? I don't believe this fixes a 3.9 >> regression, but the fix looks small, so it might be worth it. > > > I think on the whole the benefit of this change outwe

Re: r291963 - [clang] Emit `diagnose_if` warnings from system headers

2017-02-01 Thread Hans Wennborg via cfe-commits
Merged this (r291963) in r293783. And the others (r293360 + r293369) in r293784. Thanks, Hans On Tue, Jan 31, 2017 at 7:17 PM, Richard Smith wrote: > I'm fine with these patches being merged. Hopefully we still have plenty of > time to shake out any problems between now and the release. > > On

Re: r293360 - Change how we handle diagnose_if attributes.

2017-02-01 Thread Hans Wennborg via cfe-commits
Merged in r293784, as discussed on the commit thread for r291963. Thanks, Hans On Sun, Jan 29, 2017 at 5:59 PM, George Burgess IV wrote: > Hi! > > Now that the buidbots seem content, I think that this (...along with the > minor fix to the test in r293369) should be committed to the 4.0 branch. >

Re: r293787 - [CodeGen][ObjC] Avoid asserting on block pointer types in

2017-02-01 Thread Hans Wennborg via cfe-commits
OK. Merged in r293797. Thanks, Hans On Wed, Feb 1, 2017 at 9:50 AM, Alex L wrote: > Hi Hans, > > Would it be possible to merge this for 4.0? > > Cheers, > Alex > > On 1 February 2017 at 17:37, Alex Lorenz via cfe-commits > wrote: >> >> Author: arphaman >> Date: Wed Feb 1 11:37:28 2017 >> New R

Re: r293043 - [analyzer] Fix MacOSXAPIChecker fp with static locals seen from nested blocks.

2017-02-01 Thread Hans Wennborg via cfe-commits
If Anna is Ok with it, I'm fine with merging. Thanks, Hans On Wed, Feb 1, 2017 at 10:29 AM, Artem Dergachev wrote: > Hans, > > This is a fixed and tested version of the previously-merged-and-reverted > r292800, do we still have time to land this into 4.0? > > Thanks, > Artem. > > > On 1/25/17 1:

r293800 - Drop 'dllimport' when redeclaring inline function template without the attribute (PR31695)

2017-02-01 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Feb 1 12:52:53 2017 New Revision: 293800 URL: http://llvm.org/viewvc/llvm-project?rev=293800&view=rev Log: Drop 'dllimport' when redeclaring inline function template without the attribute (PR31695) For non-template dllimport functions, MSVC allows providing an inline defi

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

2017-02-01 Thread Hans Wennborg via cfe-commits
On Tue, Jan 31, 2017 at 11:40 AM, Renato Golin wrote: > On 31 January 2017 at 18:36, Hans Wennborg wrote: Can you attach all commits that need to be backported into a bug against PR31622? We should probably squash them all before merge. >>> >>> What's the status here? >> >> Pi

[libcxxabi] r293813 - Merging r292638:

2017-02-01 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Feb 1 15:30:36 2017 New Revision: 293813 URL: http://llvm.org/viewvc/llvm-project?rev=293813&view=rev Log: Merging r292638: r292638 | ericwf | 2017-01-20 11:34:19 -0800 (Fri, 20 Jan 2017) | 9 lines Fi

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

2017-02-01 Thread Hans Wennborg via cfe-commits
Merged this one in r293813. Cheers, Hans On Wed, Feb 1, 2017 at 1:16 PM, Renato Golin wrote: > Right, the other one was 292607 and has already been merged. Sorry for > the confusion. We just need to merge this one and we're done. > > --renato > > On 1 February 2017 at 21:14, Renato Golin wrote:

Re: r293043 - [analyzer] Fix MacOSXAPIChecker fp with static locals seen from nested blocks.

2017-02-03 Thread Hans Wennborg via cfe-commits
Ping? On Wed, Feb 1, 2017 at 11:00 AM, Hans Wennborg wrote: > If Anna is Ok with it, I'm fine with merging. > > Thanks, > Hans > > On Wed, Feb 1, 2017 at 10:29 AM, Artem Dergachev wrote: >> Hans, >> >> This is a fixed and tested version of the previously-merged-and-reverted >> r292800, do we sti

Re: r294008 - [Sema][ObjC++] Typo correction should handle ivars and properties

2017-02-03 Thread Hans Wennborg via cfe-commits
IIUC, this isn't strictly fixing a regression from 3.9, but it looks like a pretty small diff. Richard, what do you think? On Fri, Feb 3, 2017 at 6:37 AM, Alex L wrote: > Hi Hans, > > Is there any chance we can merge this for 4.0? It fixed a nasty bug where > clang didn't catch invalid ObjC++ co

Re: r293043 - [analyzer] Fix MacOSXAPIChecker fp with static locals seen from nested blocks.

2017-02-03 Thread Hans Wennborg via cfe-commits
r294050. Thanks, Hans On Fri, Feb 3, 2017 at 1:50 PM, Anna Zaks wrote: > Fine with merging. Thank you! > Anna. >> On Feb 1, 2017, at 11:00 AM, Hans Wennborg wrote: >> >> If Anna is Ok with it, I'm fine with merging. >> >> Thanks, >> Hans >> >> On Wed, Feb 1, 2017 at 10:29 AM, Artem Dergachev w

Re: r294008 - [Sema][ObjC++] Typo correction should handle ivars and properties

2017-02-03 Thread Hans Wennborg via cfe-commits
Thanks! r294059. On Fri, Feb 3, 2017 at 2:29 PM, Richard Smith wrote: > It looks like the only cases it should have any real impact on are those > where we would previously miscompile/crash, so this seems OK to me to merge > to Clang 4. > > > On 3 February 2017 at 13:45, Hans Wennborg wrote: >>

[libcxx] r294249 - Merging r294133 and r294142:

2017-02-06 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Feb 6 15:59:19 2017 New Revision: 294249 URL: http://llvm.org/viewvc/llvm-project?rev=294249&view=rev Log: Merging r294133 and r294142: r294133 | marshall | 2017-02-05 12:06:38 -0800 (Sun, 05 Feb 2017)

Re: [libcxx] r294133 - Change the base class of std::bad_optional_access. This is a (subtle) ABI change, and is in response to http://http://wg21.link/LWG2806, which I *expect* to be adopted in Kona.

2017-02-06 Thread Hans Wennborg via cfe-commits
I've merged this, together with your r294142, to 4.0 in r294249, as requested. If I understand correctly, we should also merge Eric's follow-ups r294138 and r294139, but I get merge conflicts for the Linux one so I've asked about how to handle that. Thanks, Hans On Sun, Feb 5, 2017 at 12:06 PM,

Re: [libcxx] r294138 - Adjust Linux ABI list after r294133

2017-02-06 Thread Hans Wennborg via cfe-commits
The diff here is huge compared to the Apple one (r294139). Did the file format change and this file was previously not updated? This makes it hard to merge the change. Can you advise on how to generate this file or how to do the same change on 4.0? On Sun, Feb 5, 2017 at 12:14 PM, Eric Fiselier

Re: [libcxx] r294138 - Adjust Linux ABI list after r294133

2017-02-07 Thread Hans Wennborg via cfe-commits
Ping? On Mon, Feb 6, 2017 at 2:15 PM, Hans Wennborg wrote: > The diff here is huge compared to the Apple one (r294139). > > Did the file format change and this file was previously not updated? > > This makes it hard to merge the change. Can you advise on how to > generate this file or how to do t

[libcxx] r294483 - Docs: drop minor version

2017-02-08 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Feb 8 11:28:23 2017 New Revision: 294483 URL: http://llvm.org/viewvc/llvm-project?rev=294483&view=rev Log: Docs: drop minor version Modified: libcxx/branches/release_40/docs/conf.py Modified: libcxx/branches/release_40/docs/conf.py URL: http://llvm.org/viewvc/llvm-pr

[libcxx] r294540 - Creating release candidate rc2 from release_400 branch

2017-02-08 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Feb 8 18:14:12 2017 New Revision: 294540 URL: http://llvm.org/viewvc/llvm-project?rev=294540&view=rev Log: Creating release candidate rc2 from release_400 branch Added: libcxx/tags/RELEASE_400/rc2/ (props changed) - copied from r294539, libcxx/branches/release_

[libcxxabi] r294541 - Creating release candidate rc2 from release_400 branch

2017-02-08 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Feb 8 18:14:16 2017 New Revision: 294541 URL: http://llvm.org/viewvc/llvm-project?rev=294541&view=rev Log: Creating release candidate rc2 from release_400 branch Added: libcxxabi/tags/RELEASE_400/rc2/ (props changed) - copied from r294540, libcxxabi/branches/re

[libunwind] r294547 - Creating release candidate rc2 from release_400 branch

2017-02-08 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Feb 8 18:14:34 2017 New Revision: 294547 URL: http://llvm.org/viewvc/llvm-project?rev=294547&view=rev Log: Creating release candidate rc2 from release_400 branch Added: libunwind/tags/RELEASE_400/rc2/ (props changed) - copied from r294546, libunwind/branches/re

Re: [libcxx] r294612 - Fix PR31916 - std::visit rejects visitors accepting lvalue arguments

2017-02-09 Thread Hans Wennborg via cfe-commits
Sounds good to me. You said "these changes"; are there more than this one? On Thu, Feb 9, 2017 at 11:15 AM, Eric Fiselier wrote: > I'm planning to merge this fix into the 4.0 release branch. > > Although not a regression, since is a new feature, it would still > be nice to ship without this bug.

<    4   5   6   7   8   9   10   11   12   13   >