[libcxx] r261690 - Creating release candidate rc3 from release_380 branch

2016-02-23 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Feb 23 15:40:01 2016 New Revision: 261690 URL: http://llvm.org/viewvc/llvm-project?rev=261690&view=rev Log: Creating release candidate rc3 from release_380 branch Added: libcxx/tags/RELEASE_380/rc3/ (props changed) - copied from r261689, libcxx/branches/release_

[libunwind] r261697 - Creating release candidate rc3 from release_380 branch

2016-02-23 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Feb 23 15:40:24 2016 New Revision: 261697 URL: http://llvm.org/viewvc/llvm-project?rev=261697&view=rev Log: Creating release candidate rc3 from release_380 branch Added: libunwind/tags/RELEASE_380/rc3/ - copied from r261696, libunwind/branches/release_38/ ___

Re: r261717 - Default vaarg lowering should support indirect struct types.

2016-02-24 Thread Hans Wennborg via cfe-commits
On Wed, Feb 24, 2016 at 5:11 AM, Joerg Sonnenberger via cfe-commits wrote: > On Wed, Feb 24, 2016 at 03:03:32AM -, James Y Knight via cfe-commits > wrote: >> Author: jyknight >> Date: Tue Feb 23 20:59:33 2016 >> New Revision: 261717 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=261717&vi

Re: r268055 - Recommitted r264281 "Supporting all entities declared in lexical scope in LLVM debug info."

2016-04-29 Thread Hans Wennborg via cfe-commits
Chromium builds are failing too, see https://llvm.org/bugs/show_bug.cgi?id=27579 That is with LLVM/Clang r268086. On Fri, Apr 29, 2016 at 1:47 PM, Aboud, Amjad via cfe-commits wrote: > I could not reproduce the issue. > This error appeared before and it always meant that LLVM and Clang were not

Re: [PATCH] D19756: Expand aggregate arguments more often on 32-bit Windows

2016-04-29 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. This is awesome! lgtm I only have nits and questions. Want to reference PR27522 in the patch description? Also in the description: > I also expanded the workaround handle C++ records with constr

[PATCH] D19881: clang-cl: Print a blank line at the start of /showIncludes (PR27226)

2016-05-03 Thread Hans Wennborg via cfe-commits
hans created this revision. hans added reviewers: thakis, brad.king. hans added a subscriber: cfe-commits. MSVC prints a blank line there, and it turns out CMake (at least currently released versions) expects it to be there. http://reviews.llvm.org/D19881 Files: lib/Frontend/HeaderIncludeGen.

Re: [PATCH] D19881: clang-cl: Print a blank line at the start of /showIncludes (PR27226)

2016-05-03 Thread Hans Wennborg via cfe-commits
hans added inline comments. Comment at: lib/Frontend/HeaderIncludeGen.cpp:106 @@ +105,3 @@ +// it to be there. +*OutputFile << '\n'; + } thakis wrote: > Doesn't do that for me: > > C:\src\ninja>cl /c test.cc /nologo /showIncludes > test.cc > Note: includ

Re: [PATCH] D19881: clang-cl: Print a blank line at the start of /showIncludes (PR27226)

2016-05-03 Thread Hans Wennborg via cfe-commits
hans added a comment. In http://reviews.llvm.org/D19881#420244, @thakis wrote: > I agree with Brad that it'd be nice if we didn't have to add this :-) > > What's the workaround for current cmake releases? Passing -DCMAKE_CL_SHOWINCLUDES_PREFIX="Note: including file: " is the work-around I used

Re: [PATCH] D19881: clang-cl: Print a blank line at the start of /showIncludes (PR27226)

2016-05-03 Thread Hans Wennborg via cfe-commits
hans abandoned this revision. hans added a comment. In http://reviews.llvm.org/D19881#420250, @thakis wrote: > So ninja knows how to filter out the source line that cl.exe prints > unconditionally, without a way to disable that. If you add a bare newline, > ninja won't filter that out and this

Re: [PATCH] D19947: [Clang] Fix some Clang-tidy readability-simplify-boolean-expr and Include What You Use warnings

2016-05-05 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm nice improvement with getFlag()! Repository: rL LLVM http://reviews.llvm.org/D19947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r269148 - Disable -Wcast-calling-convention by default (follow-up to r269116)

2016-05-10 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue May 10 19:49:20 2016 New Revision: 269148 URL: http://llvm.org/viewvc/llvm-project?rev=269148&view=rev Log: Disable -Wcast-calling-convention by default (follow-up to r269116) Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/test/Sema/calling

Re: r269116 - Add -Wcast-calling-convention to warn when casting away calling conventions

2016-05-10 Thread Hans Wennborg via cfe-commits
On Tue, May 10, 2016 at 2:00 PM, Reid Kleckner via cfe-commits wrote: > Author: rnk > Date: Tue May 10 16:00:03 2016 > New Revision: 269116 > > URL: http://llvm.org/viewvc/llvm-project?rev=269116&view=rev > Log: > Add -Wcast-calling-convention to warn when casting away calling conventions > > Summ

Re: r269148 - Disable -Wcast-calling-convention by default (follow-up to r269116)

2016-05-10 Thread Hans Wennborg via cfe-commits
> Clangs diagnostics wouldn't have developed as well as they have if we took > this approach to all warnings. > > > On Tuesday, May 10, 2016, Hans Wennborg via cfe-commits > wrote: >> >> Author: hans >> Date: Tue May 10 19:49:20 2016 >> New Revision: 26

Re: [PATCH] D20213: [Clang] Fix Clang-tidy modernize-use-bool-literals in generated code.

2016-05-12 Thread Hans Wennborg via cfe-commits
hans added inline comments. Comment at: utils/TableGen/ClangAttrEmitter.cpp:338 @@ -310,1 +337,3 @@ +OS << "\n\n static const " << getType() << " Default" << getUpperName() + << " = " << Default << ";"; } Everything up to the " = " part is

Re: [PATCH] D20213: [Clang] Fix Clang-tidy modernize-use-bool-literals in generated code.

2016-05-12 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM http://reviews.llvm.org/D20213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

Re: [PATCH] D20254: [Clang] Fix some Clang-tidy modernize-use-bool-literals warnings; other minor fixes.

2016-05-16 Thread Hans Wennborg via cfe-commits
hans added a comment. I'd leave out the blank lines between DEF_TRAVERSE_STMTs, but the rest looks good. Comment at: include/clang/AST/RecursiveASTVisitor.h:2014 @@ -2002,2 +2013,3 @@ DEF_TRAVERSE_STMT(ObjCAutoreleasePoolStmt, {}) + DEF_TRAVERSE_STMT(CXXForRangeStmt, { --

Re: r269572 - Warn when a reference is bound to an empty l-value (dereferenced null pointer).

2016-05-16 Thread Hans Wennborg via cfe-commits
On Sat, May 14, 2016 at 10:44 AM, Nick Lewycky via cfe-commits wrote: > > Author: nicholas > Date: Sat May 14 12:44:14 2016 > New Revision: 269572 > > URL: http://llvm.org/viewvc/llvm-project?rev=269572&view=rev > Log: > Warn when a reference is bound to an empty l-value (dereferenced null > poin

Re: r269572 - Warn when a reference is bound to an empty l-value (dereferenced null pointer).

2016-05-16 Thread Hans Wennborg via cfe-commits
On Mon, May 16, 2016 at 10:03 AM, Nick Lewycky wrote: > Hans Wennborg wrote: >> >> On Sat, May 14, 2016 at 10:44 AM, Nick Lewycky via cfe-commits >> wrote: >>> >>> >>> Author: nicholas >>> Date: Sat May 14 12:44:14 2016 >>> New Revision: 269572 >>> >>> URL: http://llvm.org/viewvc/llvm-project?re

Re: [PATCH] D20291: [ms] Reintroduce feature guards in intrinsic headers in Microsoft mode

2016-05-16 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D20291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

Re: [clang-tools-extra] r261991 - [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

2016-05-19 Thread Hans Wennborg via cfe-commits
+Tom who manages 3.8.1 +Alex who's owner of clang-tidy: is this ok for 3.8.1? On Thu, May 19, 2016 at 1:56 AM, Edoardo P. via cfe-commits wrote: > Is it possible to port this commit to 3.8.1? > > Cheers, > Edward-san > > 2016-02-26 10:19 GMT+01:00 Haojian Wu via cfe-commits > : >> Author: hokein

Re: r265425 - Add -fno-jump-tables and-fjump-tables flags

2016-04-05 Thread Hans Wennborg via cfe-commits
On Tue, Apr 5, 2016 at 10:50 AM, Nirav Dave via cfe-commits wrote: > Author: niravd > Date: Tue Apr 5 12:50:43 2016 > New Revision: 265425 > > URL: http://llvm.org/viewvc/llvm-project?rev=265425&view=rev > Log: > Add -fno-jump-tables and-fjump-tables flags > > Add no-jump-tables flag to disable u

Re: r265622 - [CrashReproducer] Setup 'case-sensitive' in YAML files.

2016-04-06 Thread Hans Wennborg via cfe-commits
On Wed, Apr 6, 2016 at 5:00 PM, Bruno Cardoso Lopes via cfe-commits wrote: > Author: bruno > Date: Wed Apr 6 19:00:57 2016 > New Revision: 265622 > > URL: http://llvm.org/viewvc/llvm-project?rev=265622&view=rev > Log: > [CrashReproducer] Setup 'case-sensitive' in YAML files. This doesn't compile

r265994 - libclang: fix two memory leaks (PR26292)

2016-04-11 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Apr 11 15:53:59 2016 New Revision: 265994 URL: http://llvm.org/viewvc/llvm-project?rev=265994&view=rev Log: libclang: fix two memory leaks (PR26292) Modified: cfe/trunk/tools/libclang/CIndex.cpp Modified: cfe/trunk/tools/libclang/CIndex.cpp URL: http://llvm.org/viewvc

Re: [patch] clang-cl: Remove -isystem, add -imsvc, expose -nostdlibinc

2016-04-12 Thread Hans Wennborg via cfe-commits
On Mon, Apr 11, 2016 at 7:16 PM, Nico Weber wrote: > r260990 exposed -isystem in clang-cl. -isystem adds a directory to the front > of the system include search path. The idea was to use this to point to a > hermetic msvc install, but as it turns out this doesn't work: -isystem then > adds the her

Re: r265994 - libclang: fix two memory leaks (PR26292)

2016-04-12 Thread Hans Wennborg via cfe-commits
r 12, 2016 at 9:51 AM, David Blaikie via cfe-commits wrote: > Any chance of using unique_ptr, or at least a scoped cleanup device, here? > > On Mon, Apr 11, 2016 at 1:54 PM, Hans Wennborg via cfe-commits > wrote: >> >> Author: hans >> Date: Mon Apr 11 15:53:59 2016

Re: [patch] clang-cl: Remove -isystem, add -imsvc, expose -nostdlibinc

2016-04-12 Thread Hans Wennborg via cfe-commits
LGTM On Tue, Apr 12, 2016 at 11:40 AM, Nico Weber wrote: > All done. phab's back, but since we started with a patch attachment, let's > keep it that way. > > > > On Tue, Apr 12, 2016 at 12:12 PM, Hans Wennborg wrote: >> >> On Mon, Apr 11, 2016 at 7:16 PM, Nico Weber wrote: >> > r260990 exposed

r266242 - Make sure CheckDestructor gets called on dllimported classes if the vtable is used (PR27319)

2016-04-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Apr 13 15:21:15 2016 New Revision: 266242 URL: http://llvm.org/viewvc/llvm-project?rev=266242&view=rev Log: Make sure CheckDestructor gets called on dllimported classes if the vtable is used (PR27319) Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp cfe/trunk/test/Code

r266395 - clang-cl: Make /link accept an optional joined argument.

2016-04-14 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Apr 14 19:24:15 2016 New Revision: 266395 URL: http://llvm.org/viewvc/llvm-project?rev=266395&view=rev Log: clang-cl: Make /link accept an optional joined argument. For example, "cl.exe a.c /linkfoo bar" is a valid invocation and forwards "foo" and "bar" to link.exe. This m

Re: r266186 - Enable support for __float128 in Clang

2016-04-14 Thread Hans Wennborg via cfe-commits
On Wed, Apr 13, 2016 at 2:49 AM, Nemanja Ivanovic via cfe-commits wrote: > Author: nemanjai > Date: Wed Apr 13 04:49:45 2016 > New Revision: 266186 > > URL: http://llvm.org/viewvc/llvm-project?rev=266186&view=rev > Log: > Enable support for __float128 in Clang > > This patch corresponds to review:

r266402 - clang-cl: Don't check for existence of linker inputs when /link is used

2016-04-14 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Apr 14 20:12:32 2016 New Revision: 266402 URL: http://llvm.org/viewvc/llvm-project?rev=266402&view=rev Log: clang-cl: Don't check for existence of linker inputs when /link is used There might be flags passed to the linker (e.g. /libpath), causing it to search in paths the C

Re: [PATCH] D20576: [Driver] Add support for -finline-functions and /Ob2 flags

2016-05-24 Thread Hans Wennborg via cfe-commits
hans added a comment. Thanks! Some comments below: Comment at: lib/Driver/Tools.cpp:5335 @@ -5334,3 +5334,3 @@ - if (Args.hasArg(options::OPT_fno_inline_functions)) -CmdArgs.push_back("-fno-inline-functions"); + if (Arg* InlineArg = Args.getLastArg(options::OPT_finline_f

Re: [PATCH] D20576: [Driver] Add support for -finline-functions and /Ob2 flags

2016-05-24 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good to me! Do you have commit access, or would you like me to commit this for you? http://reviews.llvm.org/D20576 ___ cfe-commits mailing lis

r270609 - [Driver] Add support for -finline-functions and /Ob2 flags

2016-05-24 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue May 24 15:40:51 2016 New Revision: 270609 URL: http://llvm.org/viewvc/llvm-project?rev=270609&view=rev Log: [Driver] Add support for -finline-functions and /Ob2 flags -finline-functions and /Ob2 are currently ignored by Clang. The only way to enable inlining is to use the g

Re: [PATCH] D20576: [Driver] Add support for -finline-functions and /Ob2 flags

2016-05-24 Thread Hans Wennborg via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL270609: [Driver] Add support for -finline-functions and /Ob2 flags (authored by hans). Changed prior to commit: http://reviews.llvm.org/D20576?vs=58302&id=58308#toc Repository: rL LLVM http://review

r270614 - clang-cl: Bake /Ob0 and /Ob2 into the general /O option handling

2016-05-24 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue May 24 16:23:29 2016 New Revision: 270614 URL: http://llvm.org/viewvc/llvm-project?rev=270614&view=rev Log: clang-cl: Bake /Ob0 and /Ob2 into the general /O option handling This is a follow-up to r270609, wherein I forgot that /O options can be combined, and e.g. /Odb2 is a

Re: [PATCH] D20576: [Driver] Add support for -finline-functions and /Ob2 flags

2016-05-24 Thread Hans Wennborg via cfe-commits
hans added a subscriber: majnemer. hans added a comment. majnemer reminded me that /O options can be combined, so e.g. /Odb2 would be a valid combination. I've followed up with r270614 to move the /Ob flags into that mechanism. Repository: rL LLVM http://reviews.llvm.org/D20576 _

r270633 - Rename test/CodeGen/inline-optim.cc to .c and provide a triple

2016-05-24 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue May 24 18:37:56 2016 New Revision: 270633 URL: http://llvm.org/viewvc/llvm-project?rev=270633&view=rev Log: Rename test/CodeGen/inline-optim.cc to .c and provide a triple Added: cfe/trunk/test/CodeGen/inline-optim.c - copied, changed from r270615, cfe/trunk/test/C

Re: [PATCH] D20576: [Driver] Add support for -finline-functions and /Ob2 flags

2016-05-24 Thread Hans Wennborg via cfe-commits
hans added a comment. In http://reviews.llvm.org/D20576#438581, @Ilod wrote: > It seems the new test was commited as .cc instead of .c, which changes the > name mangling, making // NOINLINE-LABEL: @foo fail. > Either the file should be renamed, or -x c should be added to clang > invocation, or

r270642 - clang-cl: Fix unused argument warning when combining /O2 and /Ob2

2016-05-24 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue May 24 19:43:45 2016 New Revision: 270642 URL: http://llvm.org/viewvc/llvm-project?rev=270642&view=rev Log: clang-cl: Fix unused argument warning when combining /O2 and /Ob2 Modified: cfe/trunk/lib/Driver/MSVCToolChain.cpp cfe/trunk/test/Driver/cl-options.c Modifie

[PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

2016-05-24 Thread Hans Wennborg via cfe-commits
hans created this revision. hans added reviewers: rnk, thakis. hans added a subscriber: cfe-commits. This matches what MSVC does, and should make compiles faster by avoiding to unnecessarily emit a lot of code. http://reviews.llvm.org/D20608 Files: lib/Sema/SemaTemplate.cpp test/CodeGenCXX/

Re: [PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

2016-05-25 Thread Hans Wennborg via cfe-commits
hans added a comment. In http://reviews.llvm.org/D20608#438760, @majnemer wrote: > Does this change our behavior for mingw? No, this only affects the MS ABI. MinGW doesn't seem to do this trick. For example, in this code, they will emit a definition for S::Inner::f: template struct S {

Re: [PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

2016-05-25 Thread Hans Wennborg via cfe-commits
hans added a comment. Thanks for the review! In http://reviews.llvm.org/D20608#439480, @thakis wrote: > Do we have test coverage for `template class __declspec(dllexport) > codecvt;` somewhere already? Yes, that's covered by tests in CodeGenCXX/dllexport.cpp Comment at: lib

Re: [PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

2016-05-25 Thread Hans Wennborg via cfe-commits
hans updated this revision to Diff 58461. hans added a comment. tweaks http://reviews.llvm.org/D20608 Files: lib/Sema/SemaTemplate.cpp test/CodeGenCXX/dllexport.cpp test/CodeGenCXX/dllimport.cpp Index: test/CodeGenCXX/dllimport.cpp

Re: [PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

2016-05-25 Thread Hans Wennborg via cfe-commits
hans added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7382 @@ +7381,3 @@ + if (A->getKind() == AttributeList::AT_DLLExport) { +// dllexport trumps dllexport here. +DLLImport = false; thakis wrote: > trumps _dllimport_ here > > (te

Re: [PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

2016-05-25 Thread Hans Wennborg via cfe-commits
hans updated this revision to Diff 58484. hans added a comment. Fix the "dllexport trumps" comment, and add a test. http://reviews.llvm.org/D20608 Files: lib/Sema/SemaTemplate.cpp test/CodeGenCXX/dllexport.cpp test/CodeGenCXX/dllimport.cpp Index: test/CodeGenCXX/dllimport.cpp ===

r270748 - clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

2016-05-25 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed May 25 15:16:43 2016 New Revision: 270748 URL: http://llvm.org/viewvc/llvm-project?rev=270748&view=rev Log: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811) This matches what MSVC does, and should make compiles faster

Re: [PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

2016-05-25 Thread Hans Wennborg via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL270748: clang-cl: Treat dllimport explicit template instantiation definitions as… (authored by hans). Changed prior to commit: http://reviews.llvm.org/D20608?vs=58484&id=58488#toc Repository: rL LLVM

r270754 - Revert r270748 "clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)"

2016-05-25 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed May 25 15:49:14 2016 New Revision: 270754 URL: http://llvm.org/viewvc/llvm-project?rev=270754&view=rev Log: Revert r270748 "clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)" It seems to have broken the sanitizer-windo

Re: [PATCH] D20672: Don't pass -fms-compatibility-version flag during build

2016-05-26 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm if it works :-) Repository: rL LLVM http://reviews.llvm.org/D20672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

r270897 - Re-commit r270748 "clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)"

2016-05-26 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu May 26 14:42:56 2016 New Revision: 270897 URL: http://llvm.org/viewvc/llvm-project?rev=270897&view=rev Log: Re-commit r270748 "clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)" Also make explicit instantiation decls n

r271688 - Obj-C: Fix assert-on-invalid (PR27822)

2016-06-03 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Jun 3 11:59:13 2016 New Revision: 271688 URL: http://llvm.org/viewvc/llvm-project?rev=271688&view=rev Log: Obj-C: Fix assert-on-invalid (PR27822) Clang would assert when isObjCInstancetype() was called on a tok::annot_cxxscope token. Modified: cfe/trunk/include/clang/

[PATCH] D21113: Add support for case-insensitive header lookup

2016-06-07 Thread Hans Wennborg via cfe-commits
hans created this revision. hans added reviewers: rsmith, rnk, thakis. hans added subscribers: compnerd, majnemer, benlangmuir, cfe-commits. This is useful when dealing with headers that are normally used on case-insensitive filesystems, such as the Windows SDK, when cross-compiling from a file-

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-07 Thread Hans Wennborg via cfe-commits
hans updated this revision to Diff 59982. hans added a comment. Add --show-includes test. http://reviews.llvm.org/D21113 Files: include/clang/Basic/VirtualFileSystem.h include/clang/Driver/Options.td include/clang/Lex/HeaderSearchOptions.h lib/Basic/VirtualFileSystem.cpp lib/Driver/To

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-08 Thread Hans Wennborg via cfe-commits
hans updated this revision to Diff 60054. hans marked 2 inline comments as done. hans added a comment. Addressing Saleem's comments, and renaming the flag to -fcase-insensitive-paths, since this doesn't apply just to includes, but anything that goes through vfs, including the main source filenam

Re: Virtual patch: `svn mv lib/Headers/Intrin.h lib/Headers/intrin.h`

2016-06-08 Thread Hans Wennborg via cfe-commits
On Wed, Jun 8, 2016 at 10:20 AM, Nico Weber wrote: > It looks like we're starting to be more careful about header case. MSVC's > intrin.h is called intrin.h with a lower-case 'i'; ours starts with an > upper-case 'I' for no good reason. > > It looks like file-only renames work fine as of svn 1.7 w

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-08 Thread Hans Wennborg via cfe-commits
hans added a comment. In http://reviews.llvm.org/D21113#452431, @thakis wrote: > For performance: Can you check how build times for some large target in > Chromium on Linux targeting Windows compares with this vs having the sdk in a > fat mount? That would give us some data. I measured compil

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-08 Thread Hans Wennborg via cfe-commits
hans added a comment. In http://reviews.llvm.org/D21113#452558, @thakis wrote: > Can you try building a few more files? Say, v8_base? Well, that was depressing: Putting the sdk on a vfat fs: real2m26.077s user68m31.476s sys 1m25.702s Using the flag: real9m5.179s

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-08 Thread Hans Wennborg via cfe-commits
hans added a comment. In http://reviews.llvm.org/D21113#452673, @thakis wrote: > Not sure if we want a flag that adds 50% overhead, no matter how convenient > it might be :-/ I now have a version of the patch that caches directory contents that it lists: real2m31.461s user68m42.09

Re: [PATCH] D20347: Add support to clang-cl driver for /GS switch

2016-06-09 Thread Hans Wennborg via cfe-commits
hans added a comment. Is this waiting for anything more now that http://reviews.llvm.org/D20346 has landed? http://reviews.llvm.org/D20347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-09 Thread Hans Wennborg via cfe-commits
hans updated this revision to Diff 60220. hans added a comment. Adding the version that caches directory contents. This has the problem the it doesn't play with modules, the rewriter, and possibly others, because they write to the file system without any way for the vfs to find out. I've tried

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-10 Thread Hans Wennborg via cfe-commits
On Thu, Jun 9, 2016 at 5:31 PM, Joerg Sonnenberger via cfe-commits wrote: > On Wed, Jun 08, 2016 at 01:12:31AM +0000, Hans Wennborg via cfe-commits wrote: >> There has been a patch for this before (http://reviews.llvm.org/D2972), >> but this one is more general, as it works

r272583 - clang-cl: Support -resource-dir option (PR28074)

2016-06-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Jun 13 15:31:30 2016 New Revision: 272583 URL: http://llvm.org/viewvc/llvm-project?rev=272583&view=rev Log: clang-cl: Support -resource-dir option (PR28074) It's useful e.g. for distributed build systems. Modified: cfe/trunk/include/clang/Driver/Options.td cfe/trun

Re: Virtual patch: `svn mv lib/Headers/Intrin.h lib/Headers/intrin.h`

2016-06-14 Thread Hans Wennborg via cfe-commits
SGTM, then :-) On Tue, Jun 14, 2016 at 11:54 AM, Nico Weber wrote: > I locally set up an SVN repo with a file called "File.txt" and then renamed > it with `svn mv` using a new svn client (1.8). > > Then I tried updating several local checkouts of my local repo with svn > 1.6.6 clients. All method

r272702 - s/Intrin.h/intrin.h/, trying to fix the build after r272701

2016-06-14 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Jun 14 15:14:24 2016 New Revision: 272702 URL: http://llvm.org/viewvc/llvm-project?rev=272702&view=rev Log: s/Intrin.h/intrin.h/, trying to fix the build after r272701 Modified: cfe/trunk/lib/Headers/CMakeLists.txt cfe/trunk/lib/Headers/intrin.h cfe/trunk/test/C

Re: [PATCH] D20647: Add support for /Ob1 and -finline-hint-functions flags

2016-06-21 Thread Hans Wennborg via cfe-commits
hans added inline comments. Comment at: test/Driver/cl-options.c:283 @@ -282,3 +282,2 @@ // RUN:/nologo \ -// RUN:/Ob1 \ // RUN:/openmp- \ You're removing it from the ignored flags here, but I don't see any code change or test for how clang-cl's sup

[PATCH] D21566: Widen EHScope::ClenupBitFields::FixupDepth to avoid overflowing it (PR23490)

2016-06-21 Thread Hans Wennborg via cfe-commits
hans created this revision. hans added a reviewer: rjmccall. hans added a subscriber: cfe-commits. It currently only takes 2048 gotos to overflow the FixupDepth bitfield, causing silent miscompilation. Apparently some parser generators run into this (see PR). I don't know that that data structur

Re: [PATCH] D20647: Add support for /Ob1 and -finline-hint-functions flags

2016-06-21 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. In http://reviews.llvm.org/D20647#463590, @Ilod wrote: > Fixed passing argument from clang driver to cc1. > Added driver tests. lgtm, thanks! http://reviews.llvm.org/D20647 ___ cfe-commits maili

Re: [PATCH] D21566: Widen EHScope::ClenupBitFields::FixupDepth to avoid overflowing it (PR23490)

2016-06-22 Thread Hans Wennborg via cfe-commits
hans updated this revision to Diff 61560. hans marked 3 inline comments as done. hans added a comment. Addressing comments. http://reviews.llvm.org/D21566 Files: lib/CodeGen/CGCleanup.h test/CodeGen/fixup-depth-overflow.c Index: test/CodeGen/fixup-depth-overflow.c =

Re: [PATCH] D21566: Widen EHScope::ClenupBitFields::FixupDepth to avoid overflowing it (PR23490)

2016-06-22 Thread Hans Wennborg via cfe-commits
hans added a comment. Thanks for the review! Please take another look. Comment at: lib/CodeGen/CGCleanup.h:93 @@ -92,3 +92,3 @@ /// from this index onwards belong to this scope. -unsigned FixupDepth : 32 - 18 - NumCommonBits; // currently 12 +unsigned FixupDepth;

r273434 - Widen EHScope::ClenupBitFields::FixupDepth to avoid overflowing it (PR23490)

2016-06-22 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jun 22 11:21:14 2016 New Revision: 273434 URL: http://llvm.org/viewvc/llvm-project?rev=273434&view=rev Log: Widen EHScope::ClenupBitFields::FixupDepth to avoid overflowing it (PR23490) It currently only takes 2048 gotos to overflow the FixupDepth bitfield, causing silent mi

Re: [PATCH] D21566: Widen EHScope::ClenupBitFields::FixupDepth to avoid overflowing it (PR23490)

2016-06-22 Thread Hans Wennborg via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL273434: Widen EHScope::ClenupBitFields::FixupDepth to avoid overflowing it (PR23490) (authored by hans). Changed prior to commit: http://reviews.llvm.org/D21566?vs=61560&id=61563#toc Repository: rL L

Re: [PATCH] D20647: Add support for /Ob1 and -finline-hint-functions flags

2016-06-22 Thread Hans Wennborg via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL273440: Add support for /Ob1 and -finline-hint-functions flags (authored by hans). Changed prior to commit: http://reviews.llvm.org/D20647?vs=61418&id=61565#toc Repository: rL LLVM http://reviews.ll

r273440 - Add support for /Ob1 and -finline-hint-functions flags

2016-06-22 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jun 22 11:56:16 2016 New Revision: 273440 URL: http://llvm.org/viewvc/llvm-project?rev=273440&view=rev Log: Add support for /Ob1 and -finline-hint-functions flags Add support for /Ob1 (and equivalent -finline-hint-functions), which enable inlining only for functions marked

Re: r273911 - [ExprConstant] Fix PR28314 - crash while evluating objectsize.

2016-06-28 Thread Hans Wennborg via cfe-commits
+Tom who does the "dot" releases. I don't know if he's planning for a 3.8.2, but just in case, I suppose it's on the radar now :-) Thanks, Hans On Mon, Jun 27, 2016 at 11:21 PM, George Burgess IV wrote: > +Richard, Hans > > This patch fixes a crash that's also present in Clang 3.8. So, I think

Re: [PATCH] D21970: Add attribute abi_tag to the release notes

2016-07-18 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, and feel free to move to before the "no longer passes --build-id" item above. https://reviews.llvm.org/D21970 ___ cfe-commits mailing list cfe

Re: r275820 - [analyzer] Add checker modeling potential C++ self-assignment

2016-07-18 Thread Hans Wennborg via cfe-commits
It seems to have broken this buildbot: http://bb.pgr.jp/builders/cmake-llvm-x86_64-linux/builds/40225/ I'm just about to create the 3.9 release branch, so it would be great if this could fixed/figured out soon. Thanks, Hans On Mon, Jul 18, 2016 at 10:23 AM, Devin Coughlin via cfe-commits wrote:

Re: [PATCH] D17695: clang-cl: Implement initial limited support for precompiled headers.

2016-02-29 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Very nice! I only have some style nits, really. Look forward to using this :-) Comment at: include/clang/Basic/DiagnosticDriverKinds.td:112 @@ +111,3 @@ +def warn_drv_yc_multiple

[clang-tools-extra] r262257 - IdentifierNamingCheck.cpp: try to fix MSVC build

2016-02-29 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Feb 29 15:17:39 2016 New Revision: 262257 URL: http://llvm.org/viewvc/llvm-project?rev=262257&view=rev Log: IdentifierNamingCheck.cpp: try to fix MSVC build It was failing to build with: clang-tidy\readability\IdentifierNamingCheck.cpp(640): error C2882: 'format' : illegal

Re: [clang-tools-extra] r262257 - IdentifierNamingCheck.cpp: try to fix MSVC build

2016-03-01 Thread Hans Wennborg via cfe-commits
t 10:17 PM, Hans Wennborg via cfe-commits > wrote: >> >> Author: hans >> Date: Mon Feb 29 15:17:39 2016 >> New Revision: 262257 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=262257&view=rev >> Log: >> IdentifierNamingCheck.cpp: try to

Re: [PATCH] D17695: clang-cl: Implement initial limited support for precompiled headers.

2016-03-01 Thread Hans Wennborg via cfe-commits
hans added a comment. lgtm2 Comment at: include/clang/Driver/Job.h:142 @@ +141,3 @@ +/// Like Command, but always pretends that the wrapped command succeeded. +/// the primary command crashes. +class ForceSuccessCommand : public Command { The second sentence loo

[libcxx] r262557 - Creating release candidate final from release_380 branch

2016-03-02 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Mar 2 18:19:14 2016 New Revision: 262557 URL: http://llvm.org/viewvc/llvm-project?rev=262557&view=rev Log: Creating release candidate final from release_380 branch Added: libcxx/tags/RELEASE_380/final/ (props changed) - copied from r262556, libcxx/branches/rele

[libcxxabi] r262558 - Creating release candidate final from release_380 branch

2016-03-02 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Mar 2 18:19:17 2016 New Revision: 262558 URL: http://llvm.org/viewvc/llvm-project?rev=262558&view=rev Log: Creating release candidate final from release_380 branch Added: libcxxabi/tags/RELEASE_380/final/ (props changed) - copied from r262557, libcxxabi/branche

[libunwind] r262564 - Creating release candidate final from release_380 branch

2016-03-02 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Mar 2 18:19:35 2016 New Revision: 262564 URL: http://llvm.org/viewvc/llvm-project?rev=262564&view=rev Log: Creating release candidate final from release_380 branch Added: libunwind/tags/RELEASE_380/final/ - copied from r262563, libunwind/branches/release_38/ ___

r263031 - ReleaseNotes: update 'you may prefer' link to 3.8

2016-03-09 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Mar 9 11:26:46 2016 New Revision: 263031 URL: http://llvm.org/viewvc/llvm-project?rev=263031&view=rev Log: ReleaseNotes: update 'you may prefer' link to 3.8 Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewv

Re: r188037 - clang-cl: Support /showIncludes

2016-03-13 Thread Hans Wennborg via cfe-commits
On Sat, Mar 12, 2016 at 7:50 PM, Nico Weber via cfe-commits wrote: > On Thu, Aug 8, 2013 at 8:32 PM, Hans Wennborg wrote: >> >> Author: hans >> Date: Thu Aug 8 19:32:23 2013 >> New Revision: 188037 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=188037&view=rev >> Log: >> clang-cl: Support /s

Re: [PATCH] D18392: clang-cl: Don't warn about /Oy- being unused in 64-bit builds.

2016-03-23 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, thanks! http://reviews.llvm.org/D18392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

r257516 - Don't store CGOpenMPRegionInfo::CodeGen as a reference (PR26078)

2016-01-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Jan 12 14:54:36 2016 New Revision: 257516 URL: http://llvm.org/viewvc/llvm-project?rev=257516&view=rev Log: Don't store CGOpenMPRegionInfo::CodeGen as a reference (PR26078) The referenced llvm::function_ref object can go away before CodeGen is used, resulting in a crash. M

Re: [PATCH] D15599: [CodeGen] Fix a crash that occurs when attribute "naked" is attached to a c++ member function

2016-01-12 Thread Hans Wennborg via cfe-commits
hans added a subscriber: hans. hans added a reviewer: rnk. hans added a comment. Just out of curiosity, where does this come up in practice? It seems a little backward that we're first emitting a bunch of instructions, only to remove them later. It would be nice if for naked function we wouldn't

r257537 - clang-cl: Support /Dfoo#bar (PR25984)

2016-01-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Jan 12 17:17:03 2016 New Revision: 257537 URL: http://llvm.org/viewvc/llvm-project?rev=257537&view=rev Log: clang-cl: Support /Dfoo#bar (PR25984) Such flags will now be translated to -Dfoo=bar. Modified: cfe/trunk/lib/Driver/MSVCToolChain.cpp cfe/trunk/test/Driver/

r257541 - Follow-up to r257537: add test that majnemer asked about

2016-01-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Jan 12 17:31:58 2016 New Revision: 257541 URL: http://llvm.org/viewvc/llvm-project?rev=257541&view=rev Log: Follow-up to r257537: add test that majnemer asked about Modified: cfe/trunk/test/Driver/cl-options.c Modified: cfe/trunk/test/Driver/cl-options.c URL: http://l

[libcxx] r257629 - Update version to 3.9

2016-01-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 13 11:33:21 2016 New Revision: 257629 URL: http://llvm.org/viewvc/llvm-project?rev=257629&view=rev Log: Update version to 3.9 Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__config URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/incl

r257628 - Update version to 3.9

2016-01-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 13 11:32:59 2016 New Revision: 257628 URL: http://llvm.org/viewvc/llvm-project?rev=257628&view=rev Log: Update version to 3.9 Modified: cfe/trunk/docs/ReleaseNotes.rst cfe/trunk/docs/conf.py Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewvc

[libcxxabi] r257635 - Creating release_38 branch off revision 257626

2016-01-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 13 11:35:10 2016 New Revision: 257635 URL: http://llvm.org/viewvc/llvm-project?rev=257635&view=rev Log: Creating release_38 branch off revision 257626 Added: libcxxabi/branches/release_38/ - copied from r257626, libcxxabi/trunk/ __

[libcxx] r257634 - Creating release_38 branch off revision 257626

2016-01-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 13 11:35:07 2016 New Revision: 257634 URL: http://llvm.org/viewvc/llvm-project?rev=257634&view=rev Log: Creating release_38 branch off revision 257626 Added: libcxx/branches/release_38/ (props changed) - copied from r257626, libcxx/trunk/ Propchange: libcxx

[libunwind] r257641 - Creating release_38 branch off revision 257626

2016-01-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 13 11:35:29 2016 New Revision: 257641 URL: http://llvm.org/viewvc/llvm-project?rev=257641&view=rev Log: Creating release_38 branch off revision 257626 Added: libunwind/branches/release_38/ - copied from r257626, libunwind/trunk/ __

Re: [libcxx] r257629 - Update version to 3.9

2016-01-13 Thread Hans Wennborg via cfe-commits
Marshall, Eric, Please check that this was OK, as I don't usually commit to libc++. Thanks, Hans On Wed, Jan 13, 2016 at 9:33 AM, Hans Wennborg via cfe-commits wrote: > Author: hans > Date: Wed Jan 13 11:33:21 2016 > New Revision: 257629 > > URL: http://llvm.org/viewvc/llv

r257652 - Update cxx_dr_status.html after the 3.8 branch

2016-01-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 13 13:14:03 2016 New Revision: 257652 URL: http://llvm.org/viewvc/llvm-project?rev=257652&view=rev Log: Update cxx_dr_status.html after the 3.8 branch Modified: cfe/trunk/www/cxx_dr_status.html Modified: cfe/trunk/www/cxx_dr_status.html URL: http://llvm.org/viewvc

Re: r257652 - Update cxx_dr_status.html after the 3.8 branch

2016-01-13 Thread Hans Wennborg via cfe-commits
Richard, can you check that I got this right? Are there any more DRs that were addressed in 3.8? If it looks good, I'll merge this to the branch. Cheers, Hans On Wed, Jan 13, 2016 at 11:14 AM, Hans Wennborg via cfe-commits wrote: > Author: hans > Date: Wed Jan 13 13:14:03 2016 >

Re: r257652 - Update cxx_dr_status.html after the 3.8 branch

2016-01-13 Thread Hans Wennborg via cfe-commits
#x27;ll merge this to the branch. >> >> Cheers, >> Hans >> >> On Wed, Jan 13, 2016 at 11:14 AM, Hans Wennborg via cfe-commits >> wrote: >> > Author: hans >> > Date: Wed Jan 13 13:14:03 2016 >> > New Revision: 257652 >> >

[libcxx] r257716 - Merging r257682:

2016-01-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 13 17:53:40 2016 New Revision: 257716 URL: http://llvm.org/viewvc/llvm-project?rev=257716&view=rev Log: Merging r257682: r257682 | marshall | 2016-01-13 13:54:34 -0800 (Wed, 13 Jan 2016) | 1 line F

<    9   10   11   12   13   14   15   16   17   >