I only noticed this when I tried to build the weekly Windows snapshot, and I didn't build one last week, so I don't know exactly when it started failing. As you said, it might be due to a header change somewhere. Since this was inside a DEBUG(), I suppose it would only show in builds with asserts enabled.
On Tue, Mar 1, 2016 at 5:54 AM, Alexander Kornienko via cfe-commits <cfe-commits@lists.llvm.org> wrote: > Thanks for the fix! When did it start failing? The last change in this file > was quite a while ago. Did it start breaking because of a change in a > header? > > On Mon, Feb 29, 2016 at 10:17 PM, Hans Wennborg via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> Author: hans >> Date: Mon Feb 29 15:17:39 2016 >> New Revision: 262257 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=262257&view=rev >> Log: >> IdentifierNamingCheck.cpp: try to fix MSVC build >> >> It was failing to build with: >> >> clang-tidy\readability\IdentifierNamingCheck.cpp(640): >> error C2882: 'format' : illegal use of namespace identifier in expression >> >> Modified: >> >> clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp >> >> Modified: >> clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp?rev=262257&r1=262256&r2=262257&view=diff >> >> ============================================================================== >> --- >> clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp >> (original) >> +++ >> clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp Mon >> Feb 29 15:17:39 2016 >> @@ -634,10 +634,10 @@ void IdentifierNamingCheck::check(const >> std::string Fixup = fixupWithStyle(Name, Style); >> if (StringRef(Fixup).equals(Name)) { >> if (!IgnoreFailedSplit) { >> - DEBUG(llvm::dbgs() << Decl->getLocStart().printToString( >> - *Result.SourceManager) >> - << format(": unable to split words for %s >> '%s'\n", >> - KindName.c_str(), Name)); >> + DEBUG(llvm::dbgs() >> + << Decl->getLocStart().printToString(*Result.SourceManager) >> + << llvm::format(": unable to split words for %s '%s'\n", >> + KindName.c_str(), Name)); >> } >> } else { >> NamingCheckFailure &Failure = NamingCheckFailures[Decl]; >> >> >> _______________________________________________ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
