[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 224286. gchatelet added a comment. - Fix missing rename Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 Files: clang/include/clang/Basic/Attr.td clang/include/cla

[PATCH] D68792: [Alignment] Migrate Attribute::getWith(Stack)Alignment

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, nhaehnle, jvesely, arsenm. Herald added a reviewer: jdoerfert. Herald added projects: clang, LLVM. This is patch is part of a series to introduce an Alignment type

[PATCH] D68792: [Alignment] Migrate Attribute::getWith(Stack)Alignment

gchatelet added a comment. @courbet there's a slight difference in the way the field is serialized in the mir / ir format (hence not [NFC]) but there's no change in semantics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68792/new/ https://review

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet added a comment. A gentle ping @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68792: [Alignment] Migrate Attribute::getWith(Stack)Alignment

gchatelet updated this revision to Diff 225006. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68792/new/ https://reviews.llvm.org/D68792 Files: clang/lib/CodeGen/CGCall.cpp llvm/include/llvm/IR/Att

[PATCH] D68792: [Alignment] Migrate Attribute::getWith(Stack)Alignment

gchatelet updated this revision to Diff 225010. gchatelet added a comment. - Fix naming collision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68792/new/ https://reviews.llvm.org/D68792 Files: clang/lib/CodeGen/CGCall.cpp llvm/include/llvm/IR

[PATCH] D68792: [Alignment] Migrate Attribute::getWith(Stack)Alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rGb65fa483058f: [Alignment] Migrate Attribute::getWith(Stack)Alignment (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68792/new/ https

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3600 "attribute">; +def err_attribute_no_builtin_invalid_builtin_name : Error< + "'%0' is not a valid builtin name for %1">; aaron.ballman wrote: > I think this shou

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 225435. gchatelet marked 13 inline comments as done. gchatelet added a comment. Herald added subscribers: s.egerton, simoncook, aheejin, dschuff. - Address comments - Fix missing rename - Address comments - Add warning category Repository: rG LLVM Github

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 225575. gchatelet marked 3 inline comments as done. gchatelet added a comment. - Change NoBuiltin from InheritableAttr to Attr - Improve tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 225576. gchatelet marked an inline comment as done. gchatelet added a comment. - Improve tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 Files: clang/include/

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 225578. gchatelet added a comment. - Reverting whole file formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 Files: clang/include/clang/AST/Decl.h clang/i

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 225593. gchatelet added a comment. - Call sites to virtual functions are not annotated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 Files: clang/include/clang/AS

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet marked 4 inline comments as done. gchatelet added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3609 + "'%0' is not a valid builtin name for %1">, + InGroup; // Which group should it be in? +def err_attribute_no_builtin_wildcard_or_buil

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 225618. gchatelet added a comment. - Fix documentation and Warning category Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 Files: clang/include/clang/AST/Decl.h

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet marked an inline comment as done. gchatelet added a comment. LGTY @aaron.ballman ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 ___ cfe-commits mai

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet added a comment. In D68028#1723568 , @aaron.ballman wrote: > LGTM! Thx a lot for bearing with me and for your valuable comments ! Really appreciate it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D68028: [clang] Add no_builtin attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd8791610948: [clang] Add no_builtin attribute (authored by gchatelet). Changed prior to commit: https://reviews.llvm.org/D68028?vs=225618&id=226687#toc Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D69569: isBuiltinFunc() uses StringRef instead of const char*

gchatelet created this revision. gchatelet added a reviewer: vlad.tsyrklevich. Herald added a project: clang. Herald added a subscriber: cfe-commits. gchatelet edited the summary of this revision. This prevents a bug when passing `nullptr`, `StringRef` ctor would call `strlen(nullptr)`. This shou

[PATCH] D69569: isBuiltinFunc() uses StringRef instead of const char*

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG1c85a2e8dc7e: isBuiltinFunc() uses StringRef instead of const char* (authored by gchatelet). Repository: rG LLVM Github

[PATCH] D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions

gchatelet added a comment. I would harden the verifier and declare the i64 versions of mem intrinsics illegal on 32 bits architectures. Also the intrinsic sections of LangRef should be updated accordingly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet marked 2 inline comments as done. gchatelet added inline comments. Comment at: clang/test/Sema/builtins-memcpy-inline.c:7 +#warning defined as expected +// expected-warning@-1 {{defined as expected}} +#endif gchatelet wrote: > efriedma wrote: > > melver

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet marked 3 inline comments as done. gchatelet added inline comments. Comment at: clang/test/Sema/builtins-memcpy-inline.c:7 +#warning defined as expected +// expected-warning@-1 {{defined as expected}} +#endif efriedma wrote: > melver wrote: > > It appear

[PATCH] D79279: Add overloaded versions of builtin mem* functions

gchatelet added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:489 BUILTIN(__builtin_memcpy_inline, "vv*vC*Iz", "nt") +BUILTIN(__builtin_overloaded_memcpy, "v*v*vC*z", "nt") BUILTIN(__builtin_memmove, "v*v*vC*z", "nF") `overloaded` doesn't

[PATCH] D79279: Add overloaded versions of builtin mem* functions

gchatelet added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:489 BUILTIN(__builtin_memcpy_inline, "vv*vC*Iz", "nt") +BUILTIN(__builtin_overloaded_memcpy, "v*v*vC*z", "nt") BUILTIN(__builtin_memmove, "v*v*vC*z", "nF") jfb wrote: > gchatele

[PATCH] D78443: [Local] Update getOrEnforceKnownAlignment/getKnownAlignment to use Align/MaybeAlign.

gchatelet added a comment. Thx @craig.topper ! I'm happy to see this effort percolate :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78443/new/ https://reviews.llvm.org/D78443 ___ cfe-commits mailing

[PATCH] D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument

gchatelet accepted this revision. gchatelet added a comment. This revision is now accepted and ready to land. Thx for the patch, please address the comment before submitting. Comment at: clang/lib/Sema/SemaChecking.cpp:1946-1953 +auto ArgArrayConversion = [&](unsigned Arg)

[PATCH] D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument

gchatelet accepted this revision. gchatelet added a comment. Much better, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121475/new/ https://reviews.llvm.org/D121475 ___ cfe-commits mailing lis

[PATCH] D121965: Add validation for number of arguments of __builtin_memcpy_inline

gchatelet accepted this revision. gchatelet added a comment. This revision is now accepted and ready to land. Thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121965/new/ https://reviews.llvm.org/D121965 _

[PATCH] D121965: Add validation for number of arguments of __builtin_memcpy_inline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b3a27e2e026: Add validation for number of arguments of __builtin_memcpy_inline (authored by royjacobson, committed by gchatelet). Repository: rG

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

gchatelet added a comment. This patch broke my build as well (discovered by runnin `git bisect`), command line > cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_COMPILER=/usr/local/bin/clang > -DCMAKE_ASM_COMPILER=/usr/local/bin/clang > -DCMAKE_CXX_COMPILER=/usr/local/bin/clang++ > -DCMAKE_EXPORT_CO

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

gchatelet added a comment. Thx for the summary @tejohnson. In D61634#1808265 , @tejohnson wrote: > >> 3. Propagate/merge the `no-builtin` IR attribute for LTO by "updating > >> `AttributeFuncs::areInlineCompatible` and/or > >> `AttributeFuncs::mergeAttr

[PATCH] D87458: [Clang] Clarify __builtin_memcpy_inline documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGe38be7091ee3: [Clang] Clarify __builtin_memcpy_inline documentation (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87458/new/ https:

[PATCH] D87458: [Clang] Clarify __builtin_memcpy_inline documentation

gchatelet marked an inline comment as done. gchatelet added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2439 +guarantees not to call any external functions. See LLVM IR `llvm.memcpy.inline +`_ Int

[PATCH] D87458: [Clang] Clarify __builtin_memcpy_inline documentation

gchatelet marked an inline comment as done. gchatelet added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2439 +guarantees not to call any external functions. See LLVM IR `llvm.memcpy.inline +`_ Int

[PATCH] D87458: [Clang] Clarify __builtin_memcpy_inline documentation

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added a project: clang. Herald added a subscriber: cfe-commits. gchatelet requested review of this revision. This patch updates the documentation about `__builtin_memcpy_inline` and reorders the sections so it is more co

[PATCH] D91975: clang-tidy: detect narrowing conversions involving typedefs

gchatelet accepted this revision. gchatelet added a comment. This revision is now accepted and ready to land. Thx for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91975/new/ https://reviews.llvm.org/D91975 _

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet updated this revision to Diff 346657. gchatelet added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Remove dependency on iterable_range header - Simplified implementation, added tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet updated this revision to Diff 346669. gchatelet added a comment. - Forward argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102760/new/ https://reviews.llvm.org/D102760 Files: clang/include/clang/Basic/Module.h llvm/include/llv

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet added inline comments. Comment at: clang/include/clang/Basic/Module.h:98 public: + Module(const Module &) = default; + fhahn wrote: > how is this related? > how is this related? I'm glad you ask! I'm still investigating the errors that led to this ad

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet updated this revision to Diff 348228. gchatelet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102760/new/ https://reviews.llvm.org/D102760 Files: clang/include/clang/Basic/Module.h llvm/include/llvm/ADT/Iter

[PATCH] D97223: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg.

gchatelet added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:1037 + assert(AddrAlign >= ResultTy->getPrimitiveSizeInBits() / 8); + Add an error message? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D97223: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg.

gchatelet added a comment. In D97223#2581587 , @jyknight wrote: > In D97223#2581126 , @rjmccall wrote: > >> Looks like you didn't update the .bc reader/writer and the .ll >> printer/parser. > > The instructions alr

[PATCH] D97223: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg.

gchatelet accepted this revision. gchatelet added a comment. LGTM as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97223/new/ https://reviews.llvm.org/D97223 ___ cfe-commits mailing list cfe-commits

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet added a comment. @Quuxplusone thx a lot for the comment. It is very relevant and I agree that this addition may be dangerous. The intend was to prevent adding more constructors (and dependencies) to SmallVector in D102679 . I can try to see what it tak

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet abandoned this revision. gchatelet added a comment. In D102760#2802520 , @Quuxplusone wrote: > @gchatelet: Thanks for the link to D102679 > — that seems like very relevant background info I didn't have! Havi

[PATCH] D104018: [clang-tidy] Allow disabling integer narrowing conversions for cppcoreguidelines-narrowing-conversions

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. gchatelet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monore

[PATCH] D104018: [clang-tidy] Allow disabling integer narrowing conversions for cppcoreguidelines-narrowing-conversions

This revision was automatically updated to reflect the committed changes. Closed by commit rG89c41c335dac: [clang-tidy] Allow disabling integer narrowing conversions for… (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104018/n

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

gchatelet added a comment. LGTM once tests are passing. Maybe wait a bit for a comment from @aaron.ballman . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 ___ cfe-commits mailing list cfe-commits@

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet added a comment. In D126903#3884873 , @courbet wrote: > I think there's a bug in the code though: > > // If this is memset, we just need to see if the offset is valid in the size > // of the memset.. > if (MI->getIntrinsicID() == Intri

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet added a comment. It should be fixed now @aganea . Can you check? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 ___ cfe-commits mailing list cfe-comm

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet added a comment. In D126903#3885269 , @aganea wrote: > In D126903#3885114 , @gchatelet > wrote: > >> It should be fixed now @aganea . Can you check? > > Works now, thanks again for the quick response. S

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

gchatelet added a comment. It also broke `llvm-exegesis` for 32 bits targets, see https://github.com/llvm/llvm-project/issues/57348 Reverting changes for the files in `tools/llvm-exegesis/` solves the compilation issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D141134: [NFC] Only expose getXXXSize functions in TypeSize

gchatelet updated this revision to Diff 487339. gchatelet added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Fix missing clang change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141134/new/ https://reviews.l

[PATCH] D141134: [NFC] Only expose getXXXSize functions in TypeSize

gchatelet added a comment. I've created https://reviews.llvm.org/D141267 to get a feel of what it looks like to only keep the Size version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141134/new/ https://reviews.llvm.org/D141134 ___

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added a project: All. gchatelet requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This remove the last uses of GlobalObject::getAlignment and marks

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

gchatelet added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); + Var->getAlign().valueOr

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

gchatelet added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); + Var->getAlign().valueOr

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

gchatelet added a comment. Thx @efriedma for reminding me of this. I'll update the documentation and try to give a shot at removing `MaybeAlign` from `GlobalObject`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142459/new/ https://reviews.llvm.or

[PATCH] D143386: Add function pointer alignment to DataLayout

gchatelet created this revision. gchatelet added a reviewer: efriedma. Herald added subscribers: luke, kosarev, mattd, gchakrabarti, pmatos, asb, asavonic, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasy

[PATCH] D141134: [NFC] Only expose getXXXSize functions in TypeSize

gchatelet closed this revision. gchatelet added a comment. So i've submitted the following patches which remove the usage of `TypeSize::getFixedSize()` and `TypeSize::getKnownMinSize()` - rG6916ebd02650 : [clang][NFC] Use the

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet created this revision. gchatelet added reviewers: courbet, efriedma, t.p.northover, jdoerfert. Herald added subscribers: jsji, pengfei, hiraditya. Herald added a project: All. gchatelet requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-c

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 433858. gchatelet added a comment. - remove unused variable and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files: clang/docs/LanguageExtensions.rst

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 433978. gchatelet added a comment. - Rebase over formatted CGBuilder.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files: clang/docs/LanguageExtensions.rst

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 433982. gchatelet added a comment. - Fix sema checking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files: clang/docs/LanguageExtensions.rst clang/include/cl

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet marked 2 inline comments as done. gchatelet added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2293-2315 + case Builtin::BI__builtin_memset_inline: { +if (checkArgCount(*this, TheCall, 3)) + return ExprError(); +auto ArgArrayConversionFaile

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 434750. gchatelet marked 2 inline comments as done. gchatelet added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files: clang/docs/Language

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet added inline comments. Comment at: clang/test/Sema/builtins-memcpy-inline.cpp:11 +void test_memcpy_inline_invalid_arg_types() { + __builtin_memcpy_inline(1, 2, 3); // expected-error {{cannot initialize a parameter of type 'void *' with an rvalue of type 'int'}} +} ---

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 434793. gchatelet marked 8 inline comments as done. gchatelet added a comment. Herald added subscribers: pmatos, asb, aheejin, jgravelle-google, sbc100, dschuff. - Address comments, add more codegen tests, rebase Repository: rG LLVM Github Monorepo CHA

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet added a comment. Pending D127279 before making sure that all `EmitTargetCodeForMemset` implementations are enforcing `AlwaysInline`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://rev

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 435877. gchatelet marked an inline comment as done. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files: clang/doc

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:7334 if (TSI) { SDValue Result = TSI->EmitTargetCodeForMemset( *this, dl, Chain, Dst, Src, Size, Alignment, isVol, DstPtrInfo); courbet wrote: > There is

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 435883. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files: clang/docs/LanguageExtensions.rst clang/include/cla

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 435890. gchatelet added a comment. - Update assert message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files: clang/docs/LanguageExtensions.rst clang/includ

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 435893. gchatelet added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Bui

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG38637ee47754: [clang] Add support for __builtin_memset_inline (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet added a comment. Buggy trace here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76504/new/ https://reviews.llvm.org/D76504 __

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet created this revision. gchatelet added reviewers: efriedma, courbet. Herald added a project: clang. Herald added a subscriber: cfe-commits. gchatelet added a subscriber: abrachet. gchatelet added a comment. Buggy trace here

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1655 +clang::Expr *SizeOp = TheCall->getArg(2); +// If any arg is instantiation dependent we bail out. +if (DstOp->isInstantiationDependent() || courbet wrote: > Are the firs

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet updated this revision to Diff 251671. gchatelet marked an inline comment as done. gchatelet added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76504/new/ https://reviews.llvm.org/D76504 Files: clang/lib/Sem

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet updated this revision to Diff 251780. gchatelet added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76504/new/ https://reviews.llvm.org/D76504 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/builtin

[PATCH] D76504: [clang] Fix crash during template sema checking

This revision was automatically updated to reflect the committed changes. Closed by commit rGd260a10d98df: [clang] Fix crash during template sema checking (authored by gchatelet). Changed prior to commit: https://reviews.llvm.org/D76504?vs=251780&id=251837#toc Repository: rG LLVM Github Mono

[PATCH] D76551: [Alignment][NFC] Use TargetFrameLowering::getStackAlign()

gchatelet updated this revision to Diff 251969. gchatelet marked 3 inline comments as done. gchatelet added a comment. Herald added subscribers: libc-commits, openmp-commits, libcxx-commits, cfe-commits, Joonsoo, kerbowa, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, csigg, nicolasvasilach

[PATCH] D76551: [Alignment][NFC] Use TargetFrameLowering::getStackAlign()

gchatelet updated this revision to Diff 251971. gchatelet added a comment. Herald added a reviewer: jdoerfert. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76551/new/ https://reviews.llvm.org/D76551 Files: llvm/lib/CodeGen/MachineFunctio

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

gchatelet added a comment. In D61634#1732884 , @tejohnson wrote: > In D61634#1682660 , @gchatelet wrote: > > > In D61634#1679331 , @tejohnson > > wrote: > > > > > In D61634#

[PATCH] D71193: [clang] Turn -fno-builtin flag into an IR Attribute

gchatelet created this revision. gchatelet added reviewers: aaron.ballman, courbet. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow up on https://reviews.llvm.org/D61634#1742154 to turn the clang driver -fno-builtin flag into an IR attribute. I also investi

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, nhaehnle, jvesely, arsenm. Herald added projects: clang, LLVM. This is patch is part of a series to introduce an Alignment type. See this thread for context: http

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet marked 2 inline comments as done. gchatelet added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:2910 +const Align Alignment = +assumeAligned(cast(I.getArgOperand(2))->getZExtValue()); Value *Mask = I.getArgOperand(

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet updated this revision to Diff 233074. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71213/new/ https://reviews.llvm.org/D71213 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBu

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet added a comment. Thx for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71213/new/ https://reviews.llvm.org/D71213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b2842bf902a: [Alignment][NFC] CreateMemSet use MaybeAlign (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71213/new/ https://reviews

[PATCH] D71193: [clang] Turn -fno-builtin flag into an IR Attribute

gchatelet updated this revision to Diff 233272. gchatelet marked 3 inline comments as done. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71193/new/ https://reviews.llvm.org/D71193 Files: clang/lib/C

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet added a comment. In D71213#1779841 , @foad wrote: > @gchatelet in general would it be possible to make changes like this in a > backwards-compatible way, or in two stages without a "flag day" change? We > have out-of-tree users of CreateMemSet

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet added a comment. >> Thx for letting me know @foad . I'll make sure to keep the old API with a >> deprecation message from now on. >> Do you have any other suggestions on how to make this less painful for >> out-of-tree users? I'm afraid that the cleanup phase (removal of deprecated >

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet added a comment. @foad do you have any insights on how to go with the deprecation? LLVM has this `LLVM_ATTRIBUTE_DEPRECATED` macro, it's convenient to get a warning but it only works when building without `-Wall`. Bots and in-tree users have it set by default, it's fine as I'll be fixi

[PATCH] D71193: [clang] Turn -fno-builtin flag into an IR Attribute

gchatelet marked an inline comment as done. gchatelet added inline comments. Comment at: clang/test/CodeGen/libcalls-fno-builtin.c:163 -// CHECK: [[ATTR]] = { nobuiltin } +// GLOBAL: #2 = { nobuiltin "no-builtins" } +// INDIVIDUAL: #2 = { nobuiltin "no-builtin-ceil" "no-builtin

[PATCH] D71420: [Alignment][NFC] Adding Align compatible methods to IntrinsicInst/IRBuilder

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This is patch is part of a series to introduce an Alignment type. See this thread for context: http://lists.llvm.org/pipermail/

[PATCH] D71420: [Alignment][NFC] Adding Align compatible methods to IntrinsicInst/IRBuilder

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbc5acf8ce8a: [Alignment][NFC] Adding Align compatible methods to IntrinsicInst/IRBuilder (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D71193: [clang] Turn -fno-builtin flag into an IR Attribute

gchatelet marked an inline comment as done. gchatelet added inline comments. Comment at: clang/test/CodeGen/libcalls-fno-builtin.c:163 -// CHECK: [[ATTR]] = { nobuiltin } +// GLOBAL: #2 = { nobuiltin "no-builtins" } +// INDIVIDUAL: #2 = { nobuiltin "no-builtin-ceil" "no-builtin

[PATCH] D71193: [clang] Turn -fno-builtin flag into an IR Attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG0508c994f0b1: [clang] Turn -fno-builtin flag into an IR Attribute (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71193/new/ https://

<    1   2   3   >