[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea added inline comments. Comment at: test/Driver/openmp-offload-gpu.c:150 +/// bitcode library and add it to the LIBRARY_PATH. +// RUN: touch %T/libomptarget-nvptx-sm_60.bc +// RUN: env LIBRARY_PATH=%T %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda \

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 137999. gtbercea added a comment. Herald added a subscriber: jholewinski. Change name of folder. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/CodeGen/CGDecl.cpp lib/CodeGen/CGOpenMPRu

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138000. gtbercea added a comment. Rename folder. Fix test. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index: test/Drive

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138001. gtbercea added a comment. Fixes. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index: test/Driver/openmp-offload-g

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138002. gtbercea added a comment. Add input file. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/Inputs/libomptarget/libomptarget-nvptx-sm_20.bc

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138242. gtbercea added a comment. Address comments. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/Inputs/libomptarget/libomptarget-nvptx-sm_20.bc

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138260. gtbercea added a comment. Improve test robustness for the case when CUDA libdevice cannot be found. Check that the warning is not emitted when the bc lib is found. Repository: rC Clang https://reviews.llvm.org/D43197 Files: test/Driver/Inputs/

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138261. gtbercea added a comment. Add bclib. Repository: rC Clang https://reviews.llvm.org/D43197 Files: test/Driver/openmp-offload-gpu.c Index: test/Driver/openmp-offload-gpu.c === ---

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138262. gtbercea added a comment. Test. Repository: rC Clang https://reviews.llvm.org/D43197 Files: test/Driver/openmp-offload-gpu.c Index: test/Driver/openmp-offload-gpu.c === --- test

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138265. gtbercea added a comment. Update patch manually. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/Inputs/libomptarget/libomptarget-nvptx-sm_

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138266. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/Inputs/libomptarget/libomptarget-nvptx-sm_20.bc test/Driver/openmp-offload-gpu.c Index: t

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138274. gtbercea added a comment. - Revert - Add back. - Improve tests. - Add bclib. - Fix. - Fix. Repository: rC Clang https://reviews.llvm.org/D43197 Files: test/Driver/openmp-offload-gpu.c Index: test/Driver/openmp-offload-gpu.c =

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138275. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/Inputs/libomptarget/libomptarget-nvptx-sm_20.bc test/Driver/openmp-offload-gpu.c Index: t

[PATCH] D44541: [OpenMP][Clang] Move device global stack init before master-workers split

gtbercea created this revision. gtbercea added reviewers: ABataev, carlo.bertolli, grokos, caomhin. Herald added subscribers: cfe-commits, guansong, jholewinski. This patch moves the call to the stack init data sharing function before the splitting of threads into master and workers. This ensures

[PATCH] D44588: [OpenMP][Clang] Pass global thread ID to outlined function

gtbercea created this revision. gtbercea added reviewers: ABataev, grokos, carlo.bertolli, caomhin. Herald added subscribers: cfe-commits, guansong, jholewinski. The data sharing wrapper function needs to pass a valid global thread ID to the parallel outlined function when the parallel is combine

[PATCH] D44588: [OpenMP][Clang] Pass global thread ID to outlined function

gtbercea abandoned this revision. gtbercea added a comment. After some internal discussion with @ABataev he is going to replace the manual computation of the thread ID with a call to the runtime in a new patch. Repository: rC Clang https://reviews.llvm.org/D44588 _

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

gtbercea added a comment. > Assuming we do proceed with back-to-CUDA approach, one thing I'd consider > would be using clang's -fcuda-include-gpubinary option which CUDA uses to > include GPU code into the host object. You may be able to use it to avoid > compiling and partially linking .fatbin

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

gtbercea added a comment. The error is related to lack of device linking, just like you explained two paragraphs down. This is the error I get: main.o: In function `__cuda_module_ctor': main.cu:(.text+0x674): undefined reference to `__cudaRegisterLinkedBinary__nv_c5b75865' You nailed the p

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

gtbercea added a comment. > I disagree in this context because this patch currently means that static > archives will only work with NVPTX and there is no clear path how to "fix" > things for other offloading targets. I'll try to work on my proposal over the > next few days (sorry, very busy

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

gtbercea added a comment. In https://reviews.llvm.org/D47394#1119056, @Hahnfeld wrote: > Hmm, maybe the scope is much larger: I just tried linking an executable that > references a `declare target` function in a shared library. My assumption was > that this already works, given that `libomptarg

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

gtbercea added a comment. In https://reviews.llvm.org/D47394#1120255, @Hahnfeld wrote: > In https://reviews.llvm.org/D47394#1119489, @gtbercea wrote: > > > In https://reviews.llvm.org/D47394#1119056, @Hahnfeld wrote: > > > > > Hmm, maybe the scope is much larger: I just tried linking an executabl

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

gtbercea added a comment. @tra Thank you for your comments and help with the patch. Repository: rC Clang https://reviews.llvm.org/D47394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

gtbercea created this revision. gtbercea added reviewers: Hahnfeld, tra, hfinkel, carlo.bertolli, caomhin, ABataev. Herald added subscribers: cfe-commits, guansong, mgorny. In current Clang, on the OpenMP NVPTX toolchain, math functions are resolved as math functions for the host. For example, a

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

gtbercea added inline comments. Comment at: lib/Headers/__clang_cuda_device_functions.h:65 } +#if defined(__cplusplus) __DEVICE__ void __brkpt() { asm volatile("brkpt;"); } Hahnfeld wrote: > Why is that only valid for C++? C does not support overloading of func

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

gtbercea added a comment. In https://reviews.llvm.org/D47849#1124638, @Hahnfeld wrote: > IMO this goes into the right direction, we should use the fast implementation > in libdevice. If LLVM doesn't lower these calls in the NVPTX backend, I think > it's ok to use header wrappers as CUDA already

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

gtbercea added a comment. I just stumbled upon a very interesting situation. I noticed that, for OpenMP, the use of device math functions happens as I expected for -O0. For -O1 or higher math functions such as "sqrt" resolve to llvm builtins/intrinsics: call double @llvm.sqrt.f64(double %1)

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

gtbercea marked 3 inline comments as done. gtbercea added inline comments. Comment at: include/clang/Driver/Compilation.h:312 + /// \param skipBundler - bool value set once by the driver. + void setSkipOffloadBundler(bool skipBundler); + sfantao wrote: > Why is

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

gtbercea updated this revision to Diff 150947. gtbercea added a comment. Added separate test. Repository: rC Clang https://reviews.llvm.org/D47394 Files: include/clang/Driver/Action.h include/clang/Driver/Compilation.h include/clang/Driver/Driver.h include/clang/Driver/Options.td i

[PATCH] D53443: [OpenMP][NVPTX] Enable default scheduling for parallel for in non-SPMD cases.

gtbercea created this revision. gtbercea added reviewers: ABataev, caomhin. Herald added subscribers: cfe-commits, guansong, jholewinski. This patch enables the choosing of the default schedule for parallel for loops even in non-SPMD cases. Repository: rC Clang https://reviews.llvm.org/D5344

[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

gtbercea updated this revision to Diff 170236. gtbercea added a comment. Herald added subscribers: cfe-commits, jholewinski. Refactor. Repository: rC Clang https://reviews.llvm.org/D53141 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp Index: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp ==

[PATCH] D53443: [OpenMP][NVPTX] Enable default scheduling for parallel for in non-SPMD cases.

gtbercea updated this revision to Diff 170237. gtbercea added a comment. Refactor. Repository: rC Clang https://reviews.llvm.org/D53443 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp Index: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp ==

[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

gtbercea updated this revision to Diff 170238. gtbercea added a comment. Refactor. Repository: rOMP OpenMP https://reviews.llvm.org/D53141 Files: libomptarget/deviceRTLs/nvptx/src/data_sharing.cu libomptarget/deviceRTLs/nvptx/src/interface.h libomptarget/deviceRTLs/nvptx/src/omptarge

[PATCH] D53448: [OpenMP][NVPTX] Use single loops when generating code for distribute parallel for

gtbercea created this revision. gtbercea added reviewers: ABataev, caomhin. Herald added subscribers: cfe-commits, guansong, jholewinski. This patch adds a new code generation path for bound sharing directives containing distribute parallel for. The new code generation scheme applies to chunked

[PATCH] D53448: [OpenMP][NVPTX] Use single loops when generating code for distribute parallel for

gtbercea updated this revision to Diff 170241. gtbercea added a comment. Rebase. Repository: rC Clang https://reviews.llvm.org/D53448 Files: include/clang/AST/StmtOpenMP.h include/clang/Basic/OpenMPKinds.h lib/AST/StmtOpenMP.cpp lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenM

[PATCH] D53448: [OpenMP][NVPTX] Use single loops when generating code for distribute parallel for

gtbercea updated this revision to Diff 171081. gtbercea added a comment. Refactor chunk one checking. Repository: rC Clang https://reviews.llvm.org/D53448 Files: include/clang/AST/StmtOpenMP.h lib/AST/StmtOpenMP.cpp lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h li

[PATCH] D53448: [OpenMP][NVPTX] Use single loops when generating code for distribute parallel for

gtbercea updated this revision to Diff 171084. gtbercea marked an inline comment as done. gtbercea added a comment. Use NumIterations. Repository: rC Clang https://reviews.llvm.org/D53448 Files: include/clang/AST/StmtOpenMP.h lib/AST/StmtOpenMP.cpp lib/CodeGen/CGOpenMPRuntime.cpp lib

[PATCH] D53448: [OpenMP][NVPTX] Use single loops when generating code for distribute parallel for

gtbercea marked 3 inline comments as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:904 + /// + virtual bool isStaticChunked(OpenMPDistScheduleClauseKind ScheduleKind, + bool Chunked) const; ABataev

[PATCH] D53448: [OpenMP][NVPTX] Use single loops when generating code for distribute parallel for

gtbercea updated this revision to Diff 171116. gtbercea marked an inline comment as done. gtbercea added a comment. Refactor static chunk schedules. Fix tests. Repository: rC Clang https://reviews.llvm.org/D53448 Files: include/clang/AST/StmtOpenMP.h lib/AST/StmtOpenMP.cpp lib/CodeGe

[PATCH] D53448: [OpenMP][NVPTX] Use single loops when generating code for distribute parallel for

gtbercea updated this revision to Diff 171127. gtbercea added a comment. Simplify code. Repository: rC Clang https://reviews.llvm.org/D53448 Files: include/clang/AST/StmtOpenMP.h lib/AST/StmtOpenMP.cpp lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGOp

[PATCH] D53448: [OpenMP][NVPTX] Use single loops when generating code for distribute parallel for

gtbercea updated this revision to Diff 171170. gtbercea added a comment. Add test for collapse. Repository: rC Clang https://reviews.llvm.org/D53448 Files: include/clang/AST/StmtOpenMP.h lib/AST/StmtOpenMP.cpp lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGe

[PATCH] D53448: [OpenMP][NVPTX] Use single loops when generating code for distribute parallel for

gtbercea updated this revision to Diff 171180. gtbercea added a comment. Change tests. Repository: rC Clang https://reviews.llvm.org/D53448 Files: include/clang/AST/StmtOpenMP.h lib/AST/StmtOpenMP.cpp lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGOpenM

[PATCH] D53443: [OpenMP][NVPTX] Enable default scheduling for parallel for in non-SPMD cases.

gtbercea updated this revision to Diff 171310. gtbercea added a comment. Add test. Repository: rC Clang https://reviews.llvm.org/D53443 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp test/OpenMP/nvptx_parallel_for_codegen.cpp Index: test/OpenMP/nvptx_parallel_for_codegen.cpp

[PATCH] D53772: [NFC][OpenMP] Add new test for parallel for code generation.

gtbercea created this revision. gtbercea added reviewers: ABataev, caomhin. Herald added subscribers: cfe-commits, guansong. This is a simple test of the parallel for code generation. It will be used to showcase the change introduced by patch https://reviews.llvm.org/D53443. Repository: rC Cl

[PATCH] D53443: [OpenMP][NVPTX] Enable default scheduling for parallel for in non-SPMD cases.

gtbercea updated this revision to Diff 171352. gtbercea added a comment. Add test. Repository: rC Clang https://reviews.llvm.org/D53443 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp test/OpenMP/nvptx_parallel_for_codegen.cpp Index: test/OpenMP/nvptx_parallel_for_codegen.cpp ===

[PATCH] D53448: [OpenMP][NVPTX] Use single loops when generating code for distribute parallel for

gtbercea updated this revision to Diff 171499. gtbercea added a comment. Fix comment. Repository: rC Clang https://reviews.llvm.org/D53448 Files: include/clang/AST/StmtOpenMP.h lib/AST/StmtOpenMP.cpp lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGOpenMP

[PATCH] D53443: [OpenMP][NVPTX] Enable default scheduling for parallel for in non-SPMD cases.

gtbercea added a comment. ping Repository: rC Clang https://reviews.llvm.org/D53443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53827: [OpenMP][NFC] Fix condition.

gtbercea created this revision. Herald added subscribers: cfe-commits, guansong. gtbercea added reviewers: ABataev, caomhin. Iteration variable must be strictly less than the number of iterations. Repository: rC Clang https://reviews.llvm.org/D53827 Files: lib/Sema/SemaOpenMP.cpp Index:

[PATCH] D53827: [OpenMP][NFC] Fix condition.

gtbercea updated this revision to Diff 171558. gtbercea added a comment. Add tests. Repository: rC Clang https://reviews.llvm.org/D53827 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/distribute_parallel_for_codegen.cpp test/OpenMP/distribute_parallel_for_simd_codegen.cpp test/OpenMP/n

[PATCH] D56790: [OpenMP] Update release notes with OpenMP related changes

gtbercea created this revision. gtbercea added reviewers: ABataev, caomhin. Herald added subscribers: cfe-commits, guansong. Update release notes with OpenMP related changes. Repository: rC Clang https://reviews.llvm.org/D56790 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst ==

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

gtbercea added a comment. Could we add the changes in D56790 to this diff? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56733/new/ https://reviews.llvm.org/D56733 ___ cfe-commits mailing list cfe-commits@

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

gtbercea added a comment. In D56733#1362182 , @kkwli0 wrote: > In D56733#1360221 , @gtbercea wrote: > > > Could we add the changes in D56790 to > > this diff? > > > Sure, I will do

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

gtbercea added inline comments. Comment at: docs/OpenMPSupport.rst:62 + +- Simplified code generation for distribute and parallel in SPMD mode. + Simplified SPMD code generation for `distribute parallel for` when the new default schedules are applicable. CHA

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

gtbercea accepted this revision. gtbercea added a comment. This revision is now accepted and ready to land. Thanks for the update! LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56733/new/ https://reviews.llvm.org/D56733 ___ cfe-commits

[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

gtbercea updated this revision to Diff 171988. gtbercea added a comment. Address comments. Repository: rOMP OpenMP https://reviews.llvm.org/D53141 Files: libomptarget/deviceRTLs/nvptx/src/data_sharing.cu libomptarget/deviceRTLs/nvptx/src/interface.h libomptarget/deviceRTLs/nvptx/src/

[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

gtbercea updated this revision to Diff 171993. gtbercea added a comment. Move while on else branch. Repository: rOMP OpenMP https://reviews.llvm.org/D53141 Files: libomptarget/deviceRTLs/nvptx/src/data_sharing.cu libomptarget/deviceRTLs/nvptx/src/interface.h libomptarget/deviceRTLs/nvp

[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

gtbercea updated this revision to Diff 172007. gtbercea added a comment. Reinstate assert. Repository: rOMP OpenMP https://reviews.llvm.org/D53141 Files: libomptarget/deviceRTLs/nvptx/src/data_sharing.cu libomptarget/deviceRTLs/nvptx/src/interface.h libomptarget/deviceRTLs/nvptx/src/

[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: libomptarget/deviceRTLs/nvptx/src/supporti.h:191 PRINT(LD_MEM, "malloc data of size %zu for %s: 0x%llx\n", size, msg, P64(ptr)); - ASSERT(LT_SAFETY, ptr, "failed to allocate %zu bytes for

[PATCH] D54970: [OpenMP] Add a new version of the SPMD deinit kernel function

gtbercea created this revision. gtbercea added reviewers: ABataev, caomhin. Herald added subscribers: cfe-commits, guansong, jholewinski. gtbercea added a parent revision: D54969: [OpenMP][libomptarget] Add new version of SPMD deinit kernel function with argument. This patch adds a new runtime fo

[PATCH] D54970: [OpenMP] Add a new version of the SPMD deinit kernel function

gtbercea updated this revision to Diff 175570. gtbercea added a comment. Delete old function. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54970/new/ https://reviews.llvm.org/D54970 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp test/OpenMP/nvptx_target_para

[PATCH] D54970: [OpenMP] Add a new version of the SPMD deinit kernel function

gtbercea updated this revision to Diff 175573. gtbercea added a comment. Add constant values to function calls. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54970/new/ https://reviews.llvm.org/D54970 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp test/OpenMP

[PATCH] D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries

gtbercea created this revision. gtbercea added reviewers: ABataev, Hahnfeld, caomhin. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. NVLINK does not support dynamic linking so passing dynamic libraries to NVLINK should be avoided. This patch fixes a bu

[PATCH] D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:707 CmdArgs.push_back(StaticLibName); +} else if (OrigInputFileName.endswith(".so")) { + // Only static libraries are supported.

[PATCH] D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:707 CmdArgs.push_back(StaticLibName); +} else if (OrigInputFileName.endswith(".so")) { + // Only static libraries are supported.

[PATCH] D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:707 CmdArgs.push_back(StaticLibName); +} else if (OrigInputFileName.endswith(".so")) { + // Only static libraries are supported.

[PATCH] D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries

gtbercea added a comment. For now this patch doesn't make sense until the main linking patch lands but it's a case we need to keep in mind. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59028/new/ https://reviews.llvm.org/D59028 __

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

gtbercea added a comment. Thank you both for the feedback. It's good to see that there's an interest to move this forward, I will try to refactor this patch according to Hal's suggestions and see if there are any blockers. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://r

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea created this revision. gtbercea added reviewers: ABataev, AlexEichenberger, caomhin. Herald added subscribers: cfe-commits, jdoerfert, jfb, guansong, jholewinski. Herald added a project: clang. This patch adds support for the registration of the requires directives with the runtime. Eac

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 194741. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/C

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 194743. gtbercea marked 6 inline comments as done. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked 4 inline comments as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3870 llvm::Function * +CGOpenMPRuntime::createRequiresDirectiveRegistration() { + // If we don't have entries or if we are emitting code for the device, we ---

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 194758. gtbercea marked 2 inline comments as done. gtbercea added a comment. - Fix enum. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp li

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 194760. gtbercea added a comment. - Split patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGe

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 194781. gtbercea added a comment. - Handle OpenMP simd case. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195185. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/C

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195186. gtbercea added a comment. - Remove atomic flags. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h li

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195190. gtbercea added a comment. - Fix type. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/C

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195195. gtbercea added a comment. - Add break. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked 2 inline comments as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:1438 + /// requires directives was used in the current module. + virtual llvm::Function *emitRequiresDirectiveRegFun(); + ABataev wrote: > ABata

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked 2 inline comments as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8978 +if (Clause->getClauseKind() == OMPC_unified_shared_memory) { + CGM.getOpenMPRuntime().HasRequiresUnifiedSharedMemory = true; + break; ---

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195200. gtbercea added a comment. - Remove const. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeG

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: test/OpenMP/openmp_offload_registration.cpp:38 +// CHECK: define internal void @.omp_offloading.requires_reg() +// CHECK: call void @__tgt_register_requires(i64 0) +// CHECK: ret vo

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195394. gtbercea added a comment. - Fix checks for use of requires directive. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/C

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:644 + /// Flag for keeping track of weather a target region has been emitted. + bool hasEmittedTargetRegion = false; + ABataev wrote: > Why do y

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:644 + /// Flag for keeping track of weather a target region has been emitted. + bool hasEmittedTargetRegion = false; + ABataev wrote: > gtbercea

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:644 + /// Flag for keeping track of weather a target region has been emitted. + bool hasEmittedTargetRegion = false; + gtbercea wrote: > ABataev

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:644 + /// Flag for keeping track of weather a target region has been emitted. + bool hasEmittedTargetRegion = false; + ABataev wrote: > gtbercea

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:644 + /// Flag for keeping track of weather a target region has been emitted. + bool hasEmittedTargetRegion = false; + ABataev wrote: > gtbercea

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195608. gtbercea marked an inline comment as done. gtbercea added a comment. - Add support for declare target routines. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/C

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195609. gtbercea marked an inline comment as done. gtbercea added a comment. - Update error message. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRunt

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked 2 inline comments as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8975 +CGM.Error(Clause->getBeginLoc(), + "Target region emitted before requires directive."); + HasRequiresUnifiedSharedMemory = tr

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195644. gtbercea added a comment. - Update tests. - Move error check in sema. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: include/clang/Basic/DiagnosticSemaKinds.td li

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:476 + isa(CNew))) { +SemaRef.Diag(Loc, + diag::err_omp_target_before_requires) ABataev wrote: > DSAStack usually i

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195739. gtbercea added a comment. - Add const. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/C

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea created this revision. gtbercea added reviewers: ABataev, AlexEichenberger, caomhin. Herald added subscribers: cfe-commits, jdoerfert, jfb, guansong. Herald added a project: clang. The requires directive containing target related clauses must appear before any target region in the compil

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea updated this revision to Diff 195762. gtbercea added a comment. Fix test, Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaOpenMP.cpp test/Ope

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea updated this revision to Diff 195768. gtbercea marked an inline comment as done. gtbercea added a comment. - Fix test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 Files: include/clang/Basic/DiagnosticSemaKi

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea updated this revision to Diff 195770. gtbercea marked an inline comment as done. gtbercea added a comment. - Fix. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 Files: include/clang/Basic/DiagnosticSemaKinds.t

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea updated this revision to Diff 195771. gtbercea added a comment. - Fix. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaOpenMP.cpp test/OpenMP/r

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195775. gtbercea added a comment. - Move error check in sema. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea updated this revision to Diff 195793. gtbercea added a comment. - Lower case. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaOpenMP.cpp test/O

<    1   2   3   4   5   6   7   >